Re: [PATCH] AM35xx: Add clock support for new modules on AM35xx

2010-01-11 Thread Ranjith Lohithakshan
Hi Paul, On Sat, 09-Jan-10 4:37 AM +0530, Paul Walmsley wrote: > Hello Ranjith, > > On Fri, 8 Jan 2010, Ranjith Lohithakshan wrote: > >> These ACK bits are for the target IdleAck status. I will add a custom >> find_companion code for AM35xx. > > ... > >> OK. I will extend the existing find_idl

Re: [PATCH] AM35xx: Add clock support for new modules on AM35xx

2010-01-08 Thread Paul Walmsley
Hello Ranjith, On Fri, 8 Jan 2010, Ranjith Lohithakshan wrote: > These ACK bits are for the target IdleAck status. I will add a custom > find_companion code for AM35xx. ... > OK. I will extend the existing find_idlest to pass back what value needs > to be checked as you suggested. I will make t

Re: [PATCH] AM35xx: Add clock support for new modules on AM35xx

2010-01-08 Thread Ranjith Lohithakshan
Hello Paul, On Wed, 06-Jan-10 2:51 AM +0530, Paul Walmsley wrote: > On Fri, 18 Dec 2009, Ranjith Lohithakshan wrote: > >> On Fri, 18-Dec-09 7:12 AM +0530, Paul Walmsley wrote: >> >>> +/* Clocks for AM35XX */ >>> +static struct clk emac_ick = { >>> +.name = "emac_ick", >>> +.ops

Re: [PATCH] AM35xx: Add clock support for new modules on AM35xx

2010-01-05 Thread Paul Walmsley
Hi Ranjith, (please keep attribution lines in message replies, otherwise it becomes very difficult to keep track of who said what) On Fri, 18 Dec 2009, Ranjith Lohithakshan wrote: > On Fri, 18-Dec-09 7:12 AM +0530, Paul Walmsley wrote: > >> +/* Clocks for AM35XX */ >> +static struct clk emac_i

RE: [PATCH] AM35xx: Add clock support for new modules on AM35xx

2010-01-04 Thread Lohithakshan, Ranjith
Behalf Of > Lohithakshan, Ranjith > Sent: Friday, December 18, 2009 4:02 PM > To: Paul Walmsley > Cc: linux-omap@vger.kernel.org > Subject: Re: [PATCH] AM35xx: Add clock support for new > modules on AM35xx > > Hello Paul, > > Thanks for the review comments. My replies belo

Re: [PATCH] AM35xx: Add clock support for new modules on AM35xx

2009-12-18 Thread Ranjith Lohithakshan
Hello Paul, Thanks for the review comments. My replies below. On Fri, 18-Dec-09 7:12 AM +0530, Paul Walmsley wrote: >> +/* Clocks for AM35XX */ >> +static struct clk emac_ick = { >> +.name = "emac_ick", >> +.ops= &clkops_omap2_dflt, > > Shouldn't this clock use &clkops_omap

Re: [PATCH] AM35xx: Add clock support for new modules on AM35xx

2009-12-17 Thread Paul Walmsley
On Thu, 17 Dec 2009, Paul Walmsley wrote: > On Wed, 16 Dec 2009, Ranjith Lohithakshan wrote: > > > This patch adds clock support for the following AM35xx modules > > - Ethernet MAC > > - CAN Controller (HECC) > > - New MUSB OTG Controller with integrated Phy > > - Video Processing

Re: [PATCH] AM35xx: Add clock support for new modules on AM35xx

2009-12-17 Thread Paul Walmsley
Hello Ranjith, some comments: On Wed, 16 Dec 2009, Ranjith Lohithakshan wrote: > This patch adds clock support for the following AM35xx modules > - Ethernet MAC > - CAN Controller (HECC) > - New MUSB OTG Controller with integrated Phy > - Video Processing Front End (VPFE)