Hello Anuj,
On Thu, 7 Jan 2010, Aggarwal, Anuj wrote:
> > > > In the interim, I would suggest that you remove the the clock source
> > and
> > > > receiver source change functions from omap-mcbsp.c, split them into
> > OMAP1
> > > > and OMAP2/3 variants, and place them into arch/arm/mach-omap*/mc
.org; Lohithakshan,
> Ranjith
> Subject: RE: [PATCH] OMAP: Exporting functions doing common register
> access
>
> > > > In the interim, I would suggest that you remove the the clock source
> > and
> > > > receiver source change functions from omap-mcbsp.c,
> > > In the interim, I would suggest that you remove the the clock source
> and
> > > receiver source change functions from omap-mcbsp.c, split them into
> OMAP1
> > > and OMAP2/3 variants, and place them into arch/arm/mach-omap*/mcbsp.c.
> > > Expand struct omap_mcbsp_ops to add function pointers
Hi Jarkko,
On Wed, 18 Nov 2009, Jarkko Nikula wrote:
> On Wed, 18 Nov 2009 03:40:40 -0700 (MST)
> Paul Walmsley wrote:
>
> > In the interim, I would suggest that you remove the the clock source and
> > receiver source change functions from omap-mcbsp.c, split them into OMAP1
> > and OMAP2/3 v
On Wed, 18 Nov 2009 03:40:40 -0700 (MST)
Paul Walmsley wrote:
> In the interim, I would suggest that you remove the the clock source and
> receiver source change functions from omap-mcbsp.c, split them into OMAP1
> and OMAP2/3 variants, and place them into arch/arm/mach-omap*/mcbsp.c.
> Expan
On Wed, 18 Nov 2009, Aggarwal, Anuj wrote:
> [Aggarwal, Anuj] Any comments on this patch? Do I have to re-work this?
Yes. omap_ctrl_*() should not be exported, as mentioned earlier.
A lot of rework will be needed at some point in sound/soc/omap/ to get all
of the chip- and board-integration de
ect: RE: [PATCH] OMAP: Exporting functions doing common register
> access
>
> > -Original Message-
> > From: Paul Walmsley [mailto:p...@pwsan.com]
> > Sent: Tuesday, November 17, 2009 2:46 AM
> > To: Aggarwal, Anuj
> > Cc: linux-omap@vger.kernel.org
> &
> -Original Message-
> From: Paul Walmsley [mailto:p...@pwsan.com]
> Sent: Tuesday, November 17, 2009 2:46 AM
> To: Aggarwal, Anuj
> Cc: linux-omap@vger.kernel.org
> Subject: Re: [PATCH] OMAP: Exporting functions doing common register
> access
>
> Hello Anu
Hello Anuj,
On Mon, 16 Nov 2009, Anuj Aggarwal wrote:
> These functions need to be exported so that drivers (e.g. McBSP) can
> be configured as modules.
>
> McBSP driver gets built as a module when ASoC driver for OMAP3 EVM
> is configured as module. McBSP driver uses functions like
> omap_ctrl_
