RE: [PATCH] OMAP: Exporting functions doing common register access

2010-01-13 Thread Paul Walmsley
Hello Anuj, On Thu, 7 Jan 2010, Aggarwal, Anuj wrote: In the interim, I would suggest that you remove the the clock source and receiver source change functions from omap-mcbsp.c, split them into OMAP1 and OMAP2/3 variants, and place them into arch/arm/mach-omap*/mcbsp.c.

RE: [PATCH] OMAP: Exporting functions doing common register access

2010-01-10 Thread Aggarwal, Anuj
, Ranjith Subject: RE: [PATCH] OMAP: Exporting functions doing common register access In the interim, I would suggest that you remove the the clock source and receiver source change functions from omap-mcbsp.c, split them into OMAP1 and OMAP2/3 variants, and place them into arch/arm

RE: [PATCH] OMAP: Exporting functions doing common register access

2010-01-07 Thread Aggarwal, Anuj
In the interim, I would suggest that you remove the the clock source and receiver source change functions from omap-mcbsp.c, split them into OMAP1 and OMAP2/3 variants, and place them into arch/arm/mach-omap*/mcbsp.c. Expand struct omap_mcbsp_ops to add function pointers to those

RE: [PATCH] OMAP: Exporting functions doing common register access

2009-11-18 Thread Paul Walmsley
On Wed, 18 Nov 2009, Aggarwal, Anuj wrote: [Aggarwal, Anuj] Any comments on this patch? Do I have to re-work this? Yes. omap_ctrl_*() should not be exported, as mentioned earlier. A lot of rework will be needed at some point in sound/soc/omap/ to get all of the chip- and board-integration

Re: [PATCH] OMAP: Exporting functions doing common register access

2009-11-18 Thread Jarkko Nikula
On Wed, 18 Nov 2009 03:40:40 -0700 (MST) Paul Walmsley p...@pwsan.com wrote: In the interim, I would suggest that you remove the the clock source and receiver source change functions from omap-mcbsp.c, split them into OMAP1 and OMAP2/3 variants, and place them into

RE: [PATCH] OMAP: Exporting functions doing common register access

2009-11-17 Thread Aggarwal, Anuj
: Exporting functions doing common register access -Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Tuesday, November 17, 2009 2:46 AM To: Aggarwal, Anuj Cc: linux-omap@vger.kernel.org Subject: Re: [PATCH] OMAP: Exporting functions doing common register access

Re: [PATCH] OMAP: Exporting functions doing common register access

2009-11-16 Thread Paul Walmsley
Hello Anuj, On Mon, 16 Nov 2009, Anuj Aggarwal wrote: These functions need to be exported so that drivers (e.g. McBSP) can be configured as modules. McBSP driver gets built as a module when ASoC driver for OMAP3 EVM is configured as module. McBSP driver uses functions like

RE: [PATCH] OMAP: Exporting functions doing common register access

2009-11-16 Thread Aggarwal, Anuj
-Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Tuesday, November 17, 2009 2:46 AM To: Aggarwal, Anuj Cc: linux-omap@vger.kernel.org Subject: Re: [PATCH] OMAP: Exporting functions doing common register access Hello Anuj, On Mon, 16 Nov 2009, Anuj Aggarwal