RE: [PATCH-V2 3/4] ARM: OMAP2+: CLEANUP: Remove unnecessary ifdef around __omap2_set_globals

2012-05-14 Thread Hiremath, Vaibhav
On Sat, May 12, 2012 at 03:24:51, Hilman, Kevin wrote: > "Hiremath, Vaibhav" writes: > > > On Fri, May 11, 2012 at 03:09:39, Hilman, Kevin wrote: > >> "Hiremath, Vaibhav" writes: > >> > >> > On Wed, May 09, 2012 at 04:08:09, Hilman, Kevin wrote: > >> >> Vaibhav Hiremath writes: > >> >> > >> >

Re: [PATCH-V2 3/4] ARM: OMAP2+: CLEANUP: Remove unnecessary ifdef around __omap2_set_globals

2012-05-11 Thread Kevin Hilman
"Hiremath, Vaibhav" writes: > On Fri, May 11, 2012 at 03:09:39, Hilman, Kevin wrote: >> "Hiremath, Vaibhav" writes: >> >> > On Wed, May 09, 2012 at 04:08:09, Hilman, Kevin wrote: >> >> Vaibhav Hiremath writes: >> >> >> >> > The function __omap2_set_globals() can be common across all >> >> > p

RE: [PATCH-V2 3/4] ARM: OMAP2+: CLEANUP: Remove unnecessary ifdef around __omap2_set_globals

2012-05-10 Thread Hiremath, Vaibhav
On Fri, May 11, 2012 at 12:07:59, R, Sricharan wrote: > Vaibhav, > > > > >> > This patch adds new config flag SOC_HAS_OMAP2_SDRC to handle > > sdrc, > > > >> > so that we can reuse same function across omap2/3/4... > > > >> > > > >> But what happens when a single kernel is built that has support >

RE: [PATCH-V2 3/4] ARM: OMAP2+: CLEANUP: Remove unnecessary ifdef around __omap2_set_globals

2012-05-10 Thread Sricharan R
Vaibhav, > > >> > This patch adds new config flag SOC_HAS_OMAP2_SDRC to handle > sdrc, > > >> > so that we can reuse same function across omap2/3/4... > > >> > > >> But what happens when a single kernel is built that has support > for an > > >> SoC with an SDRC (OMAP4) and one that doesn't (AM33xx

RE: [PATCH-V2 3/4] ARM: OMAP2+: CLEANUP: Remove unnecessary ifdef around __omap2_set_globals

2012-05-10 Thread Hiremath, Vaibhav
On Fri, May 11, 2012 at 03:09:39, Hilman, Kevin wrote: > "Hiremath, Vaibhav" writes: > > > On Wed, May 09, 2012 at 04:08:09, Hilman, Kevin wrote: > >> Vaibhav Hiremath writes: > >> > >> > The function __omap2_set_globals() can be common across all > >> > platforms/architectures, even in case of

Re: [PATCH-V2 3/4] ARM: OMAP2+: CLEANUP: Remove unnecessary ifdef around __omap2_set_globals

2012-05-10 Thread Kevin Hilman
"Hiremath, Vaibhav" writes: > On Wed, May 09, 2012 at 04:08:09, Hilman, Kevin wrote: >> Vaibhav Hiremath writes: >> >> > The function __omap2_set_globals() can be common across all >> > platforms/architectures, even in case of omap4, internally it >> > calls same set of functions as in __omap2_

RE: [PATCH-V2 3/4] ARM: OMAP2+: CLEANUP: Remove unnecessary ifdef around __omap2_set_globals

2012-05-09 Thread Hiremath, Vaibhav
On Wed, May 09, 2012 at 04:08:09, Hilman, Kevin wrote: > Vaibhav Hiremath writes: > > > The function __omap2_set_globals() can be common across all > > platforms/architectures, even in case of omap4, internally it > > calls same set of functions as in __omap2_set_globals() function > > (except fo

Re: [PATCH-V2 3/4] ARM: OMAP2+: CLEANUP: Remove unnecessary ifdef around __omap2_set_globals

2012-05-08 Thread Kevin Hilman
Vaibhav Hiremath writes: > The function __omap2_set_globals() can be common across all > platforms/architectures, even in case of omap4, internally it > calls same set of functions as in __omap2_set_globals() function > (except for sdrc). OK so far. > This patch adds new config flag SOC_HAS_OMA