Hello Rajendra,
here are a few more comments on the CPUIdle patch set. Many of these, we
discussed today. A closer look at patch 11/11 reveals that it will need
some additional attention.
- Paul
General
---
1. Please separate the context save/restore patches from the CPUIdle
patches,
> -Original Message-
> From: Woodruff, Richard [mailto:[EMAIL PROTECTED]
> Sent: Wednesday, August 13, 2008 6:06 PM
> To: Högander Jouni; Nayak, Rajendra
> Cc: linux-omap@vger.kernel.org
> Subject: RE: [PATCH 00/11] OMAP3 CPUidle patches - ver 2
>
> > >
Hi Richard,
"ext Woodruff, Richard" <[EMAIL PROTECTED]> writes:
>> >> Doing this would make serial console to work faster.
>> >
>> > Yes, I removed these in my patches and put in the changes suggested by
>> Richard
>> > in 8250.c
>>
>> I doubt that your changes to 8250.c will be applied. I have u
> >> Doing this would make serial console to work faster.
> >
> > Yes, I removed these in my patches and put in the changes suggested by
> Richard
> > in 8250.c
>
> I doubt that your changes to 8250.c will be applied. I have understood
> that omap specific changes are not accepted to generic 8250
>
"ext Rajendra Nayak" <[EMAIL PROTECTED]> writes:
>>
>> Check wether serial can sleep is missing from
>> omap3_enter_idle and it should be removed from omap3_can_sleep:
>>
>> diff --git a/arch/arm/mach-omap2/cpuidle34xx.c
>> b/arch/arm/mach-omap2/cpuidle34xx.c
>> index a02da6d..16ff30b 100644
>
>
> >
> > Serial and gpio clock disabling and gpio_prepare/resume can
> be removed
> > from omap3_pm_idle because they are already done in omap_sram_idle.
> > And if omap_serial_can_sleep is removed from
> omap3_can_sleep it should
> > be added to omap3_pm_idle.
> > Omap3_pm_idle can be als
>
> Check wether serial can sleep is missing from
> omap3_enter_idle and it should be removed from omap3_can_sleep:
>
> diff --git a/arch/arm/mach-omap2/cpuidle34xx.c
> b/arch/arm/mach-omap2/cpuidle34xx.c
> index a02da6d..16ff30b 100644
> --- a/arch/arm/mach-omap2/cpuidle34xx.c
> +++ b/arch/arm
Hi Rajendra,
"ext Rajendra Nayak" <[EMAIL PROTECTED]> writes:
> Hi,
>
> Re-posting a refreshed version of these patches.
>
> regards
> Rajendra
I think these are beginning to look good to me, altought patches can't
be applied using git. Few things:
Check wether serial can sleep is missing from
On ke, 2008-08-06 at 18:42 +0530, ext Rajendra Nayak wrote:
> Hi,
>
> Re-posting a refreshed version of these patches.
I'm getting this error when trying to apply these patches with 'git-am'
command:
$ git-am ~/.evolution/mail/local/stage
Applying Basic cpuidle driver
fatal: patch fragment
