Re: [PATCH 02/24] omap2/3/4: ioremap omap_globals module

2010-02-16 Thread Paul Walmsley
Hello Santosh, some comments: On Tue, 16 Feb 2010, Santosh Shilimkar wrote: This is a clean-up patch towards dynamic allocation of IO space instead of using harcoded macros to calculate virtual addresses. Also update the sdrc, prcm, tap and control module to allocate iospace dynamically

RE: [PATCH 02/24] omap2/3/4: ioremap omap_globals module

2010-02-16 Thread Shilimkar, Santosh
snip /** diff --git a/arch/arm/plat-omap/common.c b/arch/arm/plat-omap/common.c index 4f29e8c..ee9499e 100644 --- a/arch/arm/plat-omap/common.c +++ b/arch/arm/plat-omap/common.c @@ -256,11 +256,11 @@ static void __init __omap2_set_globals(struct omap_globals *omap2_globals)