Re: [PATCH 05/11] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-06-11 Thread Cousson, Benoit
On 6/8/2012 9:10 PM, Hiremath, Vaibhav wrote: On Fri, Jun 08, 2012 at 01:33:46, Paul Walmsley wrote: Hi On Thu, 7 Jun 2012, Hiremath, Vaibhav wrote: I couldn't finish my testing today, got into continuous meetings. No worries, I understand. Tomorrow, I will test it and update you on this.

Re: [PATCH 05/11] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-06-08 Thread Paul Walmsley
On Fri, 8 Jun 2012, Tero Kristo wrote: > There's a bug in this patch, see below. ... > There should by binary or, not logical here. Thanks for reporting this, I've added some credit in the patch description. This has been fixed by switching back to using a flag-based approach based on some c

RE: [PATCH 05/11] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-06-08 Thread Hiremath, Vaibhav
On Fri, Jun 08, 2012 at 01:33:46, Paul Walmsley wrote: > Hi > > On Thu, 7 Jun 2012, Hiremath, Vaibhav wrote: > > > I couldn't finish my testing today, got into continuous meetings. > > No worries, I understand. > > > Tomorrow, I will test it and update you on this. > > That would be great. >

Re: [PATCH 05/11] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-06-08 Thread Tero Kristo
Hi Paul, There's a bug in this patch, see below. > { > @@ -1141,8 +1143,26 @@ static void _enable_sysc(struct omap_hwmod *oh) > sf = oh->class->sysc->sysc_flags; > > if (sf & SYSC_HAS_SIDLEMODE) { > - idlemode = (oh->flags & HWMOD_SWSUP_SIDLE) ? > -

RE: [PATCH 05/11] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-06-07 Thread Paul Walmsley
Hi On Thu, 7 Jun 2012, Hiremath, Vaibhav wrote: > I couldn't finish my testing today, got into continuous meetings. No worries, I understand. > Tomorrow, I will test it and update you on this. That would be great. I took a look at SPRUH73F and sure enough, at least one module (CONTROL) doesn

RE: [PATCH 05/11] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-06-07 Thread Hiremath, Vaibhav
On Thu, Jun 07, 2012 at 12:38:50, Paul Walmsley wrote: > Hi > > On Thu, 7 Jun 2012, Hiremath, Vaibhav wrote: > > > Isn't this impact AM33xx devices, where we do not support smart idle mode??? > > Anyway, I will also test it on both OMAP3EVM and AM33xx platform now... > > Thanks, please let me kn

RE: [PATCH 05/11] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-06-07 Thread Paul Walmsley
Hi On Thu, 7 Jun 2012, Hiremath, Vaibhav wrote: > Isn't this impact AM33xx devices, where we do not support smart idle mode??? > Anyway, I will also test it on both OMAP3EVM and AM33xx platform now... Thanks, please let me know how your tests go. If it doesn't work, we'll go back to the flag-b

RE: [PATCH 05/11] ARM: OMAP2+: hwmod code/data: fix 32K sync timer

2012-06-06 Thread Hiremath, Vaibhav
On Thu, Jun 07, 2012 at 11:43:10, Paul Walmsley wrote: > Kevin discovered that commit c8d82ff68fb6873691536cf33021977efbf5593c > ("ARM: OMAP2/3: hwmod data: Add 32k-sync timer data to hwmod > database") broke CORE idle on OMAP3. This prevents device low power > states. > > The root cause is that