Re: [PATCH 1/1] Watchdog: OMAP3: fix wrong boot status from wdt reboot

2012-07-05 Thread zumeng.chen
On 2012年07月05日 21:05, Bedia, Vaibhav wrote: Hello, On Wed, Jul 04, 2012 at 21:24:01, Zumeng Chen wrote: Does the following fix make sense? WDIOC_GETBOOTSTATUS always return 0 even if the machine comes from omap-wdt reboot. Because WKUP_MOD is not right for OMAP3, so give the right addr 0xA00 o

RE: [PATCH 1/1] Watchdog: OMAP3: fix wrong boot status from wdt reboot

2012-07-05 Thread Bedia, Vaibhav
Hello, On Wed, Jul 04, 2012 at 21:24:01, Zumeng Chen wrote: > Does the following fix make sense? > > WDIOC_GETBOOTSTATUS always return 0 even if the machine > comes from omap-wdt reboot. Because WKUP_MOD is not right > for OMAP3, so give the right addr 0xA00 of PRM_RSTST for > get_reset_sources,

Re: [PATCH 1/1] Watchdog: OMAP3: fix wrong boot status from wdt reboot

2012-07-04 Thread Zumeng Chen
于 2012年07月05日 13:39, Shubhrajyoti 写道: Hello, On Wednesday 04 July 2012 09:27 PM, zumeng.chen wrote: To: Shubhrajyoti On 2012年07月04日 23:54, Zumeng Chen wrote: Does the following fix make sense? yes , thanks for the patch. IIRC Rajendra had a similar one. Some comments below. WDIOC_GETBOOTSTATU

Re: [PATCH 1/1] Watchdog: OMAP3: fix wrong boot status from wdt reboot

2012-07-04 Thread Shubhrajyoti
Hello, On Wednesday 04 July 2012 09:27 PM, zumeng.chen wrote: > To: Shubhrajyoti > On 2012年07月04日 23:54, Zumeng Chen wrote: >> Does the following fix make sense? yes , thanks for the patch. IIRC Rajendra had a similar one. Some comments below. >> >> WDIOC_GETBOOTSTATUS always return 0 even if the m

Re: [PATCH 1/1] Watchdog: OMAP3: fix wrong boot status from wdt reboot

2012-07-04 Thread zumeng.chen
To: Shubhrajyoti On 2012年07月04日 23:54, Zumeng Chen wrote: Does the following fix make sense? WDIOC_GETBOOTSTATUS always return 0 even if the machine comes from omap-wdt reboot. Because WKUP_MOD is not right for OMAP3, so give the right addr 0xA00 of PRM_RSTST for get_reset_sources, which inputs