Vaibhav,
>[Murali] Shouldn't we remove omap_vout_uservirt_to_phys() and use
>videobuf_iolock() instead as we have done in vpfe_capture.c?
>
>As mentioned before, in my opinion we can address this in sub-sequent patch
>series, and should not block this patch in getting to main-line.
>
>> +/*
>> + *
bject: Re: [PATCH 1/2] OMAP2/3 V4L2: Add support for OMAP2/3 V4L2 driver
> on top of DSS2
>
> Hi Vaibhav,
>
> Here is my review. I've tried to avoid repeating the points Murali made.
[Hiremath, Vaibhav] Thanks Hans, I do agree with all of them. I have already
incorporate
/2] OMAP2/3 V4L2: Add support for OMAP2/3 V4L2 driver
> on top of DSS2
>
>
> Vaibhav,
>
> >>
> >[Hiremath, Vaibhav] Thanks Murali, I really appreciate your comments here.
> >Please find response below -
>
> You had responded only to some comments. Can I
hvaib...@ti.com wrote:
From: Vaibhav Hiremath
Features Supported -
1. Provides V4L2 user interface for the video pipelines of DSS
2. Basic streaming working on LCD, DVI and TV.
3. Works on latest DSS2 library from Tomi
4. Support for various pixel formats like YUV
Vaibhav,
>>
>[Hiremath, Vaibhav] Thanks Murali, I really appreciate your comments here.
>Please find response below -
You had responded only to some comments. Can I assume that you are taking care
of the other comments as well? I have also asked Hans to provide
his comments since this is a new
.com
> Subject: Re: [PATCH 1/2] OMAP2/3 V4L2: Add support for OMAP2/3 V4L2 driver
> on top of DSS2
>
> Vaibhav,
>
> I have some comments on this patch. Please address them.
>
[Hiremath, Vaibhav] Thanks Murali, I really appreciate your comments here.
Please find response below -
&
Vaibhav,
I have some comments on this patch. Please address them.
> +
> +#include
Add a line here??
> +#include
> +#include
> +#include
> +#include
> +
> +#include "omap_voutlib.h"
> +#include "omap_voutdef.h"
> +
> +MODULE_AUTHOR("Texas Instruments");
> +MODULE_DESCRIPTION("OMAP Video for
