Re: [PATCH 1/4] initial support for LogicPD's OMAP3 SOM and TORPEDO development kits

2010-08-11 Thread Russell King - ARM Linux
Jacob, Please avoid sending copies of your messages to all addresses you can find for me. I only require one copy, preferably to the linux@ address if its mainly about Linux stuff. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord

Re: [PATCH 1/4] initial support for LogicPD's OMAP3 SOM and TORPEDO development kits

2010-08-11 Thread Felipe Balbi
On Wed, Aug 11, 2010 at 08:51:22PM +0200, ext Jacob Tanenbaum wrote: Valid point we will remove the ifdefs please follow the Netiquette [1]. Send only plain text emails, with your replies right below the topic you're replying to. Don't top-post, it makes it really difficult to follow you're e

RE: [PATCH 1/4] initial support for LogicPD's OMAP3 SOM and TORPEDO development kits

2010-08-11 Thread Jacob Tanenbaum
] initial support for LogicPD's OMAP3 SOM and TORPEDO development kits Jacob Tanenbaum writes: > Adding LogicPD OMAP3 board support > > Adding support for LogicPD's OMAP 3530 LV SOM and > OMAP 35x Torpedo board. > >

RE: [PATCH 1/4] initial support for LogicPD's OMAP3 SOM and TORPEDO development kits

2010-08-11 Thread Jacob Tanenbaum
; r...@arm.linux.org.uk; t...@atomide.com Subject: Re: [PATCH 1/4] initial support for LogicPD's OMAP3 SOM and TORPEDO development kits Hi, On Wed, Aug 11, 2010 at 08:45:22PM +0200, ext Jacob Tanenbaum wrote: >No one else uses the ifdef but we were told from an earlier submission >we sho

Re: [PATCH 1/4] initial support for LogicPD's OMAP3 SOM and TORPEDO development kits

2010-08-11 Thread Felipe Balbi
Hi, On Wed, Aug 11, 2010 at 08:45:22PM +0200, ext Jacob Tanenbaum wrote: No one else uses the ifdef but we were told from an earlier submission we should because if both boards are disabled in the .config it would inform the user on bootup What do you mean ? If these boards are't enabled on .c

RE: [PATCH 1/4] initial support for LogicPD's OMAP3 SOM and TORPEDO development kits

2010-08-11 Thread Jacob Tanenbaum
] initial support for LogicPD's OMAP3 SOM and TORPEDO development kits Hi Jacob, few style comments only On Wed, Aug 11, 2010 at 06:31:34PM +0200, ext Jacob Tanenbaum wrote: > > Adding LogicPD OMAP3 board support > > Adding support for LogicPD's OMAP 3530 LV SOM

Re: [PATCH 1/4] initial support for LogicPD's OMAP3 SOM and TORPEDO development kits

2010-08-11 Thread Kevin Hilman
Jacob Tanenbaum writes: > Adding LogicPD OMAP3 board support > > Adding support for LogicPD's OMAP 3530 LV SOM and > OMAP 35x Torpedo board. > >Tested against: linux-next 81e09f50c93edff607259cbe374a3006c9c5fa74 > Signed-off-by: Jacob Tanenbaum [

Re: [PATCH 1/4] initial support for LogicPD's OMAP3 SOM and TORPEDO development kits

2010-08-11 Thread Sam Ravnborg
Hi Jacob. Some quick comments. Sam > diff --git a/arch/arm/configs/omap3_defconfig > b/arch/arm/configs/omap3_defconfig > index 5db9a6b..f510dfd 100644 > --- a/arch/arm/configs/omap3_defconfig > +++ b/arch/arm/configs/omap3_defconfig > @@ -37,6 +37,8 @@ CONFIG_MACH_OMAP_2430SDP=y > CON

Re: [PATCH 1/4] initial support for LogicPD's OMAP3 SOM and TORPEDO development kits

2010-08-11 Thread Felipe Balbi
Hi Jacob, few style comments only On Wed, Aug 11, 2010 at 06:31:34PM +0200, ext Jacob Tanenbaum wrote: Adding LogicPD OMAP3 board support Adding support for LogicPD's OMAP 3530 LV SOM and OMAP 35x Torpedo board. Tested against: linux-next 81e09f50c93e