RE: [PATCH 1/5] OMAP1/2/3/4: DEBUG_LL: cleanup

2009-09-18 Thread Pandita, Vikram
>-Original Message- >From: Russell King - ARM Linux [mailto:li...@arm.linux.org.uk] >Sent: Thursday, September 17, 2009 2:48 PM >To: Pandita, Vikram >Cc: Kevin Hilman; linux-omap@vger.kernel.org; >linux-arm-ker...@lists.arm.linux.org.uk >Subject: Re: [PATCH 1/5]

Re: [PATCH 1/5] OMAP1/2/3/4: DEBUG_LL: cleanup

2009-09-17 Thread Russell King - ARM Linux
On Fri, Sep 18, 2009 at 12:30:25AM +0530, Pandita, Vikram wrote: > There are review comments by Kevin [2] still getting fixed, > but a 'Russell-look' will surely help to the in-lined patch [3] . Still not good. > + mov r9, r0 > + > + bl get_uart_base @

RE: [PATCH 1/5] OMAP1/2/3/4: DEBUG_LL: cleanup

2009-09-17 Thread Pandita, Vikram
Russell >-Original Message- >From: Russell King - ARM Linux [mailto:li...@arm.linux.org.uk] >Sent: Wednesday, September 16, 2009 2:11 PM >To: Kevin Hilman >Cc: Pandita, Vikram; linux-omap@vger.kernel.org; >linux-arm-ker...@lists.arm.linux.org.uk >Subject: Re: [P

Re: [PATCH 1/5] OMAP1/2/3/4: DEBUG_LL: cleanup

2009-09-16 Thread Russell King - ARM Linux
On Thu, Aug 27, 2009 at 04:29:35PM +0300, Kevin Hilman wrote: > > The idea is to write to phys_io and io_pg_offset from kernel/head.S > > very early based on the uart address found in compressed/misc.c > > > > To make map_io writable, I will have to change the MACHINE_START to > > remove the const.

Re: [PATCH 1/5] OMAP1/2/3/4: DEBUG_LL: cleanup

2009-08-27 Thread Kevin Hilman
"Pandita, Vikram" writes: >>-Original Message- >>From: Kevin Hilman [mailto:khil...@deeprootsystems.com] >>"Pandita, Vikram" writes: >> Vikram Pandita wrote: > This patch cleans up the DEBUG_LL infrastructure for omap boards. >>> Could you give reference to this code on DaVi

RE: [PATCH 1/5] OMAP1/2/3/4: DEBUG_LL: cleanup

2009-08-27 Thread Pandita, Vikram
>-Original Message- >From: Kevin Hilman [mailto:khil...@deeprootsystems.com] >"Pandita, Vikram" writes: > >>>Vikram Pandita wrote: This patch cleans up the DEBUG_LL infrastructure for omap boards. >>> >> >> Could you give reference to this code on DaVinci? > >http://git.kernel.org/?

Re: [PATCH 1/5] OMAP1/2/3/4: DEBUG_LL: cleanup

2009-08-27 Thread Kevin Hilman
"Pandita, Vikram" writes: >>Vikram Pandita wrote: >>> This patch cleans up the DEBUG_LL infrastructure for omap boards. >> >>Thanks Vikram, this is indeed in need of some cleanup. But I have some >>comments about the approach taken. >> >>This approach still doesn't solve one of the fundamental p

RE: [PATCH 1/5] OMAP1/2/3/4: DEBUG_LL: cleanup

2009-08-26 Thread Pandita, Vikram
Kevin >-Original Message- >From: Kevin Hilman [mailto:khil...@deeprootsystems.com] >Sent: Saturday, August 22, 2009 2:57 AM >To: Pandita, Vikram >Cc: linux-omap@vger.kernel.org; linux-arm-ker...@lists.arm.linux.org.uk >Subject: Re: [PATCH 1/5] OMAP1/2/3/4: DEBUG_LL:

Re: [PATCH 1/5] OMAP1/2/3/4: DEBUG_LL: cleanup

2009-08-24 Thread Tony Lindgren
* Kevin Hilman [090822 16:31]: > Vikram Pandita wrote: >> This patch cleans up the DEBUG_LL infrastructure for omap boards. > > Thanks Vikram, this is indeed in need of some cleanup. But I have some > comments about the approach taken. > > This approach still doesn't solve one of the fundamental

Re: [PATCH 1/5] OMAP1/2/3/4: DEBUG_LL: cleanup

2009-08-22 Thread Kevin Hilman
Vikram Pandita wrote: This patch cleans up the DEBUG_LL infrastructure for omap boards. Thanks Vikram, this is indeed in need of some cleanup. But I have some comments about the approach taken. This approach still doesn't solve one of the fundamental problems with the current implementation.

RE: [PATCH 1/5] OMAP1/2/3/4: DEBUG_LL: cleanup

2009-08-22 Thread Shilimkar, Santosh
Vikram, Thanks for this clean-up series !! Couple of comments. > -Original Message- > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > ow...@vger.kernel.org] On Behalf Of Pandita, Vikram > Sent: Friday, August 21, 2009 11:25 PM > To: linux-omap@vger.kernel.org; linux-arm-ker..