Re: [PATCH 1/6 v2] OMAP4: Fix cpu detection

2009-12-11 Thread Nishanth Menon
On Thu, Dec 10, 2009 at 10:43 PM, Shilimkar, Santosh wrote: >> > >> > +void __init omap4_check_revision(void) >> > +{ >> > +   u32 idcode; >> > +   u16 hawkeye; >> > +   u8 rev; >> > +   char *rev_name = "ES1.0"; >> should'nt you decide this inside the rev check path? > > This is initialized value

RE: [PATCH 1/6 v2] OMAP4: Fix cpu detection

2009-12-10 Thread Shilimkar, Santosh
> > > > +void __init omap4_check_revision(void) > > +{ > > + u32 idcode; > > + u16 hawkeye; > > + u8 rev; > > + char *rev_name = "ES1.0"; > should'nt you decide this inside the rev check path? This is initialized value by default. Since the chip is ES1.0 additionaly I am not doing it. e.g

Re: [PATCH 1/6 v2] OMAP4: Fix cpu detection

2009-12-10 Thread Nishanth Menon
Shilimkar, Santosh had written, on 12/10/2009 12:22 AM, the following: This patch fixes the OMAP4430 cpu detection. The IC rev detection is done with hawkeye and rev. Note that rev does not map directly to defined processor revision numbers as ES1.0 uses value 0.It also fixes the SCM base address