Re: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-08-10 Thread Ohad Ben-Cohen
On Tue, Jul 6, 2010 at 8:42 PM, Nicolas Pitre wrote: > Another function pair would be needed instead, which would do almost > like the suspend/resume code is already doing.  Something like: > > /* >  * Indicate to the core SDIO layer that we're not requiring that the >  * function remain powered.

Re: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-09 Thread Grazvydas Ignotas
On Fri, Jul 9, 2010 at 11:32 AM, Ohad Ben-Cohen wrote: > Hi Roger, > > On Fri, Jul 9, 2010 at 11:12 AM, Roger Quadros > wrote: >> You are already >> creating a new platform device for wl1271_sdio just to pass platform_data > > With the new approach, I can remove this platform device altogether,

Re: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-09 Thread Ohad Ben-Cohen
Hi Roger, On Fri, Jul 9, 2010 at 11:12 AM, Roger Quadros wrote: > You are already > creating a new platform device for wl1271_sdio just to pass platform_data With the new approach, I can remove this platform device altogether, and completely rely on the sdio function device for driver probing (a

Re: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-09 Thread Roger Quadros
Hi Ohad, On 07/08/2010 11:10 PM, ext Ohad Ben-Cohen wrote: Hi Nicolas and Roger, On Tue, Jul 6, 2010 at 8:42 PM, Nicolas Pitre wrote: On Tue, 6 Jul 2010, Roger Quadros wrote: If the Power enable GPIO can be treated as SDIO slot supply (i.e. vmmc), then the SDIO/MMC core should tackle it, jus

Re: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-08 Thread Ohad Ben-Cohen
Hi Nicolas and Roger, On Tue, Jul 6, 2010 at 8:42 PM, Nicolas Pitre wrote: > On Tue, 6 Jul 2010, Roger Quadros wrote: > > If the Power enable GPIO can be treated as SDIO slot supply (i.e. vmmc), > > then > > the SDIO/MMC core should tackle it, just like it deals with supply for slots > > with re

Re: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-08 Thread Roger Quadros
On 07/07/2010 04:52 PM, ext Nicolas Pitre wrote: On Wed, 7 Jul 2010, Roger Quadros wrote: On 07/06/2010 08:42 PM, ext Nicolas Pitre wrote: On Tue, 6 Jul 2010, Roger Quadros wrote: OK, this is how I see it. - Treat the non-removable card as non-removable. So no need to do card detect emulati

Re: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-07 Thread Nicolas Pitre
On Wed, 7 Jul 2010, Adrian Hunter wrote: > Nicolas Pitre wrote: > > On Wed, 7 Jul 2010, Roger Quadros wrote: > > > > > On 07/06/2010 10:51 PM, Hunter Adrian (Nokia-MS/Helsinki) wrote: > > > > For eMMC in omap_hsmmc, this is all done via claim_host / release_host > > > > which call ->enable() / ->

Re: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-07 Thread Adrian Hunter
Nicolas Pitre wrote: On Wed, 7 Jul 2010, Roger Quadros wrote: On 07/06/2010 10:51 PM, Hunter Adrian (Nokia-MS/Helsinki) wrote: For eMMC in omap_hsmmc, this is all done via claim_host / release_host which call ->enable() / ->disable() methods. omap_hsmmc makes use of mmc_power_restore_host() w

RE: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-07 Thread Nicolas Pitre
> > wirel...@vger.kernel.org; linux-...@vger.kernel.org; linux- > > o...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > > li...@arm.linux.org.uk; Chikkature Rajashekar Madhusudhan; Coelho Luciano > > (Nokia-MS/Helsinki); a...@linux-foundation.org; San Mehat > &g

RE: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-07 Thread Madhusudhan
ger.kernel.org; linux-arm-ker...@lists.infradead.org; > li...@arm.linux.org.uk; Chikkature Rajashekar Madhusudhan; Coelho Luciano > (Nokia-MS/Helsinki); a...@linux-foundation.org; San Mehat > Subject: Re: [PATCH 11/15] wireless: wl1271: introduce platform device > support > >

Re: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-07 Thread Nicolas Pitre
On Wed, 7 Jul 2010, Roger Quadros wrote: > On 07/06/2010 10:51 PM, Hunter Adrian (Nokia-MS/Helsinki) wrote: > > For eMMC in omap_hsmmc, this is all done via claim_host / release_host > > which call ->enable() / ->disable() methods. omap_hsmmc makes use of > > mmc_power_restore_host() which calls

Re: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-07 Thread Nicolas Pitre
On Wed, 7 Jul 2010, Roger Quadros wrote: > On 07/06/2010 08:42 PM, ext Nicolas Pitre wrote: > > On Tue, 6 Jul 2010, Roger Quadros wrote: > > > > > OK, this is how I see it. > > > > > > - Treat the non-removable card as non-removable. So no need to do card > > > detect > > > emulation. > > > > >

Re: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-07 Thread Roger Quadros
On 07/06/2010 10:51 PM, Hunter Adrian (Nokia-MS/Helsinki) wrote: Nicolas Pitre wrote: On Tue, 6 Jul 2010, Roger Quadros wrote: On 07/06/2010 03:53 PM, ext Ohad Ben-Cohen wrote: Hi Roger, On Tue, Jul 6, 2010 at 1:35 PM, Roger Quadros wrote: My point is that shouldn't this be handled by SDIO

Re: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-07 Thread Roger Quadros
On 07/06/2010 08:42 PM, ext Nicolas Pitre wrote: On Tue, 6 Jul 2010, Roger Quadros wrote: On 07/06/2010 03:53 PM, ext Ohad Ben-Cohen wrote: Hi Roger, On Tue, Jul 6, 2010 at 1:35 PM, Roger Quadros wrote: My point is that shouldn't this be handled by SDIO core? Care to explain what you mean

Re: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-06 Thread Adrian Hunter
Nicolas Pitre wrote: On Tue, 6 Jul 2010, Roger Quadros wrote: On 07/06/2010 03:53 PM, ext Ohad Ben-Cohen wrote: Hi Roger, On Tue, Jul 6, 2010 at 1:35 PM, Roger Quadros wrote: My point is that shouldn't this be handled by SDIO core? Care to explain what you mean / give a code example ? If t

Re: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-06 Thread Nicolas Pitre
On Tue, 6 Jul 2010, Roger Quadros wrote: > On 07/06/2010 03:53 PM, ext Ohad Ben-Cohen wrote: > > Hi Roger, > > > > On Tue, Jul 6, 2010 at 1:35 PM, Roger Quadros > > wrote: > > > My point is that shouldn't this be handled by SDIO core? > > > > Care to explain what you mean / give a code example ?

Re: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-06 Thread Roger Quadros
On 07/06/2010 03:53 PM, ext Ohad Ben-Cohen wrote: Hi Roger, On Tue, Jul 6, 2010 at 1:35 PM, Roger Quadros wrote: My point is that shouldn't this be handled by SDIO core? Care to explain what you mean / give a code example ? If the Power enable GPIO can be treated as SDIO slot supply (i.e.

Re: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-06 Thread Ohad Ben-Cohen
Hi Roger, On Tue, Jul 6, 2010 at 1:35 PM, Roger Quadros wrote: > My point is that shouldn't this be handled by SDIO core? Care to explain what you mean / give a code example ? > If there are no users for the SDIO function and the card, doesn't the SDIO > core power down the slot and take care o

Re: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-06 Thread Roger Quadros
Hi Ohad, On 07/06/2010 12:30 PM, ext Ohad Ben-Cohen wrote: Hi Roger, On Tue, Jul 6, 2010 at 11:53 AM, Roger Quadros wrote: Could you please explain why you need to do this? To minimize power consumption when the wlan device is not in use, we would like to keep the device powered off as long

Re: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-06 Thread Ohad Ben-Cohen
Hi Roger, On Tue, Jul 6, 2010 at 11:53 AM, Roger Quadros wrote: > Could you please explain why you need to do this? To minimize power consumption when the wlan device is not in use, we would like to keep the device powered off as long as the interface is down, and only power it on when the user

Re: [PATCH 11/15] wireless: wl1271: introduce platform device support

2010-07-06 Thread Roger Quadros
Hi, On 07/06/2010 03:37 AM, ext Ohad Ben-Cohen wrote: From: Ohad Ben-Cohen Introduce a platform device support which is decoupled from the life cycle of the sdio function. The platform device objective is to deliver board-specific values (like irq, ref_clock, and software card-detect emulation