f.org.uk;
> sa...@linux.intel.com;
> l...@slimlogic.co.uk; Nayak, Rajendra; Syed, Rafiuddin; Ben Dooks
> Subject: Re: [PATCH 16/24] omap4: Add i2c support on omap4 platform
>
> Hello Santosh,
>
> one general comment on this patch, before the specific comments. Rather
> than addi
Rafiuddin; Ben Dooks
> Subject: Re: [PATCH 16/24] omap4: Add i2c support on omap4 platform
>
> * Santosh Shilimkar [100216 07:55]:
> > This patch is rebased version of earlier post to add I2C
> > driver support to OMAP4 platform. On OMAP4, all
> > I2C register address offs
Hello Santosh,
one general comment on this patch, before the specific comments. Rather
than adding more cpu_is_omap*() all over, please instead convert this code
to use flags passed in via platform_data. The I2C hwmod conversion
patches are one attempt to do that via the hwmod mechanism; you
* Santosh Shilimkar [100216 07:55]:
> This patch is rebased version of earlier post to add I2C
> driver support to OMAP4 platform. On OMAP4, all
> I2C register address offsets are changed from OMAP1/2/3 I2C.
> In order to not have #ifdef's at various places in code,
> as well as to support multi-O
