Re: [PATCH 2/2] Input: ads7846 - configure pendown gpio as input

2011-02-02 Thread Varadarajan, Charulatha
On Thu, Feb 3, 2011 at 12:06, Anand Gadiyar wrote: > Varadarajan, Charulatha wrote: >> On Wed, Feb 2, 2011 at 21:00, Sourav Poddar > wrote: >> > The ads7846 driver requests a gpio to detect pendown events, >> > but does not configure its direction. Configure this gpio >> > as an input after reque

RE: [PATCH 2/2] Input: ads7846 - configure pendown gpio as input

2011-02-02 Thread Anand Gadiyar
Varadarajan, Charulatha wrote: > On Wed, Feb 2, 2011 at 21:00, Sourav Poddar wrote: > > The ads7846 driver requests a gpio to detect pendown events, > > but does not configure its direction. Configure this gpio > > as an input after requesting it. > > > > NACK to this patch too for similar reasons

Re: [PATCH 2/2] Input: ads7846 - configure pendown gpio as input

2011-02-02 Thread Varadarajan, Charulatha
On Wed, Feb 2, 2011 at 21:00, Sourav Poddar wrote: > The ads7846 driver requests a gpio to detect pendown events, > but does not configure its direction. Configure this gpio > as an input after requesting it. > NACK to this patch too for similar reasons as in patch1 of this series. > Signed-off-

Re: [PATCH 2/2] Input: ads7846 - configure pendown gpio as input

2011-02-02 Thread Felipe Balbi
Hi, On Wed, Feb 02, 2011 at 09:00:46PM +0530, Sourav Poddar wrote: > The ads7846 driver requests a gpio to detect pendown events, > but does not configure its direction. Configure this gpio > as an input after requesting it. > > Signed-off-by: Sourav Poddar > --- > drivers/input/touchscreen/ads