Re: [PATCH 2/2] omap:mailbox-provide multiple reader support

2010-07-28 Thread Ohad Ben-Cohen
Hi Hari, On Wed, Jul 28, 2010 at 1:02 AM, Ohad Ben-Cohen wrote: > On Wed, Jul 21, 2010 at 12:41 AM, Hari Kanigeri wrote: > > This patch provides mutiple readers support for a mailbox > > instance. > > > > Signed-off-by: Hari Kanigeri > > --- > >  arch/arm/plat-omap/include/plat/mailbox.h |    6

Re: [PATCH 2/2] omap:mailbox-provide multiple reader support

2010-07-27 Thread Ohad Ben-Cohen
Hi Hari, On Wed, Jul 21, 2010 at 12:41 AM, Hari Kanigeri wrote: > This patch provides mutiple readers support for a mailbox > instance. > > Signed-off-by: Hari Kanigeri > --- >  arch/arm/plat-omap/include/plat/mailbox.h |    6 ++- >  arch/arm/plat-omap/mailbox.c              |   63 +

Re: [PATCH 2/2] omap:mailbox-provide multiple reader support

2010-07-22 Thread Hari Kanigeri
Fernando, Thanks for looking at the patch. On Tue, Jul 20, 2010 at 4:59 PM, Guzman Lugo, Fernando wrote: > > > Hi Hari, > >> >> @@ -252,28 +252,30 @@ static int omap_mbox_startup(struct omap_mbox *mbox) >>               } >>       } >> >> -     ret = request_irq(mbox->irq, mbox_interrupt, IRQF_S

Re: [PATCH 2/2] omap:mailbox-provide multiple reader support

2010-07-22 Thread Hari Kanigeri
Phil, Thanks for looking at the patch. On Wed, Jul 21, 2010 at 4:45 AM, wrote: > Apologies - top posting and not quoting properly due to having to use MS's > braindead OWA. > > It appears that most of the "changes" are simply indentation changes caused > by the inclusion of a new inner block

RE: [PATCH 2/2] omap:mailbox-provide multiple reader support

2010-07-21 Thread ext-phil.2.carmody
Apologies - top posting and not quoting properly due to having to use MS's braindead OWA. It appears that most of the "changes" are simply indentation changes caused by the inclusion of a new inner block here: + if (atomic_inc_return(&mbox->use_count) == 1) { rather than just using a goto

RE: [PATCH 2/2] omap:mailbox-provide multiple reader support

2010-07-20 Thread Guzman Lugo, Fernando
Hi Hari, > -Original Message- > From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- > ow...@vger.kernel.org] On Behalf Of Kanigeri, Hari > Sent: Tuesday, July 20, 2010 4:42 PM > To: Linux Omap; Tony Lindgren; Hiroshi DOYU > Cc: Ohad Ben-Cohen; Kanigeri, Hari > Subject: [PATCH 2/2]