Re: [PATCH 3/3] OMAP clock/hwmod: fix off-by-one errors

2009-11-18 Thread Paul Walmsley
On Wed, 18 Nov 2009, Tony Lindgren wrote: To me it sounds like this can wait until the merge window, so not adding to omap-fixes for now. Indeed, there's no rush on this one, so let's set it up for 2.6.33. I'll keep that macro in plat/system.h unless you or Russell have a better suggestion.

Re: [PATCH 3/3] OMAP clock/hwmod: fix off-by-one errors

2009-11-17 Thread Paul Walmsley
Hi Russell, On Mon, 16 Nov 2009, Russell King - ARM Linux wrote: On Mon, Nov 16, 2009 at 06:36:55AM -0700, Paul Walmsley wrote: Fix loop bailout off-by-one bugs reported by Juha Leppänen juha_motorsport...@luukku.com. I'm not sure the new code is any easier to read than the old code.

RE: [PATCH 3/3] OMAP clock/hwmod: fix off-by-one errors

2009-11-17 Thread Pandita, Vikram
Subject: Re: [PATCH 3/3] OMAP clock/hwmod: fix off-by-one errors snip +/** + * omap_test_timeout - busy-loop, testing a condition + * @cond: condition to test until it evaluates to true + * @timeout: maximum number of microseconds in the timeout + * @index: loop index (integer) + * + * Loop waiting

Re: [PATCH 3/3] OMAP clock/hwmod: fix off-by-one errors

2009-11-17 Thread Tony Lindgren
...@lists.infradead.org; Juha Leppänen; linux-omap@vger.kernel.org Subject: Re: [PATCH 3/3] OMAP clock/hwmod: fix off-by-one errors snip +/** + * omap_test_timeout - busy-loop, testing a condition + * @cond: condition to test until it evaluates to true + * @timeout: maximum number

Re: [PATCH 3/3] OMAP clock/hwmod: fix off-by-one errors

2009-11-16 Thread Russell King - ARM Linux
On Mon, Nov 16, 2009 at 06:36:55AM -0700, Paul Walmsley wrote: Fix loop bailout off-by-one bugs reported by Juha Leppänen juha_motorsport...@luukku.com. I'm not sure the new code is any easier to read than the old code. And what with some checks post-loop being = and others being , it's a