RE: [PATCH 3/3] OMAP4: clockdomain: Add wkup/sleep dependency support

2011-02-14 Thread Paul Walmsley
On Mon, 14 Feb 2011, Rajendra Nayak wrote: > Thanks for the changes. I used the 'integration-2.6.39-20110212-002' > tag (with the OMAP4 changes as well) and tested OFF mode in suspend > on my 3430sdp. > Also boot tested (making sure all static deps are cleared at boot) > on my 4430sdp. Sounds goo

RE: [PATCH 3/3] OMAP4: clockdomain: Add wkup/sleep dependency support

2011-02-14 Thread Rajendra Nayak
Hi Paul, > -Original Message- > From: Paul Walmsley [mailto:p...@pwsan.com] > Sent: Sunday, February 13, 2011 4:27 AM > To: Rajendra Nayak > Cc: linux-omap@vger.kernel.org; Kevin Hilman; Benoit Cousson; linux-arm-ker...@lists.infradead.org > Subject: RE: [PATCH 3/3]

RE: [PATCH 3/3] OMAP4: clockdomain: Add wkup/sleep dependency support

2011-02-12 Thread Paul Walmsley
Here's the updated OMAP4 version. The stable integration tag with this change is 'integration-2.6.39-20110212-002' of git://git.pwsan.com/linux-integration - Paul From: Rajendra Nayak Date: Sat, 12 Feb 2011 15:32:47 -0700 Subject: [PATCH] OMAP4: clockdomain: Add wkup/sleep dependency support

RE: [PATCH 3/3] OMAP4: clockdomain: Add wkup/sleep dependency support

2011-02-12 Thread Paul Walmsley
On Fri, 11 Feb 2011, Rajendra Nayak wrote: > > Does that sound okay to you? > > Yep, that sounds better. Here's an updated patch for the main code and the OMAP2/3 implementation. Comments, testing welcome. The stable integration tag with this change is 'integration-2.6.39-20110212-001' of gi

RE: [PATCH 3/3] OMAP4: clockdomain: Add wkup/sleep dependency support

2011-02-10 Thread Rajendra Nayak
> -Original Message- > From: Paul Walmsley [mailto:p...@pwsan.com] > Sent: Friday, February 11, 2011 10:44 AM > To: Rajendra Nayak > Cc: linux-omap@vger.kernel.org; Kevin Hilman; Benoit Cousson; linux-arm-ker...@lists.infradead.org > Subject: RE: [PATCH 3/3] OMAP4: clo

RE: [PATCH 3/3] OMAP4: clockdomain: Add wkup/sleep dependency support

2011-02-10 Thread Paul Walmsley
Hi Rajendra On Fri, 11 Feb 2011, Rajendra Nayak wrote: > Failing silently is going to make it more difficult to identify and fix. > Maybe a WARN in else? > > if (cd->clkdm) { > ... > } else > WARN() I was thinking it might be nice to put it right next to

RE: [PATCH 3/3] OMAP4: clockdomain: Add wkup/sleep dependency support

2011-02-10 Thread Rajendra Nayak
> -Original Message- > From: Paul Walmsley [mailto:p...@pwsan.com] > Sent: Friday, February 11, 2011 10:08 AM > To: Rajendra Nayak > Cc: linux-omap@vger.kernel.org; Kevin Hilman; Benoit Cousson; linux-arm-ker...@lists.infradead.org > Subject: RE: [PATCH 3/3] OMAP4: clo

RE: [PATCH 3/3] OMAP4: clockdomain: Add wkup/sleep dependency support

2011-02-10 Thread Paul Walmsley
On Fri, 11 Feb 2011, Rajendra Nayak wrote: > My initial version actually did have a check for cd->clkdm_name instead > of cd->clkdm, and then I ran into aborts when a clkdm, though belonging > to the right chip version, failed lookup (in clkdm_init) and left the > cd->clkdm pointer NULL. This h

RE: [PATCH 3/3] OMAP4: clockdomain: Add wkup/sleep dependency support

2011-02-10 Thread Rajendra Nayak
[PATCH 3/3] OMAP4: clockdomain: Add wkup/sleep dependency support > > Hi > > On Mon, 7 Feb 2011, Rajendra Nayak wrote: > > > Add OMAP4 platform specific implementation to support clkdm > > wkup and sleep dependencies a.k.a static dependencies. > > > > Signed-off-by

Re: [PATCH 3/3] OMAP4: clockdomain: Add wkup/sleep dependency support

2011-02-10 Thread Paul Walmsley
Hi On Mon, 7 Feb 2011, Rajendra Nayak wrote: > Add OMAP4 platform specific implementation to support clkdm > wkup and sleep dependencies a.k.a static dependencies. > > Signed-off-by: Rajendra Nayak This patch had a similar bug to the OMAP2/3 variants; updated patch follows - - Paul From: R

Re: [PATCH 3/3] OMAP4: clockdomain: Add wkup/sleep dependency support

2011-02-08 Thread Paul Walmsley
On Mon, 7 Feb 2011, Rajendra Nayak wrote: > Add OMAP4 platform specific implementation to support clkdm > wkup and sleep dependencies a.k.a static dependencies. > > Signed-off-by: Rajendra Nayak I made two minor changes to this before merging: one to keep the formatting of the OMAP4_CM_STATICD