RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-03-02 Thread Madhusudhan
: omap_hsmmc: enable SDIO card interrupts On Thu, Feb 18, 2010 at 12:21 PM, Paul Walmsley p...@pwsan.com wrote: (cc'ing Steve, Richard, Anand) There appear to be least seven SDIO card drivers in 2.6.34-rc7. At least one of these is for a TI chip - the wl1251.  I think some of the Gumstix

Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-03-02 Thread Steve Sakoman
On Tue, Mar 2, 2010 at 2:08 PM, Madhusudhan madhu...@ti.com wrote: That is correct, a Wi2Wi wifi module is connected via mmc2 on the Overo Air and Fire products. A dumb question. Is this Wi2Wi wifi module available as a standard SDIO card which can be plugged into a SD card cage? Or is it

Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-22 Thread David Vrabel
Madhusudhan wrote: A little bit of rearranging the David's changes to the irq handler gets the MMC/SD cards to work fine again. Changes are shown in the attached patch for now and it should not hurt the CIRQ handling as well. This breaks detecting card interrupts unless a command is in

RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-19 Thread Madhusudhan
-Original Message- From: David Vrabel [mailto:david.vra...@csr.com] Sent: Wednesday, February 10, 2010 5:52 AM To: linux-...@vger.kernel.org Cc: David Vrabel; linux-omap@vger.kernel.org; madhu...@ti.com Subject: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts Enable the

RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-19 Thread Madhusudhan
: omap_hsmmc: enable SDIO card interrupts Hi, (cc'ing Steve, Richard, Anand) On Thu, 18 Feb 2010, Madhusudhan wrote: Not to add further confusion but as far as I understand SDIO should be able to asynchronously wakeup OMAP regardless of MMC clocks being OFF . As per the SDIO spec DAT1

RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-19 Thread Madhusudhan
-Original Message- From: linux-mmc-ow...@vger.kernel.org [mailto:linux-mmc- ow...@vger.kernel.org] On Behalf Of Madhusudhan Sent: Friday, February 19, 2010 3:05 PM To: 'David Vrabel'; linux-...@vger.kernel.org Cc: linux-omap@vger.kernel.org Subject: RE: [PATCH 3/3] mmc: omap_hsmmc

Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread David Vrabel
Madhusudhan wrote: My question was more related to the idle path. In a scenario where you start using the SDIO functionality and after some time you leave the SDIO card idle, does the FCLK still remain enabled? Or do you see that sdio_irq_thread exits and disables the FCLK? What do you mean

RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread Madhusudhan
-Original Message- From: David Vrabel [mailto:david.vra...@csr.com] Sent: Thursday, February 18, 2010 6:16 AM To: Madhusudhan Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org Subject: Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts Madhusudhan wrote: My

Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread Paul Walmsley
On Thu, 18 Feb 2010, David Vrabel wrote: Paul Walmsley wrote: Perhaps I'm misunderstanding what you're referring to, but it seems there is some confusion as to what target smart-idle mode does. The TI OMAP 34xx TRM is the one of the most obtuse document I've had to read. An even

RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread Madhusudhan
-Original Message- From: Paul Walmsley [mailto:p...@pwsan.com] Sent: Thursday, February 18, 2010 11:44 AM To: David Vrabel Cc: Madhusudhan; linux-...@vger.kernel.org; linux-omap@vger.kernel.org Subject: Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts On Thu, 18 Feb

RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread Nicolas Pitre
On Thu, 18 Feb 2010, Madhusudhan wrote: If I look in the mainline kernel today there is only one SDIO card driver sdio_uart.c. And at least I don't see a way I can test any of these features myself. There are many other SDIO drivers in the kernel today: - The libertas wireless driver

RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread Madhusudhan
-Original Message- From: Nicolas Pitre [mailto:n...@fluxnic.net] Sent: Thursday, February 18, 2010 1:27 PM To: Madhusudhan Cc: 'Paul Walmsley'; 'David Vrabel'; linux-...@vger.kernel.org; linux- o...@vger.kernel.org Subject: RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card

RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread Paul Walmsley
Hi, (cc'ing Steve, Richard, Anand) On Thu, 18 Feb 2010, Madhusudhan wrote: Not to add further confusion but as far as I understand SDIO should be able to asynchronously wakeup OMAP regardless of MMC clocks being OFF . As per the SDIO spec DAT1 line is used for signaling the card interrupt

Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread Steve Sakoman
On Thu, Feb 18, 2010 at 12:21 PM, Paul Walmsley p...@pwsan.com wrote: (cc'ing Steve, Richard, Anand) There appear to be least seven SDIO card drivers in 2.6.34-rc7. At least one of these is for a TI chip - the wl1251.  I think some of the Gumstix Overo OMAP3 boards are using an

Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-18 Thread Nicolas Pitre
On Thu, 18 Feb 2010, Steve Sakoman wrote: On Thu, Feb 18, 2010 at 12:21 PM, Paul Walmsley p...@pwsan.com wrote: (cc'ing Steve, Richard, Anand) There appear to be least seven SDIO card drivers in 2.6.34-rc7. At least one of these is for a TI chip - the wl1251.  I think some of the

Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-17 Thread David Vrabel
David Vrabel wrote: +static void omap_hsmmc_enable_sdio_irq(struct mmc_host *mmc, int enable) +{ + struct omap_hsmmc_host *host = mmc_priv(mmc); + u32 ie, con; + unsigned long flags; + + spin_lock_irqsave(host-irq_lock, flags); + + /* + * When interrupts are

RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-17 Thread Madhusudhan
-Original Message- From: David Vrabel [mailto:david.vra...@csr.com] Sent: Wednesday, February 10, 2010 5:52 AM To: linux-...@vger.kernel.org Cc: David Vrabel; linux-omap@vger.kernel.org; madhu...@ti.com Subject: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts Enable the

Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-17 Thread David Vrabel
Madhusudhan wrote: -Original Message- From: David Vrabel [mailto:david.vra...@csr.com] Sent: Wednesday, February 10, 2010 5:52 AM To: linux-...@vger.kernel.org Cc: David Vrabel; linux-omap@vger.kernel.org; madhu...@ti.com Subject: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card

Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-17 Thread Paul Walmsley
On Wed, 17 Feb 2010, David Vrabel wrote: Madhusudhan wrote: -Original Message- From: David Vrabel [mailto:david.vra...@csr.com] Sent: Wednesday, February 10, 2010 5:52 AM To: linux-...@vger.kernel.org Cc: David Vrabel; linux-omap@vger.kernel.org; madhu...@ti.com

RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-17 Thread Cousson, Benoit
From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of David Vrabel Sent: Wednesday, February 17, 2010 7:10 PM David Vrabel wrote: +static void omap_hsmmc_enable_sdio_irq(struct mmc_host *mmc, int enable) +{ +struct omap_hsmmc_host *host =

RE: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts

2010-02-17 Thread Madhusudhan
-Original Message- From: David Vrabel [mailto:david.vra...@csr.com] Sent: Wednesday, February 17, 2010 1:40 PM To: Madhusudhan Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org Subject: Re: [PATCH 3/3] mmc: omap_hsmmc: enable SDIO card interrupts Madhusudhan wrote