RE: [PATCH 4/4]usb : musb:USB driver using omap_device_build for device registration.

2010-06-29 Thread Kalliguddi, Hema
Hello, >-Original Message- >From: Sergei Shtylyov [mailto:sshtyl...@mvista.com] >Sent: Tuesday, June 29, 2010 4:35 PM >To: Kalliguddi, Hema >Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; >Felipe Balbi; t...@atomide.com >Subject: Re: [PATCH 4/4]usb :

Re: [PATCH 4/4]usb : musb:USB driver using omap_device_build for device registration.

2010-06-29 Thread Tony Lindgren
* Kalliguddi, Hema [100628 16:52]: > > Yes. The comment is being removed in the patch I posted. I will keep it. Thanks. Tony -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.o

Re: [PATCH 4/4]usb : musb:USB driver using omap_device_build for device registration.

2010-06-29 Thread Sergei Shtylyov
Hello. Hema HK wrote: From: Hema HK I think the patch description has clarity issues... Changed the musb driver to use omap_build_device api instead of I don't see where are you changing the MUSB driver. platform_device_registration. Why underscores here? The device specif

RE: [PATCH 4/4]usb : musb:USB driver using omap_device_build for device registration.

2010-06-28 Thread Kalliguddi, Hema
...@vger.kernel.org; linux-omap@vger.kernel.org; >Felipe Balbi >>Subject: Re: [PATCH 4/4]usb : musb:USB driver using >>omap_device_build for device registration. >> >>* Kalliguddi, Hema [100628 16:26]: >>> >>> >>> >-Original Message

RE: [PATCH 4/4]usb : musb:USB driver using omap_device_build for device registration.

2010-06-28 Thread Kalliguddi, Hema
>-Original Message- >From: Tony Lindgren [mailto:t...@atomide.com] >Sent: Monday, June 28, 2010 7:12 PM >To: Kalliguddi, Hema >Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; Felipe Balbi >Subject: Re: [PATCH 4/4]usb : musb:USB driver using >omap_de

Re: [PATCH 4/4]usb : musb:USB driver using omap_device_build for device registration.

2010-06-28 Thread Tony Lindgren
Balbi > >Subject: Re: [PATCH 4/4]usb : musb:USB driver using > >omap_device_build for device registration. > > > >* Hema HK [100628 15:12]: > >> - > >> - /* > >> - * REVISIT: This line can be removed once all the > >platforms using > >&g

RE: [PATCH 4/4]usb : musb:USB driver using omap_device_build for device registration.

2010-06-28 Thread Kalliguddi, Hema
>-Original Message- >From: Tony Lindgren [mailto:t...@atomide.com] >Sent: Monday, June 28, 2010 6:59 PM >To: Kalliguddi, Hema >Cc: linux-...@vger.kernel.org; linux-omap@vger.kernel.org; Felipe Balbi >Subject: Re: [PATCH 4/4]usb : musb:USB driver using >omap_de

Re: [PATCH 4/4]usb : musb:USB driver using omap_device_build for device registration.

2010-06-28 Thread Tony Lindgren
* Hema HK [100628 15:12]: > - > - /* > - * REVISIT: This line can be removed once all the platforms using > - * musb_core.c have been converted to use use clkdev. > - */ > - musb_plat.clock = "ick"; This comment is still valid, please don't remove it. Regards, Tony -- To