RE: [PATCH 5/9] ARM: OMAP2+: gpmc-smc91x: Adapt to use gpmc driver

2012-06-14 Thread Mohammed, Afzal
Hi Tony, On Wed, Jun 13, 2012 at 19:13:24, Tony Lindgren wrote: > * Mohammed, Afzal [120613 06:43]: > > Do you mean for all the gpmc-* helpers existing initialization > > needs to be modified to use the new interface, the previous version > > was doing so. But then that will cause all boards usi

Re: [PATCH 5/9] ARM: OMAP2+: gpmc-smc91x: Adapt to use gpmc driver

2012-06-13 Thread Tony Lindgren
* Mohammed, Afzal [120613 06:43]: > Hi Tony, > > On Wed, Jun 13, 2012 at 17:59:50, Tony Lindgren wrote: > > > Here too we just need to care about the mainline kernel users > > and convert them to use the new interface. No need to keep > > gpmc_cs_set_timings around. The same applies for other si

RE: [PATCH 5/9] ARM: OMAP2+: gpmc-smc91x: Adapt to use gpmc driver

2012-06-13 Thread Mohammed, Afzal
Hi Tony, On Wed, Jun 13, 2012 at 17:59:50, Tony Lindgren wrote: > Here too we just need to care about the mainline kernel users > and convert them to use the new interface. No need to keep > gpmc_cs_set_timings around. The same applies for other similar > patches. Not sure whether I follow you h

Re: [PATCH 5/9] ARM: OMAP2+: gpmc-smc91x: Adapt to use gpmc driver

2012-06-13 Thread Tony Lindgren
* Afzal Mohammed [120611 08:19]: > --- a/arch/arm/mach-omap2/gpmc-smc91x.c > +++ b/arch/arm/mach-omap2/gpmc-smc91x.c > @@ -114,7 +136,13 @@ static int smc91c96_gpmc_retime(void) > if (gpmc_cfg->flags & GPMC_MUX_ADD_DATA) > return 0; > > - return gpmc_cs_set_timings(gpmc_c