RE: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

2011-01-27 Thread Tardy, Pierre
[snip] > > > > Now I really started liking this patch. > > Acked-by: Linus Walleij > > Which shall be interpreted as for the patch with the above code, not > the one which is subject for this post I believe. > > Pierre, I can't locate your patches for some reason, care to repost > them? https://

Re: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

2011-01-26 Thread Linus Walleij
2011/1/26 Linus Walleij : > 2011/1/25 Tardy, Pierre : >> @@ -1231,6 +1233,27 @@ static void sdhci_set_ios(struct mmc_host *mmc, >> struct mmc_ios *ios) >>                goto out; >> >>        /* >> +        * get/put runtime_pm usage counter at ios->clock transitions >> +        * We need to do

Re: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

2011-01-26 Thread Linus Walleij
2011/1/25 Tardy, Pierre : > Actually in sdhci, you power off the MMC IP block, you power OFF the > MCLK (at least on our platform) > > I don't know other platform where mmc clock is not controlled more or > less directlty by the sdhc IP. This is the case with host/mmci.c. It is taking a clock in

RE: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

2011-01-25 Thread Tardy, Pierre
> -Original Message- > From: Linus Walleij [mailto:linus.ml.wall...@gmail.com] > Sent: Monday, January 24, 2011 11:11 PM > To: Chris Ball > Cc: Tardy, Pierre; linux-...@vger.kernel.org; Ohad Ben-Cohen; linux-omap > Mailing List > Subject: Re: [PATCH v1 1/3]mmc: imple

Re: [PATCH v1 1/3]mmc: implemented runtime pm for mmc host

2011-01-24 Thread Linus Walleij
2011/1/20 Chris Ball : > On Wed, Jan 19, 2011 at 09:45:57AM +, Tardy, Pierre wrote: >> Chris, >> (Sorry for top posting) >> Seems we have a intel intern disagreement. >> >> Could we have maintainer opinion on this ? > > Linus W and Ohad, any input here?  Thanks, What I see is orthogonal purpos