RE: [PATCH v2] ARM: OMAP: SDMA: Fix omap_stop_dma() API for channel linking

2009-10-20 Thread Shilimkar, Santosh
> > > Hmm, I'm thinking it should be like this instead to also clear > > > the dma_chan[lch].flags instead of returning before that. > > > > > > Can you try this with your testcase? > > This works too. OMAP1 doesn't support channel linking so this is > fine. In case it was, then it would have been

Re: [PATCH v2] ARM: OMAP: SDMA: Fix omap_stop_dma() API for channel linking

2009-10-20 Thread Tony Lindgren
Jarkko > > Nikula > > Subject: Re: [PATCH v2] ARM: OMAP: SDMA: Fix omap_stop_dma() API for > > channel linking > > > > * Santosh Shilimkar [091015 00:07]: > > > OMAP sDMA driver API omap_stop_dma() doesn't really stop the dma > > when used > > >

RE: [PATCH v2] ARM: OMAP: SDMA: Fix omap_stop_dma() API for channel linking

2009-10-19 Thread Shilimkar, Santosh
Tony, > -Original Message- > From: Tony Lindgren [mailto:t...@atomide.com] > Sent: Monday, October 19, 2009 10:54 PM > To: Shilimkar, Santosh > Cc: linux-omap@vger.kernel.org; S, Venkatraman; Hari n; Jarkko > Nikula > Subject: Re: [PATCH v2] ARM: OMAP: SDMA: Fix om

Re: [PATCH v2] ARM: OMAP: SDMA: Fix omap_stop_dma() API for channel linking

2009-10-19 Thread Tony Lindgren
* Santosh Shilimkar [091015 00:07]: > OMAP sDMA driver API omap_stop_dma() doesn't really stop the dma when used > in linking scenario. This patch fixes the same. > > Signed-off-by: Santosh Shilimkar > Signed-off-by: Venkatraman S > Reviewed-By: Tony Lindgren > CC: Hari n > CC: Jarkko Nikula