RE: [PATCH v3 02/13] OMAP: DMA: Introduce errata handling feature

2010-11-10 Thread G, Manjunath Kondaiah
t; Shilimkar, Santosh > Subject: Re: [PATCH v3 02/13] OMAP: DMA: Introduce errata > handling feature > > "G, Manjunath Kondaiah" writes: > > [...] > > >> > +if (omap_type() == OMAP3430_REV_ES1_0) > >> > +SET_DMA_ERRAT

Re: [PATCH v3 02/13] OMAP: DMA: Introduce errata handling feature

2010-11-10 Thread Kevin Hilman
"G, Manjunath Kondaiah" writes: [...] >> > + if (omap_type() == OMAP3430_REV_ES1_0) >> > + SET_DMA_ERRATA(DMA_ERRATA_i88); >> > + >> > + /* >> > + * Errata 3.2/3.3: sometimes 0 is returned if CSAC/CDAC is >> >> This doesn't look like a unique errata identifier. Chapter 3 >> is us

RE: [PATCH v3 02/13] OMAP: DMA: Introduce errata handling feature

2010-11-10 Thread G, Manjunath Kondaiah
t; Shilimkar, Santosh > Subject: Re: [PATCH v3 02/13] OMAP: DMA: Introduce errata > handling feature > > "G, Manjunath Kondaiah" writes: > > > Implement errata handling to use flags instead of cpu_is_* > > and cpu_class_* in the code. > > > > The e

Re: [PATCH v3 02/13] OMAP: DMA: Introduce errata handling feature

2010-11-09 Thread Kevin Hilman
"G, Manjunath Kondaiah" writes: > Implement errata handling to use flags instead of cpu_is_* > and cpu_class_* in the code. > > The errata flags are initialized at init time and during runtime > we are using the errata variable (via the IS_DMA_ERRATA macro) > to execute the required errata workar