RE: [PATCH v3 1/6] mfd: TPS65910: Handle non-existent devices

2011-11-03 Thread Mohammed, Afzal
Hi Kyle, On Thu, Nov 03, 2011 at 22:38:01, Kyle Manna wrote: > + ret = mfd_add_devices(tps65910->dev, -1, tps65910s, > + ARRAY_SIZE(tps65910s), NULL, 0); > + if (ret < 0) > + goto err2; Isn't goto err sufficient Regards Afzal -- To unsubscribe from this li

RE: [PATCH v3 1/6] mfd: TPS65910: Handle non-existent devices

2011-11-03 Thread Mohammed, Afzal
Hi Kyla, On Thu, Nov 03, 2011 at 22:38:01, Kyle Manna wrote: > The JTAGREVNUM register contains a silicon revision number in the lower > four bits and the upper four bits are to always read 0. > > To detect the presence of the device, attempt to read JTAGREVNUM > register and check that it return