RE: [RFC][PATCH 1/5] ARM: OMAP2+: gpmc: driver conversion

2012-03-27 Thread Mohammed, Afzal
Hi Jon, On Tue, Mar 27, 2012 at 21:01:56, Hunter, Jon wrote: > > These are for the peripheral resources not in control of GPMC, like > > gpio irq. These are copied in gpmc_create_child. > > Right, I see they are copied during gpmc_create_child. However, I don't > see where they are initialised b

Re: [RFC][PATCH 1/5] ARM: OMAP2+: gpmc: driver conversion

2012-03-27 Thread Jon Hunter
Hi Afzal, On 3/27/2012 0:12, Mohammed, Afzal wrote: Hi Jon, On Mon, Mar 26, 2012 at 23:12:26, Hunter, Jon wrote: Also, I don't see where the gpmc_child->res and gpmc_child->num_res are actually used. Are these needed? These are for the peripheral resources not in control of GPMC, like gpio i

RE: [RFC][PATCH 1/5] ARM: OMAP2+: gpmc: driver conversion

2012-03-26 Thread Mohammed, Afzal
Hi Jon, On Mon, Mar 26, 2012 at 23:12:26, Hunter, Jon wrote: > Also, I don't see where the gpmc_child->res and gpmc_child->num_res are > actually used. Are these needed? These are for the peripheral resources not in control of GPMC, like gpio irq. These are copied in gpmc_create_child. > > Gpmc

Re: [RFC][PATCH 1/5] ARM: OMAP2+: gpmc: driver conversion

2012-03-26 Thread Jon Hunter
Hi Afzal, On 3/26/2012 3:04, Mohammed, Afzal wrote: Hi Jon, On Sat, Mar 24, 2012 at 04:51:13, Hunter, Jon wrote: +struct gpmc_child { + char*name; + int id; + struct resource *res; + unsignednum_res; +

RE: [RFC][PATCH 1/5] ARM: OMAP2+: gpmc: driver conversion

2012-03-26 Thread Mohammed, Afzal
Hi Jon, On Sat, Mar 24, 2012 at 04:51:13, Hunter, Jon wrote: > > +struct gpmc_child { > > + char*name; > > + int id; > > + struct resource *res; > > + unsignednum_res; > > + struct resource gpmc_res[GPMC_CS_NUM]; >

RE: [RFC][PATCH 1/5] ARM: OMAP2+: gpmc: driver conversion

2012-03-25 Thread Mohammed, Afzal
Hi Balbi, On Fri, Mar 23, 2012 at 21:59:00, Balbi, Felipe wrote: > yeah, I was thinking about drivers/ocd (off-chip devices) or > drivers/mmio... and that should be flexible enough to hold gpmc, lli and > c2c (from OMAP's perspective). Ok, I will check feasibility of having GPMC driver at those p

RE: [RFC][PATCH 1/5] ARM: OMAP2+: gpmc: driver conversion

2012-03-25 Thread Mohammed, Afzal
Hi Benoit, On Fri, Mar 23, 2012 at 21:09:21, Cousson, Benoit wrote: > But EMIF does not have anything to do in MFD either :-) > > What was the feedback for this series? > > We discussed that at Linaro connect, but it looks like MFD is becoming > the place for miscellaneous drivers that we do no

Re: [RFC][PATCH 1/5] ARM: OMAP2+: gpmc: driver conversion

2012-03-23 Thread Jon Hunter
Hi Afzal, On 03/23/2012 01:36 AM, Afzal Mohammed wrote: [snip] +struct gpmc_child { + char*name; + int id; + struct resource *res; + unsignednum_res; + struct resource gpmc_res[GPMC_CS_NUM];

Re: [RFC][PATCH 1/5] ARM: OMAP2+: gpmc: driver conversion

2012-03-23 Thread Felipe Balbi
Hi, On Fri, Mar 23, 2012 at 04:39:21PM +0100, Cousson, Benoit wrote: > + Felipe > > On 3/23/2012 11:20 AM, Mohammed, Afzal wrote: > >Hi Benoit, > > > >On Fri, Mar 23, 2012 at 15:07:30, Cousson, Benoit wrote: > >>>Final destination aimed for this driver is MFD. > >> > >>Why? Are you sure this is a

Re: [RFC][PATCH 1/5] ARM: OMAP2+: gpmc: driver conversion

2012-03-23 Thread Cousson, Benoit
+ Felipe On 3/23/2012 11:20 AM, Mohammed, Afzal wrote: Hi Benoit, On Fri, Mar 23, 2012 at 15:07:30, Cousson, Benoit wrote: Final destination aimed for this driver is MFD. Why? Are you sure this is appropriate? This is not really a multifunction device but rather a bus device that can manage

RE: [RFC][PATCH 1/5] ARM: OMAP2+: gpmc: driver conversion

2012-03-23 Thread Mohammed, Afzal
Hi Benoit, On Fri, Mar 23, 2012 at 15:07:30, Cousson, Benoit wrote: > > Final destination aimed for this driver is MFD. > > Why? Are you sure this is appropriate? This is not really a > multifunction device but rather a bus device that can manage multiple > kind of devices. Agree, this not an

Re: [RFC][PATCH 1/5] ARM: OMAP2+: gpmc: driver conversion

2012-03-23 Thread Cousson, Benoit
On 3/23/2012 7:36 AM, Afzal Mohammed wrote: Convert GPMC code to driver. Boards using GPMC should provide driver with type of configuration, timing, GPMC address space details (if already configured, driver will retrieve, as is existing). Platform devices would the be created for each connected p