Re: [RFC] mtd: nand: Fix bad block identification issue

2011-04-29 Thread Artem Bityutskiy
On Fri, 2011-04-29 at 11:03 -0700, Brian Norris wrote: > As promised (but too late?): > > Acked-by: Brian Norris No, not late, I rebase my l2 tree with no shame :-) But once the patch hits the real mtd tree, then we never change it. So, I've added you tag, thanks. -- Best Regards, Artem Bityut

Re: [RFC] mtd: nand: Fix bad block identification issue

2011-04-29 Thread Brian Norris
; Basheer, Mansoor Ahamed; linux- o...@vger.kernel.org Subject: Re: [RFC] mtd: nand: Fix bad block identification issue On Wed, 2011-04-27 at 17:39 +0530, Saxena, Parth wrote: This patch solves the above issue for omap by initialising badblockbits. We are working further on this to find a generic fix to

RE: [RFC] mtd: nand: Fix bad block identification issue

2011-04-29 Thread Artem Bityutskiy
g; Basheer, Mansoor Ahamed; linux- > > o...@vger.kernel.org > > Subject: Re: [RFC] mtd: nand: Fix bad block identification issue > > > > On Wed, 2011-04-27 at 17:39 +0530, Saxena, Parth wrote: > > > This patch solves the above issue for omap by initialising > &

RE: [RFC] mtd: nand: Fix bad block identification issue

2011-04-29 Thread Saxena, Parth
> -Original Message- > From: Artem Bityutskiy [mailto:dedeki...@gmail.com] > Sent: Thursday, April 28, 2011 11:01 PM > To: Saxena, Parth; Brian Norris > Cc: linux-...@lists.infradead.org; Basheer, Mansoor Ahamed; linux- > o...@vger.kernel.org > Subject: Re: [RFC] mtd

Re: [RFC] mtd: nand: Fix bad block identification issue

2011-04-29 Thread Artem Bityutskiy
On Thu, 2011-04-28 at 20:30 +0300, Artem Bityutskiy wrote: > On Wed, 2011-04-27 at 17:39 +0530, Saxena, Parth wrote: > > This patch solves the above issue for omap by initialising > > badblockbits. We are working further on this to find a generic fix > > to the problem in nand_base.c. > > But it l

Re: [RFC] mtd: nand: Fix bad block identification issue

2011-04-28 Thread Artem Bityutskiy
On Wed, 2011-04-27 at 17:39 +0530, Saxena, Parth wrote: > This patch solves the above issue for omap by initialising > badblockbits. We are working further on this to find a generic fix > to the problem in nand_base.c. But it looks like the generic solution is to return the line which was accident

Re: [RFC] mtd: nand: Fix bad block identification issue

2011-04-27 Thread Brian Norris
Hi, On 4/27/2011 8:45 AM, Grazvydas Ignotas wrote: > Brian, > > did you really intend to remove badblockbits? Maybe it should go back > to nand_base.c? No, I had no intention of the sorts! It surely should not have been removed in the first place. I will "ack" a patch to revert it, or next time

Re: [RFC] mtd: nand: Fix bad block identification issue

2011-04-27 Thread Grazvydas Ignotas
Brian, did you really intend to remove badblockbits? Maybe it should go back to nand_base.c? On Wed, Apr 27, 2011 at 3:09 PM, Saxena, Parth wrote: > Commit e0b58d0 ("mtd: nand: add ->badblockbits for minimum number > of set bits in bad block byte") by Maxim Levitsky added > badblockbits to nand_