RE: [rtc-linux] [PATCH v3 1/5] rtc: OMAP: Add system pm_power_off to rtc driver

2012-12-09 Thread AnilKumar, Chimata
On Wed, Nov 28, 2012 at 16:42:26, Russell King - ARM Linux wrote: On Tue, Nov 27, 2012 at 03:42:39PM -0800, Andrew Morton wrote: + /* Do not allow to execute any other task */ + spin_lock_irqsave(lock, flags); + while (1); I suspect this doesn't do what you want it to do.

Re: [rtc-linux] [PATCH v3 1/5] rtc: OMAP: Add system pm_power_off to rtc driver

2012-11-28 Thread Russell King - ARM Linux
On Tue, Nov 27, 2012 at 03:42:39PM -0800, Andrew Morton wrote: + /* Do not allow to execute any other task */ + spin_lock_irqsave(lock, flags); + while (1); I suspect this doesn't do what you want it to do. Firstly, please provide adequate code comments here so that code readers

Re: [rtc-linux] [PATCH v3 1/5] rtc: OMAP: Add system pm_power_off to rtc driver

2012-11-27 Thread Andrew Morton
On Tue, 20 Nov 2012 15:18:43 +0530 AnilKumar Ch anilku...@ti.com wrote: From: Colin Foe-Parker colin.foepar...@logicpd.com Add system power off control to rtc driver which is the in-charge of controlling the BeagleBone system power. The power_off routine can be hooked up to pm_power_off