Re: [PATCH 1/5 RESEND] ARM: OMAP: USB: HOST TLL platform driver

2012-03-20 Thread Felipe Balbi
On Tue, Mar 20, 2012 at 04:21:18PM +0530, Munegowda, Keshava wrote: > On Tue, Mar 20, 2012 at 3:29 PM, Felipe Balbi wrote: > > Hi, > > > > On Tue, Mar 20, 2012 at 03:00:50PM +0530, Munegowda, Keshava wrote: > >> >> +MODULE_AUTHOR("Keshava Munegowda "); > >> >> +MODULE_ALIAS("platform:" USBHS_DRIVE

Re: [PATCH 1/5 RESEND] ARM: OMAP: USB: HOST TLL platform driver

2012-03-20 Thread Munegowda, Keshava
On Tue, Mar 20, 2012 at 3:29 PM, Felipe Balbi wrote: > Hi, > > On Tue, Mar 20, 2012 at 03:00:50PM +0530, Munegowda, Keshava wrote: >> >> +MODULE_AUTHOR("Keshava Munegowda "); >> >> +MODULE_ALIAS("platform:" USBHS_DRIVER_NAME); >> >> +MODULE_LICENSE("GPL v2"); >> >> +MODULE_DESCRIPTION("usb tll dri

Re: [PATCH 1/5 RESEND] ARM: OMAP: USB: HOST TLL platform driver

2012-03-20 Thread Felipe Balbi
On Tue, Mar 20, 2012 at 01:02:58PM +0530, Munegowda, Keshava wrote: > On Mon, Mar 19, 2012 at 12:18 PM, Keshava Munegowda > wrote: > > From: Keshava Munegowda > > > > The platform driver for the TLL component of the OMAP USB host controller > > is implemented. Depending on the TLL hardware revisi

Re: [PATCH 1/5 RESEND] ARM: OMAP: USB: HOST TLL platform driver

2012-03-20 Thread Felipe Balbi
Hi, On Tue, Mar 20, 2012 at 03:00:50PM +0530, Munegowda, Keshava wrote: > >> +MODULE_AUTHOR("Keshava Munegowda "); > >> +MODULE_ALIAS("platform:" USBHS_DRIVER_NAME); > >> +MODULE_LICENSE("GPL v2"); > >> +MODULE_DESCRIPTION("usb tll driver for TI OMAP EHCI and OHCI > >> controllers"); > >> + > >>

Re: [PATCH 1/5 RESEND] ARM: OMAP: USB: HOST TLL platform driver

2012-03-20 Thread Munegowda, Keshava
On Mon, Mar 19, 2012 at 3:36 PM, Felipe Balbi wrote: > Hi, > > On Mon, Mar 19, 2012 at 12:18:31PM +0530, Keshava Munegowda wrote: >> +     ver =  usbtll_read(base, OMAP_USBTLL_REVISION); >> +     if (ver == OMAP_USBTLL_REV1) >> +             count = OMAP_TLL_CHANNEL_COUNT; >> +     else if (ver ==

Re: [PATCH 1/5 RESEND] ARM: OMAP: USB: HOST TLL platform driver

2012-03-20 Thread Munegowda, Keshava
On Tue, Mar 20, 2012 at 2:22 PM, Shubhrajyoti wrote: > Hi Keshava, > > On Tuesday 20 March 2012 12:58 PM, Munegowda, Keshava wrote: +} + +static const struct dev_pm_ops usbtllomap_dev_pm_ops = { +     .runtime_suspend        = usbtll_runtime_suspend, +     .runtime_resume

Re: [PATCH 1/5 RESEND] ARM: OMAP: USB: HOST TLL platform driver

2012-03-20 Thread Shubhrajyoti
Hi Keshava, On Tuesday 20 March 2012 12:58 PM, Munegowda, Keshava wrote: >>> +} >>> + >>> +static const struct dev_pm_ops usbtllomap_dev_pm_ops = { >>> + .runtime_suspend= usbtll_runtime_suspend, >>> + .runtime_resume = usbtll_runtime_resume, >>> +}; >>> + >> Also how about

Re: [PATCH 1/5 RESEND] ARM: OMAP: USB: HOST TLL platform driver

2012-03-20 Thread Munegowda, Keshava
On Mon, Mar 19, 2012 at 12:18 PM, Keshava Munegowda wrote: > From: Keshava Munegowda > > The platform driver for the TLL component of the OMAP USB host controller > is implemented. Depending on the TLL hardware revision , the TLL channels > are configured. The USB HS core driver uses this driver

Re: [PATCH 1/5 RESEND] ARM: OMAP: USB: HOST TLL platform driver

2012-03-20 Thread Munegowda, Keshava
On Mon, Mar 19, 2012 at 3:11 PM, Shubhrajyoti wrote: > Hi Keshava, > Some doubts / comments . > On Monday 19 March 2012 12:18 PM, Keshava Munegowda wrote: >> From: Keshava Munegowda >> >> The platform driver for the TLL component of the OMAP USB host controller >> is implemented. Depending on the

Re: [PATCH 1/5 RESEND] ARM: OMAP: USB: HOST TLL platform driver

2012-03-20 Thread Munegowda, Keshava
On Mon, Mar 19, 2012 at 4:39 PM, Sergei Shtylyov wrote: > Hello. > > > On 19-03-2012 14:06, Felipe Balbi wrote: > >>> +       ver =  usbtll_read(base, OMAP_USBTLL_REVISION); >>> +       if (ver == OMAP_USBTLL_REV1) >>> +               count = OMAP_TLL_CHANNEL_COUNT; >>> +       else if (ver == OMA

Re: [PATCH 1/5 RESEND] ARM: OMAP: USB: HOST TLL platform driver

2012-03-19 Thread Sergei Shtylyov
Hello. On 19-03-2012 14:06, Felipe Balbi wrote: + ver = usbtll_read(base, OMAP_USBTLL_REVISION); + if (ver == OMAP_USBTLL_REV1) + count = OMAP_TLL_CHANNEL_COUNT; + else if (ver == OMAP_USBTLL_REV2) + count = OMAP_REV2_TLL_CHANNEL_COUNT; + els

Re: [PATCH 1/5 RESEND] ARM: OMAP: USB: HOST TLL platform driver

2012-03-19 Thread Felipe Balbi
Hi, On Mon, Mar 19, 2012 at 12:18:31PM +0530, Keshava Munegowda wrote: > + ver = usbtll_read(base, OMAP_USBTLL_REVISION); > + if (ver == OMAP_USBTLL_REV1) > + count = OMAP_TLL_CHANNEL_COUNT; > + else if (ver == OMAP_USBTLL_REV2) > + count = OMAP_REV2_TLL_CHANNE

Re: [PATCH 1/5 RESEND] ARM: OMAP: USB: HOST TLL platform driver

2012-03-19 Thread Shubhrajyoti
Hi Keshava, Some doubts / comments . On Monday 19 March 2012 12:18 PM, Keshava Munegowda wrote: > From: Keshava Munegowda > > The platform driver for the TLL component of the OMAP USB host controller > is implemented. Depending on the TLL hardware revision , the TLL channels > are configured. The