Re: [PATCH v2] OMAP: Fix McBSP spin_lock deadlock.

2009-01-13 Thread stanley.miao
On Mon, 2009-01-12 at 12:46 +0200, Tony Lindgren wrote: > * stanley.miao [090112 12:34]: > > On Thu, 2009-01-08 at 15:33 +0200, Tony Lindgren wrote: > > > * stanley.miao [081107 15:47]: > > > > This solution keeps the virtual clock in place and enable the child > > > > clocks before enable the vi

Re: [PATCH v2] OMAP: Fix McBSP spin_lock deadlock.

2009-01-13 Thread Tony Lindgren
* Eero Nurkkala [090113 11:11]: > > Can you please repost your first version of the patch? > > Please. This V1 patch is good if one wishes to provide the fclk > for McBSP from the MCBSP_CLKS. Then the fclk from the per can be turned > off. With the V2 patch it's not that straightforward at all.

Re: [PATCH v2] OMAP: Fix McBSP spin_lock deadlock.

2009-01-13 Thread Eero Nurkkala
> Can you please repost your first version of the patch? Please. This V1 patch is good if one wishes to provide the fclk for McBSP from the MCBSP_CLKS. Then the fclk from the per can be turned off. With the V2 patch it's not that straightforward at all. - Eero -- To unsubscribe from this list: s

Re: [PATCH v2] OMAP: Fix McBSP spin_lock deadlock.

2009-01-12 Thread Tony Lindgren
* stanley.miao [090112 12:34]: > On Thu, 2009-01-08 at 15:33 +0200, Tony Lindgren wrote: > > * stanley.miao [081107 15:47]: > > > This solution keeps the virtual clock in place and enable the child > > > clocks before enable the virtual clock. So, any comments ? > > > > What if we just removed t

Re: [PATCH v2] OMAP: Fix McBSP spin_lock deadlock.

2009-01-12 Thread stanley.miao
On Thu, 2009-01-08 at 15:33 +0200, Tony Lindgren wrote: > * stanley.miao [081107 15:47]: > > This solution keeps the virtual clock in place and enable the child > > clocks before enable the virtual clock. So, any comments ? > > What if we just removed the custom clock and had a struct **clk > in

Re: [PATCH v2] OMAP: Fix McBSP spin_lock deadlock.

2009-01-08 Thread Tony Lindgren
* stanley.miao [081107 15:47]: > This solution keeps the virtual clock in place and enable the child > clocks before enable the virtual clock. So, any comments ? What if we just removed the custom clock and had a struct **clk in struct omap_mcbsp that contains the clocks for each instance? Regar

Re: [PATCH v2] OMAP: Fix McBSP spin_lock deadlock.

2008-11-07 Thread stanley.miao
This solution keeps the virtual clock in place and enable the child clocks before enable the virtual clock. So, any comments ? Stanley. On Thu, 2008-11-06 at 20:44 +0800, Stanley.Miao wrote: > A spin_lock deadlock will occur when omap_mcbsp_request() is invoked. > > omap_mcbsp_request()