Re: [PATCH v3 00/13] gpio/omap: Some more driver cleanup and fixes

2012-03-12 Thread Kevin Hilman
Tarun Kanti DebBarma writes: > The cleanup is mostly getting rid of redundant fields in struct gpio_bank{} > as we already have them as part of bank->context now. Also, remove un-used > variable from gpio_irq_handler. > > The fixes include correction of _set_gpio_irqenable() implementation, > mis

Re: [PATCH v3 00/13] gpio/omap: Some more driver cleanup and fixes

2012-03-12 Thread DebBarma, Tarun Kanti
On Tue, Mar 13, 2012 at 12:24 AM, Kevin Hilman wrote: > Tarun Kanti DebBarma writes: > >> The cleanup is mostly getting rid of redundant fields in struct gpio_bank{} >> as we already have them as part of bank->context now. Also, remove un-used >> variable from gpio_irq_handler. >> >> The fixes in

Re: [PATCH v3 00/13] gpio/omap: Some more driver cleanup and fixes

2012-03-12 Thread DebBarma, Tarun Kanti
On Tue, Mar 13, 2012 at 1:23 AM, DebBarma, Tarun Kanti wrote: > On Tue, Mar 13, 2012 at 12:24 AM, Kevin Hilman wrote: >> Tarun Kanti DebBarma writes: >> >>> The cleanup is mostly getting rid of redundant fields in struct gpio_bank{} >>> as we already have them as part of bank->context now. Also,

Re: [PATCH v3 00/13] gpio/omap: Some more driver cleanup and fixes

2012-03-12 Thread DebBarma, Tarun Kanti
On Tue, Mar 13, 2012 at 1:38 AM, DebBarma, Tarun Kanti wrote: > On Tue, Mar 13, 2012 at 1:23 AM, DebBarma, Tarun Kanti > wrote: >> On Tue, Mar 13, 2012 at 12:24 AM, Kevin Hilman wrote: >>> Tarun Kanti DebBarma writes: >>> The cleanup is mostly getting rid of redundant fields in struct gpio

Re: [PATCH v3 00/13] gpio/omap: Some more driver cleanup and fixes

2012-03-12 Thread Kevin Hilman
"DebBarma, Tarun Kanti" writes: [...] >>> Oops... I am sorry. >>> I was in the process of updating the branch with latest comments after >>> base-lining on Grant's: >>> git://git.secretlab.ca/git/linux-2.6.git >>> Branch: gpio/next >>> Because this has all the gpio changes including Benoit's lat

Re: [PATCH v3 00/13] gpio/omap: Some more driver cleanup and fixes

2012-03-12 Thread Kevin Hilman
"DebBarma, Tarun Kanti" writes: [...] >>> Oops... I am sorry. >>> I was in the process of updating the branch with latest comments after >>> base-lining on Grant's: >>> git://git.secretlab.ca/git/linux-2.6.git >>> Branch: gpio/next >>> Because this has all the gpio changes including Benoit's lat

Re: [PATCH v3 00/13] gpio/omap: Some more driver cleanup and fixes

2012-03-12 Thread Grant Likely
On Mon, 12 Mar 2012 15:28:42 -0700, Kevin Hilman wrote: > "DebBarma, Tarun Kanti" writes: > > [...] > > >>> Oops... I am sorry. > >>> I was in the process of updating the branch with latest comments after > >>> base-lining on Grant's: > >>> git://git.secretlab.ca/git/linux-2.6.git > >>> Branch:

Re: [PATCH v3 00/13] gpio/omap: Some more driver cleanup and fixes

2012-03-12 Thread DebBarma, Tarun Kanti
On Tue, Mar 13, 2012 at 9:27 AM, Grant Likely wrote: > On Mon, 12 Mar 2012 15:28:42 -0700, Kevin Hilman wrote: >> "DebBarma, Tarun Kanti" writes: >> >> [...] >> >> >>> Oops... I am sorry. >> >>> I was in the process of updating the branch with latest comments after >> >>> base-lining on Grant's: