Re: [PATCH v4] power: introduce library for device-specific OPPs

2010-09-27 Thread Nishanth Menon
Paul E. McKenney had written, on 09/25/2010 07:56 PM, the following: On Sat, Sep 25, 2010 at 10:55:20PM +0200, Rafael J. Wysocki wrote: On Friday, September 24, 2010, Paul E. McKenney wrote: On Fri, Sep 24, 2010 at 07:50:40AM -0500, Nishanth Menon wrote: ... Looks like a good start!!! Some

Re: [PATCH v4] power: introduce library for device-specific OPPs

2010-09-27 Thread Nishanth Menon
Paul E. McKenney had written, on 09/24/2010 04:40 PM, the following: [...] +/** + * opp_find_freq_ceil() - Search for an rounded ceil freq + * @dev: device for which we do this operation + * @freq:Start frequency + * + * Search for the matching ceil *available* OPP from a starting freq +

Re: [PATCH v4] power: introduce library for device-specific OPPs

2010-09-27 Thread Rafael J. Wysocki
On Monday, September 27, 2010, Nishanth Menon wrote: Paul E. McKenney had written, on 09/25/2010 07:56 PM, the following: On Sat, Sep 25, 2010 at 10:55:20PM +0200, Rafael J. Wysocki wrote: On Friday, September 24, 2010, Paul E. McKenney wrote: On Fri, Sep 24, 2010 at 07:50:40AM -0500,

Re: [PATCH v4] power: introduce library for device-specific OPPs

2010-09-25 Thread Rafael J. Wysocki
On Friday, September 24, 2010, Paul E. McKenney wrote: On Fri, Sep 24, 2010 at 07:50:40AM -0500, Nishanth Menon wrote: ... Looks like a good start!!! Some questions and suggestions about RCU usage interspersed below. ... + * Locking: RCU reader. + */ +int opp_get_opp_count(struct

Re: [PATCH v4] power: introduce library for device-specific OPPs

2010-09-24 Thread Paul E. McKenney
On Fri, Sep 24, 2010 at 07:50:40AM -0500, Nishanth Menon wrote: SoCs have a standard set of tuples consisting of frequency and voltage pairs that the device will support per voltage domain. These are called Operating Performance Points or OPPs. The actual definitions of OPP varies over silicon

Re: [PATCH v4] power: introduce library for device-specific OPPs

2010-09-24 Thread Nishanth Menon
Paul E. McKenney had written, on 09/24/2010 02:37 PM, the following: [...] Looks like a good start!!! Some questions and suggestions about RCU Thanks for the review.. few comments below.. usage interspersed below. Thanx, Paul [...] +

Re: [PATCH v4] power: introduce library for device-specific OPPs

2010-09-24 Thread Paul E. McKenney
On Fri, Sep 24, 2010 at 04:26:21PM -0500, Nishanth Menon wrote: Paul E. McKenney had written, on 09/24/2010 02:37 PM, the following: [...] Looks like a good start!!! Some questions and suggestions about RCU Thanks for the review.. few comments below.. Back at you! ;-) usage interspersed