Re: am335x: TSC & ADC reworking including DT pieces, take 4

2013-06-14 Thread Mark Brown
On Tue, Jun 11, 2013 at 05:29:22PM +0200, Sebastian Andrzej Siewior wrote: > On 06/11/2013 04:23 PM, Samuel Ortiz wrote: > > Please fix your commit logs, and your subject lines. It should be e.g. > > mfd: input: ti_am335x_adc: Blablabla > > if it's mostly an mfd patch that also touches an input d

Re: am335x: TSC & ADC reworking including DT pieces, take 4

2013-06-12 Thread Sebastian Andrzej Siewior
On 06/12/2013 04:41 PM, Samuel Ortiz wrote: >> This forces me redo a few things and most likely adding it to the >> iio and input driver to be consistent here. > I'm not asking for that. The current MFD code uses regmap fine without > the iio and input using it, I don't see why you would have to ad

Re: am335x: TSC & ADC reworking including DT pieces, take 4

2013-06-12 Thread Samuel Ortiz
On Wed, Jun 12, 2013 at 04:02:00PM +0200, Sebastian Andrzej Siewior wrote: > >> By keep the regmap code you mean I am allowed to remove the regmap > >> usage in mfd (keep patch #1) or do you insist on adding its usage in > >> iio and input? > > I insist on keeping it on the MFD driver, i.e. _not_ k

Re: am335x: TSC & ADC reworking including DT pieces, take 4

2013-06-12 Thread Sebastian Andrzej Siewior
On 06/12/2013 03:50 PM, Samuel Ortiz wrote: > Hi Sebastian, Hi Samuel, >> By keep the regmap code you mean I am allowed to remove the regmap >> usage in mfd (keep patch #1) or do you insist on adding its usage in >> iio and input? > I insist on keeping it on the MFD driver, i.e. _not_ keeping pat

Re: am335x: TSC & ADC reworking including DT pieces, take 4

2013-06-12 Thread Samuel Ortiz
Hi Sebastian, On Wed, Jun 12, 2013 at 03:29:43PM +0200, Sebastian Andrzej Siewior wrote: > On 06/11/2013 07:55 PM, Samuel Ortiz wrote: > > Hi Jonathan, > > Hi Samuel, > > > Sebastian, please address the commit log and cosmetic issues I pointed out, > > keep the regmap code and I'll pull this pat

Re: am335x: TSC & ADC reworking including DT pieces, take 4

2013-06-12 Thread Sebastian Andrzej Siewior
On 06/11/2013 07:55 PM, Samuel Ortiz wrote: > Hi Jonathan, Hi Samuel, > Sebastian, please address the commit log and cosmetic issues I pointed out, > keep the regmap code and I'll pull this patchset in. By keep the regmap code you mean I am allowed to remove the regmap usage in mfd (keep patch #

Re: am335x: TSC & ADC reworking including DT pieces, take 4

2013-06-11 Thread Jonathan Cameron
On 06/11/2013 03:23 PM, Samuel Ortiz wrote: > Hi Sebastian, > > On Tue, Jun 11, 2013 at 01:30:46PM +0200, Sebastian Andrzej Siewior wrote: >> I believe the whole thing should go via the MFD tree. It touches also >> input & iio subsystem. I collected ACKs where I got some in the meantime. > Please

Re: am335x: TSC & ADC reworking including DT pieces, take 4

2013-06-11 Thread Samuel Ortiz
Hi Jonathan, On Tue, Jun 11, 2013 at 05:27:48PM +0100, Jonathan Cameron wrote: > Samuel Ortiz wrote: > >On Tue, Jun 11, 2013 at 09:04:16AM -0700, Dmitry Torokhov wrote: > >> On Tue, Jun 11, 2013 at 04:23:58PM +0200, Samuel Ortiz wrote: > >> > Hi Sebastian, > >> > > >> > On Tue, Jun 11, 2013 at 0

Re: am335x: TSC & ADC reworking including DT pieces, take 4

2013-06-11 Thread Lars-Peter Clausen
On 06/11/2013 06:27 PM, Jonathan Cameron wrote: > > > Samuel Ortiz wrote: > >> Hi Dmitry, >> >> On Tue, Jun 11, 2013 at 09:04:16AM -0700, Dmitry Torokhov wrote: >>> On Tue, Jun 11, 2013 at 04:23:58PM +0200, Samuel Ortiz wrote: Hi Sebastian, On Tue, Jun 11, 2013 at 01:30:46PM +020

Re: am335x: TSC & ADC reworking including DT pieces, take 4

2013-06-11 Thread Jonathan Cameron
Samuel Ortiz wrote: >Hi Dmitry, > >On Tue, Jun 11, 2013 at 09:04:16AM -0700, Dmitry Torokhov wrote: >> On Tue, Jun 11, 2013 at 04:23:58PM +0200, Samuel Ortiz wrote: >> > Hi Sebastian, >> > >> > On Tue, Jun 11, 2013 at 01:30:46PM +0200, Sebastian Andrzej Siewior >wrote: >> > > I believe the who

Re: am335x: TSC & ADC reworking including DT pieces, take 4

2013-06-11 Thread Sebastian Andrzej Siewior
On 06/11/2013 06:10 PM, Samuel Ortiz wrote: > Hi Sebastian, Hi Samuel, > On Tue, Jun 11, 2013 at 05:29:22PM +0200, Sebastian Andrzej Siewior wrote: >>> Then, this is a pretty big patchset, with iio, input and mfd all mixed >>> together and it is likely to create merge conflicts. >> They somehow d

Re: am335x: TSC & ADC reworking including DT pieces, take 4

2013-06-11 Thread Samuel Ortiz
Hi Dmitry, On Tue, Jun 11, 2013 at 09:04:16AM -0700, Dmitry Torokhov wrote: > On Tue, Jun 11, 2013 at 04:23:58PM +0200, Samuel Ortiz wrote: > > Hi Sebastian, > > > > On Tue, Jun 11, 2013 at 01:30:46PM +0200, Sebastian Andrzej Siewior wrote: > > > I believe the whole thing should go via the MFD tr

Re: am335x: TSC & ADC reworking including DT pieces, take 4

2013-06-11 Thread Samuel Ortiz
Hi Sebastian, On Tue, Jun 11, 2013 at 05:29:22PM +0200, Sebastian Andrzej Siewior wrote: > > Then, this is a pretty big patchset, with iio, input and mfd all mixed > > together and it is likely to create merge conflicts. > They somehow depend on each other. Otherwise I would have sent three > seri

Re: am335x: TSC & ADC reworking including DT pieces, take 4

2013-06-11 Thread Dmitry Torokhov
Hi Samuel, On Tue, Jun 11, 2013 at 04:23:58PM +0200, Samuel Ortiz wrote: > Hi Sebastian, > > On Tue, Jun 11, 2013 at 01:30:46PM +0200, Sebastian Andrzej Siewior wrote: > > I believe the whole thing should go via the MFD tree. It touches also > > input & iio subsystem. I collected ACKs where I got

Re: am335x: TSC & ADC reworking including DT pieces, take 4

2013-06-11 Thread Sebastian Andrzej Siewior
On 06/11/2013 04:23 PM, Samuel Ortiz wrote: > Hi Sebastian, Hi Samuel, > On Tue, Jun 11, 2013 at 01:30:46PM +0200, Sebastian Andrzej Siewior wrote: >> I believe the whole thing should go via the MFD tree. It touches also >> input & iio subsystem. I collected ACKs where I got some in the meantime.

Re: am335x: TSC & ADC reworking including DT pieces, take 4

2013-06-11 Thread Samuel Ortiz
Hi Sebastian, On Tue, Jun 11, 2013 at 01:30:46PM +0200, Sebastian Andrzej Siewior wrote: > I believe the whole thing should go via the MFD tree. It touches also > input & iio subsystem. I collected ACKs where I got some in the meantime. Please fix your commit logs, and your subject lines. It shoul

Re: am335x: TSC & ADC reworking including DT pieces, take 4

2013-06-11 Thread Lars-Peter Clausen
On 06/11/2013 02:05 PM, Lee Jones wrote: >> I believe the whole thing should go via the MFD tree. It touches also >> input & iio subsystem. I collected ACKs where I got some in the meantime. >> >> I added Lee Jones because I hear no sign of life from Samuel. > > Unfortunately I can't be of any add

Re: am335x: TSC & ADC reworking including DT pieces, take 4

2013-06-11 Thread Lee Jones
> I believe the whole thing should go via the MFD tree. It touches also > input & iio subsystem. I collected ACKs where I got some in the meantime. > > I added Lee Jones because I hear no sign of life from Samuel. Unfortunately I can't be of any added help here, as I also send my pull-requests th

am335x: TSC & ADC reworking including DT pieces, take 4

2013-06-11 Thread Sebastian Andrzej Siewior
I believe the whole thing should go via the MFD tree. It touches also input & iio subsystem. I collected ACKs where I got some in the meantime. I added Lee Jones because I hear no sign of life from Samuel. The following changes since commit d683b96b072dc4680fc74964eca77e6a23d1fa6e: Linux 3.10-