Re: v4l2_device/v4l2_subdev: please review (PATCH 1/3)

2008-11-30 Thread Hans Verkuil
Hi Laurent, On Sunday 30 November 2008 22:02:21 Laurent Pinchart wrote: > Hi Hans, > > On Saturday 29 November 2008, Hans Verkuil wrote: > > Hi Laurent, > > > > Let me start by thanking you for reviewing this! Much appreciated. > > You're welcome. > > > On Saturday 29 November 2008 00:34:44 Lauren

Re: v4l2_device/v4l2_subdev: please review (PATCH 1/3)

2008-11-30 Thread Laurent Pinchart
Hi Hans, On Saturday 29 November 2008, Hans Verkuil wrote: > Hi Laurent, > > Let me start by thanking you for reviewing this! Much appreciated. You're welcome. > On Saturday 29 November 2008 00:34:44 Laurent Pinchart wrote: > > Hi Hans, > > > > On Tuesday 25 November 2008, Hans Verkuil wrote: >

Re: v4l2_device/v4l2_subdev: please review (PATCH 1/3)

2008-11-30 Thread Hans Verkuil
On Saturday 29 November 2008 20:08:44 Guennadi Liakhovetski wrote: > On Sat, 29 Nov 2008, Hans Verkuil wrote: > > > > +Introduction > > > > + > > > > + > > > > +The V4L2 drivers tend to be very complex due to the complexity > > > > of the +hardware: most devices have multiple ICs, expor

Re: v4l2_device/v4l2_subdev: please review (PATCH 1/3)

2008-11-29 Thread Hans Verkuil
On Saturday 29 November 2008 20:46:43 David Brownell wrote: > On Saturday 29 November 2008, Hans Verkuil wrote: > > > > +And this to go from an i2c_client to a v4l2_subdev struct: > > > > + > > > > +   struct v4l2_subdev *sd = i2c_get_clientdata(client); > > > > + > > > > +Finally you need to make

Re: v4l2_device/v4l2_subdev: please review (PATCH 1/3)

2008-11-29 Thread David Brownell
On Saturday 29 November 2008, Hans Verkuil wrote: > > > +And this to go from an i2c_client to a v4l2_subdev struct: > > > + > > > +   struct v4l2_subdev *sd = i2c_get_clientdata(client); > > > + > > > +Finally you need to make a command function to make > > > +driver->command() call the right subde

Re: v4l2_device/v4l2_subdev: please review (PATCH 1/3)

2008-11-29 Thread Guennadi Liakhovetski
On Sat, 29 Nov 2008, Hans Verkuil wrote: > > > +Introduction > > > + > > > + > > > +The V4L2 drivers tend to be very complex due to the complexity of > > > the +hardware: most devices have multiple ICs, export multiple > > > device nodes in +/dev, and create also non-V4L2 devices such

Re: v4l2_device/v4l2_subdev: please review (PATCH 1/3)

2008-11-29 Thread Hans Verkuil
Hi Laurent, Let me start by thanking you for reviewing this! Much appreciated. On Saturday 29 November 2008 00:34:44 Laurent Pinchart wrote: > Hi Hans, > > On Tuesday 25 November 2008, Hans Verkuil wrote: > > As requested, the patches as separate posts for review. > > > > Hans > > > > # HG ch

Re: v4l2_device/v4l2_subdev: please review (PATCH 1/3)

2008-11-28 Thread Laurent Pinchart
Hi Hans, On Tuesday 25 November 2008, Hans Verkuil wrote: > As requested, the patches as separate posts for review. > > Hans > > # HG changeset patch > # User Hans Verkuil <[EMAIL PROTECTED]> > # Date 1227560990 -3600 > # Node ID d9ec70c0b0c55e18813f91218c6da6212ca9b7e6 > # Parent b63737bf9e

Re: v4l2_device/v4l2_subdev: please review (PATCH 1/3)

2008-11-25 Thread Hans Verkuil
On Tuesday 25 November 2008 08:27:29 Trilok Soni wrote: > Hi Hans, > > > I'm not going to spam the list with these quite big patches. Just > > go to http://linuxtv.org/hg/~hverkuil/v4l-dvb-ng/ and click on the > > 'raw' link after each change to see the patch. Most of these > > changes are just bor