Re: [PATCH 4/8 v2] ARM OMAP2+ GPMC: fix debug output alignment

2015-02-25 Thread Roger Quadros
On 24/02/15 22:05, Robert ABEL wrote: GPMC debug output is aligned to 10 characters for field names. However, some fields have bigger names, screwing up the alignment. Consequently, alignment was changed to longest field name (17 chars) for now. Signed-off-by: Robert ABEL

[PATCH] ARM: omap-device: add missed callback for suspend-to-disk

2015-02-25 Thread grygorii.strashko
From: Grygorii Strashko grygorii.stras...@linaro.org Add missed callback needed for supporting suspend-to-disk (hibernation) mode. Signed-off-by: Grygorii Strashko grygorii.stras...@linaro.org --- arch/arm/mach-omap2/omap_device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

Re: [PATCH 3/8 v2] ARM OMAP2+ GPMC: add bus children

2015-02-25 Thread Roger Quadros
Robert, On 24/02/15 22:05, Robert ABEL wrote: This patch adds support for spawning busses as children of the GPMC. Signed-off-by: Robert ABEL ra...@cit-ec.uni-bielefeld.de --- drivers/memory/omap-gpmc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 6/8 v2] ARM OMAP2+ GPMC: always program GPMCFCLKDIVIDER

2015-02-25 Thread Roger Quadros
On 24/02/15 22:05, Robert ABEL wrote: The WAITMONITORINGTIME is expressed as a number of GPMC_CLK clock cycles, even though the access is defined as asynchronous, and no GPMC_CLK clock is provided to the external device. Still, GPMCFCLKDIVIDER is used as a divider for the GPMC clock, so it

Re: [PATCH 5/8 v2] ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS

2015-02-25 Thread Roger Quadros
On 24/02/15 22:05, Robert ABEL wrote: DTS output was formatted to require additional work when copy-pasting into DTS. Nano-second timings were removed, because they were not a confidence interval nor an indication what timing values would result in the same #ticks If they were not is it

Re: [PATCH] ARM: omap-device: add missed callback for suspend-to-disk

2015-02-25 Thread Grygorii Strashko
On 02/25/2015 05:44 PM, Tony Lindgren wrote: * grygorii.stras...@linaro.org grygorii.stras...@linaro.org [150225 06:17]: From: Grygorii Strashko grygorii.stras...@linaro.org Add missed callback needed for supporting suspend-to-disk (hibernation) mode. Is this needed as a fix for the -rc

Re: [PATCH 3/8 v2] ARM OMAP2+ GPMC: add bus children

2015-02-25 Thread Roger Quadros
Robert, On 25/02/15 17:06, Robert Abel wrote: Hi Roger, On 25 Feb 2015 13:02, Roger Quadros wrote: This creates platform devices for the children of child, but what about platform device for the child itself? It seems my first try in the other patch set wasn't so wrong after all. Maybe

[PATCH] ASoC: omap: fix up SND_OMAP_SOC_OMAP_ABE_TWL6040 dependency

2015-02-25 Thread Arnd Bergmann
The change to enable OMAP5 support on this platform was a little too eager in adding a 'select' for a particular clock driver that might not be enabled in all configurations, which in turn leads to a build error: warning: (SND_OMAP_SOC_OMAP_ABE_TWL6040) selects COMMON_CLK_PALMAS which has unmet

Re: [PATCH 3/8 v2] ARM OMAP2+ GPMC: add bus children

2015-02-25 Thread Robert Abel
Hi Roger, On 25 Feb 2015 13:02, Roger Quadros wrote: This creates platform devices for the children of child, but what about platform device for the child itself? It seems my first try in the other patch set wasn't so wrong after all. Maybe unconditionally call

Re: [PATCH 5/8 v2] ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS

2015-02-25 Thread Tony Lindgren
* Roger Quadros rog...@ti.com [150225 05:28]: On 24/02/15 22:05, Robert ABEL wrote: DTS output was formatted to require additional work when copy-pasting into DTS. Nano-second timings were removed, because they were not a confidence interval nor an indication what timing values would

Re: [PATCH v5 0/7] irqchip: Move OMAP{4,5}/DRA7 to use stacked domains

2015-02-25 Thread Nishanth Menon
On 02/24/2015 04:41 AM, Marc Zyngier wrote: On 23/02/15 20:39, Nishanth Menon wrote: On 02/23/2015 02:32 PM, Nishanth Menon wrote: On 17:44-20150223, Marc Zyngier wrote: [...] create mode 100644 Documentation/devicetree/bindings/interrupt-controller/ti,omap4-wugen-mpu delete mode 100644

Re: [PATCH 9/8 v2] ARM OMAP2+ GPMC: fix programming/showing reserved timing parameters

2015-02-25 Thread Robert Abel
Hi Roger, On 25 Feb 2015 11:44, Roger Quadros wrote: typo ATTCHEDDEVICEPAGELENGTH-ATTACHEDDEVICEPAGELENGTH Yep. +/** DEVICESIZE Max Value */ +#define GPMC_CONFIG1_DEVICESIZE_MAX GPMC_CONFIG1_DEVICESIZE_16 Shouldn't this be 1 instead? I'm hoping max value is without the shift based on

Re: [PATCH] ASoC: omap: fix up SND_OMAP_SOC_OMAP_ABE_TWL6040 dependency

2015-02-25 Thread Arnd Bergmann
On Wednesday 25 February 2015 17:31:47 Peter Ujfalusi wrote: Would it be better to have this changed to: select COMMON_CLK_PALMAS if MFD_PALMAS instead of removing. All OMAP5 boards uses Palmas as PMIC and the boards where twl6040 audio is in use the 32K clock for the codec is

Re: [PATCH] ASoC: omap: fix up SND_OMAP_SOC_OMAP_ABE_TWL6040 dependency

2015-02-25 Thread Peter Ujfalusi
On 02/25/2015 05:05 PM, Arnd Bergmann wrote: The change to enable OMAP5 support on this platform was a little too eager in adding a 'select' for a particular clock driver that might not be enabled in all configurations, which in turn leads to a build error: warning:

[PATCH v2] ASoC: omap: fix up SND_OMAP_SOC_OMAP_ABE_TWL6040 dependency

2015-02-25 Thread Arnd Bergmann
The change to enable OMAP5 support on this platform was a little too eager in adding a 'select' for a particular clock driver that might not be enabled in all configurations, which in turn leads to a build error: warning: (SND_OMAP_SOC_OMAP_ABE_TWL6040) selects COMMON_CLK_PALMAS which has unmet

Re: [PATCH] ARM: omap-device: add missed callback for suspend-to-disk

2015-02-25 Thread Tony Lindgren
* grygorii.stras...@linaro.org grygorii.stras...@linaro.org [150225 06:17]: From: Grygorii Strashko grygorii.stras...@linaro.org Add missed callback needed for supporting suspend-to-disk (hibernation) mode. Is this needed as a fix for the -rc series or are there still other missing

Re: [PATCH 9/8 v2] ARM OMAP2+ GPMC: fix programming/showing reserved timing parameters

2015-02-25 Thread Roger Quadros
Robert, On 25/02/15 17:17, Robert Abel wrote: Hi Roger, On 25 Feb 2015 11:44, Roger Quadros wrote: typo ATTCHEDDEVICEPAGELENGTH-ATTACHEDDEVICEPAGELENGTH Yep. +/** DEVICESIZE Max Value */ +#define GPMC_CONFIG1_DEVICESIZE_MAX GPMC_CONFIG1_DEVICESIZE_16 Shouldn't this be 1 instead? I'm

Re: [PATCH] ARM: omap-device: add missed callback for suspend-to-disk

2015-02-25 Thread Tony Lindgren
* Grygorii Strashko grygorii.stras...@ti.com [150225 07:56]: On 02/25/2015 05:44 PM, Tony Lindgren wrote: * grygorii.stras...@linaro.org grygorii.stras...@linaro.org [150225 06:17]: From: Grygorii Strashko grygorii.stras...@linaro.org Add missed callback needed for supporting suspend-to-disk

[PATCH] omapdss: extend pm notifier to handle hibernation

2015-02-25 Thread grygorii.strashko
From: Grygorii Strashko grygorii.stras...@linaro.org Add handling of missed events in omap_dss_pm_notif which are needed to support hibernation (suspend to disk). Signed-off-by: Grygorii Strashko grygorii.stras...@linaro.org --- drivers/video/fbdev/omap2/dss/core.c | 4 1 file changed, 4

Dead Kconfig Option OMAP4_ERRATA_I688

2015-02-25 Thread Stefan Hengelein
During the research for my masters thesis i came across the OMAP4_ERRATA_I688 option and realized, it is never possible to enable this option. The a62a6e98 commit added the !ARCH_MULTIPLATFORM dependency to disable this option for multiplatforms. However, because of enclosing dependencies, this

Re: Dead Kconfig Option OMAP4_ERRATA_I688

2015-02-25 Thread Tony Lindgren
Hi, Adding Santosh to Cc on this one. * Stefan Hengelein stefan.hengel...@fau.de [150225 09:13]: During the research for my masters thesis i came across the OMAP4_ERRATA_I688 option and realized, it is never possible to enable this option. The a62a6e98 commit added the !ARCH_MULTIPLATFORM

Re: [PATCH 7/8 v2] ARM OMAP2+ GPMC: calculate GPMCFCLKDIVIDER based on WAITMONITORINGTIME

2015-02-25 Thread Robert Abel
On 25 Feb 2015 18:20, Roger Quadros wrote: Need to patch mach-omap2/usb-tusb6010.c as well. else we get arch/arm/mach-omap2/usb-tusb6010.c: In function ‘tusb_set_async_mode’: arch/arm/mach-omap2/usb-tusb6010.c:74:2: error: too few arguments to function ‘gpmc_cs_set_timings’ In file included

Re: Dead Kconfig Option OMAP4_ERRATA_I688

2015-02-25 Thread santosh shilimkar
On 2/25/2015 9:14 AM, Tony Lindgren wrote: Hi, Adding Santosh to Cc on this one. * Stefan Hengelein stefan.hengel...@fau.de [150225 09:13]: During the research for my masters thesis i came across the OMAP4_ERRATA_I688 option and realized, it is never possible to enable this option. The

Re: [PATCH 8/8 v2] ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug

2015-02-25 Thread Roger Quadros
Robert, On 24/02/15 22:05, Robert ABEL wrote: The WAITMONITORINGTIME is expressed as a number of GPMC_CLK clock cycles, even though the access is defined as asynchronous, and no GPMC_CLK clock is provided to the external device. Still, GPMCFCLKDIVIDER is used as a divider for the GPMC

Re: [GIT PULL] omap fixes against v4.0-rc1

2015-02-25 Thread Arnd Bergmann
On Tuesday 24 February 2015 12:52:20 Tony Lindgren wrote: The following changes since commit c517d838eb7d07bbe9507871fab3931deccff539: Linux 4.0-rc1 (2015-02-22 18:21:14 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap

[PATCH] drm/omap: tiler: add hibernation callback

2015-02-25 Thread grygorii.strashko
From: Grygorii Strashko grygorii.stras...@linaro.org Setting a dev_pm_ops resume callback but not a set of hibernation handler means that pm function will not be called upon hibernation. Fix this by using SIMPLE_DEV_PM_OPS, which appropriately assigns the suspend and hibernation handlers and move

Re: [PATCH 5/8 v2] ARM OMAP2+ GPMC: change get_gpmc_timing_reg output for DTS

2015-02-25 Thread Robert Abel
Hi Tony, On 25 Feb 2015 16:23, Tony Lindgren wrote: * Roger Quadros rog...@ti.com [150225 05:28]: On 24/02/15 22:05, Robert ABEL wrote: DTS output was formatted to require additional work when copy-pasting into DTS. Nano-second timings were removed, because they were not a confidence interval

Re: [PATCH 3/8 v2] ARM OMAP2+ GPMC: add bus children

2015-02-25 Thread Robert Abel
Hi Roger, On 25 Feb 2015 17:18, Roger Quadros wrote: OK. Would be interesting to see how unconditional call to of_platform_decide_create() behaves for your case. I'm not able to test today, so results will be in tomorrow. If that doesn't work, I'll just resubmit my first patch with the

Re: [PATCH 8/8 v2] ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug

2015-02-25 Thread Roger Quadros
Robert, On 25/02/15 19:07, Robert Abel wrote: Hi Roger, On 25 Feb 2015 17:58, Roger Quadros wrote: static unsigned int gpmc_ticks_to_ps(unsigned int ticks) @@ -346,16 +395,22 @@ static void gpmc_cs_bool_timings(int cs, const struct gpmc_bool_timings *p) * @st_bit Start Bit *

Re: [PATCH 3/8 v2] ARM OMAP2+ GPMC: add bus children

2015-02-25 Thread Roger Quadros
On 25/02/15 18:23, Robert Abel wrote: Hi Roger, On 25 Feb 2015 17:18, Roger Quadros wrote: OK. Would be interesting to see how unconditional call to of_platform_decide_create() behaves for your case. I'm not able to test today, so results will be in tomorrow. If that doesn't work, I'll

Re: [PATCH 7/8 v2] ARM OMAP2+ GPMC: calculate GPMCFCLKDIVIDER based on WAITMONITORINGTIME

2015-02-25 Thread Roger Quadros
On 24/02/15 22:05, Robert ABEL wrote: The WAITMONITORINGTIME is expressed as a number of GPMC_CLK clock cycles, even though the access is defined as asynchronous, and no GPMC_CLK clock is provided to the external device. Still, GPMCFCLKDIVIDER is used as a divider for the GPMC clock, so it

Re: [PATCH 8/8 v2] ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug

2015-02-25 Thread Robert Abel
Hi Roger, On 25 Feb 2015 17:58, Roger Quadros wrote: static unsigned int gpmc_ticks_to_ps(unsigned int ticks) @@ -346,16 +395,22 @@ static void gpmc_cs_bool_timings(int cs, const struct gpmc_bool_timings *p) * @st_bit Start Bit * @end_bit End Bit. Must be = @st_bit. * @nameDTS

[PATCH] ARM: dts: am335x-boneblack: enable aes and sham

2015-02-25 Thread Matt Porter
Beaglebone Black doesn't have AES and SHAM enabled like the original Beaglebone White dts. This breaks applications that leverage the crypto blocks so fix this by enabling these nodes. Signed-off-by: Matt Porter mpor...@konsulko.com --- arch/arm/boot/dts/am335x-boneblack.dts | 8 1 file

Re: [PATCH 7/8 v2] ARM OMAP2+ GPMC: calculate GPMCFCLKDIVIDER based on WAITMONITORINGTIME

2015-02-25 Thread Robert Abel
Hi Roger, On 25 Feb 2015 17:33, Roger Quadros wrote: ./scripts/checkpatch.pl detects some styling errors. Well, there's like a million lines over 80 characters. I'm also a heathen and don't use an 80 character terminal either. I'll fix the more serious issues checkpatch finds, but some styling

build warning on v4.0-rc1

2015-02-25 Thread Felipe Balbi
Hi Al, commit 3b994d98a815d934ab6a77a380882865982c14f9 (get rid of the second argument of acct_kill()) added a new build warning when building kernel/acct.c. Warning can be seen below. Revert of that commit is non-trivial, so I haven't tried to check if reverting it fixes the warning. One one to

Re: [PATCH 8/8 v2] ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug

2015-02-25 Thread Roger Quadros
On 25/02/15 19:22, Robert Abel wrote: Hi Roger, On 25 Feb 2015 18:17, Roger Quadros wrote: How will the user know by looking at the kernel log that it was really an error? We don't fail probe if set_gpmc_timing_reg() fails so I feel it is necessary to clearly show an Error message.

Re: [PATCH 7/8 v2] ARM OMAP2+ GPMC: calculate GPMCFCLKDIVIDER based on WAITMONITORINGTIME

2015-02-25 Thread Roger Quadros
Robert, On 25/02/15 18:33, Roger Quadros wrote: On 24/02/15 22:05, Robert ABEL wrote: The WAITMONITORINGTIME is expressed as a number of GPMC_CLK clock cycles, even though the access is defined as asynchronous, and no GPMC_CLK clock is provided to the external device. Still, GPMCFCLKDIVIDER

Re: [PATCH 8/8 v2] ARM OMAP2+ GPMC: fix WAITMONITORINGTIME divider bug

2015-02-25 Thread Robert Abel
Hi Roger, On 25 Feb 2015 18:17, Roger Quadros wrote: How will the user know by looking at the kernel log that it was really an error? We don't fail probe if set_gpmc_timing_reg() fails so I feel it is necessary to clearly show an Error message. You can probably reword it like %s: Error!! GPMC

[PATCHv3 28/35] ARM: dts: am43xx-epos-evm: fix pinmux node layout

2015-02-25 Thread Tero Kristo
Pinmux node should be a reference to the base one, not a complete re-write of it. Having the node like this also prevents modifying the node layout in the base am4372.dtsi file, which is needed for control module changes. Signed-off-by: Tero Kristo t-kri...@ti.com ---

[PATCHv3 31/35] ARM: OMAP4: display: convert display to use syscon for dsi muxing

2015-02-25 Thread Tero Kristo
The legacy control module APIs will be gone, thus convert the display driver to use syscon. This change should eventually be moved to display driver from the board directory. Signed-off-by: Tero Kristo t-kri...@ti.com Cc: Tomi Valkeinen tomi.valkei...@ti.com --- arch/arm/mach-omap2/display.c |

[PATCHv3 33/35] ARM: dts: omap5: add system control module node

2015-02-25 Thread Tero Kristo
Add node for system control module, and move all the existing system control IO space users under this new node as its children. A new node for scm_conf area is also added. Signed-off-by: Tero Kristo t-kri...@ti.com --- .../devicetree/bindings/arm/omap/ctrl.txt |1 +

[PATCHv3 34/35] ARM: dts: dra7: add system control module node

2015-02-25 Thread Tero Kristo
Add node for system control module, and move all the existing system control IO space users under this new node as its children. A new node for scm_conf area is also added. Signed-off-by: Tero Kristo t-kri...@ti.com --- .../devicetree/bindings/arm/omap/ctrl.txt |1 +

[PATCHv3 35/35] ARM: OMAP4+: control: add support for initializing control module via DT

2015-02-25 Thread Tero Kristo
OMAP4, OMAP5 and DRA7 now parse DT entries for control module address spaces, and set up syscon mappings appropriately. Low level IO init is updated to remove the legacy control module mappings for these devices also. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/mach-omap2/control.c |

[PATCHv3 27/35] ARM: dts: am33xx: merge control module features under scrm node

2015-02-25 Thread Tero Kristo
This patch moves all the control module related features under scrm node. scm_conf area is changed to use syscon, and also the clocks are moved under scm_conf area. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/boot/dts/am33xx.dtsi | 48 - 1

[PATCHv3 32/35] ARM: OMAP4+: control: remove support for legacy pad read/write

2015-02-25 Thread Tero Kristo
omap4_ctrl_pad_readl/writel are no longer used by anybody, so remove these. Syscon / pinctrl should be used to access the padconf area instead. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/mach-omap2/control.c | 24 +--- arch/arm/mach-omap2/control.h |5 +

Re: [PATCHv3 04/35] ARM: OMAP3+: PRM: add common APIs for prm_vp_check/clear_txdone

2015-02-25 Thread Tero Kristo
On 02/25/2015 09:09 PM, Felipe Balbi wrote: Hi, On Wed, Feb 25, 2015 at 09:04:14PM +0200, Tero Kristo wrote: diff --git a/arch/arm/mach-omap2/prm_common.c b/arch/arm/mach-omap2/prm_common.c index 2c2e7ed..79cee11 100644 --- a/arch/arm/mach-omap2/prm_common.c +++

Re: [PATCH] ARM: dts: am335x-boneblack: enable aes and sham

2015-02-25 Thread Robert Nelson
On Wed, Feb 25, 2015 at 11:07 AM, Matt Porter mpor...@konsulko.com wrote: Beaglebone Black doesn't have AES and SHAM enabled like the original Beaglebone White dts. This breaks applications that leverage the crypto blocks so fix this by enabling these nodes. Signed-off-by: Matt Porter

Re: [PATCH] ARM: dts: am335x-boneblack: enable aes and sham

2015-02-25 Thread Matt Porter
On Wed, Feb 25, 2015 at 12:36:11PM -0600, Robert Nelson wrote: On Wed, Feb 25, 2015 at 11:07 AM, Matt Porter mpor...@konsulko.com wrote: Beaglebone Black doesn't have AES and SHAM enabled like the original Beaglebone White dts. This breaks applications that leverage the crypto blocks so fix

[PATCHv3 11/35] ARM: OMAP2+: clock: move clock provider infrastructure to clock driver

2015-02-25 Thread Tero Kristo
Splits the clock provider init out of the PRM driver and moves it to clock driver. This is needed so that once the PRCM drivers are separated, they can logically just access the clock driver not needing to go through common PRM code. This would be wrong in the case of control module for example.

[PATCHv3 12/35] ARM: OMAP2+: PRCM: split PRCM module init to their own driver files

2015-02-25 Thread Tero Kristo
Splits the clock related provider module inits under their own driver files. Previously this was done for all modules under the common PRM driver. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/mach-omap2/cm.h |1 + arch/arm/mach-omap2/cm_common.c | 51

[PATCHv3 09/35] Documentation: DT: document PRCM compatible strings for dm81x SoCs

2015-02-25 Thread Tero Kristo
These PRCM nodes were earlier added in patch 7800064ba5 (ARM: dts: Add basic dm816x device tree configuration), but the documentation for the same wasn't added. Fix this by adding the missing compatible strings under the generic prcm.txt document. Signed-off-by: Tero Kristo t-kri...@ti.com ---

[PATCHv3 08/35] clk: ti: fix ti_clk_get_reg_addr error handling

2015-02-25 Thread Tero Kristo
There is a case where NULL can be a valid return value for ti_clk_get_reg_addr, specifically the case where both the provider index and register offsets are zero. In this case, the current error checking against a NULL pointer will fail. Thus, change the API to return a ERR_PTR value in an error

[PATCHv3 02/35] ARM: OMAP3: PRM: invert the wkst_mask for the prm_clear_mod_irqs

2015-02-25 Thread Tero Kristo
This makes the API the same as used with OMAP2, and makes it possible to implement a generic driver API for the functionality. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/mach-omap2/pm34xx.c | 18 +- arch/arm/mach-omap2/prm3xxx.c |8

[PATCHv3 13/35] ARM: OMAP2+: CM: determine CM base address from device tree

2015-02-25 Thread Tero Kristo
There is no need to provide the CM base address through a low-level API from the low-level IO init, as this information is available through DT. Re-routed the parsing function to be called from the CM drivers also to simplify the implementation under io.c. Signed-off-by: Tero Kristo

[PATCHv3 07/35] ARM: OMAP4: PRM: move omap4xxx_prm_init earlier in init order

2015-02-25 Thread Tero Kristo
OMAP4 has different ordering of PRM and CM init calls in the early init. Re-oder these accordingly for OMAP4 also. This is needed so that we can do some optimizations in the following patches for the PRCM init. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/mach-omap2/io.c |2 +- 1

Re: [PATCH v2] ARM: dts: am335x-bone-common: enable aes and sham

2015-02-25 Thread Robert Nelson
On Wed, Feb 25, 2015 at 12:52 PM, Matt Porter mpor...@konsulko.com wrote: Beaglebone Black doesn't have AES and SHAM enabled like the original Beaglebone White dts. This breaks applications that leverage the crypto blocks so fix this by enabling these nodes in the am335x-bone-common.dtsi. With

Re: [PATCHv3 04/35] ARM: OMAP3+: PRM: add common APIs for prm_vp_check/clear_txdone

2015-02-25 Thread Felipe Balbi
Hi, On Wed, Feb 25, 2015 at 09:04:14PM +0200, Tero Kristo wrote: diff --git a/arch/arm/mach-omap2/prm_common.c b/arch/arm/mach-omap2/prm_common.c index 2c2e7ed..79cee11 100644 --- a/arch/arm/mach-omap2/prm_common.c +++ b/arch/arm/mach-omap2/prm_common.c @@ -555,6 +555,40 @@ int

Re: [PATCH] ARM: omap-device: add missed callback for suspend-to-disk

2015-02-25 Thread Kevin Hilman
grygorii.stras...@linaro.org writes: From: Grygorii Strashko grygorii.stras...@linaro.org Add missed callback needed for supporting suspend-to-disk (hibernation) mode. Signed-off-by: Grygorii Strashko grygorii.stras...@linaro.org Acked-by: Kevin Hilman khil...@linaro.org ---

[PATCHv3 22/35] ARM: OMAP2+: control: remove API for getting control module base address

2015-02-25 Thread Tero Kristo
This shall not be used anymore, as control module driver is converted into using regmap. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/mach-omap2/control.c |5 - arch/arm/mach-omap2/control.h |2 -- 2 files changed, 7 deletions(-) diff --git a/arch/arm/mach-omap2/control.c

[PATCHv3 26/35] ARM: dts: omap3: merge control module features under scrm node

2015-02-25 Thread Tero Kristo
This patch moves all the control module related features under scrm node. scm_conf area is changed to use syscon, and also the clocks are moved under scm_conf area. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/boot/dts/am3517.dtsi |2 +- arch/arm/boot/dts/omap3.dtsi

[PATCHv3 06/35] ARM: OMAP4+: CM: move omap_cm_base_init under OMAP4 CM driver

2015-02-25 Thread Tero Kristo
There is no need to call this separately from io.c, rather this can be done commonly under the CM driver. Also, this patch makes the API static, as it is no longer used outside the driver file. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/mach-omap2/cm44xx.h |1 -

[PATCHv3 17/35] ARM: OMAP4+: PRM: determine prm_device_inst based on DT compatibility

2015-02-25 Thread Tero Kristo
PRM device instance offset is now provided through the prm_init_data. This gets rid of some cpu_is_X / soc_is_X calls from PRM core code, preparing for PRM to be its own separate driver. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/mach-omap2/prcm-common.h |2 ++

[PATCHv3 21/35] ARM: OMAP2+: clock: add low-level support for regmap

2015-02-25 Thread Tero Kristo
Some of the TI clock providers will be converted to use syscon, thus low-level regmap support is needed for the clock drivers also. This patch adds this support, which can be enabled for individual drivers in later patches. Signed-off-by: Tero Kristo t-kri...@ti.com ---

[PATCHv3 15/35] ARM: OMAP2+: control: determine control module base address from DT

2015-02-25 Thread Tero Kristo
There is no need to provide the control module base address through a low-level API from the low-level IO init, as this information is available through DT. This patch adds a new API to initialize the control module though, but mostly makes the old API obsolete. The old API can be completely

[PATCHv3 24/35] ARM: OMAP2+: control: add syscon support for register accesses

2015-02-25 Thread Tero Kristo
Control module driver needs to support syscon for register accesses, as the DT hierarchy for control module driver is going to be changed. All the control module related features will be moved under control module node, including clocks, pinctrl, and generic configuration register access.

[PATCHv3 18/35] ARM: OMAP2+: CM: move SoC specific init calls within a generic API

2015-02-25 Thread Tero Kristo
This gets rid of need for some exported driver APIs, and simplifies the initialization of the CM driver. Done in preparation to make CM a separate driver. The init data is now also passed to the SoC specific implementations, allowing future expansion to add feature flags etc. Signed-off-by: Tero

[PATCHv3 05/35] ARM: OMAP4+: PRM: move omap_prm_base_init under OMAP4 PRM driver

2015-02-25 Thread Tero Kristo
There is no need to call this separately from io.c, rather this can be done commonly under the PRM driver. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/mach-omap2/io.c |4 arch/arm/mach-omap2/prm44xx.c |2 ++ 2 files changed, 2 insertions(+), 4 deletions(-) diff

[PATCHv3 04/35] ARM: OMAP3+: PRM: add common APIs for prm_vp_check/clear_txdone

2015-02-25 Thread Tero Kristo
PRM driver now only exports a generic API for clearing / checking VP txdone status. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/mach-omap2/prm.h | 14 ++ arch/arm/mach-omap2/prm3xxx.c |6 -- arch/arm/mach-omap2/prm3xxx.h |4

[PATCHv3 19/35] ARM: OMAP4+: PRM: setup prm_features from the PRM init time flags

2015-02-25 Thread Tero Kristo
Currently some cpu_is_X checks are used to setup prm_features, however the same can be accomplished by just passing these flags from the PRM init data. This is done in preparation to make PRM a separate driver. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/mach-omap2/prm44xx.c|

[PATCHv3 10/35] ARM: OMAP2+: PRCM: add support for static clock memmap indices

2015-02-25 Thread Tero Kristo
All clock provider related drivers will now register their iomaps with a static index. This makes it easier to split up the individual drivers to their own files in subsequent patches. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/mach-omap2/prcm-common.h |8

[PATCH] ARM: OMAP4: remove dead kconfig option OMAP4_ERRATA_I688

2015-02-25 Thread Stefan Hengelein
The Kconfig-Option OMAP4_ERRATA_I688 is never visible due to a contradiction in it's dependencies. The option requires ARCH_MULTIPLATFORM to be 'disabled'. However, an enclosing menu requires either ARCH_MULTI_V6 or ARCH_MULTI_V7 to be enabled. These options inherit a dependency from an enclosing

Re: [PATCHv2 00/33] ARM: OMAP2+: PRCM/omap ctrl cleanups against 3.19-rc1

2015-02-25 Thread Tero Kristo
On 02/13/2015 08:33 PM, Tony Lindgren wrote: Hi Tero, * Tero Kristo t-kri...@ti.com [150213 08:16]: Hi, Updates since v1: - fixed omap2/am33xx boot issues - added regmap support to generic omap clock core - control module driver converted to use syscon I made some comments to patch 25 of

[PATCH v2] ARM: dts: am335x-bone-common: enable aes and sham

2015-02-25 Thread Matt Porter
Beaglebone Black doesn't have AES and SHAM enabled like the original Beaglebone White dts. This breaks applications that leverage the crypto blocks so fix this by enabling these nodes in the am335x-bone-common.dtsi. With this change, enabling the nodes in am335x-bone.dts is no longer required so

[PATCHv3 25/35] ARM: dts: omap24xx: merge control module features under scrm node

2015-02-25 Thread Tero Kristo
This patch moves all the control module related features under scrm node. scm_conf area is changed to use syscon, and also the clocks are moved under scm_conf area. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/boot/dts/omap2420.dtsi| 33 +-

[PATCHv3 30/35] ARM: dts: omap4: add system control module node

2015-02-25 Thread Tero Kristo
Add node for system control module, and move all the existing system control IO space users under this new node as its children. A new node for scm_conf area is also added. DT documentation is also updated by this patch to reflect the existence of system control module nodes, separately of PRCM

[PATCHv3 29/35] ARM: dts: am4372: merge control module features under scrm node

2015-02-25 Thread Tero Kristo
This patch moves all the control module related features under scrm node. scm_conf area is provided to support syscon, and also the clocks are moved under scm_conf area. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/boot/dts/am4372.dtsi | 48 +++--

[PATCHv3 03/35] ARM: OMAP2+: PRM: add generic API for clear_mod_irqs

2015-02-25 Thread Tero Kristo
OMAP2/3 now use generic API for the prm_clear_mod_irqs, the SoC specific implementation details are provided through prm_ll_data. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/mach-omap2/pm24xx.c | 24 +++- arch/arm/mach-omap2/pm34xx.c | 18

[PATCHv3 14/35] ARM: OMAP2+: PRM: determine PRM base address from device tree

2015-02-25 Thread Tero Kristo
There is no need to provide the PRM base address through a low-level API from the low-level IO init, as this information is available through DT. Re-routed the parsing function to be called from the PRM drivers also to simplify the implementation under io.c. Signed-off-by: Tero Kristo

[PATCHv3 00/35] ARM: OMAP2+: PRCM / SCM cleanups against 4.0-rc1

2015-02-25 Thread Tero Kristo
Hi, Changes in this set compared to v2: - Changed the SCM module DT node layout to address Tony's comments; only scm-conf area / any other necessary portions are syscon mapped. Rest of the IO space is only mapped by the underlying drivers. - Added patch for changing omap4 display driver to

[PATCHv3 16/35] ARM: OMAP2+: PRM: move SoC specific init calls within a generic API

2015-02-25 Thread Tero Kristo
This gets rid of need for some exported driver APIs, and simplifies the initialization of the PRM driver. Done in preparation to make PRM a separate driver. The init data is now also passed to the SoC specific implementations, allowing future expansion to add feature flags etc. Signed-off-by:

[PATCHv3 23/35] ARM: OMAP2+: id: cache omap_type value

2015-02-25 Thread Tero Kristo
There is no need to read the register with every invocation of the function, as the value is constant. Thus, cache the value in a static variable. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/mach-omap2/id.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [PATCHv3 03/35] ARM: OMAP2+: PRM: add generic API for clear_mod_irqs

2015-02-25 Thread Felipe Balbi
Hi, On Wed, Feb 25, 2015 at 09:04:13PM +0200, Tero Kristo wrote: +int omap_prm_clear_mod_irqs(s16 module, u8 regs, u32 wkst_mask) +{ + if (!prm_ll_data-clear_mod_irqs) { + WARN_ONCE(1, prm: %s: no mapping function defined\n, + __func__); you can combine

[PATCHv3 20/35] ARM: OMAP4+: PRM: get rid of cpu_is_omap44xx calls from interrupt init

2015-02-25 Thread Tero Kristo
The compatible DT node is now passed with the prm init, so there is no need to do node matching here again. Added a new flag to the init data also, to detect default IRQ support for OMAP4. Also, any booting omap4 DT setup always has a PRM node, so there is no need to check against the special case

[PATCHv3 01/35] ARM: OMAP2+: PRCM: rename of_prcm_init to omap_prcm_init

2015-02-25 Thread Tero Kristo
This avoids conflicts in the global namespace, and is more descriptive of the purpose anyway. Signed-off-by: Tero Kristo t-kri...@ti.com --- arch/arm/mach-omap2/io.c |2 +- arch/arm/mach-omap2/prm.h|2 +- arch/arm/mach-omap2/prm_common.c |8 +++- 3 files changed,

OMAP baseline test results for v4.0-rc1

2015-02-25 Thread Paul Walmsley
Here are some basic OMAP test results for Linux v4.0-rc1. Logs and other details at: http://www.pwsan.com/omap/testlogs/test_v4.0-rc1/2015022439/ Test summary Build: uImage: Pass ( 3/ 3): omap1_defconfig, omap1_defconfig_1510innovator_only,

Re: build warning on v4.0-rc1

2015-02-25 Thread Al Viro
On Wed, Feb 25, 2015 at 11:51:43AM -0600, Felipe Balbi wrote: Hi Al, commit 3b994d98a815d934ab6a77a380882865982c14f9 (get rid of the second argument of acct_kill()) added a new build warning when building kernel/acct.c. Warning can be seen below. Revert of that commit is non-trivial, so I

Re: advanced LED controllers

2015-02-25 Thread Pavel Machek
On Mon 2015-02-23 16:58:36, Felipe Balbi wrote: On Mon, Feb 23, 2015 at 11:34:57PM +0100, Pavel Machek wrote: On Thu 2015-02-19 15:14:24, Felipe Balbi wrote: Hi, Do we have support for LED controllers which can handle patterns of different kinds ? I mean, currently, if we have an

Re: [PATCH] OMAP: DSS: DPI: disable vt-switch on suspend/resume.

2015-02-25 Thread NeilBrown
On Wed, 25 Feb 2015 12:03:36 +0200 Tomi Valkeinen tomi.valkei...@ti.com wrote: On 25/02/15 11:37, NeilBrown wrote: These devices do not need to return to non-graphic console for suspend, so disable that option. This means there is less work to do in the suspend/resume cycle, making it

Re: advanced LED controllers

2015-02-25 Thread NeilBrown
On Wed, 25 Feb 2015 22:49:41 +0100 Pavel Machek pa...@ucw.cz wrote: On Mon 2015-02-23 16:58:36, Felipe Balbi wrote: On Mon, Feb 23, 2015 at 11:34:57PM +0100, Pavel Machek wrote: On Thu 2015-02-19 15:14:24, Felipe Balbi wrote: Hi, Do we have support for LED controllers which can

Re: Enabling DBGEN signal in GP OMAP3

2015-02-25 Thread Matthijs van Duin
On 26 February 2015 at 02:09, Grazvydas Ignotas nota...@gmail.com wrote: And hey, it worked too with your code modified to use USB Blaster in it's bitbang mode over libftdi. This setup also works with openocd, but somewhat unreliably (only occasionally gets through init, often gets register

Re: [PATCH 01/15] power_supply core: support use of devres to register/unregister a power supply.

2015-02-25 Thread Sebastian Reichel
Hi Heil, On Tue, Feb 24, 2015 at 03:33:50PM +1100, NeilBrown wrote: Using devm_power_supply_register allows the unregister to happen automatically on error or final put. Signed-off-by: NeilBrown ne...@suse.de Thanks, applied to battery-2.6.git. -- Sebastian signature.asc Description:

Re: [PATCH v2 RESEND] ASoC: OMAP: mcbsp: ensure that CLKX and CLKR are not used as ouput pins when they are used as input clock for the SRG.

2015-02-25 Thread Mark Brown
On Sat, Feb 21, 2015 at 06:11:29PM +0100, Thomas Niederprüm wrote: This patch fixes faulty behaviour in a setup where the input clock for the SRG is fed through the CLKR/CLKX pin but the McBSP is configured to be master (SND_SOC_DAIFMT_CBS_CFS). In that case of course CLKR/CLKX must not be

Re: [PATCH] ASoC: omap: fix up SND_OMAP_SOC_OMAP_ABE_TWL6040 dependency

2015-02-25 Thread Mark Brown
On Wed, Feb 25, 2015 at 04:44:15PM +0100, Arnd Bergmann wrote: Unfortunately, I've sent the changed v2 patch without fixing up the commit message. Instead of sending another v3 right away, I'll wait for Mark to comment. Well, I wasn't going to look until Peter reviewed it... Please don't

Re: Enabling DBGEN signal in GP OMAP3

2015-02-25 Thread Matthijs van Duin
On 26 February 2015 at 02:09, Grazvydas Ignotas nota...@gmail.com wrote: I've finally got rid of nTRST pulldown (haven't connected TDO though), created hw-omap3.{h,cc}, but couldn't get it to do anything, until it came to my mind that you may be running ARM on your BBB slower that 1GHz that

Re: Enabling DBGEN signal in GP OMAP3

2015-02-25 Thread Grazvydas Ignotas
On Mon, Feb 23, 2015 at 1:52 PM, Matthijs van Duin matthijsvand...@gmail.com wrote: At least on the am335x, the trick actually works! I have a working demo which configures ICEPick registers and even performs transactions on the debug interconnect. Nice! I've been lazy and imported a bunch

Re: [PATCH] OMAPDSS: restore name sysfs entry.

2015-02-25 Thread NeilBrown
On Wed, 25 Feb 2015 11:32:18 +0200 Tomi Valkeinen tomi.valkei...@ti.com wrote: Yep, I don't think so. In any case, all this is to be deprecated, and as soon as omapdrm driver works reliably that should be the driver to use. How close is that? Is it worth experimenting yet? Is there an xorg

[PATCH] dma: cppi41: add missing directions bitfield

2015-02-25 Thread Felipe Balbi
Without those we will see a kernel WARN() when loading musb on am335x devices. Signed-off-by: Felipe Balbi ba...@ti.com --- drivers/dma/cppi41.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/dma/cppi41.c b/drivers/dma/cppi41.c index 512cb8e2805e..4e9cc8e8100c 100644 ---

Re: Nokia N900: omap aes is broken

2015-02-25 Thread Pali Rohár
On Wednesday 25 February 2015 10:50:00 Pavel Machek wrote: On Tue 2015-02-24 09:37:34, Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [150224 09:42]: On Tuesday 24 February 2015 18:25:12 Tony Lindgren wrote: * Pali Rohár pali.ro...@gmail.com [150218 16:03]: ---

Re: [PATCH 9/8 v2] ARM OMAP2+ GPMC: fix programming/showing reserved timing parameters

2015-02-25 Thread Roger Quadros
Robert, On 24/02/15 22:05, Robert ABEL wrote: GPMC_CONFIG1_i parameters CLKACTIVATIONTIME and WAITMONITORINGTIME have reserved values. Raise an error if calculated timings try to program reserved values. GPMC_CONFIG1_i ATTCHEDDEVICEPAGELENGTH and DEVICESIZE were already checked typo

Re: [PATCH 1/8 v2] ARM OMAP2+ GPMC: don't undef DEBUG

2015-02-25 Thread Roger Quadros
On 24/02/15 22:05, Robert ABEL wrote: OMAP2+ GPMC driver undefines DEBUG, which makes it unnecessarily hard to turn DEBUG on. Remove the offending lines. Signed-off-by: Robert ABEL ra...@cit-ec.uni-bielefeld.de Acked-by: Roger Quadros rog...@ti.com cheers, -roger ---

  1   2   >