Re: [PATCH] [RFC] dmtimer library is very inefficient today

2008-03-19 Thread Kevin Hilman
Woodruff, Richard [EMAIL PROTECTED] writes: Here is a patch to look at it. Seems to work for me. It adds the use of posting for the timer. Previously, every write could lock the requestor for almost 3x32KHz cycles. This now only synchronizes before writes and reads instead of after them

Re: source.mvista links are broken

2008-04-04 Thread Kevin Hilman
Tony Lindgren [EMAIL PROTECTED] writes: * Iqbal [EMAIL PROTECTED] [080404 13:07]: Looks like the OMAP tree links are broken and the summary,short log and other fields don't work. http://source.mvista.com/git/?p=linux-omap-2.6.git;a=commit;h=8a88c221c88399bc694c367dbea01ffc4153ef20

Re: source.mvista links are broken

2008-04-09 Thread Kevin Hilman
I am not able to find x-loader git tree, maintained by Kyungmin Park of Samsung on source.mvista.com? I've fixed the gitweb so it finds all the active trees, and now http://source.mvista.com/git/ will show the xloader tree as well. That being said, it hasn't been touched for 2+ years. Is

Re: [PATCH 1/4] Adding OMAP3 EVM support

2008-04-24 Thread Kevin Hilman
Minor cosmetic suggestion... As new files are added, can we please leave out full path to the file in the file header? Not only is this unnecessary clutter, after a short amount of time, these are usually wrong as files get renamed, reorganized etc. and the paths rarely get updated. It's best

Re: [RFC/PATCH] OMAP PM interface

2008-04-29 Thread Kevin Hilman
Paul Walmsley [EMAIL PROTECTED] writes: Linux PM QOS parameters: As of February, the mainline Linux kernel contains code that is somewhat similar to the SRF: the Linux PM QOS parameters code, located in kernel/pm_qos_params.c. (This code replaced the latency management code that was

Re: [RFC/PATCH] OMAP PM interface

2008-05-01 Thread Kevin Hilman
Paul Walmsley [EMAIL PROTECTED] writes: On Tue, 29 Apr 2008, Kevin Hilman wrote: I've only given a quick glance so far at the actual patch, but my first comments are regarding the dismissal of the PM QoS framework. I totally agree that the QoS framework in its current form has several

[PATCH 0/5] RT: Misc. fixups for ARM/OMAP against 2.6.25.4-rt3

2008-05-20 Thread Kevin Hilman
What follows are a series of minor fixes to get -rt3 building/booting on ARM. The first 3 are ready do be included into the -rt patch, while the last 4th one (cmpxchg duplication) needs a little investigating. The 5th one needs to go upstream via the OMAP tree. This was build/boot tested on

[PATCH 4/5] RT: ARM: disable duplicate cmpxchg

2008-05-20 Thread Kevin Hilman
FIXME: The ARM cmpxchg macro conflicts with the generic ones from cmpxchg-local. Signed-off-by: Kevin Hilman [EMAIL PROTECTED] --- include/asm-arm/atomic.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/asm-arm/atomic.h b/include/asm-arm/atomic.h index b5ba735

[PATCH 2/5] RT: wrap BUILD_CHECK_IRQ_FLAGS

2008-05-20 Thread Kevin Hilman
The macros used by BUILD_CHECK_IRQ_FLAGS() are defined in kernel.h, but this file is sometimes included before kernel.h (or even by kernel.h) Signed-off-by: Kevin Hilman [EMAIL PROTECTED] --- include/linux/irqflags.h |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git

[RFC/PATCH 4/5] RT: ARM: disable duplicate cmpxchg

2008-05-20 Thread Kevin Hilman
FIXME: The ARM cmpxchg macro conflicts with the generic ones from cmpxchg-local. Signed-off-by: Kevin Hilman [EMAIL PROTECTED] --- include/asm-arm/atomic.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/asm-arm/atomic.h b/include/asm-arm/atomic.h index b5ba735

[PATCH 3/5] RT: ARM: remove __attribute_used__ from semaphore code

2008-05-20 Thread Kevin Hilman
Signed-off-by: Kevin Hilman [EMAIL PROTECTED] --- arch/arm/kernel/semaphore.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/arm/kernel/semaphore.c b/arch/arm/kernel/semaphore.c index 6036f57..11f7d04 100644 --- a/arch/arm/kernel/semaphore.c +++ b/arch/arm

git server source.mvista.com unavailable this weekend

2008-06-04 Thread Kevin Hilman
FYI... source.mvista.com which hosts the git repository will be unavailable this Friday night through Saturday mid-morning (US Pacific: GMT -8) This is due to scheduled maintaince in the building where the machine is hosted. Kevin -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 5/5] ARM: OMAP: remove unnecessary locking in clk_get_rate()

2008-06-04 Thread Kevin Hilman
Paul Walmsley wrote: Hi Kevin, On Tue, 20 May 2008, Kevin Hilman wrote: The locking in the get_rate() hook is unnecessary, and causes problems when used with the -rt patch, since it may be called recursively. Signed-off-by: Kevin Hilman [EMAIL PROTECTED] Acked-by: Paul Walmsley

Re: [PATCH 5/5] ARM: OMAP: remove unnecessary locking in clk_get_rate()

2008-06-04 Thread Kevin Hilman
Tony Lindgren wrote: * Kevin Hilman [EMAIL PROTECTED] [080604 09:37]: Paul Walmsley wrote: Hi Kevin, On Tue, 20 May 2008, Kevin Hilman wrote: The locking in the get_rate() hook is unnecessary, and causes problems when used with the -rt patch, since it may be called recursively

Re: [PATCH 01/02] OMAP3 CPUidle driver

2008-06-17 Thread Kevin Hilman
Rajendra Nayak [EMAIL PROTECTED] writes: Rajendra Nayak [EMAIL PROTECTED] writes: This patch adds the OMAP3 cpuidle driver. Irq enable/disable is done in the core cpuidle driver before it queries the governor for the next state. Can you explain why you need the IRQ/FIQ disable added

Re: [PATCH 01/02] OMAP3 CPUidle driver

2008-06-20 Thread Kevin Hilman
[EMAIL PROTECTED] (Högander Jouni) writes: ext Kevin Hilman [EMAIL PROTECTED] writes: Rajendra Nayak [EMAIL PROTECTED] writes: Rajendra Nayak [EMAIL PROTECTED] writes: This patch adds the OMAP3 cpuidle driver. Irq enable/disable is done in the core cpuidle driver before it queries

Re: [PATCH 01/02] OMAP3 CPUidle driver

2008-06-23 Thread Kevin Hilman
[EMAIL PROTECTED] (Högander Jouni) writes: ext Kevin Hilman [EMAIL PROTECTED] writes: [EMAIL PROTECTED] (Högander Jouni) writes: ext Kevin Hilman [EMAIL PROTECTED] writes: Rajendra Nayak [EMAIL PROTECTED] writes: Rajendra Nayak [EMAIL PROTECTED] writes: This patch adds the OMAP3

Re: Issues with calling pm_runtime functions in platform_pm_suspend_noirq/IRQ disabled context.

2010-08-03 Thread Kevin Hilman
Basak, Partha p-bas...@ti.com writes: Resending with the corrected mailing list Hello Kevin, I want to draw your attention to an issue the following patch introduces. http://dev.omapzoom.org/?p=swarch/linux-omap-adv.git;a=commitdiff;h=8041359e18e49bf8a3d41f15894db9e476f3a8fc [...] I

Re: [PATCH 04/11] OMAP3: DMA: HWMOD: Add hwmod data structures

2010-08-03 Thread Kevin Hilman
Manjunatha GK manj...@ti.com writes: This patch adds OMAP3 DMA hwmod structures. Signed-off-by: Manjunatha GK manj...@ti.com [...] +static struct omap_hwmod omap3xxx_dma_system_hwmod = { + .name = dma, + .class = omap3xxx_dma_hwmod_class, + .mpu_irqs

Re: [GIT PULL] OMAP: clock, hwmod, omap_device, PM constraints: patches for 2.6.36

2010-08-03 Thread Kevin Hilman
) are available in the git repository at: git://git.pwsan.com/linux-2.6 for_2.6.36 Anand Gadiyar (1): OMAP3: wait on IDLEST after enabling USBTLL fclk Benoit Cousson (1): OMAP23: hwmod: Remove _hwmod prefix in name string Kevin Hilman (8): OMAP24xx: CM: fix mask used

Re: [RFC 0/7] OMAP: Basic DVFS framework

2010-08-03 Thread Kevin Hilman
inter VDD dependencies. 2. Add OMAP4 support. Contributors to conceptualization of the design include Benoit Cousson b-cous...@ti.com, Kevin Hilman khil...@deeprootsystems.com, Paul Wamsley p...@pwsan.com, Vishwanath Sripathy vishwanath...@ti.com Parthasarathy Basak p-bas...@ti.com Anand Sawant

Re: [RFC 3/7] OMAP: Introduce voltage domain pointer and device specific set rate and get rate in device opp structures.

2010-08-03 Thread Kevin Hilman
Thara Gopinath th...@ti.com writes: This patch extends the device opp structure to contain info about the voltage domain to which the device belongs to and to contain pointers to scale the operating rate of the device. This patch also adds an API in the opp layer that can be used by the

Re: [RFC 3/7] OMAP: Introduce voltage domain pointer and device specific set rate and get rate in device opp structures.

2010-08-04 Thread Kevin Hilman
Gopinath, Thara th...@ti.com writes: @@ -385,6 +380,11 @@ int opp_add(const struct omap_opp_def *opp_def) dev_opp-oh = oh; dev_opp-dev = oh-od-pdev.dev; + dev_opp-vdd_name = kzalloc(strlen(opp_def-vdd_name) + 1, + GFP_KERNEL); +

Re: [PM-SR] [PATCH] OMAP: PM: Remove the usage of vdd id's.

2010-08-04 Thread Kevin Hilman
Cousson, Benoit b-cous...@ti.com writes: On 8/4/2010 6:31 AM, Gopinath, Thara wrote: From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Friday, June 25, 2010 11:56 PM Thara Gopinathth...@ti.com writes: This patch removes the usage of vdd and sr id alltogether. This is achieved

Re: Issues with calling pm_runtime functions in platform_pm_suspend_noirq/IRQ disabled context.

2010-08-04 Thread Kevin Hilman
Basak, Partha p-bas...@ti.com writes: -Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Tuesday, August 03, 2010 11:06 PM To: Basak, Partha Cc: Paul Walmsley; linux-omap@vger.kernel.org; Kalliguddi, Hema; Raja, Govindraj; Varadarajan, Charulatha; Nayak

Re: Issues with calling pm_runtime functions in platform_pm_suspend_noirq/IRQ disabled context.

2010-08-04 Thread Kevin Hilman
Kevin Hilman khil...@deeprootsystems.com writes: Basak, Partha p-bas...@ti.com writes: -Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Tuesday, August 03, 2010 11:06 PM To: Basak, Partha Cc: Paul Walmsley; linux-omap@vger.kernel.org; Kalliguddi

PM branch updated to v2.6.35, SRF dropped

2010-08-04 Thread Kevin Hilman
Hello, It's been a while since a PM branch update, thanks to a nice summer vacation for me. :) The PM branch has now been updated to v2.6.35 plus Tony's for-next branch. This is mostly a rebase, but the most important change is that I'm finally dropping SRF as promised[1]. The new DVFS

Re: Issues with calling pm_runtime functions in platform_pm_suspend_noirq/IRQ disabled context.

2010-08-04 Thread Kevin Hilman
Kevin Hilman khil...@deeprootsystems.com writes: Kevin Hilman khil...@deeprootsystems.com writes: Basak, Partha p-bas...@ti.com writes: -Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Tuesday, August 03, 2010 11:06 PM To: Basak, Partha Cc: Paul

Re: Issues with calling pm_runtime functions in platform_pm_suspend_noirq/IRQ disabled context.

2010-08-04 Thread Kevin Hilman
Basak, Partha p-bas...@ti.com writes: Tested GPIO for Suspend with these changes obtained dump of Circular Locking dependencies: It would *really* help to have these GPIO conversion patches posted against a public tree/branch one could see exactly what is going on and be able to reproduce

Re: [PATCH] platform: Facilitate the creation of pseduo-platform busses

2010-08-04 Thread Kevin Hilman
2001 From: Kevin Hilman khil...@deeprootsystems.com Date: Mon, 28 Jun 2010 16:08:14 -0700 Subject: [PATCH] driver core: allow platform_devices and platform_drivers on custom busses This allows platform_devices and platform_drivers to be registered onto custom busses that are compatible

Re: [PATCH 3/6] TI816X: Update common OMAP machine specific sources

2010-08-05 Thread Kevin Hilman
Hemant Pedanekar hema...@ti.com writes: This patch updates the common machine spcific source files with support for TI816X. Note that the nr_irqs is overridden in INTC driver since the number of IRQs on TI816X are different (128) comapared to other OMAPs (96). Signed-off-by: Hemant

Re: [PATCH 2/6] TI816X: Update common omap platform files

2010-08-05 Thread Kevin Hilman
Hemant Pedanekar hema...@ti.com writes: This patch updates the common platform files with TI816X specific additions. Also adds new files for TI816X modules base addresseses and irq definitions. Signed-off-by: Hemant Pedanekar hema...@ti.com General question on the static mapping of the

Re: [PATCH 2/6] TI816X: Update common omap platform files

2010-08-05 Thread Kevin Hilman
Hemant Pedanekar hema...@ti.com writes: This patch updates the common platform files with TI816X specific additions. Also adds new files for TI816X modules base addresseses and irq definitions. Signed-off-by: Hemant Pedanekar hema...@ti.com ---

Re: [PATCH 4/6] TI816X: Create board support for TI816X_EVM

2010-08-05 Thread Kevin Hilman
Hemant Pedanekar hema...@ti.com writes: This patch adds minimal support for TI816X EVM to enable kernel boot. Signed-off-by: Hemant Pedanekar hema...@ti.com [...] diff --git a/arch/arm/mach-omap2/board-ti8168evm.c b/arch/arm/mach-omap2/board-ti8168evm.c new file mode 100644 index

Re: [PATCH] platform: Facilitate the creation of pseduo-platform busses

2010-08-05 Thread Kevin Hilman
Magnus Damm magnus.d...@gmail.com writes: On Thu, Aug 5, 2010 at 7:14 AM, Patrick Pannuto ppann...@codeaurora.org wrote: Inspiration for this comes from: http://www.mail-archive.com/linux-omap@vger.kernel.org/msg31161.html RFC: http://lkml.org/lkml/2010/8/3/496 Patch is unchanged from the

Re: [PATCH] platform: Facilitate the creation of pseduo-platform busses

2010-08-05 Thread Kevin Hilman
Patrick Pannuto ppann...@codeaurora.org writes: You had indicated that you were going on vacation for a month and I had not seen any more follow-up on this issue, so I forged ahead. Great, I'm glad you forged ahead. There is definitely a broader need for something like this, and I have

Re: PM branch updated to v2.6.35, SRF dropped

2010-08-05 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: Kevin Hilman had written, on 08/04/2010 05:50 PM, the following: [...] I've only tested the new PM branch on a couple boards to avoid any further delay getting this version out, update, so hopefully others will help test. I've tested RET on idle suspend

Re: PM branch updated to v2.6.35, SRF dropped

2010-08-05 Thread Kevin Hilman
Nayak, Rajendra rna...@ti.com writes: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap-ow...@vger.kernel.org] On Behalf Of Kevin Hilman Sent: Thursday, August 05, 2010 4:21 AM To: linux-omap@vger.kernel.org Subject: PM branch updated to v2.6.35, SRF

Re: [PATCH 2/6] TI816X: Update common omap platform files

2010-08-06 Thread Kevin Hilman
Pedanekar, Hemant hema...@ti.com writes: Hi Kevin, Kevin Hilman wrote: Hemant Pedanekar hema...@ti.com writes: This patch updates the common platform files with TI816X specific additions. Also adds new files for TI816X modules base addresseses and irq definitions. Signed-off

Re: Issues with calling pm_runtime functions in platform_pm_suspend_noirq/IRQ disabled context.

2010-08-09 Thread Kevin Hilman
in omap_sram_idle(). From be3aeea5f8d29c8ce2fa278f48aef849eb682282 Mon Sep 17 00:00:00 2001 From: Kevin Hilman khil...@deeprootsystems.com Date: Mon, 9 Aug 2010 08:12:39 -0700 Subject: [PATCH] PM: allow runtime PM get/put from interrupts-disabled context When using runtime PM in combination

Re: Issues with calling pm_runtime functions in platform_pm_suspend_noirq/IRQ disabled context.

2010-08-09 Thread Kevin Hilman
Shilimkar, Santosh santosh.shilim...@ti.com writes: -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Kevin Hilman Sent: Monday, August 09, 2010 9:01 PM To: Basak, Partha Cc: Paul Walmsley; linux-omap@vger.kernel.org

Re: [PATCH 1/3] OMAP4: prcm: Add temporarily helper functions for rmw and read inside the PRM

2010-08-09 Thread Kevin Hilman
of these? Kevin Signed-off-by: Benoit Cousson b-cous...@ti.com Cc: Paul Walmsley p...@pwsan.com Cc: Kevin Hilman khil...@deeprootsystems.com --- arch/arm/mach-omap2/prcm.c | 24 arch/arm/plat-omap/include/plat/prcm.h |2 ++ 2 files changed, 26

Re: [PATCH] OMAP1: PM: Fix OMAP1610 build

2010-08-09 Thread Kevin Hilman
-off-by: Manjunatha GK manj...@ti.com Cc: Kevin Hilman khil...@deeprootsystems.com Thanks, will fold this into the OMAP1 bus support in pm-wip/runtime Kevin --- arch/arm/mach-omap1/pm_bus.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/arch/arm/mach-omap1

Re: [PATCH] OMAP PM: MPU/DMA Latency constraints

2010-08-09 Thread Kevin Hilman
Vishwanath Sripathy vishwanath...@ti.com writes: This patch has implementation for OMAP MPU/DMA Latency constraints using PM QOS. Changelog is missing description of the problem being solved and the motivation for the solution. In particular, a system-wide API is being changed here with no

Re: [PATCH v3 0/7] OMAP: hwmod: Full data set for OMAP4430 ES1 ES2

2010-08-09 Thread Kevin Hilman
Benoit Cousson b-cous...@ti.com writes: Hi Kevin Paul, Here is the OMAP4430 ES1 ES2 hwmod data v3 series. Please note that there is no difference between the ES1 ES2 wrt hwmod. This series is re-organised in order to allow initial submission for upstream with minimal interconnect data

Re: [PATCH v3] serial: Add OMAP high-speed UART driver

2010-08-09 Thread Kevin Hilman
Govindraj govindraj...@gmail.com writes: On Wed, Jul 7, 2010 at 5:32 PM, Tony Lindgren t...@atomide.com wrote: * Govindraj govindraj...@gmail.com [100608 09:24]: On Mon, Jun 7, 2010 at 9:45 PM, Luke-Jr l...@dashjr.org wrote: On Monday 07 June 2010 08:28:51 am Govindraj wrote: Link:

Re: [PATCH 1/8] usb: musb: Adding names for IRQs in resource structure

2010-08-09 Thread Kevin Hilman
of resource definition need not be always in order of device interrupt and then dma interrupt Signed-off-by: Hema HK hem...@ti.com Cc: Felipe Balbi felipe.ba...@nokia.com Cc: Tony Lindgren t...@atomide.com Cc: Kevin Hilman khil...@deeprootsystems.com --- Based off omap4-next branch. In patch

Re: [PATCH 0/8]usb: musb:USB driver changes to use hwmod+ omap-device apis

2010-08-09 Thread Kevin Hilman
Cousson, Benoit b-cous...@ti.com writes: On 8/6/2010 5:54 PM, HEMA HK wrote: From: Hema HKhem...@ti.com Series of patches to port musb driver to use hwmod and runtime pm APIs for OMAP4 and OMAP3.These patches are tested on OMAP4430SDP and OMAP3630-ZOOM3 boards. The patch 1 and 2 are are

Re: [PATCH V2 6/8] usb: musb: Offmode fix for idle path

2010-08-09 Thread Kevin Hilman
Kalliguddi, Hema hem...@ti.com writes: [...] Changed the usb sysconfig settings as per the usbotg functional spec. When the device is not active, configure to force idle and force standby mode. When it is being used, configure in smart standby and smart idle mode. So while attempting to

Re: [PATCH 12/13 v5] OMAP: GPIO: Use dev_pm_ops instead of sys_dev_class

2010-08-09 Thread Kevin Hilman
Charulatha V ch...@ti.com writes: @@ -1728,7 +1729,6 @@ static int __devinit omap_gpio_probe(struct platform_device *pdev) } pm_runtime_enable(bank-dev); - pm_runtime_get_sync(bank-dev); Why do you remove this? omap_gpio_mod_init(bank, id); This next call

Re: [PATCH 01/13 v5] OMAP: GPIO: Modify init() in preparation for platform device implementation

2010-08-09 Thread Kevin Hilman
Charulatha V ch...@ti.com writes: This is in prepartion for implementing GPIO as a platform device. gpio bank's base addresses are moved from gpio.c to plat/gpio.h. This patch also modifies omap_gpio_init() to make use of omap_gpio_chip_init() and omap_gpio_mod_init(). omap_gpio_mod_init()

Re: [PATCH 13/13 v5] OMAP: GPIO: Remove omap_gpio_init()

2010-08-09 Thread Kevin Hilman
Charulatha V ch...@ti.com writes: This patch removes the usage of omap_gpio_init() from all omap board files since omap_gpio_init() does nothing, after gpio is implemented as a platform device. This patch should also remove the function from plat/gpio.c Kevin Signed-off-by: Charulatha V

Re: [PATCH 10/13 v5] OMAP: GPIO: Implement GPIO as a platform device

2010-08-09 Thread Kevin Hilman
Charulatha V ch...@ti.com writes: @@ -650,21 +511,28 @@ static void _set_gpio_debounce(struct gpio_bank *bank, unsigned gpio, __raw_writel(debounce, reg); reg = bank-base; - if (cpu_is_omap44xx()) + if (bank-method == METHOD_GPIO_44XX) reg +=

Re: [PATCH 09/13 v5] OMAP: GPIO: Introduce support for OMAP2PLUS chip GPIO init

2010-08-09 Thread Kevin Hilman
Charulatha V ch...@ti.com writes: This patch adds support for handling GPIO as a HWMOD FW adapted platform device for OMAP2PLUS chips. gpio_init needs to be done before machine_init functions access gpio APIs.Hence gpio_init is made as a postcore_initcall. Signed-off-by: Charulatha V

Re: [PATCH 12/13 v5] OMAP: GPIO: Use dev_pm_ops instead of sys_dev_class

2010-08-09 Thread Kevin Hilman
Charulatha V ch...@ti.com writes: This patch makes GPIO driver to use dev_pm_ops instead of sysdev_class. With this approach, gpio_bank_suspend gpio_bank_resume are not part of sys_dev_class. According to this patch, a GPIO bank relinquishes the clock using PM runtime APIs when all the

Re: [PATCH 09/13 v5] OMAP: GPIO: Introduce support for OMAP2PLUS chip GPIO init

2010-08-09 Thread Kevin Hilman
Charulatha V ch...@ti.com writes: This patch adds support for handling GPIO as a HWMOD FW adapted platform device for OMAP2PLUS chips. gpio_init needs to be done before machine_init functions access gpio APIs.Hence gpio_init is made as a postcore_initcall. Signed-off-by: Charulatha V

[PATCH] OMAP: omap_hwmod: remove locking from hwmod_for_each iterators

2010-08-10 Thread Kevin Hilman
){.+.+.+}, at: [c0129aa8] sysfs_write_file+0xe8/0x144 [ 810.172363] #2: (pm_mutex){+.+.+.}, at: [c00a5e64] enter_state+0x20/0x120 [ 810.172393] #3: (dpm_list_mtx){+.+...}, at: [c023baf8] dpm_suspend_noirq+0x28/0x188 Tested-by: Partha Basak p-bas...@ti.com Signed-off-by: Kevin Hilman khil

[PATCH] PM: runtime PM + idle: allow usage when interrupts are disabled

2010-08-10 Thread Kevin Hilman
of the spinlock API. Reported-by: Partha Basak p-bas...@ti.com Signed-off-by: Kevin Hilman khil...@deeprootsystems.com --- RFC: I'm not crazy about having the 'flags' in struct dev_pm_info, but since the locks are taken and released in separate functions, this seems better than changing the function APIs

Re: [PATCH 10/13 v5] OMAP: GPIO: Implement GPIO as a platform device

2010-08-10 Thread Kevin Hilman
Basak, Partha p-bas...@ti.com writes: Instead, please propose an API to hwmod for getting the optional clock(s), or possibly cleaner, an API to directly enable/disable optional clocks for an omap_device. As per our discussion with Paul you during workshop, I believe, optional clock control

Re: [PATCH 12/13 v5] OMAP: GPIO: Use dev_pm_ops instead of sys_dev_class

2010-08-10 Thread Kevin Hilman
Basak, Partha p-bas...@ti.com writes: [...] In the idle path (interrupt disabled context), PM runtime APIs cannot be used as they are not mutex-free functions. Hence omap_device APIs are used in the idle and resume after idle path. This needs much more fleshing out. Exactly what

Re: CONFIG_CPU_IDLE broken for N900

2010-08-10 Thread Kevin Hilman
Ameya Palande ameya.pala...@nokia.com writes: When I enable CONFIG_CPU_IDLE and boot kernel, it hangs around the point when it switches to user space. I am able to reproduce this for 2.6.35 on linux-omap and linux-2.6 trees. Has anyone else noticed the same thing for omap3 based boards? I

[PATCH] OMAP3: PM: ensure IO wakeups are properly disabled

2010-08-10 Thread Kevin Hilman
From: Kevin Hilman khil...@ti.com During idle, if the PER powerdomain transitions and CORE does not (as is the case with the lower C-states when using CPUidle) the IO pad wakeups are not being disabled in the idle path after they are enabled. This patch ensures that the check for disabling IO

Re: Overo serial problems after resume, vs. Beagleboard

2010-08-10 Thread Kevin Hilman
On Tue, Jun 22, 2010 at 7:31 AM, Kevin Hilman khil...@deeprootsystems.com wrote: Mike Rapoport m...@compulab.co.il writes: Kevin Hilman wrote: Peter Tseng tsenpe...@gmail.com writes: I am seeing some discrepancies between the Overo (I believe I have a Water) and the Beagleboard (I have

[PATCH 0/4] OMAP OPP layer

2010-08-10 Thread Kevin Hilman
This series introduces a layer to manage Operating Performance Points (OPPs) for OMAP SoCs. Special thanks to Nishanth for doing the bulk of the grunt work for this series and to Thara for doing significant review, testing and updates. Kevin Hilman (1): omap3: pm: remove OPP interfaces from

[PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-08-10 Thread Kevin Hilman
Premi for the initial concept: http://patchwork.kernel.org/patch/50998/ Kevin Hilman for converting original design to device-based Kevin Hilman and Paul Walmsey for cleaning up many of the function abstractions, improvements and data structure handling Romit Dasgupta for using enums instead

[PATCH 0/4] OMAP OPP layer

2010-08-10 Thread Kevin Hilman
This series introduces a layer to manage Operating Performance Points (OPPs) for OMAP SoCs. Special thanks to Nishanth for doing the bulk of the grunt work for this series and to Thara for doing significant review, testing and updates. Kevin Hilman (1): omap3: pm: remove OPP interfaces from

[PATCH 1/4] OMAP: introduce OPP layer for device-specific OPPs

2010-08-10 Thread Kevin Hilman
Premi for the initial concept: http://patchwork.kernel.org/patch/50998/ Kevin Hilman for converting original design to device-based Kevin Hilman and Paul Walmsey for cleaning up many of the function abstractions, improvements and data structure handling Romit Dasgupta for using enums instead

[PATCH 2/4] omap: opp: twl/tps: Introduce TWL/TPS-specific code

2010-08-10 Thread Kevin Hilman
-off-by: Nishanth Menon n...@ti.com Signed-off-by: Kevin Hilman khil...@deeprootsystems.com --- arch/arm/plat-omap/Makefile |1 + arch/arm/plat-omap/include/plat/opp_twl_tps.h | 21 + arch/arm/plat-omap/opp_twl_tps.c | 41

[PATCH 3/4] omap3: pm: remove OPP interfaces from OMAP PM layer

2010-08-10 Thread Kevin Hilman
With new OPP layer, OPP users will access OPP API directly instead of using OMAP PM layer, so remove all notions of OPPs from the OMAP PM layer. Signed-off-by: Kevin Hilman khil...@deeprootsystems.com Signed-off-by: Nishanth Menon n...@ti.com Signed-off-by: Roger Quadros ext-roger.quad

[PATCH 4/4] OMAP: Remove dependency of generic opp layer on cpufreq.

2010-08-10 Thread Kevin Hilman
From: Thara Gopinath th...@ti.com This patch removes the dependency of the opp layer on cpufreq layer. OPP layer is now enabled to compile and exist in the system irrespective of whether cpu freq layer is enabled or not. [NM Note: Original Patch: https://patchwork.kernel.org/patch/111664/ Still

Re: [PATCH 0/4] OMAP OPP layer

2010-08-10 Thread Kevin Hilman
Sorry for the duplicate series... I had a git-send-email hiccup on my side. :( Kevin -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2] OMAP3: PM: ensure IO wakeups are properly disabled

2010-08-11 Thread Kevin Hilman
From: Kevin Hilman khil...@ti.com Commit 5a5f561 (convert OMAP3 PRCM macros to the _SHIFT/_MASK suffixes) mistakenly removed the check for PER when disabling the IO chain. During idle, if the PER powerdomain transitions and CORE does not (as is the case with the lower C-states when using CPUidle

Re: [PATCH 1/4] initial support for LogicPD's OMAP3 SOM and TORPEDO development kits

2010-08-11 Thread Kevin Hilman
Jacob Tanenbaum jacob.tanenb...@logicpd.com writes: Adding LogicPD OMAP3 board support Adding support for LogicPD's OMAP 3530 LV SOM and OMAP 35x Torpedo board. Tested against: linux-next 81e09f50c93edff607259cbe374a3006c9c5fa74

Re: [PATCH 2/4] Low-level initialization for hsmmc controller on LogicPD's OMAP3 SOM and TORPEDO dev kits

2010-08-11 Thread Kevin Hilman
Jacob Tanenbaum jacob.tanenb...@logicpd.com writes: ARM: OMAP3LOGIC: Adding SDMMC support Add low-level initialization for hsmmc controller for LogicPD's OMAP 3530 LV SOM and OMAP 35x Torpedo board. Also removes mux setup of SDRC pins which is not described

Re: [PATCH v2 0/6] Introduce support for TI816X processor series

2010-08-11 Thread Kevin Hilman
Hemant Pedanekar hema...@ti.com writes: This patch series adds support for TI816X processor series. First device in this series is DM8168 and details can be found at: http://www.ti.com/ww/en/dsp/davinci-netra/index.shtml This device is architecturally closer to the OMAP devices. Hence,

Re: [PATCH v2 4/6] TI816X: Create board support for TI816X_EVM

2010-08-11 Thread Kevin Hilman
Hemant Pedanekar hema...@ti.com writes: This patch adds minimal support for TI816X EVM to enable kernel boot. Signed-off-by: Hemant Pedanekar hema...@ti.com [...] +static void __init ti8168_evm_init_irq(void) +{ + /* Timer1 is reserved on TI816X so skip to first available */ reserved

Re: [PATCH 0/2] Put OMAP2 SPI CS in unactive state when return from suspend

2010-08-11 Thread Kevin Hilman
Gregory CLEMENT gclemen...@gmail.com writes: We notice that when system wake up from OFF mode, then CS is in unactive state until the first SPI transfert. For our design it lead to some conflict on this I/O. Unactive state for CS when there is no transfert shoudl be the correct behaviour:

Re: [PATCH] OMAP: omap_hwmod: remove locking from hwmod_for_each iterators

2010-08-11 Thread Kevin Hilman
Paul Walmsley p...@pwsan.com writes: Hi Kevin, On Tue, 10 Aug 2010, Kevin Hilman wrote: Remove unnecessary locking in the 'for_each' iterators. Any locking should be taken care of by using hwmod API functions in the functions called by the iterators. In addition, having locking here

Re: [PATCH 6/6 v2] OMAP2PLUS: WDT: Conversion to runtime PM

2010-08-11 Thread Kevin Hilman
Charulatha V ch...@ti.com writes: This patch converts the OMAP Watchdog timer driver to get adapted to HWMOD FW and to use the runtime PM APIs. Signed-off-by: Charulatha V ch...@ti.com Signed-off-by: Basak, Partha p-bas...@ti.com This series looks good. One minor comment below... ---

Re: [PATCH] OMAP: Voltage: fix typos, compile break

2010-08-11 Thread Kevin Hilman
mturque...@gmail.com writes: From: Mike Turquette mturque...@ti.com mach-omap/voltage.c incorrectly called omap_get_mpuss_device and omap_get_l3_device. The correct function names are omap2_get_mpuss_device and omap2_get_l3_device respectively. This fixes a compile break. Test on

Re: [PM-OPP][PATCH v2 1/2] omap: pm: opp: remove opp_id

2010-08-11 Thread Kevin Hilman
eduardo.valen...@nokia.com Cc: Kevin Hilman khil...@deeprootsystems.com Cc: Paul Walmsley p...@pwsan.com Cc: Rajendra Nayak rna...@ti.com Cc: Sanjeev Premi pr...@ti.com Cc: Thara Gopinath th...@ti.com Cc: Tony Lindgren t...@atomide.com Signed-off-by: Nishanth Menon n...@ti.com --- v1: original

[PATCH] OMAP: hwmod: separate list locking and hwmod hardware locking

2010-08-11 Thread Kevin Hilman
From: Kevin Hilman khil...@ti.com Currently omap_hwmod_mutex is being used to protect both the list access/modification and concurrent access to hwmod functions. This patch separates these two types of locking. First, omap_hwmod_mutex is used only to protect access and modification

Re: [PATCH v2] OMAP3: PM: ensure IO wakeups are properly disabled

2010-08-12 Thread Kevin Hilman
Ameya Palande ameya.pala...@nokia.com writes: Hi Kevin, On Wed, 2010-08-11 at 18:03 +0200, ext Kevin Hilman wrote: From: Kevin Hilman khil...@ti.com Commit 5a5f561 (convert OMAP3 PRCM macros to the _SHIFT/_MASK suffixes) mistakenly removed the check for PER when disabling the IO chain

Re: [PATCH 12/13 v5] OMAP: GPIO: Use dev_pm_ops instead of sys_dev_class

2010-08-12 Thread Kevin Hilman
Basak, Partha p-bas...@ti.com writes: [...] Why is this better than passing the next power state? This would keep the GPIO function omap2_gpio_prepare_for_idle agnostic of Power state definition dependencies. And why is this better? Personally, I think the GPIO code should be

Re: [RFC v.4] omap: hwspinlock: Added hwspinlock driver

2010-08-12 Thread Kevin Hilman
reason for using pm_runtime_put instead of pm_runtime_put_sync? Using pm_runtime_gett_sync pm_runtime_put_sync have been recommended by Kevin Hilman. err, not exacly. I recommend use of the runtime PM API. Driver writers can decide whether they want to use the _sync() version of the API (which

Re: [PATCH] OMAP: PM debugfs removing OMAP3 hardcodings.

2010-08-12 Thread Kevin Hilman
Thara Gopinath th...@ti.com writes: This patch removes omap3 hardcodings from pm-debug.c so that enabling PM debugfs support does break compilation for other OMAP's. This is a preparatory patch for supporting OMAP4 pm entries through PM debugfs. Signed-off-by: Thara Gopinath th...@ti.com

Re: [PATCH 0/2] Put OMAP2 SPI CS in unactive state when return from suspend

2010-08-12 Thread Kevin Hilman
Gregory CLEMENT gclemen...@gmail.com writes: 2010/8/11 Kevin Hilman khil...@deeprootsystems.com Gregory CLEMENT gclemen...@gmail.com writes: We notice that when system wake up from OFF mode, then CS is in unactive state until the first SPI transfert. For our design it lead to some

Re: [PM-OPP][PATCH 2/2] omap3: opp: make independent of cpufreq

2010-08-12 Thread Kevin Hilman
Gopinath, Thara th...@ti.com writes: [...] No reason why we should have a different file for OMAP4. So a better name than opp3xxx_data.c? why do we need to have it in the same file? Remember, 3630,3430 are under OMAP3 family, but omap4 is considered a different arch. Code is more or less

Re: [PATCH 3/6] OMAP3: PM: ensure IO wakeups are properly disabled

2010-08-19 Thread Kevin Hilman
Sergei Shtylyov sshtyl...@mvista.com writes: Hello. Tony Lindgren wrote: From: Kevin Hilman khil...@ti.com Commit 5a5f561 (convert OMAP3 PRCM macros to the _SHIFT/_MASK suffixes) mistakenly removed the check for PER when disabling the IO chain. During idle, if the PER powerdomain

Re: [PATCH 3/3] davinci: Map sram using MT_MEMORY_NONCACHED instead of MT_DEVICE

2010-08-19 Thread Kevin Hilman
, the MT_MEMORY_NONCACHED can be used now. Have not tested this, so somebody with Davinci hardware can try this out Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com Cc: davinci-linux-open-sou...@linux.davincidsp.com Cc: Kevin Hilman khil...@deeprootsystems.com Acked-by: Kevin Hilman khil

Re: [linux-pm] [PATCH] PM: runtime PM + idle: allow usage when interrupts are disabled

2010-08-19 Thread Kevin Hilman
Alan Stern st...@rowland.harvard.edu writes: On Tue, 10 Aug 2010, Kevin Hilman wrote: When using runtime PM in combination with CPUidle, the runtime PM transtions of some devices may be triggered during the idle path. Late in the idle sequence, interrupts will likely be disabled when

Re: [linux-pm] [PATCH] PM: runtime PM + idle: allow usage when interrupts are disabled

2010-08-19 Thread Kevin Hilman
Rafael J. Wysocki r...@sisk.pl writes: On Tuesday, August 10, 2010, Kevin Hilman wrote: When using runtime PM in combination with CPUidle, the runtime PM transtions of some devices may be triggered during the idle path. Late in the idle sequence, interrupts will likely be disabled when

Re: NAND ECC in linux-omap

2010-08-19 Thread Kevin Hilman
Cliff Brake cliff.br...@gmail.com writes: On Wed, Aug 18, 2010 at 12:14 AM, Ghorai, Sukumar s-gho...@ti.com wrote: [Ghorai] 1. Can you send the git tree link and branch you are referring? git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git branch: pm

Re: [PATCH 0/5] OMAP: McSPI: Implement McSPI in HWMOD way

2010-08-19 Thread Kevin Hilman
Grant Likely grant.lik...@secretlab.ca writes: On Fri, Aug 13, 2010 at 8:05 AM, Charulatha V ch...@ti.com wrote: This patch series implements McSPI Module in HWMOD FW way and use the runtime PM layer. Hi Charulatha, I'll go through and review the patches, but I'm unfamiliar with HWMOD. Is

Re: [PATCH 3/6] OMAP3: PM: ensure IO wakeups are properly disabled

2010-08-20 Thread Kevin Hilman
Tony Lindgren t...@atomide.com writes: [...] I'll update it with the following to preserve the Fernet style, and to describe the transition: ok with me, thanks tony. Kevin -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to

Re: [linux-pm] [PATCH] PM: runtime PM + idle: allow usage when interrupts are disabled

2010-08-23 Thread Kevin Hilman
Alan Stern st...@rowland.harvard.edu writes: On Thu, 19 Aug 2010, Kevin Hilman wrote: In any case, I don't really like this change. It seems that we would be better off preventing the runtime PM calls from occurring in the first place while interrupts are disabled. Why? Because

Re: [linux-pm] [PATCH] PM: runtime PM + idle: allow usage when interrupts are disabled

2010-08-23 Thread Kevin Hilman
Rafael J. Wysocki r...@sisk.pl writes: On Thursday, August 19, 2010, Kevin Hilman wrote: Rafael J. Wysocki r...@sisk.pl writes: On Tuesday, August 10, 2010, Kevin Hilman wrote: When using runtime PM in combination with CPUidle, the runtime PM transtions of some devices may be triggered

Re: [PATCH 1/5] OMAP4: runtime: Enable PM runtime core for OMAP4

2010-08-23 Thread Kevin Hilman
Rajendra Nayak rna...@ti.com writes: The PM runtime core functions are implemented in pm_bus.c which needs to be compiled for CONFIG_ARCH_OMAP4 for runtime api's to work. Signed-off-by: Rajendra Nayak rna...@ti.com Cc: Kevin Hilman khil...@deeprootsystems.com I'll fold this one

Re: [PATCH 2/5] OMAP2xxx: hwmod: add I2C hwmods for OMAP2420, 2430

2010-08-23 Thread Kevin Hilman
Rajendra Nayak rna...@ti.com writes: From: Paul Walmsley p...@pwsan.com Add hwmod structures for I2C controllers on OMAP2420/2430. Signed-off-by: Paul Walmsley p...@pwsan.com Signed-off-by: Rajendra Nayak rna...@ti.com Cc: Kevin Hilman khil...@deeprootsystems.com --- arch/arm/mach-omap2

Re: [PATCH 5/5] OMAP: I2C: Convert i2c driver to use PM runtime api's

2010-08-23 Thread Kevin Hilman
Rajendra Nayak rna...@ti.com writes: This patch converts the i2c driver to use PM runtime apis for OMAP2+ and omap_device api's for OMAP1 Signed-off-by: Rajendra Nayak rna...@ti.com Cc: Kevin Hilman khil...@deeprootsystems.com Cc: Paul Walmsley p...@pwsan.com Some minor comments below

  1   2   3   4   5   6   7   8   9   10   >