[PATCH 2/3] DSPBRIDGE: Undo allocation of resources in case of cp_to_usr fails

2010-01-13 Thread Omar Ramirez Luna
From: Ernesto Ramos erne...@ti.com Release resources allocated during MAP, Node Allocation, STRM Buf Allocation in the case of cp_to_usr fails. Signed-off-by: Ernesto Ramos erne...@ti.com CC: Nishanth Menon n...@ti.com CC: Hiroshi Doyu hiroshi.d...@nokia.com CC: Ameya Palande

[PATCH 0/3] Interface tightening patches

2010-01-13 Thread Omar Ramirez Luna
Set of patches containing ioctl interface checks, null pointers checks and imporvement on resource handling on error. Ernesto Ramos (3): DSPBRIDGE: Interface tightening to check for invalid input parameters DSPBRIDGE: Undo allocation of resources in case of cp_to_usr fails DSPBRIDGE:

[PATCH 3/3] DSPBRIDGE: NULL Pointer Dereference fix

2010-01-13 Thread Omar Ramirez Luna
From: Ernesto Ramos erne...@ti.com This patch takes care of the possible null pointers dereferenced within dsp bridge driver. Signed-off-by: Ernesto Ramos erne...@ti.com CC: Nishanth Menon n...@ti.com CC: Hiroshi Doyu hiroshi.d...@nokia.com CC: Ameya Palande ameya.pala...@nokia.com ---

[PATCH 02/10] DSPBRIDGE: contributors file

2010-01-15 Thread Omar Ramirez Luna
This creates a new contributors file under Documentation/tidspbridge to acknowledge all the people working in DSP/Bridge project. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- Documentation/tidspbridge/CONTRIBUTORS | 70 1 files changed, 70

[PATCH 09/10] DSPBRIDGE: checkpatch - printk() should include KERN_ facility level

2010-01-15 Thread Omar Ramirez Luna
WARNING: printk() should include KERN_ facility level Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include/dspbridge/dbc.h |2 +- arch/arm/plat-omap/include/dspbridge/gt.h |2 +- drivers/dsp/bridge/gen/_gt_para.c |2 +- 3 files changed, 3

[PATCH 00/10] trivial cleanups

2010-01-15 Thread Omar Ramirez Luna
This is a small set of trivial cleanups piled up in the patch queue. Higlights: - New patch with contributors file. - Fix multiline macros to use do while patch is dropped for rework. Omar Ramirez Luna (10): DSPBRIDGE: trivial license fix in tramp and tramp_table_c6000 DSPBRIDGE

[PATCH 05/10] DSPBRIDGE: checkpatch - space required after comma

2010-01-15 Thread Omar Ramirez Luna
ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/hw/GlobalTypes.h |4 ++-- drivers/dsp/bridge/hw/PRCMRegAcM.h | 24 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers

[PATCH 01/10] DSPBRIDGE: trivial license fix in tramp and tramp_table_c6000

2010-01-15 Thread Omar Ramirez Luna
Seems that these files had a licensing mismatch, changing to GPL2. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/dynload/tramp.c | 18 +- drivers/dsp/bridge/dynload/tramp_table_c6000.c | 18 +- 2 files changed, 26

[PATCH 10/10] DSPBRIDGE: trivial cleanup for io_sm

2010-01-15 Thread Omar Ramirez Luna
and MBX_DBG_SYSPRINTF have the same value - Fix multiline comments according to Documentation/CodingStyle Functions comments will be addressed in a different patch. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/wmd/io_sm.c | 503 ++-- 1 files

[PATCH 4/4] DSPBRIDGE: Remove DPC object structure

2010-01-15 Thread Omar Ramirez Luna
Remove DPC object structure and declare required members for each tasklet inside their correspondent modules. Remove dpc header file. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include/dspbridge/_chnl_sm.h |1 - arch/arm/plat-omap/include/dspbridge/dpc.h

[PATCH 2/4] DSPBRIDGE: Remove main DPC wrapper for IO and MMUfault

2010-01-15 Thread Omar Ramirez Luna
Remove DeferredProcedure which is used as a wrapper to call either IO or MMUfault DPCs. This also removes a custom typedef. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include/dspbridge/dpc.h | 23 --- arch/arm/plat-omap/include/dspbridge/io_sm.h

[PATCH 0/3] dspbridge-pm patches

2010-01-15 Thread Omar Ramirez Luna
removal. dspbridge-pm is currently based on pm-2.6.32. Fernando Guzman Lugo (1): DSPBRIDGE: change to cpufreq_register_notifier for OPP changes Omar Ramirez Luna (2): DSPBRIDGE: Fix header locations mach to plat DSPBRIDGE: Use dspbridge to initialize platform data arch/arm/mach-omap2

[PATCH 2/3] DSPBRIDGE: change to cpufreq_register_notifier for OPP changes

2010-01-15 Thread Omar Ramirez Luna
From: Fernando Guzman Lugo x0095...@ti.com This patch changes clk_notifier_unregister with cpufreq_unregister_notifier, which is used for OPP change notifications Signed-off-by: Fernando Guzman Lugo x0095...@ti.com --- drivers/dsp/bridge/Kconfig |2 +-

[PATCH 3/3] DSPBRIDGE: Use dspbridge to initialize platform data

2010-01-15 Thread Omar Ramirez Luna
Include dspbridge compilation whenever bridge driver is selected to be compiled, either as a module or part of the kernel. This will initialize platform data specific PM functions. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/mach-omap2/Makefile |4 +++- 1 files changed

[PATCH 1/3] DSPBRIDGE: Fix header locations mach to plat

2010-01-15 Thread Omar Ramirez Luna
Fix header locations, replaced mach to plat Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/mach-omap2/dspbridge.c|2 +- arch/arm/plat-omap/include/dspbridge/host_os.h |2 +- drivers/dsp/bridge/wmd/tiomap3430.c|2 +- 3 files changed, 3

[PATCH] DSPBRIDGE: Fix wrong condition on NODE_GetUUIDProps

2010-01-18 Thread Omar Ramirez Luna
Fix wrong condition because of a wrong patch included. Discovered-by: Ernesto Ramos Falcon erne...@ti.com Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/rmgr/node.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/dsp/bridge/rmgr

[PATCH 2/3] DSPBRIDGE: return right error codes services directory

2010-01-19 Thread Omar Ramirez Luna
From: Fernando Guzman Lugo x0095...@ti.com This patch fixes bad error codes returned by some functions, it validates status of previously unchecked functions and removes unused conditional statements or status variables. Signed-off-by: Fernando Guzman Lugo x0095...@ti.com ---

[PATCH 0/3] DSPBRIDGE: Return right error codes

2010-01-19 Thread Omar Ramirez Luna
This set of patches fixes the overwritten or missing error codes returned from different bridge layers. Fernando Guzman Lugo (3): DSPBRIDGE: return right error codes wmd directory DSPBRIDGE: return right error codes services directory DSPBRIDGE: return right error codes rmgr directory

[PATCH 3/3] DSPBRIDGE: return right error codes rmgr directory

2010-01-19 Thread Omar Ramirez Luna
From: Fernando Guzman Lugo x0095...@ti.com This patch fixes bad error codes returned by some functions, it validates status of previously unchecked functions and removes unused conditional statements or status variables. Signed-off-by: Fernando Guzman Lugo x0095...@ti.com ---

[PATCH 1/3] DSPBRIDGE: return right error codes wmd directory

2010-01-19 Thread Omar Ramirez Luna
From: Fernando Guzman Lugo x0095...@ti.com This patch fixes bad error codes returned by some functions, it validates status of previously unchecked functions and removes unused conditional statements or status variables. Signed-off-by: Fernando Guzman Lugo x0095...@ti.com ---

[PATCH 2/6] DSPBRIDGE: remove NLDR_Free wrapper function

2010-01-19 Thread Omar Ramirez Luna
From: Fernando Guzman Lugo x0095...@ti.com This patch removes the NLDR_Free which is a wrapper function Signed-off-by: Fernando Guzman Lugo x0095...@ti.com --- arch/arm/plat-omap/include/dspbridge/nldr.h |1 - arch/arm/plat-omap/include/dspbridge/nldrdefs.h |1 -

[PATCH 1/6] DSPBRIDGE: Rename DEBUG define to use menuconfig style

2010-01-19 Thread Omar Ramirez Luna
Rename DEBUG to CONFIG_BRIDGE_DEBUG on preprocessor conditions that trigger debug statements. This was conflicting with pr_debug/dev_dbg definitions. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include/dspbridge/dbg.h |4 ++-- drivers/dsp/bridge/Makefile

[PATCH 4/6] DSPBRIDGE: Remove unused variables from resource cleanup

2010-01-19 Thread Omar Ramirez Luna
From: Fernando Guzman Lugo x0095...@ti.com This patch removes an unused variable parameter from resource cleanup code. Signed-off-by: Fernando Guzman Lugo x0095...@ti.com --- .../plat-omap/include/dspbridge/resourcecleanup.h |3 +-- drivers/dsp/bridge/rmgr/drv.c |5

[PATCH 5/6] DSPBRIDGE: remove wrong comment from RequestBridgeResources

2010-01-19 Thread Omar Ramirez Luna
From: Fernando Guzman Lugo x0095...@ti.com This patch removes a wrong pointer and set to NULL dwSysCtrlBase as it shouldn't be used anymore after iounmap. Signed-off-by: Fernando Guzman Lugo x0095...@ti.com --- drivers/dsp/bridge/rmgr/drv.c |7 +++ 1 files changed, 3 insertions(+), 4

[PATCH 3/6] DSPBRIDGE: Optimize remove resource functions

2010-01-19 Thread Omar Ramirez Luna
From: Fernando Guzman Lugo x0095...@ti.com This patch optimizes the remove resource functions, i.e DMM, Stream and Nodes. Signed-off-by: Fernando Guzman Lugo x0095...@ti.com --- drivers/dsp/bridge/rmgr/drv.c | 86 + 1 files changed, 35 insertions(+), 51

[PATCH 6/6] DSPBRIDGE: Always print DSP traces

2010-01-19 Thread Omar Ramirez Luna
From: Fernando Guzman Lugo x0095...@ti.com This patches prints DSP traces always removing the need to compile debug version and enable DSP traces. Signed-off-by: Fernando Guzman Lugo x0095...@ti.com --- drivers/dsp/bridge/wmd/io_sm.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

[PATCH 0/6] DSPBRIDGE: fixes from current patch queue

2010-01-19 Thread Omar Ramirez Luna
RequestBridgeResources DSPBRIDGE: Always print DSP traces Omar Ramirez Luna (2): DSPBRIDGE: Rename DEBUG define to use menuconfig style DSPBRIDGE: Remove unused variables from resource cleanup arch/arm/plat-omap/include/dspbridge/dbg.h |4 +- arch/arm/plat-omap/include/dspbridge/nldr.h

[PATCH 2/4] dspbridge: Change LST_ELEM to list_head entirely

2010-01-22 Thread Omar Ramirez Luna
From: Andy Shevchenko ext-andriy.shevche...@nokia.com * Change struct LST_ELEM to struct list_head in whole dsp bridge driver * Remove useless commentaries * Minor change in the services/mem.c: ... struct list_head *last = mMan.lst.head; struct list_head *curr = last-next; /* was:

[PATCH 4/4] DSPBRIDGE: OSAL: Remove extra include directive

2010-01-22 Thread Omar Ramirez Luna
From: Andy Shevchenko ext-andriy.shevche...@nokia.com Including the list.h in some files looks redundant. So, remove those lines. Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com --- drivers/dsp/bridge/pmgr/chnl.c |1 - drivers/dsp/bridge/pmgr/dmm.c |1 -

[PATCH 1/4] DSPBRIDGE: Get rid of services/list.c

2010-01-22 Thread Omar Ramirez Luna
From: Andy Shevchenko ext-andriy.shevche...@nokia.com * Remove LST_Init() and LST_Exit() calls because they are doing nothing except tracing, Thus, remove tracing as well. * Remove DBC_* calls. It's internal kernel business whether to have those assertions. * Move methods from list.c as

[PATCH 3/4] dspbridge: Don't use LST_Create() and LST_Delete()

2010-01-22 Thread Omar Ramirez Luna
From: Andy Shevchenko ext-andriy.shevche...@nokia.com Change LST_Create() to the MEM_Calloc() and INIT_LIST_HEAD() pair in optimal way. Use MEM_Free() instead of LST_Delete(). We can use it without checking because MEM_Free() validates input parameter. Signed-off-by: Andy Shevchenko

[PATCH 5/5] DSPBRIDGE: Remove multiple initializations of NTFY module

2010-01-22 Thread Omar Ramirez Luna
NTFY module should be only initialized by services layer. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/pmgr/wcd.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/drivers/dsp/bridge/pmgr/wcd.c b/drivers/dsp/bridge/pmgr/wcd.c index

[PATCH 2/5] DSPBRIDGE: remove crefs for SERVICES[Init|Exit]

2010-01-22 Thread Omar Ramirez Luna
No point in having a module counter if these are called only once. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/services/services.c | 92 +--- 1 files changed, 37 insertions(+), 55 deletions(-) diff --git a/drivers/dsp/bridge/services

[PATCH 0/5] DSPBRIDGE: centralized services initialization

2010-01-22 Thread Omar Ramirez Luna
It is more logic to initialize services related modules inside services layer, even if we are planning to remove it. This set should be applied after Andy's List patches. Omar Ramirez Luna (5): DSPBRIDGE: Avoid multiple calls to SERVICES_[Init|Exit] DSPBRIDGE: remove crefs for SERVICES[Init

[PATCH 1/5] DSPBRIDGE: Avoid multiple calls to SERVICES_[Init|Exit]

2010-01-22 Thread Omar Ramirez Luna
Avoid calling multiple times to SERVICES_[Init|Exit] functions, these should be called once at probe and exit respectively. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/pmgr/wcd.c | 10 ++ 1 files changed, 2 insertions(+), 8 deletions(-) diff --git

[PATCH 4/5] DSPBRIDGE: Remove multiple initializations of REG module

2010-01-22 Thread Omar Ramirez Luna
REG module should be only initialized by services layer. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/rmgr/dbdcd.c |8 +--- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/drivers/dsp/bridge/rmgr/dbdcd.c b/drivers/dsp/bridge/rmgr/dbdcd.c

[PATCH 3/5] DSPBRIDGE: Remove multiple initializations of MEM module

2010-01-22 Thread Omar Ramirez Luna
MEM module should be only initialized by services layer, removed reference counter for it. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/gen/gs.c |8 ++-- drivers/dsp/bridge/pmgr/dbll.c| 15 ++- drivers/dsp/bridge/rmgr/dbdcd.c

[PATCH] DSPBRIDGE: OSAL: Implement registry as linked list.

2010-01-22 Thread Omar Ramirez Luna
From: Andy Shevchenko ext-andriy.shevche...@nokia.com Change implementation of registry to a linked list. In future this will become to some static structures and probably list for DCD_REGKEY array. Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com ---

[PATCH] DSPBRIDGE: cache operation against kernel address instead of user's

2010-01-22 Thread Omar Ramirez Luna
From: Hiroshi DOYU hiroshi.d...@nokia.com Based on the discussion: http://www.spinics.net/lists/arm-kernel/msg72810.html HACK: export follow_page() for dspbridge cache operation Signed-off-by: Hiroshi DOYU hiroshi.d...@nokia.com --- drivers/dsp/bridge/rmgr/proc.c | 68

[PATCH 0/2] DSPBRIDGE: trivial cleanup for enums

2010-01-22 Thread Omar Ramirez Luna
Remove unused enums and replace unrelated enum constants with defines. Shivananda Hebbar (2): DSPBRIDGE: Remove un-used enums DSPBRIDGE: Remove enum definitions and replace with macros arch/arm/plat-omap/include/dspbridge/_chnl_sm.h | 11 +--

[PATCH 1/2] DSPBRIDGE: Remove un-used enums

2010-01-22 Thread Omar Ramirez Luna
From: Shivananda Hebbar x0heb...@ti.com This patch removes un-used enum definitions from bridge. Signed-off-by: Shivananda Hebbar x0heb...@ti.com --- arch/arm/plat-omap/include/dspbridge/cmmdefs.h |8 drivers/dsp/bridge/hw/IPIAccInt.h | 15 ---

[PATCH 2/2] DSPBRIDGE: Remove enum definitions and replace with macros

2010-01-22 Thread Omar Ramirez Luna
From: Shivananda Hebbar x0heb...@ti.com This patch removes unrelated enum constants and replaces it with the macros Signed-off-by: Shivananda Hebbar x0heb...@ti.com --- arch/arm/plat-omap/include/dspbridge/_chnl_sm.h | 11 +-- arch/arm/plat-omap/include/dspbridge/cmm.h |2 +-

Re: [PATCH] DSPBRIDGE: Various compile warning fixes

2010-01-25 Thread Omar Ramirez Luna
Patch looks good, just one question: This patch contains indentation fixes and cleans up various warnings uncovered with extra warning flags: - empty if() bodies am i missing something? which hunk fix this? - incorrect use of unsigned variables - bad comparison of pointer value -

Re: [PATCH] DSPBRIDGE: Fix memory leak in PROC_AutoStart()

2010-01-25 Thread Omar Ramirez Luna
Hi, On 1/21/2010 7:03 AM, Ameya Palande wrote: Signed-off-by: Ameya Palandeameya.pala...@nokia.com --- drivers/dsp/bridge/rmgr/proc.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/dsp/bridge/rmgr/proc.c b/drivers/dsp/bridge/rmgr/proc.c index

[RESEND][PATCH] DSPBRIDGE: cache operation against kernel address instead of user's

2010-01-25 Thread Omar Ramirez Luna
From: Hiroshi DOYU hiroshi.d...@nokia.com Based on the discussion: http://www.spinics.net/lists/arm-kernel/msg72810.html HACK: export follow_page() for dspbridge cache operation Signed-off-by: Hiroshi DOYU hiroshi.d...@nokia.com --- drivers/dsp/bridge/rmgr/proc.c | 68

[RESEND][PATCH 4/5] DSPBRIDGE: Remove multiple initializations of REG module

2010-01-25 Thread Omar Ramirez Luna
From cab08d7241af701397f6e78723d8e2125c3f2306 Mon Sep 17 00:00:00 2001 From: Omar Ramirez Luna omar.rami...@ti.com Date: Thu, 21 Jan 2010 20:34:20 -0600 Subject: [PATCH 08/15] DSPBRIDGE: Remove multiple initializations of REG module REG module should be only initialized by services layer

Re: [PATCH 1/2] DSPBRIDGE: Use enable_off_mode variable instead of dsp_test_sleepstate

2010-01-26 Thread Omar Ramirez Luna
Hi, On 1/23/2010 4:19 AM, Felipe Contreras wrote: From: Jouni Hoganderjouni.hogan...@nokia.com Signed-off-by: Jouni Hoganderjouni.hogan...@nokia.com Signed-off-by: Hiroshi DOYUhiroshi.d...@nokia.com This patch is missing to export enable_off_mode otherwise it will fail while linking. FTR,

Re: [PATCH] DSPBRIDGE: Various compile warning fixes

2010-01-26 Thread Omar Ramirez Luna
smaller than zero - keyword 'extern' has to be first one in variable declaration Signed-off-by: Mika Kukkonenmika.kukko...@nokia.com Signed-off-by: Ameya Palandeameya.pala...@nokia.com Acked-by: Omar Ramirez Luna omar.rami...@ti.com Pushed to dspbridge --- arch/arm/plat-omap/include

[PATCH v2 0/5]

2010-01-26 Thread Omar Ramirez Luna
It is more logic to initialize services related modules inside services layer, even if we are planning to remove it. v2: - Fixed crefs build issue (patch 2) if enabling debug Omar Ramirez Luna (5): DSPBRIDGE: Avoid multiple calls to SERVICES_[Init|Exit] DSPBRIDGE: remove crefs for SERVICES

[PATCH v2 5/5] DSPBRIDGE: Remove multiple initializations of NTFY module

2010-01-26 Thread Omar Ramirez Luna
NTFY module should be only initialized by services layer. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/pmgr/wcd.c |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/drivers/dsp/bridge/pmgr/wcd.c b/drivers/dsp/bridge/pmgr/wcd.c index

[PATCH v2 2/5] DSPBRIDGE: remove crefs for SERVICES[Init|Exit]

2010-01-26 Thread Omar Ramirez Luna
No point in having a module counter if these are called only once. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/services/services.c | 100 1 files changed, 37 insertions(+), 63 deletions(-) diff --git a/drivers/dsp/bridge/services

[PATCH v2 3/5] DSPBRIDGE: Remove multiple initializations of MEM module

2010-01-26 Thread Omar Ramirez Luna
MEM module should be only initialized by services layer, removed reference counter for it. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/gen/gs.c |8 ++-- drivers/dsp/bridge/pmgr/dbll.c| 15 ++- drivers/dsp/bridge/rmgr/dbdcd.c

[PATCH v2 4/5] DSPBRIDGE: Remove multiple initializations of REG module

2010-01-26 Thread Omar Ramirez Luna
REG module should be only initialized by services layer. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/rmgr/dbdcd.c |9 + 1 files changed, 1 insertions(+), 8 deletions(-) diff --git a/drivers/dsp/bridge/rmgr/dbdcd.c b/drivers/dsp/bridge/rmgr/dbdcd.c

[PATCH v2 1/5] DSPBRIDGE: Avoid multiple calls to SERVICES_[Init|Exit]

2010-01-26 Thread Omar Ramirez Luna
Avoid calling multiple times to SERVICES_[Init|Exit] functions, these should be called once at probe and exit respectively. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/pmgr/wcd.c | 10 ++ 1 files changed, 2 insertions(+), 8 deletions(-) diff --git

Re: [PATCH 2/4] dspbridge: Change LST_ELEM to list_head entirely

2010-01-26 Thread Omar Ramirez Luna
On 1/22/2010 9:23 PM, Ramirez Luna, Omar wrote: From: Andy Shevchenkoext-andriy.shevche...@nokia.com * Change struct LST_ELEM to struct list_head in whole dsp bridge driver * Remove useless commentaries * Minor change in the services/mem.c: ... struct list_head *last =mMan.lst.head;

Re: [PATCH 1/4] DSPBRIDGE: Get rid of services/list.c

2010-01-26 Thread Omar Ramirez Luna
On 1/22/2010 9:23 PM, Ramirez Luna, Omar wrote: From: Andy Shevchenkoext-andriy.shevche...@nokia.com * Remove LST_Init() and LST_Exit() calls because they are doing nothing except tracing, Thus, remove tracing as well. * Remove DBC_* calls. It's internal kernel business whether to have

Re: [PATCH 3/4] dspbridge: Don't use LST_Create() and LST_Delete()

2010-01-26 Thread Omar Ramirez Luna
On 1/22/2010 9:23 PM, Ramirez Luna, Omar wrote: From: Andy Shevchenkoext-andriy.shevche...@nokia.com Change LST_Create() to the MEM_Calloc() and INIT_LIST_HEAD() pair in optimal way. Use MEM_Free() instead of LST_Delete(). We can use it without checking because MEM_Free() validates input

Re: [PATCH 4/4] DSPBRIDGE: OSAL: Remove extra include directive

2010-01-26 Thread Omar Ramirez Luna
On 1/22/2010 9:23 PM, Ramirez Luna, Omar wrote: From: Andy Shevchenkoext-andriy.shevche...@nokia.com Including the list.h in some files looks redundant. So, remove those lines. Signed-off-by: Andy Shevchenkoext-andriy.shevche...@nokia.com Acked-by: Fernando Guzman Lugo x0095...@ti.com ---

Re: [PATCH 1/2] DSPBRIDGE: Remove un-used enums

2010-01-26 Thread Omar Ramirez Luna
On 1/22/2010 10:44 PM, Ramirez Luna, Omar wrote: From: Shivananda Hebbarx0heb...@ti.com This patch removes un-used enum definitions from bridge. Signed-off-by: Shivananda Hebbarx0heb...@ti.com --- arch/arm/plat-omap/include/dspbridge/cmmdefs.h |8

Re: [PATCH 2/2] DSPBRIDGE: Remove enum definitions and replace with macros

2010-01-26 Thread Omar Ramirez Luna
On 1/22/2010 10:44 PM, Omar Ramirez Luna wrote: From: Shivananda Hebbarx0heb...@ti.com This patch removes unrelated enum constants and replaces it with the macros Signed-off-by: Shivananda Hebbarx0heb...@ti.com --- arch/arm/plat-omap/include/dspbridge/_chnl_sm.h | 11 +-- arch/arm

[PATCH] DSPBRIDGE: Remove conditional check from the InputMsg function

2010-01-26 Thread Omar Ramirez Luna
From: Shivananda Hebbar x0heb...@ti.com This patch removes the conditional check which can result in message skip. Discovered-by: Bhavin Shah bs...@ti.com Signed-off-by: Shivananda Hebbar x0heb...@ti.com --- drivers/dsp/bridge/wmd/io_sm.c |5 + 1 files changed, 1 insertions(+), 4

Re: [PATCH v2 4/5] DSPBRIDGE: Remove multiple initializations of REG module

2010-01-26 Thread Omar Ramirez Luna
On 1/26/2010 7:46 PM, Guzman Lugo, Fernando wrote: Hi, -Original Message- From: linux-omap-ow...@vger.kernel.org [mailto:linux-omap- ow...@vger.kernel.org] On Behalf Of Ramirez Luna, Omar Sent: Tuesday, January 26, 2010 6:57 PM To: linux-omap Cc: Ameya Palande; Hiroshi Doyu; Felipe

Re: [PATCH 1/2] DSPBRIDGE: Use enable_off_mode variable instead of dsp_test_sleepstate

2010-01-28 Thread Omar Ramirez Luna
On 1/27/2010 6:46 PM, Menon, Nishanth wrote: Omar Ramirez Luna had written, on 01/26/2010 04:23 PM, the following: Hi, On 1/23/2010 4:19 AM, Felipe Contreras wrote: From: Jouni Hoganderjouni.hogan...@nokia.com Signed-off-by: Jouni Hoganderjouni.hogan...@nokia.com Signed-off-by: Hiroshi

Re: [PATCH v2 0/5] DSPBRIDGE: centralized services initialization

2010-01-28 Thread Omar Ramirez Luna
On 1/26/2010 6:57 PM, Ramirez Luna, Omar wrote: It is more logic to initialize services related modules inside services layer, even if we are planning to remove it. v2: - Fixed crefs build issue (patch 2) if enabling debug Omar Ramirez Luna (5): DSPBRIDGE: Avoid multiple calls to SERVICES_

Re: [PATCH] DSPBRIDGE: OSAL: Implement registry as linked list.

2010-01-28 Thread Omar Ramirez Luna
On 1/22/2010 10:26 PM, Omar Ramirez Luna wrote: From: Andy Shevchenkoext-andriy.shevche...@nokia.com Change implementation of registry to a linked list. In future this will become to some static structures and probably list for DCD_REGKEY array. Signed-off-by: Andy Shevchenkoext

Re: [PATCH] dspbridge: minor clean up in memdefs.h

2010-01-28 Thread Omar Ramirez Luna
/dspbridge/memdefs.h |3 --- drivers/dsp/bridge/wmd/tiomap_io.c |5 ++--- 2 files changed, 2 insertions(+), 6 deletions(-) Acked-by: Omar Ramirez Luna omar.rami...@ti.com Pushed to dspbridge. - omar -- To unsubscribe from this list: send the line unsubscribe linux-omap

Re: dspbridge unneeded headers

2010-02-01 Thread Omar Ramirez Luna
Hi Ameya, On 2/1/2010 5:08 AM, Ameya Palande wrote: Hi Omar, What is the plan for following files in bridgedriver source? ./arch/arm/plat-omap/include/dspbridge/mem.h.orig ./arch/arm/plat-omap/include/dspbridge/dbc.h.orig ./arch/arm/plat-omap/include/dspbridge/gt.h.orig

[PATCH v3 2/2] DSPBRIDGE: Remove DRV_ProcUpdatestate function

2010-02-02 Thread Omar Ramirez Luna
From: Gomez Castellanos, Ivan ivan.go...@ti.com The DRV_ProcUpdatestate function was only used in two places and it only assigned a value. Signed-off-by: Ivan Gomez ivan.go...@ti.com Acked-by: Ameya Palande ameya.pala...@nokia.com --- .../plat-omap/include/dspbridge/resourcecleanup.h |3

Re: [PATCH v2 2/2] DSPBRIDGE: Remove DRV_ProcUpdatestate function

2010-02-02 Thread Omar Ramirez Luna
On 1/28/2010 7:18 PM, Gomez Castellanos, Ivan wrote: In the previous patch, the function prototype was not removed. From 22a3646710806c9390a48556ded889e19178db9e Mon Sep 17 00:00:00 2001 From: Ivan Gomezivan.go...@ti.com Date: Thu, 28 Jan 2010 18:53:45 -0600 Subject: [PATCH] DSPBRIDGE: Remove

Re: [PATCH] DSPBRIDGE: Resource clean up always enabled.

2010-02-02 Thread Omar Ramirez Luna
On 1/28/2010 10:44 AM, Ameya Palande wrote: On Thu, 2010-01-28 at 17:05 +0100, ext Ramos Falcon, Ernesto wrote: From 30b0f99526350abe2bf93c2a9729f8fa5f9bafc7 Mon Sep 17 00:00:00 2001 From: Ernesto Ramoserne...@ti.com Date: Thu, 21 Jan 2010 14:36:07 -0600 Subject: [PATCH] DSPBRIDGE: Resource

[PATCH] DSPBRIDGE: Resource clean up always enabled.

2010-02-02 Thread Omar Ramirez Luna
From: Ernesto Ramos erne...@ti.com Remove flag RES_CLEANUP_DISABLE to have dspbridge resource cleanup allways enabled. Signed-off-by: Ernesto Ramos erne...@ti.com Acked-by: Ameya Palande ameya.pala...@nokia.com --- arch/arm/plat-omap/include/dspbridge/_dcd.h|3 --

Re: [RESEND][PATCH] DSPBRIDGE: cache operation against kernel address instead of user's

2010-02-02 Thread Omar Ramirez Luna
Hi, On 1/26/2010 5:52 AM, Felipe Contreras wrote: On Tue, Jan 26, 2010 at 3:56 AM, Omar Ramirez Lunaomar.rami...@ti.com wrote: From: Hiroshi DOYUhiroshi.d...@nokia.com Based on the discussion: http://www.spinics.net/lists/arm-kernel/msg72810.html HACK: export follow_page() for dspbridge

This patch should fix tabs for spaces.

2010-02-02 Thread Omar Ramirez Luna
From f19c2e71f4268e357926461a7196d44703d896ae Mon Sep 17 00:00:00 2001 From: Ernesto Ramos erne...@ti.com Date: Fri, 29 Jan 2010 01:18:56 + Subject: [PATCH v2] DSPBRIDGE: Resource clean up always enabled Remove flag RES_CLEANUP_DISABLE to have dspbridge resource cleanup allways enabled.

Re: [PATCH 1/2] DSPBRIDGE: Check process context in bridge_ioctl

2010-02-02 Thread Omar Ramirez Luna
On 1/27/2010 12:06 PM, Gomez Castellanos, Ivan wrote: From f9d2f46583399c4addd3c2978c62d1821e0100d7 Mon Sep 17 00:00:00 2001 From: Ivan Gomezivan.go...@ti.com Date: Thu, 21 Jan 2010 12:27:33 -0600 Subject: [PATCH] DSPBRIDGE: Check process context in bridge_ioctl Check pcontext

Re: [PATCH v3 2/2] DSPBRIDGE: Remove DRV_ProcUpdatestate function

2010-02-02 Thread Omar Ramirez Luna
On 2/2/2010 1:31 PM, Omar Ramirez Luna wrote: From: Gomez Castellanos, Ivanivan.go...@ti.com The DRV_ProcUpdatestate function was only used in two places and it only assigned a value. Signed-off-by: Ivan Gomezivan.go...@ti.com Acked-by: Ameya Palandeameya.pala...@nokia.com --- .../plat-omap

Re: [PATCH] DSPBRIDGE: Resource clean up always enabled.

2010-02-02 Thread Omar Ramirez Luna
On 2/2/2010 2:18 PM, Omar Ramirez Luna wrote: From: Ernesto Ramoserne...@ti.com Remove flag RES_CLEANUP_DISABLE to have dspbridge resource cleanup allways enabled. Signed-off-by: Ernesto Ramoserne...@ti.com Acked-by: Ameya Palandeameya.pala...@nokia.com --- arch/arm/plat-omap/include

[PATCH] DSPBRIDGE: check pointer before calling Proc_Detach

2010-02-04 Thread Omar Ramirez Luna
From: Ernest Ramos Falcon erne...@ti.com This patch adds a check before calling Proc_Detach, otherwise in case a failure occurs on PROC_Attach and hProcessor is invalid when the userspace task closes its handle, unexpected behavior might be seen as this pointer is dereferenced in PROC_Detach.

Re: [Patch 8/8] DSPBRIDGE: typedef cleanup -CHNL_MODE

2010-02-05 Thread Omar Ramirez Luna
Hi, On 2/2/2010 6:44 PM, Hebbar, Shivananda wrote: From 23b8b63a9f57c20b3f87ac886623d227d5448e8f Mon Sep 17 00:00:00 2001 From: Shivananda Hebbarx0heb...@ti.com Date: Thu, 28 Jan 2010 20:53:48 -0600 Subject: [PATCH] DSPBRIDGE: Remove typedef CHNL_MODE and replace it with normal C

Re: [Patch 5/8] DSPBRIDGE: typedef cleanup -DSP_HPROCESSOR

2010-02-05 Thread Omar Ramirez Luna
Hi, On 2/2/2010 6:44 PM, Hebbar, Shivananda wrote: From 82f402b577d1afb535b319eed4a18087010ef679 Mon Sep 17 00:00:00 2001 From: Shivananda Hebbarx0heb...@ti.com Date: Thu, 28 Jan 2010 20:06:40 -0600 Subject: [PATCH] DSPBRIDGE: Remove typdef used for Processor type replace it with standard C

Re: [PATCH] DSPBRIDGE: Fix memory leak in PROC_AutoStart()

2010-02-05 Thread Omar Ramirez Luna
Hi, On 2/1/2010 11:31 AM, Ameya Palande wrote: Hi Omar, On Mon, 2010-01-25 at 20:21 +0100, ext Omar Ramirez Luna wrote: Hi, On 1/21/2010 7:03 AM, Ameya Palande wrote: Signed-off-by: Ameya Palandeameya.pala...@nokia.com --- drivers/dsp/bridge/rmgr/proc.c |4 1 files changed, 4

Re: [PATCH] DSPBRIDGE: Fix to avoid possible memory leaks in bridge driver.

2010-02-05 Thread Omar Ramirez Luna
possible memory leaks detected in dsp bridge. Signed-off-by: Ernesto Ramoserne...@ti.com Acked-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/pmgr/dbll.c |3 ++- drivers/dsp/bridge/rmgr/drv.c |4 ++-- drivers/dsp/bridge/wmd/msg_sm.c |8 ++-- 3 files

Re: [PATCHv2] DSPBRIDGE: Fix memory leak in PROC_AutoStart()

2010-02-05 Thread Omar Ramirez Luna
On 2/1/2010 11:36 AM, Ameya Palande wrote: Signed-off-by: Ameya Palandeameya.pala...@nokia.com Acked-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/rmgr/proc.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/dsp/bridge/rmgr/proc.c b

Re: [PATCH] DSPBRIDGE: Get rid of driver_minor global variable

2010-02-05 Thread Omar Ramirez Luna
On 2/1/2010 12:18 PM, Ameya Palande wrote: Since there is only 1 device there is no need of driver_minor global variable. Signed-off-by: Ameya Palandeameya.pala...@nokia.com Acked-by: Omar Ramirez Luna omar.rami...@ti.com Pushed to dspbridge - omar -- To unsubscribe from this list: send

Re: [PATCH] DSPBRIDGE: Get rid of bridge_dev and bridge_device pointer

2010-02-05 Thread Omar Ramirez Luna
On 2/1/2010 1:00 PM, Ameya Palande wrote: Signed-off-by: Ameya Palandeameya.pala...@nokia.com --- drivers/dsp/bridge/rmgr/drv_interface.c | 28 ++-- 1 files changed, 6 insertions(+), 22 deletions(-) Acked-by: Omar Ramirez Luna omar.rami...@ti.com Pushed

Re: [PATCH 2/3] DSPBRIDGE: Get rid of MEM_Free()

2010-02-05 Thread Omar Ramirez Luna
++ drivers/dsp/bridge/wmd/ue_deh.c|6 +- 25 files changed, 157 insertions(+), 270 deletions(-) Acked-by: Omar Ramirez Luna omar.rami...@ti.com I had to rework the patch as it sits on top of changes adding 3 more MEM_Free lines. drv.c @@ -603,10 +603,10 @@ DSP_STATUS

Re: [PATCH 1/3] DSPBRIDGE: Get rid of MEM_CHECK mechanism

2010-02-08 Thread Omar Ramirez Luna
insertions(+), 210 deletions(-) Acked-by: Omar Ramirez Luna omar.rami...@ti.com Pushed to dspbridge. - omar -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 2/3] DSPBRIDGE: Get rid of MEM_Free()

2010-02-08 Thread Omar Ramirez Luna
On 2/6/2010 9:16 AM, ameya.pala...@nokia.com wrote: [...] If no objection I'll be pushing tomorrow. No problem :) Pushed to dspbridge - omar -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 3/3] DSPBRIDGE: Get rid of MEM_VFree()

2010-02-08 Thread Omar Ramirez Luna
insertions(+), 36 deletions(-) Acked-by: Omar Ramirez Luna omar.rami...@ti.com Pushed to dspbridge. - omar -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dspbridge: Simplify Atoi() method

2010-02-09 Thread Omar Ramirez Luna
Hi, On 2/3/2010 4:14 AM, Andy Shevchenko wrote: From: Andy Shevchenkoext-andriy.shevche...@nokia.com Try to use simple_strtol() kernel native method instead. strtol or strtoul? However, there are opened questions: - why type of Atoi() is s32 if the sign is used only to detect base? -

Re: [PATCH] dspbridge: Simplify Atoi() method

2010-02-10 Thread Omar Ramirez Luna
On 2/10/2010 1:59 AM, Andy Shevchenko wrote: On Wed, Feb 10, 2010 at 4:02 AM, Omar Ramirez Lunaomar.rami...@ti.com wrote: Try to use simple_strtol() kernel native method instead. strtol or strtoul? I don't know for sure, see below. sorry, i meant: here it says simple_strtol but the code

[PATCH 08/18] DSPBRIDGE: Remove debug statements for success in services

2010-02-16 Thread Omar Ramirez Luna
This patch removes debug statements used to print a successful status or printed during normal execution, as they just polute the logs if trying to look for a failure. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/services/cfg.c | 62

[PATCH 16/18] DSPBRIDGE: print dsp trace buffer by default

2010-02-16 Thread Omar Ramirez Luna
Print to console if the contents of the dsp trace buffer. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/wmd/io_sm.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/dsp/bridge/wmd/io_sm.c b/drivers/dsp/bridge/wmd/io_sm.c index

[PATCH 07/18] DSPBRIDGE: Remove debug statements for success in pmgr

2010-02-16 Thread Omar Ramirez Luna
This patch removes debug statements used to print a successful status or printed during normal execution, as they just polute the logs if trying to look for a failure. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/pmgr/chnl.c |3 --- drivers/dsp/bridge/pmgr

[PATCH 05/18] DSPBRIDGE: Remove debug statements for success in rmgr

2010-02-16 Thread Omar Ramirez Luna
This patch removes debug statements used to print a successful status or printed during normal execution, as they just polute the logs if trying to look for a failure. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/rmgr/dbdcd.c | 14 +--- drivers/dsp

[PATCH 12/18] DSPBRIDGE: Remove excessive debug statements for services

2010-02-16 Thread Omar Ramirez Luna
Removed debug statements that print redundant errors where returned statuses should be enough in case of failure. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/services/cfg.c | 15 +- drivers/dsp/bridge/services/mem.c | 13 - drivers/dsp/bridge

[PATCH 18/18] DSPBRIDGE: change critical error statements to pr_err in services

2010-02-16 Thread Omar Ramirez Luna
Print to console: - If extern phys_mem_pool map fails. - Clk bridge module failures. - Cfg bridge module failures. This will help to quick diagnose most common bridge errors. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/services/cfg.c | 21

[PATCH 04/18] DSPBRIDGE: Remove entry point custom debug statements for wmd

2010-02-16 Thread Omar Ramirez Luna
Remove statements using GT_ENTER custom bridge level which is used to print entry and exit points from functions. Few meaningful prints were left for reference when migrating to dev_dbg. This changes are split to touch services folder only. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com

[PATCH 01/18] DSPBRIDGE: Remove entry point custom debug statements for rmgr

2010-02-16 Thread Omar Ramirez Luna
] 1201.767883: PROC_Start -PROCWRAP_Start Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/rmgr/dbdcd.c | 44 - drivers/dsp/bridge/rmgr/disp.c | 35 --- drivers/dsp/bridge/rmgr/drv.c | 102

[PATCH 02/18] DSPBRIDGE: Remove entry point custom debug statements for wmd

2010-02-16 Thread Omar Ramirez Luna
Remove statements using GT_ENTER custom bridge level which is used to print entry and exit points from functions. Few meaningful prints were left for reference when migrating to dev_dbg. This changes are split to touch wmd folder only. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com

[PATCH 03/18] DSPBRIDGE: Remove entry point custom debug statements for pmgr

2010-02-16 Thread Omar Ramirez Luna
Remove statements using GT_ENTER custom bridge level which is used to print entry and exit points from functions. Only COD, DBLL and DMM meaningful prints were left for reference when migrating to dev_dbg. This changes are split to touch pmgr folder only. Signed-off-by: Omar Ramirez Luna

<    1   2   3   4   5   6   7   >