[PATCH 13/18] DSPBRIDGE: change init statements to pr_info in rmgr

Print to console if: - Driver is succesfully installed. - Baseimage is correctly loaded. - Processor is started. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/rmgr/drv_interface.c |3 +-- drivers/dsp/bridge/rmgr/proc.c |6 ++ 2 files changed, 3

[PATCH 11/18] DSPBRIDGE: Remove excessive debug statements for pmgr

Removed debug statements that print redundant errors where returned statuses should be enough in case of failure. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/pmgr/chnl.c | 20 +++-- drivers/dsp/bridge/pmgr/cmm.c | 58 ++ drivers

[PATCH 15/18] DSPBRIDGE: change critical error statements to pr_err in wmd

Print to console: - SHM critical size errors. - PM power transition errors. - lack of MSG frame issues. This will help to quick diagnose most common bridge errors. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/wmd/io_sm.c | 19

[PATCH 10/18] DSPBRIDGE: Remove excessive debug statements for wmd

Removed debug statements that print redundant errors where returned statuses should be enough in case of failure. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/wmd/chnl_sm.c| 23 + drivers/dsp/bridge/wmd/io_sm.c | 45

[PATCH 17/18] DSPBRIDGE: change critical error statements to pr_err in pmgr

Print to console: - DMM table creation fails. - Failure while finding dsp code. - Failure on device create This will help to quick diagnose most common bridge errors. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/pmgr/cod.c | 14

[PATCH 00/18] Custom debug cleanup

Step 1 to remove custom debug tracing Omar Ramirez Luna (18): DSPBRIDGE: Remove entry point custom debug statements for rmgr DSPBRIDGE: Remove entry point custom debug statements for wmd DSPBRIDGE: Remove entry point custom debug statements for pmgr DSPBRIDGE: Remove entry point custom

[PATCH 14/18] DSPBRIDGE: change critical error statements to pr_err in rmgr

Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/rmgr/drv.c |3 +- drivers/dsp/bridge/rmgr/drv_interface.c | 32 -- drivers/dsp/bridge/rmgr/node.c | 98 +++--- drivers/dsp/bridge/rmgr/proc.c | 21 +++ 4 files changed, 58

[PATCH 06/18] DSPBRIDGE: Remove debug statements for success in wmd

This patch removes debug statements used to print a successful status or printed during normal execution, as they just polute the logs if trying to look for a failure. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/wmd/chnl_sm.c|4 -- drivers/dsp/bridge

Re: DSPBRIDGE: Reclaim all pending buffer on resource cleanup

Hi, On 2/8/2010 4:20 PM, Guzman Lugo, Fernando wrote: From 727c83cd8b7e4aca51b214412eaa1b95cde6e4ea Mon Sep 17 00:00:00 2001 From: Fernando Guzman Lugox0095...@ti.com Date: Tue, 2 Feb 2010 20:38:10 -0600 Subject: [PATCH] DSPBRIDGE: Reclaim all pending buffer on resource cleanup Before in case

Re: DSPBRIDGE: Replace page_address with kmap

to get address in case of high mem allocation. Signed-off-by: Fernando Guzman Lugox0095...@ti.com Acked-by: Omar Ramirez Luna omar.rami...@ti.com Pushed to dspbridge - omar -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org

Re: [PATCH] DSPBRIDGE: Add BRD_SLEEP_TRANSITION in PROC_GetState

Ramirez Luna omar.rami...@ti.com Pushed to dspbridge - omar -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] dspbridge: Simplify Atoi() method (v2)

hex integers like DEAD0123h? - how many spaces could lead token? Signed-off-by: Andy Shevchenkoext-andriy.shevche...@nokia.com Acked-by: Omar Ramirez Luna omar.rami...@ti.com Pushed to dspbridge - omar -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [RESEND] [PATCH] DSPBRIDGE: Adding protection Resource cleanup linked lists

protection Resource cleanup linked lists This patch protects the Resorce cleanup lists from concurrent access Signed-off-by: Fernando Guzman Lugox0095...@ti.com Removed wcd.c changes as functions affected doesn't exist. Acked-by: Omar Ramirez Luna omar.rami...@ti.com Pushed to dspbridge - omar

Re: [PATCH] DSPBRIDGE: Avoid inserting wrong elements to STRM list

Ramirez Luna omar.rami...@ti.com Pushed to dspbridge - omar -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] dspbridge: proc: fix a double-free on 2 error paths

On 2/12/2010 10:26 AM, Phil Carmody wrote: From: Phil Carmodyext-phil.2.carm...@nokia.com We free in the tail cleanup, so don't free before jumping there. Signed-off-by: Phil Carmodyext-phil.2.carm...@nokia.com --- [...] } + + /* paranoid - must be able to kfree this on

Re: [PATCH 2/2] dspbridge: proc: fix a double-free on 2 error paths

On 2/17/2010 7:12 AM, Phil Carmody wrote: On 17/02/10 01:24 +0100, ext Omar Ramirez Luna wrote: On 2/12/2010 10:26 AM, Phil Carmody wrote: From: Phil Carmodyext-phil.2.carm...@nokia.com We free in the tail cleanup, so don't free before jumping there. Signed-off-by: Phil Carmodyext-phil.2

Re: [PATCH v4] DSPBRIDGE: Fix to avoid possible recursive locking

On 2/17/2010 10:09 AM, Menon, Nishanth wrote: Hi, From: Ameya Palande [mailto:ameya.pala...@nokia.com] Sent: Friday, February 12, 2010 12:21 AM To: Chitriki Rudramuni, Deepak Cc: linux-omap; Ramirez Luna, Omar; Menon, Nishanth Subject: Re: [PATCH v4] DSPBRIDGE: Fix to avoid possible recursive

[PATCH 11/12] DSPBRIDGE: Remove debug header files

This patch removes header files used in bridge debug implementation. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include/dspbridge/dbc.h |2 - arch/arm/plat-omap/include/dspbridge/dbg.h | 24 -- arch/arm/plat-omap/include/dspbridge/gt.h

[PATCH 00/12] Custom debug removal

Step 2 to remove custom debug tracing. This set of patches gets rid of GT_* and DBG_* functionality, and replaces them to use dev_dbg instead. This is meant to be a follow up of previous debug removal patches. More info on dynamic_debug: http://lwn.net/Articles/286191/ Omar Ramirez Luna (12

[PATCH 01/12] DSPBRIDGE: global bridge device

This patch declares and externs a pointer to a bridge device to be used with dev_dbg. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include/dspbridge/host_os.h |1 + drivers/dsp/bridge/rmgr/drv_interface.c|4 2 files changed, 5 insertions(+), 0

[PATCH 07/12] DSPBRIDGE: Remove GT_trace variables for wmd

This patch removes variables used to store masks and flags used for the previous debug implementation. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/wmd/io_sm.c |6 +- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/drivers/dsp/bridge/wmd

[PATCH 06/12] DSPBRIDGE: Remove GT_trace variables for rmgr

This patch removes variables used to store masks and flags used for the previous debug implementation. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/rmgr/dbdcd.c |2 -- drivers/dsp/bridge/rmgr/disp.c | 10 -- drivers/dsp/bridge/rmgr

[PATCH 05/12] DSPBRIDGE: Change custom GT_trace for dev_dbg in services

Remove GT_Trace custom debugging mechanism and use dev_dbg. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/services/cfg.c|3 +-- drivers/dsp/bridge/services/clk.c|5 ++--- drivers/dsp/bridge/services/regsup.c | 21 + 3 files

[PATCH 04/12] DSPBRIDGE: Change custom GT_trace for dev_dbg in pmgr

Remove GT_Trace custom debugging mechanism and use dev_dbg. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/pmgr/cmm.c |9 +++--- drivers/dsp/bridge/pmgr/cod.c |5 +-- drivers/dsp/bridge/pmgr/dbll.c | 59 +++- drivers

[PATCH 10/12] DSPBRIDGE: Remove custom debugging implementation

Replace custom debug implementation with a friendly set of pr_err, pr_info and dev_dbg messages. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include/dspbridge/dbg.h | 65 -- arch/arm/plat-omap/include/dspbridge/gt.h | 271 -- drivers

[PATCH 02/12] DSPBRIDGE: Change custom GT_trace for dev_dbg

Remove GT_Trace custom debugging mechanism and use dev_dbg. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/rmgr/dbdcd.c | 29 - drivers/dsp/bridge/rmgr/disp.c | 58 ++ drivers/dsp/bridge/rmgr/drv.c | 91

[PATCH 12/12] DSPBRIDGE: Remove unused instances of CONFIG_BRIDGE_DEBUG

Remove unused instances of CONFIG_BRIDGE_DEBUG. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/rmgr/drv_interface.c |2 -- drivers/dsp/bridge/rmgr/nldr.c |2 -- drivers/dsp/bridge/rmgr/node.c | 10 -- drivers/dsp/bridge/rmgr/proc.c

[PATCH 09/12] DSPBRIDGE: Remove GT_trace variables for services

This patch removes variables used to store masks and flags used for the previous debug implementation. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/services/cfg.c |6 -- drivers/dsp/bridge/services/clk.c |6 -- drivers/dsp/bridge/services

[PATCH 08/12] DSPBRIDGE: Remove GT_trace variables for pmgr

This patch removes variables used to store masks and flags used for the previous debug implementation. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/pmgr/chnl.c | 10 -- drivers/dsp/bridge/pmgr/cmm.c |9 - drivers/dsp/bridge/pmgr/cod.c |9

[PATCH 03/12] DSPBRIDGE: Change custom GT_trace for dev_dbg in wmd

Remove GT_Trace custom debugging mechanism and use dev_dbg. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/wmd/chnl_sm.c|4 +- drivers/dsp/bridge/wmd/io_sm.c | 106 +++-- drivers/dsp/bridge/wmd/mmu_fault.c |9

[PATCH 2/2] DSPBRIDGE: check pointer before dereference

Change the check for valid handle to detect a possible error, and now use it before dereferencing the pointer. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/pmgr/msg.c | 16 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers

[PATCH 0/2] DSPBRIDGE: unrelated fixes

A couple of unrelated fixes. Omar Ramirez Luna (2): DSPBRIDGE: logic error fix for SleepDSP timeout value DSPBRIDGE: check pointer before dereference drivers/dsp/bridge/pmgr/msg.c | 16 drivers/dsp/bridge/wmd/tiomap3430_pwr.c |2 +- 2 files changed, 9

[PATCH 1/2] DSPBRIDGE: logic error fix for SleepDSP timeout value

When leaving the loop waiting for the dsp to transition from its power state, timeout value will be negative, therefore a print for timeout waiting for the dsp won't be displayed, as the condition to check for is !timeout. Reported-by: Berenice Herrera beren...@ti.com Signed-off-by: Omar Ramirez

[RFC][PATCH 2/2] DSPBRIDGE: Distinguish between read or write buffers

values otherwise (if enabled) check will reject buffers not aligned to 128 bytes (even if they fall in the input category). Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/rmgr/proc.c | 16 1 files changed, 12 insertions(+), 4 deletions(-) diff --git

[RFC][PATCH 0/2] DSPBRIDGE: 128 bytes alignment check

composed of 2 bits to distinguish if the mapped chunk is readable/writeable, so the check can be performed on w/rw chunks of memory. Omar Ramirez Luna (2): DSPBRIDGE: add checking 128 byte alignment for dsp cache line size DSPBRIDGE: Distinguish between read or write buffers drivers/dsp/bridge

[RFC][PATCH 1/2] DSPBRIDGE: add checking 128 byte alignment for dsp cache line size

-by: Hiroshi DOYU hiroshi.d...@nokia.com [orl: check into PROC_Map, created Kconfig option] Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/Kconfig | 19 +++ drivers/dsp/bridge/rmgr/proc.c | 12 2 files changed, 31 insertions(+), 0

Re: [PATCH 1/2] dspbridge: proc: it's a pointer, not a handle

--- drivers/dsp/bridge/rmgr/proc.c | 25 +++-- 1 files changed, 11 insertions(+), 14 deletions(-) Acked-by: Omar Ramirez Luna omar.rami...@ti.com Pushed to dspbridge. - omar -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH 2/2] dspbridge: proc: fix a double-free on 2 error paths

insertions(+), 3 deletions(-) Removed NULL assignment as agreed. Acked-by: Omar Ramirez Luna omar.rami...@ti.com Pushed to dspbridge. - omar -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [RFC][PATCH 2/2] DSPBRIDGE: Distinguish between read or write buffers

On 2/19/2010 7:44 AM, Chitriki Rudramuni, Deepak wrote: Ramirez Luna, Omar wrote: This patch introduces the check to differentiate the buffers coming to the dsp through bridgedriver. So far they can be input (read) or output (write) or rw (which are treated the same way as an output buffer),

Re: [PATCH v4] DSPBRIDGE: Fix to avoid possible recursive locking

On 2/18/2010 2:36 PM, Menon, Nishanth wrote: [...] Instead of pushing this patch I'll be reverting this one: http://marc.info/?l=linux-omapm=125694410627720w=2 Explanation: After reviewing the scenario it seems that the patch fixing a flood of messages usecase doesn't seem to be the

Re: [RESEND] [PATCH 1/5] omap2/3/4: mailbox: remove compiler warning

On 2/22/2010 5:41 PM, Anna, Suman wrote: From 657358cd06a3f20bef2472945991749bacef12e6 Mon Sep 17 00:00:00 2001 From: Suman Annas-a...@ti.com Date: Mon, 25 Jan 2010 18:27:21 -0600 Subject: [PATCH] omap2/3/4: mailbox: remove compiler warning Remove a compiler warning in device-specific mailbox

Re: [RESEND] [PATCH 1/5] omap2/3/4: mailbox: remove compiler warning

On 2/22/2010 5:57 PM, Ramirez Luna, Omar wrote: why not moving omap_mbox_unregister to the block containing the ifdefs? at least you won't be adding an ifdef and if(cpu_xx) i take this back... both statements are needed because of previous registration. - omar -- To unsubscribe from this

Re: [PATCH] DSPBRIDGE: Get rid of memset() from MEM_Calloc()

| __GFP_HIGHMEM | __GFP_ZERO, + PAGE_KERNEL); break; default: GT_1trace(MEM_debugMask, GT_6CLASS, Acked-by: Omar Ramirez Luna omar.rami...@ti.com Pushed to dspbridge - omar -- To unsubscribe from this list: send

Re: [PATCH 2/2] DSPBRIDGE: Reclaim all pending buffer on resource cleanup

+- 1 files changed, 13 insertions(+), 9 deletions(-) Acked-by: Omar Ramirez Luna omar.rami...@ti.com Pushed to dspbridge - omar -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 1/4] DSPBRIDGE: Rename DMM_RES_OBJECT to DMM_MAP_OBJECT

On 2/18/2010 8:40 AM, Ameya Palande wrote: In its current state DMM_RES_OBJECT is not correctly tracking reserve and unreserve but only map and unmap. So lets rename it to DMM_MAP_OBJECT to clarify what it is really doing! In addition to this, this patch also does some trivial code cleanup.

Re: [PATCH 2/4] DSPBRIDGE: New reserved memory accounting framework

On 2/18/2010 8:40 AM, Ameya Palande wrote: DSP_RSV_OBJECT is introduced to track reserved memory accounting information. This will allow us to do proper cleanup for memory reserved using PROC_ReserveMemory(). Signed-off-by: Ameya Palandeameya.pala...@nokia.com ---

Re: [PATCH 3/4] DSPBRIDGE: Fix memory corruption in DRV_ProcFreeDMMRes

On 2/18/2010 8:40 AM, Ameya Palande wrote: This patch fixes following issues: 1. pDMMRes was dereferenced and modified when it was already freed by PROC_Ummap(). This results in memory corruption. 2. Instead of passing ulDSPAddr, ulDSPResAddr was passed to PROC_UnMap() which will not

Re: [PATCH 4/4] DSPBRIDGE: Improved mapped memory cleanup

On 2/18/2010 8:40 AM, Ameya Palande wrote: This patch improves current mapped memory cleanup mechanism by using linux native list implementation. As a side effect we also get following benefits: 1. Unnecessary data members in DMM_MAP_OBJECT are removed which results in memory saving. 2.

[PATCH] DSPBRIDGE: Remove GT_TRACE conditional macro

Remove GT_TRACE conditional macro Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include/dspbridge/dbc.h | 14 -- drivers/dsp/bridge/Makefile|5 - drivers/dsp/bridge/rmgr/drv.c |2 -- drivers/dsp/bridge/rmgr

[RESEND][PATCH] DSPBRIDGE: Remove GT_TRACE conditional macro

Please discard previous patch, I think it is best to place DBC* under CONFIG_BRIDGE_DEBUG instead of printing by default. --- Remove GT_TRACE conditional macro, replace in needed places for CONFIG_BRIDGE_DEBUG Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include

Re: [PATCH 00/18] Custom debug cleanup

On 2/16/2010 2:42 AM, Ramirez Luna, Omar wrote: Step 1 to remove custom debug tracing Omar Ramirez Luna (18): DSPBRIDGE: Remove entry point custom debug statements for rmgr DSPBRIDGE: Remove entry point custom debug statements for wmd DSPBRIDGE: Remove entry point custom debug

Re: [PATCH 00/12] Custom debug removal

://lwn.net/Articles/286191/ Omar Ramirez Luna (12): DSPBRIDGE: global bridge device DSPBRIDGE: Change custom GT_trace for dev_dbg DSPBRIDGE: Change custom GT_trace for dev_dbg in wmd DSPBRIDGE: Change custom GT_trace for dev_dbg in pmgr DSPBRIDGE: Change custom GT_trace for dev_dbg

Re: [PATCH 1/2] DSPBRIDGE: logic error fix for SleepDSP timeout value

On 2/18/2010 3:55 PM, Ramirez Luna, Omar wrote: When leaving the loop waiting for the dsp to transition from its power state, timeout value will be negative, therefore a print for timeout waiting for the dsp won't be displayed, as the condition to check for is !timeout. Reported-by: Berenice

Re: [PATCH 2/2] DSPBRIDGE: check pointer before dereference

On 2/18/2010 3:55 PM, Ramirez Luna, Omar wrote: Change the check for valid handle to detect a possible error, and now use it before dereferencing the pointer. Signed-off-by: Omar Ramirez Lunaomar.rami...@ti.com --- drivers/dsp/bridge/pmgr/msg.c | 16 1 files changed, 8

Re: [Patchv2 0/8] DSPBRIDGE: typedef cleanup

On 2/5/2010 7:21 PM, Hebbar, Shivananda wrote: Resending the patches after updating review comments and also Fixing some compilation breaks. These patches remove the typedefs and replace it with normal C types: Shivananda Hebbar (8) DSPBRIDGE: typedef cleanup -DSP RTOS DSPBRIDGE: typedef

[ANNOUNCE] dspbridge: kill camelcase

Hi All, I'm currently working on removing camel case + hungarian notation from dspbridge code in the following branch: dspbridge-next-camelcase on d.o-z I'll appreciate if you can mail any unsent patch otherwise it will need to wait (and be rebased) after the camelcase changes. If nobody

Re: [ANNOUNCE] dspbridge: kill camelcase

Hi, On 2/24/2010 1:38 AM, Menon, Nishanth wrote: Tony Lindgren said the following on 02/24/2010 05:13 AM: * Omar Ramirez Lunaomar.rami...@ti.com [100223 18:11]: Hi All, I'm currently working on removing camel case + hungarian notation from dspbridge code in the following branch:

[UPDATE] kill camel case

Hi All, CamelCase script execution has been completed, so far I replaced all the tokens picked up by the killcc script[1], and all the changes are present in the following branches: dspbridge-next-camelcase It has all the changes made in three steps: 1) Replaced all

[PATCH] DSPBRIDGE: driver version 0.2

driver version 0.2 Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/rmgr/drv_interface.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/dsp/bridge/rmgr/drv_interface.c b/drivers/dsp/bridge/rmgr/drv_interface.c index fa97caa..3f5af34

Re: [UPDATE] kill camel case

were fixed (i.e. replacementes made for Write, Allocate, Deallocate) Compilation break if compiled as part of the kernel on msg_init. If no more comments I'll push this as a single patch after 0.2. Regards, Omar On 3/1/2010 9:07 PM, Omar Ramirez Luna wrote: Hi All, CamelCase script execution

Re: [UPDATE] kill camel case

Hi, It will be fixed once they are pushed as a single patch. Regards, Omar On 3/8/2010 12:10 PM, Chitriki Rudramuni, Deepak wrote: Omar, Missing your Signed-off-by for all the patches in dspbridge-camelcase-v2 branch. Thanks, Deepak Omar Ramirez Luna wrote: Hi, Deleted: dspbridge-next

[PATCH 8/9] DSPBRIDGE: Remove DPC module from SERVICES layer

This patch removes init and exit functions for DPC module. It also deletes dpc source file and takes out the module from Makefile. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include/dspbridge/dpc.h | 26 --- drivers/dsp/bridge/Makefile

[PATCH 4/9] DSPBRIDGE: Use _IOxx macro to define ioctls

Use standard convention to define ioctls. Currently 'DB' is used as identifier for dspbridge. *** NOTE: An update in api ioctl definitions is required. *** Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include/dspbridge/wcdioctl.h | 142

[PATCH 9/9] DSPBRIDGE: Remove DPC object structure

Remove DPC object structure and declare required members for each tasklet inside their correspondent modules. Remove dpc header file. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include/dspbridge/_chnl_sm.h |1 - arch/arm/plat-omap/include/dspbridge/dpc.h

[PATCH 0/9] dspbridge cleanup patches

Following patches are cleanups, removing history of files, tab spacing and also remove DPC layer. Omar Ramirez Luna (8): DSPBRIDGE: trivial checkpatch fixes DSPBRIDGE: Fix multiline macros to use do while DSPBRIDGE: Use _IOxx macro to define ioctls DSPBRIDGE: trivial cleanup

[PATCH 5/9] DSPBRIDGE: trivial cleanup and indentation for io_sm

Remove duplicate set of braces from if statement and reduce indentation. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/wmd/io_sm.c | 96 +--- 1 files changed, 40 insertions(+), 56 deletions(-) diff --git a/drivers/dsp/bridge

[PATCH 6/9] DSPBRIDGE: Remove DPC, create, destroy and schedule wrappers

Remove DPC wrappers and replace with direct Linux calls. These changes apply to IO DPC and MMUfault DPC Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include/dspbridge/dpc.h | 90 +++-- drivers/dsp/bridge/services/dpc.c | 144

[PATCH 7/9] DSPBRIDGE: Remove main DPC wrapper for IO and MMUfault

Remove DeferredProcedure which is used as a wrapper to call either IO or MMUfault DPCs. This also removes a custom typedef. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include/dspbridge/dpc.h | 23 arch/arm/plat-omap/include/dspbridge/io_sm.h

[PATCH v2 02/20] DSPBRIDGE: trivial license fix in tramp and tramp_table_c6000

Seems that these files had a licensing mismatch, changing to GPL2. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/dynload/tramp.c | 18 +- drivers/dsp/bridge/dynload/tramp_table_c6000.c | 18 +- 2 files changed, 26

[PATCH v2 05/20] DSPBRIDGE: checkpatch - space required after comma

ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com CC: Nishant Menon n...@ti.com --- drivers/dsp/bridge/hw/GlobalTypes.h |4 ++-- drivers/dsp/bridge/hw/PRCMRegAcM.h | 24 2 files changed, 14 insertions(+), 14

[PATCH v2 09/20] DSPBRIDGE: checkpatch - printk() should include KERN_ facility level

WARNING: printk() should include KERN_ facility level Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com CC: Nishant Menon n...@ti.com --- arch/arm/plat-omap/include/dspbridge/dbc.h |2 +- arch/arm/plat-omap/include/dspbridge/gt.h |2 +- drivers/dsp/bridge/gen/_gt_para.c

[PATCH v2 17/20] DSPBRIDGE: Remove DPC, create, destroy and schedule wrappers

Remove DPC wrappers and replace with direct Linux calls. These changes apply to IO DPC and MMUfault DPC Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include/dspbridge/dpc.h | 90 +++-- drivers/dsp/bridge/services/dpc.c | 144

[PATCH v2 11/20] DSPBRIDGE: checkpatch - struct file_operations should normally be const

WARNING: struct file_operations should normally be const Signed-off-by: Omar Ramirez Lua omar.rami...@ti.com CC: Nishant Menon n...@ti.com --- drivers/dsp/bridge/rmgr/drv_interface.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/dsp/bridge/rmgr/drv_interface.c

[PATCH v2 14/20] DSPBRIDGE: Use _IOxx macro to define ioctls

and not implemented ioctls, this can be done when all the ioctls are accessed through a switch instead of a pointer to function. *** NOTE: An update in api ioctl definitions is required. *** Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com CC: Nishant Menon n...@ti.com --- arch/arm/plat-omap/include

[PATCH v2 20/20] DSPBRIDGE: Remove DPC object structure

Remove DPC object structure and declare required members for each tasklet inside their correspondent modules. Remove dpc header file. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include/dspbridge/_chnl_sm.h |1 - arch/arm/plat-omap/include/dspbridge/dpc.h

[PATCH v2 01/20] DSPBRIDGE: driver version 0.1

Prior to any further modification set the driver version to be 0.1 Also in this patch: - Move author and license macros to end of file - License to be GPL v2 as stated on the comments Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com CC: Artem Bityutskiy dedeki...@gmail.com CC: Felipe

[PATCH v2 12/20] DSPBRIDGE: checkpatch foo-should-be for pointers

ERROR: foo *__user * bar should be foo *__user *bar Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com CC: Nishant Menon n...@ti.com --- arch/arm/plat-omap/include/dspbridge/wcdioctl.h |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/plat-omap/include

[PATCH v2 10/20] DSPBRIDGE: checkpatch - braces not necessary for single statement blocks

WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com CC: Nishant Menon n...@ti.com --- drivers/dsp/bridge/gen/gs.c |3 +-- drivers/dsp/bridge/pmgr/cmm.c |5 ++--- drivers/dsp/bridge/rmgr/node.c|4

[PATCH v2 08/20] DSPBRIDGE: Checkpatch - line over 80 characters

WARNING: line over 80 characters Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com CC: Nishant Menon n...@ti.com --- arch/arm/plat-omap/include/dspbridge/dbdefs.h |2 +- drivers/dsp/bridge/wmd/io_sm.c|3 ++- drivers/dsp/bridge/wmd/mmu_fault.c|3

[PATCH v2 18/20] DSPBRIDGE: Remove main DPC wrapper for IO and MMUfault

Remove DeferredProcedure which is used as a wrapper to call either IO or MMUfault DPCs. This also removes a custom typedef. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include/dspbridge/dpc.h | 23 arch/arm/plat-omap/include/dspbridge/io_sm.h

[PATCH v2 19/20] DSPBRIDGE: Remove DPC module from SERVICES layer

This patch removes init and exit functions for DPC module. It also deletes dpc source file and takes out the module from Makefile. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include/dspbridge/dpc.h | 26 --- drivers/dsp/bridge/Makefile

[PATCH v2 00/20] dspbridge cleanups

and not implemented, will be clenaed when the big ioctl switch replaces the WCD function table. CC: Artem Bityutskiy dedeki...@gmail.com CC: Felipe Balbi felipe.ba...@nokia.com CC: Felipe Contreras felipe.contre...@gmail.com CC: Hiroshi Doyu hiroshi.d...@nokia.com CC: Nishant Menon n...@ti.com Omar Ramirez Luna

[PATCH 00/17] First set of unreviewed patches

support for dynamic loader DSPBRIDGE: Enable/Disable MCBSP_CLOCKS for MCBSP2 DSPBRIDGE: support loading 4 dependent DLL Omar Ramirez Luna (11): DSPBRIDGE: set PWRERROR notifications as an option DSPBRIDGE: Enable peripheral clocks on wake up DSPBRIDGE: Remove long busy-wait loops on PWRST

[PATCH 07/17] DSPBRIDGE: Rename usCount to timeout

Rename usCount to timeout Reported-by: Nishanth Menon n...@ti.com Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/wmd/tiomap3430.c |6 +++--- drivers/dsp/bridge/wmd/tiomap3430_pwr.c | 12 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff

[PATCH 12/17] DSPBRIDGE: check pointer before calling Proc_Detach

From: Ernest Ramos Falcon erne...@ti.com This patch adds a check before calling Proc_Detach, otherwise we will see an error. Signed-off-by: Ernest Ramos Falcon erne...@ti.com Signed-off-by: Fernando Guzman Lugo x0095...@ti.com --- drivers/dsp/bridge/rmgr/drv_interface.c |3 ++- 1 files

[PATCH 14/17] DSPBRIDGE: KFILE_Seek KFILE_Tell, u32 replaced with loff_t

KFILE_Seek KFILE_Tell, u32 replaced with loff_t Discovered-by: Ameya Palande ameya.pala...@nokia.com Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/pmgr/cod.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/dsp/bridge/pmgr/cod.c b

[PATCH 15/17] DSPBRIDGE: Delete unused files

These files seem to be unused, deleting them. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include/dspbridge/dbl.h | 354 --- arch/arm/plat-omap/include/dspbridge/dbof.h | 117 --- drivers/dsp/bridge/dynload/dlclasses_hdr.h | 41 - drivers/dsp/bridge/pmgr

[PATCH 11/17] DSPBRIDGE: Memory leak in Node Register Notify

From: Ernesto Ramos Falcon erne...@ti.com Fix for memory leak in DSPNode_RegisterNotify when unregistering an object. Signed-off-by: Ernesto Ramos Falcon erne...@ti.com --- drivers/dsp/bridge/pmgr/wcd.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git

[PATCH 17/17] DSPBRIDGE: Compilation fixes 2.6.31

Compilation fixes 2.6.31 board-sdp3430.h not found clk_handle undefined because of DVFS flag Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/mach-omap2/dspbridge.c |2 ++ drivers/dsp/bridge/rmgr/drv_interface.c |8 drivers/dsp/bridge

[PATCH 05/17] DSPBRIDGE: Enable peripheral clocks on wake up

If enable_off_mode is not set bridge target state going into suspend will be retention, on this path the peripheral clocks will be disabled but not enabled again when waking the dsp up. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/wmd/tiomap_sm.c |4 +++- 1

[PATCH 16/17] DSPBRIDGE: Avoid REGistry if pDevContext is available

Avoid calls to read the register if pDevContext is available to the function, this will save a call to query and hold a semaphore under registry operations. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- arch/arm/plat-omap/include/dspbridge/cfgdefs.h |2 +- drivers/dsp/bridge/rmgr

[PATCH 10/17] DSPBRIDGE: support loading 4 dependent DLL

From: Fernando Guzman Lugo x0095...@ti.com This patch fixes loading a SN that has 4 dependent DLLs, previously it was failing due to a non-null terminated string. Signed-off-by: Fernando Guzman Lugo x0095...@ti.com --- drivers/dsp/bridge/rmgr/dbdcd.c |2 +- 1 files changed, 1 insertions(+),

[PATCH 13/17] DSPBRIDGE: check the status of DMM_GetHandle

Check the status of DMM_GetHandle Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/rmgr/proc.c | 17 ++--- 1 files changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/dsp/bridge/rmgr/proc.c b/drivers/dsp/bridge/rmgr/proc.c index ab0b913

[PATCH 09/17] DSPBRIDGE: Do not panic on bad page count

If a page doesn't have a sane count, do not panic or release it. Loudly complain with dump_stack but do not halt with BUG. Signed-off-by: Fernando Guzman Lugo x0095...@ti.com Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/wmd/tiomap3430.c | 12 +++- 1 files

[PATCH 08/17] DSPBRIDGE: Trivial cleanup on DBDCD

Trivial spacing cleanup on DSP/BIOS Bridge Configuration Database module. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/rmgr/dbdcd.c | 343 --- 1 files changed, 179 insertions(+), 164 deletions(-) diff --git a/drivers/dsp/bridge

[PATCH 04/17] DSPBRIDGE: set PWRERROR notifications as an option

will be unusable until a recovery method cleans the error state. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/Kconfig | 11 +++ drivers/dsp/bridge/wmd/tiomap3430_pwr.c |4 drivers/dsp/bridge/wmd/ue_deh.c |2 ++ 3 files changed, 17

[PATCH 03/17] DSPBRIDGE: Enable/Disable MCBSP_CLOCKS for MCBSP2

From: Fernando Guzman Lugo x0095...@ti.com Enable/Disable McBSP_CLOCKS when McBSP2 is requested so DPLL can be gated. Signed-off-by: Fernando Guzman Lugo x0095...@ti.com Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/wmd/tiomap3430_pwr.c | 73

[PATCH 06/17] DSPBRIDGE: Remove long busy-wait loops on PWRST transitions

=c8853459b739e5f43da0badc1605a0a0c0c8195d Reported-by: Nishanth Menon n...@ti.com Signed-off-by: Fernando Guzman Lugo x0095...@ti.com Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/wmd/_tiomap_util.h |6 ++ drivers/dsp/bridge/wmd/tiomap3430_pwr.c | 24

[PATCHv2 01/18] DSPBRIDGE: Fix compile break for WCD debug mask

If debug mode is enabled compilation will break because WCD debug mask is used before behing defined. Signed-off-by: Omar Ramirez Luna omar.rami...@ti.com --- drivers/dsp/bridge/pmgr/wcd.c | 80 1 files changed, 40 insertions(+), 40 deletions(-) diff

[PATCHv2 00/18] First set of unreviewed patches

: support loading 4 dependent DLL Hiroshi DOYU (1): DSPBRIDGE: enable smart/autoidle for mailbox sysconfig Omar Ramirez Luna (11): DSPBRIDGE: Fix compile break for WCD debug mask DSPBRIDGE: set PWRERROR notifications as an option DSPBRIDGE: Enable peripheral clocks on wake up DSPBRIDGE

<    1   2   3   4   5   6   7   >