, David Cohen
+ musb_writel(musb-mregs, OTG_INTERFSEL,
musb-context.otg_interfsel);
usb_phy_set_suspend(musb-xceiv, 0);
--
1.8.4.1
--
To unsubscribe from this list: send the line unsubscribe linux-usb in
the body
around pm
callback functions. Instead of saying DWC3 will start to have warnings
when CONFIG_PM is not selected, I'd say your patch set is now a
dependence of my RFC :)
https://lkml.org/lkml/2013/12/13/4
Br, David Cohen
Felipe Balbi (7):
usb: dwc3: keystone: add basic PM support
usb: dwc3
On Tue, Dec 17, 2013 at 03:31:40PM -0800, David Cohen wrote:
On Thu, Dec 12, 2013 at 03:38:38PM -0600, Felipe Balbi wrote:
hi all,
these patches add pm_runtime support for all glue layers.
I plan to add pm_runtime support for dwc3 after these
patches are merged upstream.
Please
-by: David Cohen david.a.co...@linux.intel.com
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Dec 12, 2013 at 10:17:19PM -0600, Felipe Balbi wrote:
On Thu, Dec 12, 2013 at 05:56:05PM -0800, David Cohen wrote:
On Thu, Dec 12, 2013 at 03:38:41PM -0600, Felipe Balbi wrote:
teach the PCI glue about pm_runtime so that
it's easier to teach dwc3 core about it
later
On Thu, Dec 12, 2013 at 02:20:59AM +0200, Grazvydas Ignotas wrote:
This is a hard to reproduce problem which leads to non-functional
USB-OTG port in 0.1%-1% of all boots. Tracked it down to commit
e25bec160158abe86c omap2+: save and restore OTG_INTERFSEL,
which introduces save/restore of
will seem to need it, it would probably
make more sense to invoke the relevant mechanism from the underlying
layers rather than from a higher layer).
-extern int iommu_set_da_range(struct iommu *obj, u32 start, u32 end);
This function was introduced by David Cohen to specify the available
ISP virtual
to get them together. IMO the third option
from Laurent solves the issue for now and don't make it more difficult
to implement a better standard to OMAP.
Regards,
David Cohen
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
On Wed, Mar 30, 2011 at 4:56 PM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
On Wednesday 30 March 2011 15:50:37 Sakari Ailus wrote:
Laurent Pinchart wrote:
Hi Sakari,
Hi Laurent,
On Wednesday 30 March 2011 10:16:56 Sakari Ailus wrote:
Laurent Pinchart wrote:
On Friday
.
The generic iommu driver cannot support more than one implementation
loaded at the same time, so your patch is correct by assuming it.
Regards,
David Cohen
Regards,
--
Sakari Ailus
sakari.ai...@maxwell.research.nokia.com
--
To unsubscribe from this list: send the line unsubscribe linux-omap
new specific implementation should modify this piece of
code? Are you sure it's a good idea?
Regards,
David Cohen
A new else defining the install/uninstall_arch_iommu functions or
simply reversing the check to be OMAP2+ and error on anything else.
Regards,
Omar
--
To unsubscribe from
you won't natively find in such old kernel version. I also
suggest you to CC linux-me...@vger.kernel.org as well in next
questions.
Br,
David
As you can tell, I'm fairly new with OMAP programming.
Thanks!
Regards,
Patrick
On vr, 2011-03-25 at 16:34 +0200, David Cohen wrote:
Hi,
On Fri
using an old version of the driver. Please, use the newer one
available in mainline.
Regards,
David Cohen
On vr, 2011-03-25 at 13:24 +0200, Sakari Ailus wrote:
Patrick Radius wrote:
Hi,
Hi Patrick,
I think this question will get better answered in the linux-media list.
Cc it.
i'm trying
. Is this an acceptable requirement?
I can't see a reason why this assumption could be wrong. In my point
of view it's acceptable. Let's see Hiroshi's.
Regards,
David Cohen
Serialisation of the access to arch_iommu is done using mutex called
arch_iommu_mutex.
module_put() doesn't need to have
On Wed, Mar 9, 2011 at 9:43 AM, Sakari Ailus
sakari.ai...@maxwell.research.nokia.com wrote:
David Cohen wrote:
ISP doesn't consider 0x0 as a valid address, so it should explicitly
exclude first page from allowed 'da' range.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/mach
an ambiguous situation. This patch set moves
fixed 'da' check to the input flags.
Br,
David Cohen
---
David Cohen (1):
omap: iovmm: don't check 'da' to set IOVMF_DA_FIXED flag
Michael Jones (1):
omap: iovmm: disallow mapping NULL address when IOVMF_DA_ANON is set
arch/arm/plat-omap/include
From: Michael Jones michael.jo...@matrix-vision.de
commit c7f4ab26e3bcdaeb3e19ec658e3ad9092f1a6ceb allowed mapping the NULL
address if da_start==0, which would then not get unmapped. Disallow
this again if IOVMF_DA_ANON is set. And spell variable 'alignment'
correctly.
Signed-off-by: Michael
now
come from the user throught 'flags' parameter when mapping memory.
As IOVMF_DA_ANON and IOVMF_DA_FIXED are mutually exclusive, IOVMF_DA_ANON
can be removed. The driver will now check internally if IOVMF_DA_FIXED
is set or not.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/plat-omap
Hi Fernando,
On Tue, Mar 8, 2011 at 11:13 AM, Sakari Ailus
sakari.ai...@maxwell.research.nokia.com wrote:
Guzman Lugo, Fernando wrote:
On Mon, Mar 7, 2011 at 1:19 PM, David Cohen daco...@gmail.com wrote:
On Mon, Mar 7, 2011 at 9:17 PM, Guzman Lugo, Fernando
fernando.l...@ti.com wrote:
On Mon
for ISP IOMMU instance.
David Cohen (2):
omap3: change ISP's IOMMU da_start address
omap: iovmm: don't check 'da' to set IOVMF_DA_FIXED/IOVMF_DA_ANON
flags
Michael Jones (1):
omap: iovmm: disallow mapping NULL address
arch/arm/mach-omap2/omap-iommu.c |2 +-
arch/arm/plat-omap/iovmm.c
ISP doesn't consider 0x0 as a valid address, so it should explicitly
exclude first page from allowed 'da' range.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/mach-omap2/omap-iommu.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/omap
From: Michael Jones michael.jo...@matrix-vision.de
commit c7f4ab26e3bcdaeb3e19ec658e3ad9092f1a6ceb allowed mapping
the NULL address if da_start==0, which would then not get unmapped.
Disallow this again. And spell variable 'alignment' correctly.
Signed-off-by: Michael Jones
now
come from the user. IOVMF_DA_ANON will be automatically set if
IOVMF_DA_FIXED isn't set.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/plat-omap/iovmm.c | 12
1 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat
Hi Sakari,
On Tue, Mar 8, 2011 at 4:06 PM, Sakari Ailus
sakari.ai...@maxwell.research.nokia.com wrote:
David Cohen wrote:
ISP doesn't consider 0x0 as a valid address, so it should explicitly
exclude first page from allowed 'da' range.
Signed-off-by: David Cohen daco...@gmail.com
---
arch
IOVMF_DA_FIXED/IOVMF_DA_ANON flags
Date: Tue, 8 Mar 2011 11:59:43 -0600
On Tue, Mar 8, 2011 at 6:46 AM, David Cohen daco...@gmail.com wrote:
Currently IOVMM driver sets IOVMF_DA_FIXED/IOVMF_DA_ANON flags according
to input 'da' address when mapping memory:
da == 0: IOVMF_DA_ANON
da != 0
On Tue, Mar 8, 2011 at 8:06 PM, Guzman Lugo, Fernando
fernando.l...@ti.com wrote:
On Tue, Mar 8, 2011 at 6:46 AM, David Cohen daco...@gmail.com wrote:
From: Michael Jones michael.jo...@matrix-vision.de
commit c7f4ab26e3bcdaeb3e19ec658e3ad9092f1a6ceb allowed mapping
the NULL address
better.
Br,
David Cohen
--
To unsubscribe from this list: send the line unsubscribe linux-omap in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Mar 8, 2011 at 9:46 PM, David Cohen daco...@gmail.com wrote:
[snip]
- flags |= (da ? IOVMF_DA_FIXED : IOVMF_DA_ANON);
+ if (~flags IOVMF_DA_FIXED)
+ flags |= IOVMF_DA_ANON;
could we use only one? both are mutual exclusive, what happen if flag
On Tue, Mar 8, 2011 at 9:53 PM, Guzman Lugo, Fernando
fernando.l...@ti.com wrote:
On Tue, Mar 8, 2011 at 1:06 PM, David Cohen daco...@gmail.com wrote:
On Tue, Mar 8, 2011 at 8:06 PM, Guzman Lugo, Fernando
fernando.l...@ti.com wrote:
On Tue, Mar 8, 2011 at 6:46 AM, David Cohen daco...@gmail.com
On Tue, Mar 8, 2011 at 10:04 PM, David Cohen daco...@gmail.com wrote:
*** BLURB HERE ***
Sorry for this garbage :/
Br,
David
David Cohen (2):
omap3: change ISP's IOMMU da_start address
omap: iovmm: don't check 'da' to set IOVMF_DA_FIXED flag
Michael Jones (1):
omap: iovmm: disallow
for ISP IOMMU instance.
Br,
David Cohen
---
David Cohen (2):
omap3: change ISP's IOMMU da_start address
omap: iovmm: don't check 'da' to set IOVMF_DA_FIXED flag
Michael Jones (1):
omap: iovmm: disallow mapping NULL address when IOVMF_DA_ANON is set
arch/arm/mach-omap2/omap-iommu.c
From: Michael Jones michael.jo...@matrix-vision.de
commit c7f4ab26e3bcdaeb3e19ec658e3ad9092f1a6ceb allowed mapping the NULL
address if da_start==0, which would then not get unmapped. Disallow
this again if IOVMF_DA_ANON is set. And spell variable 'alignment'
correctly.
Signed-off-by: Michael
ISP doesn't consider 0x0 as a valid address, so it should explicitly
exclude first page from allowed 'da' range.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/mach-omap2/omap-iommu.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/omap
now
come from the user throught 'flags' parameter when mapping memory.
As IOVMF_DA_ANON and IOVMF_DA_FIXED are mutually exclusive, IOVMF_DA_ANON
can be removed. The driver will now check internally if IOVMF_DA_FIXED
is set or not.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/plat-omap
On Tue, Mar 8, 2011 at 10:31 PM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
Hi David,
On Monday 07 March 2011 22:35:31 David Cohen wrote:
On Mon, Mar 7, 2011 at 11:19 PM, Laurent Pinchart wrote:
On Monday 07 March 2011 20:41:21 David Cohen wrote:
On Mon, Mar 7, 2011 at 9:25
On Mon, Mar 7, 2011 at 9:17 PM, Guzman Lugo, Fernando
fernando.l...@ti.com wrote:
On Mon, Mar 7, 2011 at 7:10 AM, Michael Jones
michael.jo...@matrix-vision.de wrote:
From e7dbe4c4b64eb114f9b0804d6af3a3ca0e78acc8 Mon Sep 17 00:00:00 2001
From: Michael Jones michael.jo...@matrix-vision.de
Date:
On Mon, Mar 7, 2011 at 9:25 PM, Guzman Lugo, Fernando
fernando.l...@ti.com wrote:
On Mon, Mar 7, 2011 at 1:19 PM, David Cohen daco...@gmail.com wrote:
On Mon, Mar 7, 2011 at 9:17 PM, Guzman Lugo, Fernando
fernando.l...@ti.com wrote:
On Mon, Mar 7, 2011 at 7:10 AM, Michael Jones
michael.jo
On Mon, Mar 7, 2011 at 11:19 PM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
Hi David,
Hi Laurent,
On Monday 07 March 2011 20:41:21 David Cohen wrote:
On Mon, Mar 7, 2011 at 9:25 PM, Guzman Lugo, Fernando wrote:
On Mon, Mar 7, 2011 at 1:19 PM, David Cohen wrote:
On Mon, Mar
code, so it's not correct to rely on it for
this purpose.
IMO, instead of change to IS_ERR_OR_NULL(), you could only remove
IS_ERR(). The same apply for the other cases.
Kind regards,
David Cohen
pr_warning(%s: VDD specified does not exist!\n, __func__);
return 0
Hi,
[snip]
Sorry, I should've mentioned: I'm using your media-0005-omap3isp branch
based on 2.6.38-rc5. I didn't have the problem with 2.6.37, either.
It's actually not related to mis-configuring the ISP pipeline like I
thought at first- it also happens after I have successfully captured
On Fri, Mar 4, 2011 at 4:39 PM, Michael Jones
michael.jo...@matrix-vision.de wrote:
Hi David,
Hi Michael,
On 03/04/2011 02:12 PM, David Cohen wrote:
Hi,
[snip]
Sorry, I should've mentioned: I'm using your media-0005-omap3isp branch
based on 2.6.38-rc5. I didn't have the problem
[snip]
From 2712f2fd087ca782e964c912c7f1973e7d84f2b7 Mon Sep 17 00:00:00 2001
From: Michael Jones michael.jo...@matrix-vision.de
Date: Fri, 4 Mar 2011 15:09:48 +0100
Subject: [PATCH] omap: iovmm: disallow mapping NULL address
commit c7f4ab26e3bcdaeb3e19ec658e3ad9092f1a6ceb allowed mapping
Hi,
On Tue, Mar 1, 2011 at 9:46 PM, Fernando Guzman Lugo
fernando.l...@ti.com wrote:
From: Ramesh Gupta grgu...@ti.com
No patch body description at all?
Can we get at least something here?
Regards,
David
Signed-off-by: Ramesh Gupta grgu...@ti.com
Signed-off-by: Hari Kanigeri
Hi,
On Tue, Mar 1, 2011 at 9:46 PM, Fernando Guzman Lugo
fernando.l...@ti.com wrote:
From: Hari Kanigeri h-kanige...@ti.com
pgd and pte entries weren't getting flushed out leading to MMU faults.
May I ask you to add to the patch body description why it's wrong and
why your solution is
On Thu, Feb 24, 2011 at 10:35 AM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Wed, Feb 23, 2011 at 10:09:05PM +0200, Sakari Ailus wrote:
In OMAP4 the cortex M3 is a double core processor and as each core is
running they own version of the RTOS we threat them independently. So
our driver which
On Mon, Feb 21, 2011 at 2:21 PM, Felipe Balbi ba...@ti.com wrote:
On Mon, Feb 21, 2011 at 02:09:07PM +0200, David Cohen wrote:
On Mon, Feb 21, 2011 at 9:36 AM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Sat, Feb 19, 2011 at 06:04:58PM +0200, David Cohen wrote:
I have to disagree
On Wed, Feb 23, 2011 at 3:17 AM, Guzman Lugo, Fernando
fernando.l...@ti.com wrote:
On Wed, Feb 16, 2011 at 1:35 PM, David Cohen daco...@gmail.com wrote:
Add support to register an isr for IOMMU fault situations and adapt it
to allow such (*isr)() to be used as fault callback. Drivers using
On Wed, Feb 23, 2011 at 3:39 PM, Guzman Lugo, Fernando
fernando.l...@ti.com wrote:
On Wed, Feb 23, 2011 at 3:45 AM, David Cohen daco...@gmail.com wrote:
On Wed, Feb 23, 2011 at 3:17 AM, Guzman Lugo, Fernando
fernando.l...@ti.com wrote:
On Wed, Feb 16, 2011 at 1:35 PM, David Cohen daco
On Wed, Feb 23, 2011 at 10:09 PM, Sakari Ailus
sakari.ai...@maxwell.research.nokia.com wrote:
Guzman Lugo, Fernando wrote:
Hi,
Hi Fernando,
In OMAP4 the cortex M3 is a double core processor and as each core is
running they own version of the RTOS we threat them independently. So
our driver
On Wed, Feb 23, 2011 at 11:48 PM, Guzman Lugo, Fernando
fernando.l...@ti.com wrote:
On Wed, Feb 23, 2011 at 2:56 PM, Sakari Ailus
sakari.ai...@maxwell.research.nokia.com wrote:
David Cohen wrote:
On Wed, Feb 23, 2011 at 3:39 PM, Guzman Lugo, Fernando
fernando.l...@ti.com wrote:
On Wed, Feb
On Mon, Feb 21, 2011 at 7:27 PM, Oleg Nesterov o...@redhat.com wrote:
On 02/21, Oleg Nesterov wrote:
On 02/21, Peter Zijlstra wrote:
afaict its needed because struct signal_struct and struct sighand_struct
include a wait_queue_head_t. The inclusion seems to come through
completion.h,
On Mon, Feb 21, 2011 at 10:22 AM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Mon, Feb 21, 2011 at 10:18:56AM +0200, Hiroshi DOYU wrote:
From: David Cohen daco...@gmail.com
Subject: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault
handling
Date: Wed, 16 Feb 2011 21:35:51 +0200
On Mon, Feb 21, 2011 at 10:18 AM, Hiroshi DOYU hiroshi.d...@nokia.com wrote:
From: David Cohen daco...@gmail.com
Subject: [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault
handling
Date: Wed, 16 Feb 2011 21:35:51 +0200
Add support to register an isr for IOMMU fault situations
wake_up*() macros are used.
Signed-off-by: David Cohen daco...@gmail.com
---
include/linux/sched.h | 61 +-
include/linux/task_sched.h | 64
include/linux/wait.h |1 +
3 files changed, 66
: *** [drivers] Error 2
This file defines macros wake_up*() which use TASK_* defined on linux/sched.h.
But sched.h cannot be included on wait.h due to a circular dependency between
both files. This patch fixes such compilation and the circular dependency
problem.
Br,
David
---
David Cohen (1):
headers
On Mon, Feb 21, 2011 at 9:36 AM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Sat, Feb 19, 2011 at 06:04:58PM +0200, David Cohen wrote:
I have to disagree. The fundamental problem is the circular dependency
between those two files:
sched.h uses wait_queue_head_t defined in wait.h
wait.h
On Mon, Feb 21, 2011 at 1:05 PM, Alexey Dobriyan adobri...@gmail.com wrote:
On Mon, Feb 21, 2011 at 12:20 PM, David Cohen daco...@gmail.com wrote:
Currently sched.h and wait.h have circular dependency between both.
wait.h defines macros wake_up*() which use macros TASK_* defined by
sched.h
On Mon, Feb 21, 2011 at 3:57 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Mon, Feb 21, 2011 at 03:51:25PM +0200, Alexey Dobriyan wrote:
I rather have the split done and kill the circular dependency.
It's not circular for starters.
how come ? wait.h depends on sched and sched.h depends on
: *** [drivers] Error 2
This file defines macros wake_up*() which use TASK_* defined on linux/sched.h.
But sched.h cannot be included on wait.h due to a circular dependency between
both files. This patch fixes such compilation and the circular dependency
problem.
Br,
David
---
David Cohen (1):
headers
wake_up*() macros are used.
Signed-off-by: David Cohen daco...@gmail.com
---
include/linux/sched.h | 58 +-
include/linux/task_state.h | 61
include/linux/wait.h |1 +
3 files changed, 63
On Mon, Feb 21, 2011 at 5:54 PM, Peter Zijlstra pet...@infradead.org wrote:
On Mon, 2011-02-21 at 16:38 +0200, David Cohen wrote:
Currently sched.h and wait.h have circular dependency between both.
wait.h defines macros wake_up*() which use macros TASK_* defined by
sched.h. But as sched.h
On Mon, Feb 21, 2011 at 8:43 PM, Ramirez Luna, Omar omar.rami...@ti.com wrote:
Hi,
Hi,
Thanks for the comments.
On Wed, Feb 16, 2011 at 1:35 PM, David Cohen daco...@gmail.com wrote:
diff --git a/arch/arm/mach-omap2/iommu2.c b/arch/arm/mach-omap2/iommu2.c
index 49a1e5e..adb083e 100644
Hi Sakari and Felipe,
On Tue, Feb 15, 2011 at 2:17 PM, Sakari Ailus
sakari.ai...@maxwell.research.nokia.com wrote:
Felipe Balbi wrote:
Hi,
On Tue, Feb 15, 2011 at 12:50:12PM +0100, Thomas Weber wrote:
Hello Felipe,
in include/linux/wait.h
#define wake_up(x) __wake_up(x,
On Sat, Feb 19, 2011 at 5:00 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
On Sat, Feb 19, 2011 at 01:35:09PM +0200, David Cohen wrote:
aha, now I get it, so shouldn't the real fix be including linux/sched.h
on linux/wait.h, I mean, it's linuux/wait.h who uses a symbol
defined in linux/sched.h
On Sat, Feb 19, 2011 at 2:44 AM, David Cohen daco...@gmail.com wrote:
On Sat, Feb 19, 2011 at 1:33 AM, David Cohen daco...@gmail.com wrote:
Hi,
On Fri, Feb 18, 2011 at 7:08 PM, Lesly A M lesl...@ti.com wrote:
Workaround for TWL5030 Silicon Errata 27 28:
27 - VDD1, VDD2, may have
);
+
+ if (twl5030_si_ver TWL5030_REV_1_2)
+ return true;
+ else
+ return false;
No need to if...else here. You can:
return twl5030_si_ver TWL5030_REV_1_2;
Regards,
David Cohen
+}
+
void __init twl4030_power_init(struct twl4030_power_data *twl4030_scripts)
{
int
description? For me it's something like:
Add missing brackets to if statement.
Br,
David Cohen
Signed-off-by: Lesly A M lesl...@ti.com
Cc: Nishanth Menon n...@ti.com
Cc: David Derrick dderr...@ti.com
Cc: Samuel Ortiz sa...@linux.intel.com
---
drivers/mfd/twl4030-power.c | 3 ++-
1
this point.
Br,
David Cohen
+}
+EXPORT_SYMBOL(twl5030_get_si_ver);
+
static struct device *
add_numbered_child(unsigned chip, const char *name, int num,
void *pdata, unsigned pdata_len,
diff --git a/include/linux/i2c/twl.h b/include/linux/i2c/twl.h
index f4bd475..5d3f2bf 100644
;
return 0.
Regards,
David Cohen
+}
+
/* Sets up all the VDD related info for OMAP4 */
static int __init omap4_vdd_data_configure(struct omap_vdd_info *vdd)
{
@@ -983,8 +1331,8 @@ static int __init omap4_vdd_data_configure(struct
omap_vdd_info *vdd)
if (!vdd-pmic_info
On Sat, Feb 19, 2011 at 1:33 AM, David Cohen daco...@gmail.com wrote:
Hi,
On Fri, Feb 18, 2011 at 7:08 PM, Lesly A M lesl...@ti.com wrote:
Workaround for TWL5030 Silicon Errata 27 28:
27 - VDD1, VDD2, may have glitches when their output value is updated.
28 - VDD1
On Tue, Feb 15, 2011 at 5:10 PM, David Cohen daco...@gmail.com wrote:
On Tue, Feb 15, 2011 at 4:48 PM, Hiroshi DOYU hiroshi.d...@nokia.com wrote:
Hi David,
Hi Hiroshi,
Sorry for a bit late reply
You're just in time. :)
From: David Cohen daco...@gmail.com
Subject: [PATCH v2 1/1
, IOMMU user may debug much more useful information
and/or react to go back to a valid state.
Br,
David
---
David Cohen (2):
OMAP2+: IOMMU: don't print fault warning on specific layer
OMAP: IOMMU: add support to callback during fault handling
arch/arm/mach-omap2/iommu2.c| 33
IOMMU upper layer and user are responsible to handle a fault and to
define whether it will end up as an error or not. OMAP2+ specific
layer should not print anything in such case.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/mach-omap2/iommu2.c | 16
1 files
Add support to register an isr for IOMMU fault situations and adapt it
to allow such (*isr)() to be used as fault callback. Drivers using IOMMU
module might want to be informed when errors happen in order to debug it
or react.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/mach-omap2
Declaration of exported function 'iopgtable_lookup_entry' is missing from
header file. Currently we have a sparse warning as it's not being used
externally. Adding its declaration to avoid such warning and allow its usage
in future.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/plat
IOMMU upper layer is already printing error message. OMAP2+ specific
layer may print error message only for debug purpose.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/mach-omap2/iommu2.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach
such issue.
With a fault callback, IOMMU user may debug much more useful information
and/or react to go back to a valid state.
Br,
David
---
David Cohen (2):
OMAP2+: IOMMU: change OMAP2+ error message to dev_dbg()
OMAP: IOMMU: add support to callback during fault handling
arch/arm/mach
Add support to register a callback for IOMMU fault situations. Drivers using
IOMMU module might want to be informed when such errors happen in order to
debug it or react.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/mach-omap2/iommu2.c| 21 +--
arch/arm
A missing prefix in the cover letter's subject. It's: OMAP: IOMMU:
Br,
David
On Tue, Feb 15, 2011 at 3:20 PM, David Cohen daco...@gmail.com wrote:
Hi,
This patch set adds fault callback support to allow IOMMU users to debug or
react when a fault happens.
IOMMU faults might be very
On Tue, Feb 15, 2011 at 3:38 PM, Sergei Shtylyov sshtyl...@mvista.com wrote:
Hello.
Hi,
On 15-02-2011 16:20, David Cohen wrote:
IOMMU upper layer is already printing error message. OMAP2+ specific
layer may print error message only for debug purpose.
Signed-off-by: David Cohendaco
On Tue, Feb 15, 2011 at 3:56 PM, Sergei Shtylyov sshtyl...@mvista.com wrote:
On 15-02-2011 16:44, David Cohen wrote:
IOMMU upper layer is already printing error message. OMAP2+ specific
layer may print error message only for debug purpose.
Signed-off-by: David Cohendaco...@gmail.com
On Tue, Feb 15, 2011 at 3:59 PM, Jarkko Nikula jhnik...@gmail.com wrote:
On Tue, 15 Feb 2011 15:44:27 +0200
David Cohen daco...@gmail.com wrote:
@@ -163,13 +163,13 @@ static u32 omap2_iommu_fault_isr(struct iommu *obj,
u32 *ra)
da = iommu_read_reg(obj, MMU_FAULT_AD);
*ra
not so useful
debug message and does not notice user about such issue.
With a fault callback, IOMMU user may debug much more useful information
and/or react to go back to a valid state.
Br,
David
---
David Cohen (1):
OMAP: IOMMU: add support to callback during fault handling
arch/arm/mach-omap2
Add support to register a callback for IOMMU fault situations. Drivers using
IOMMU module might want to be informed when such errors happen in order to
debug it or react.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/mach-omap2/iommu2.c| 21 +--
arch/arm
On Tue, Feb 15, 2011 at 4:29 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
On Tue, Feb 15, 2011 at 04:38:32PM +0300, Sergei Shtylyov wrote:
diff --git a/arch/arm/mach-omap2/iommu2.c b/arch/arm/mach-omap2/iommu2.c
index 14ee686..4244a07 100644
--- a/arch/arm/mach-omap2/iommu2.c
On Tue, Feb 15, 2011 at 4:08 PM, David Cohen daco...@gmail.com wrote:
On Tue, Feb 15, 2011 at 3:59 PM, Jarkko Nikula jhnik...@gmail.com wrote:
On Tue, 15 Feb 2011 15:44:27 +0200
David Cohen daco...@gmail.com wrote:
@@ -163,13 +163,13 @@ static u32 omap2_iommu_fault_isr(struct iommu *obj
On Tue, Feb 15, 2011 at 4:44 PM, Russell King - ARM Linux
li...@arm.linux.org.uk wrote:
On Tue, Feb 15, 2011 at 04:36:26PM +0200, David Cohen wrote:
But pr_cont() would be wrong in case of DEBUG isn't set, isn't it?
Yes. One other solution you could do is:
char buf[80], *p = buf
On Tue, Feb 15, 2011 at 4:48 PM, Hiroshi DOYU hiroshi.d...@nokia.com wrote:
Hi David,
Hi Hiroshi,
Sorry for a bit late reply
You're just in time. :)
From: David Cohen daco...@gmail.com
Subject: [PATCH v2 1/1] OMAP: IOMMU: add support to callback during fault
handling
Date: Tue, 15
On Mon, Feb 14, 2011 at 12:36 AM, Varadarajan, Charulatha ch...@ti.com wrote:
On Sat, Feb 12, 2011 at 19:09, David Cohen daco...@gmail.com wrote:
Function declaration 'iopgtable_lookup_entry' is missing from header
file.
Is this done because of any error?
You may add a comment on why
On Mon, Feb 14, 2011 at 12:33 AM, Varadarajan, Charulatha ch...@ti.com wrote:
On Sat, Feb 12, 2011 at 18:42, David Cohen daco...@gmail.com wrote:
Generic IOMMU errors code are necessary to handle errors on generic
layer.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/plat-omap
On Mon, Feb 14, 2011 at 3:50 PM, Laurent Pinchart
laurent.pinch...@ideasonboard.com wrote:
Hi Felipe,
Hello,
On Monday 14 February 2011 14:41:16 Felipe Balbi wrote:
On Mon, Feb 14, 2011 at 02:19:24PM +0100, Laurent Pinchart wrote:
On Monday 14 February 2011 13:35:59 Felipe Balbi wrote:
On Mon, Feb 14, 2011 at 3:18 PM, Felipe Balbi ba...@ti.com wrote:
Hi,
Hi
On Mon, Feb 14, 2011 at 02:07:08PM +0100, Laurent Pinchart wrote:
diff --git a/arch/arm/mach-omap2/devices.h
b/arch/arm/mach-omap2/devices.h new file mode 100644
index 000..12ddb8a
--- /dev/null
+++
OMAP IOMMU generic layer doesn't need ot print function name during
error messages. Print module name instead which is more useful.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/plat-omap/iommu.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm
,
David
---
David Cohen (3):
OMAP: IOMMU: Add generic IOMMU errors code
OMAP2+: IOMMU: change OMAP2+ error message to dev_dbg()
OMAP: IOMMU: add support to callback during fault handling
arch/arm/mach-omap2/iommu2.c| 23 ++---
arch/arm/plat-omap/include/plat/iommu.h
Generic IOMMU errors code are necessary to handle errors on generic
layer.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/plat-omap/include/plat/iommu.h |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-omap/include/plat/iommu.h
b/arch/arm
IOMMU upper layer is already printing error message. OMAP2+ specific
layer may print error message only for debug purpose.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/mach-omap2/iommu2.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2
Add support to register a callback for IOMMU fault situations. Drivers using
IOMMU module might want to be informed when such errors happen in order to
debug it or react.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/mach-omap2/iommu2.c| 21 +--
arch/arm
Function declaration 'iopgtable_lookup_entry' is missing from header
file.
Signed-off-by: David Cohen daco...@gmail.com
---
arch/arm/plat-omap/include/plat/iommu.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/plat-omap/include/plat/iommu.h
b/arch/arm/plat
On Mon, Jan 31, 2011 at 09:16:30PM -0600, ext Ramirez Luna, Omar wrote:
Hi David,
Hi Ramirez,
Thanks for the comments.
On Mon, Jan 31, 2011 at 11:25 AM, David Cohen david.co...@nokia.com wrote:
IOMMU error messages are duplicated. They're printed on IOMMU specific
layer for OMAP2,3
From: David Cohen david@dhcppc2.(none)
Hi,
OMAP IOMMU prints error messages twice. These patches remove the error
message from the OMAP2,3 specific implementation and let them to be
printed on the above layer only.
Br,
David
---
David Cohen (2):
OMAP: Add generic IOMMU errors code
OMAP
1 - 100 of 112 matches
Mail list logo
