Re: [PATCH v3 00/23] Unrestricted media entity ID range support

2015-12-27 Thread Laurent Pinchart
/* Clocks */ > ret = iss_map_mem_resource(pdev, iss, OMAP4_ISS_MEM_TOP); > - if (ret < 0) > + if (ret < 0) { > + dev_err(iss->dev, "Unable to map memory resource\n"); > goto error; > + } > > ret = iss_get_clocks(iss); > - if (ret < 0) > + if (ret < 0) { > + dev_err(iss->dev, "Unable to get clocks\n"); > goto error; > + } > > - if (!omap4iss_get(iss)) > + if (!omap4iss_get(iss)) { > + dev_err(iss->dev, "Failed to acquire ISS resource\n"); > goto error; > + } > > ret = iss_reset(iss); > - if (ret < 0) > + if (ret < 0) { > + dev_err(iss->dev, "Unable to reset ISS\n"); > goto error_iss; > + } > > iss->revision = iss_reg_read(iss, OMAP4_ISS_MEM_TOP, ISS_HL_REVISION); > dev_info(iss->dev, "Revision %08x found\n", iss->revision); -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] video:omapdrm: make omapdrm assume the tv-out cable is always connected

2015-11-13 Thread Laurent Pinchart
for a reason, to describe connectors for which we can't get any status information. The situation is different for DPI, DBI, SDI and DSI as those are on-board busses that connect to a non-removable panel, so we can say with a good confidence that the panel is connected (the situati

Re: [PATCH 1/2] ARM: OMAP2+: Remove legacy OMAP3 ISP instantiation

2015-11-09 Thread Laurent Pinchart
Hi Tony, On Monday 12 October 2015 10:05:59 Tony Lindgren wrote: > * Tony Lindgren <t...@atomide.com> [150914 09:37]: > > * Suman Anna <s-a...@ti.com> [150914 09:33]: > >> On 09/03/2015 05:34 PM, Suman Anna wrote: > >>> On 07/16/2015 07:58 AM, Tony

Re: [PATCH 12/13] [media] omap3isp: Support for deferred probing when requesting DMA channel

2015-11-09 Thread Laurent Pinchart
turned is not > -EPROBE_DEFER, otherwise return from the probe with the -EPROBE_DEFER. > > Signed-off-by: Peter Ujfalusi <peter.ujfal...@ti.com> > CC: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > CC: Mauro Carvalho Chehab <mche...@osg.samsung.com> &

Re: [PATCH] OMAPDSS: DISPC: Remove boolean comparisons

2015-10-15 Thread Laurent Pinchart
Hi Luis, Thank you for the patch. On Thursday 15 October 2015 13:29:38 Luis de Bethencourt wrote: > Boolean tests do not need explicit comparison to true or false. > > Signed-off-by: Luis de Bethencourt <lui...@osg.samsung.com> Acked-by: Laurent Pinchart <laurent.pinch..

Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity

2015-10-13 Thread Laurent Pinchart
Hi Shawn, On Tuesday 13 October 2015 22:09:46 Shawn Guo wrote: > On Tue, Oct 13, 2015 at 12:12:29AM +0300, Laurent Pinchart wrote: > > Laurent Pinchart (37): > ... > > > ARM: imx6sx-sdb: Fix typo in regulator enable GPIO property > > ... > > > ARM: dt

[PATCH] ARM: dts: omap3-igep: Use OMAP3_CORE1_IOPAD pinmux macro

2015-10-13 Thread Laurent Pinchart
Use the macro instead of absolute register offsets to make the code more readable as the values now match register addresses from the datasheet. Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- arch/arm/boot/dts/omap3-igep.dts

[PATCH 2/2] ARM: dts: omap3-igep0020: Remove duplicate uart2 pinmux

2015-10-12 Thread Laurent Pinchart
uart2 pinmux is already defined in omap3-igep0020-common.dtsi, remove the duplicate node. Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- arch/arm/boot/dts/omap3-igep0020.dts | 9 - 1 file changed, 9 deletions(-) diff --git a/arch/arm/boot/dts/omap3-igep00

[PATCH 1/2] ARM: dts: omap3-igep: Fix indentation

2015-10-12 Thread Laurent Pinchart
Use tabs instead of spaces for indentation. Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- arch/arm/boot/dts/omap3-igep.dtsi | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/bo

[PATCH 01/37] ARM: dts: am437x-gp-evm: Remove unneeded regulator property

2015-10-12 Thread Laurent Pinchart
The enable-active-high regulator property only makes sense when an enable GPIO is specified. Remove it. Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- arch/arm/boot/dts/am437x-gp-evm.dts | 1 - 1 file changed, 1 deletion(-) Cc: linux-omap@vger.kernel.org Cc:

[PATCH 09/37] ARM: dts: omap3-tao3530: Remove invalid enable-active-low regulator property

2015-10-12 Thread Laurent Pinchart
The property isn't part of the regulator-fixed DT bindings and isn't used by the driver. Remove it. Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- arch/arm/boot/dts/omap3-tao3530.dtsi | 1 - 1 file changed, 1 deletion(-) Cc: linux-omap@vger.kernel.org Cc: Benoit C

[PATCH 33/37] ARM: dts: omap3-tao3530: Fix regulator enable GPIO polarity

2015-10-12 Thread Laurent Pinchart
The enable GPIO is active low, but is flagged as active high in the gpio property. As the gpio property flags are currently unused by the driver this doesn't cause any issue for now, but will break later if the driver starts making use of the flags. Fix it. Signed-off-by: Laurent Pinchart

[PATCH 08/37] ARM: dts: omap3-sb-t35: Remove invalid enable-active-low regulator property

2015-10-12 Thread Laurent Pinchart
The property isn't part of the regulator-fixed DT bindings and isn't used by the driver. Remove it. Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- arch/arm/boot/dts/omap3-sb-t35.dtsi | 1 - 1 file changed, 1 deletion(-) Cc: linux-omap@vger.kernel.org Cc: Benoit C

[PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity

2015-10-12 Thread Laurent Pinchart
g> Cc: Thierry Reding <thierry.red...@gmail.com> Cc: Alexandre Courbot <gnu...@gmail.com> Cc: Liam Girdwood <lgirdw...@gmail.com> Cc: Mark Brown <broo...@kernel.org> Cc: Linus Walleij <linus.wall...@linaro.org> Laurent Pinchart (37): ARM: dts: am437x-gp-evm: Remove

[PATCH 28/37] ARM: dts: omap4-duovero: Fix regulator enable GPIO polarity

2015-10-12 Thread Laurent Pinchart
The enable GPIO is active high, but is flagged as active low in the gpio property. As the gpio property flags are currently unused by the driver this doesn't cause any issue for now, but will break later if the driver starts making use of the flags. Fix it. Signed-off-by: Laurent Pinchart

[PATCH 02/37] ARM: dts: am43xx-epos-evm: Remove unneeded regulator property

2015-10-12 Thread Laurent Pinchart
The enable-active-high regulator property only makes sense when an enable GPIO is specified. Remove it. Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- arch/arm/boot/dts/am43x-epos-evm.dts | 1 - 1 file changed, 1 deletion(-) Cc: linux-omap@vger.kernel.org Cc:

[PATCH 31/37] ARM: dts: omap3-beagle: Fix regulator enable GPIO polarity

2015-10-12 Thread Laurent Pinchart
The enable GPIO is active low, but is flagged as active high in the gpio property. As the gpio property flags are currently unused by the driver this doesn't cause any issue for now, but will break later if the driver starts making use of the flags. Fix it. Signed-off-by: Laurent Pinchart

[PATCH 30/37] ARM: dts: omap3-beagle-xm: Fix regulator enable GPIO polarity

2015-10-12 Thread Laurent Pinchart
The enable GPIO is active low, but is flagged as active high in the gpio property. As the gpio property flags are currently unused by the driver this doesn't cause any issue for now, but will break later if the driver starts making use of the flags. Fix it. Signed-off-by: Laurent Pinchart

[PATCH 32/37] ARM: dts: omap3-overo-base: Fix regulator enable GPIO polarity

2015-10-12 Thread Laurent Pinchart
The enable GPIO is active low, but is flagged as active high in the gpio property. As the gpio property flags are currently unused by the driver this doesn't cause any issue for now, but will break later if the driver starts making use of the flags. Fix it. Signed-off-by: Laurent Pinchart

[PATCH 07/37] ARM: dts: omap3-evm: Remove invalid enable-active-low regulator property

2015-10-12 Thread Laurent Pinchart
The property isn't part of the regulator-fixed DT bindings and isn't used by the driver. Remove it. Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- arch/arm/boot/dts/omap3-evm-common.dtsi | 1 - 1 file changed, 1 deletion(-) Cc: linux-omap@vger.kernel.org Cc:

Re: [PATCH 1/2] ARM: dts: omap3-igep: Fix indentation

2015-10-12 Thread Laurent Pinchart
Hi Javier, On Tuesday 13 October 2015 00:26:58 Javier Martinez Canillas wrote: > On Mon, Oct 12, 2015 at 10:46 PM, Laurent Pinchart wrote: > > Use tabs instead of spaces for indentation. > > > > Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> >

Re: [PATCH 00/37] ARM: dts: Fix fixed regulators enable GPIO polarity

2015-10-12 Thread Laurent Pinchart
Hi Javier, On Tuesday 13 October 2015 00:19:20 Javier Martinez Canillas wrote: > On 10/12/2015 11:46 PM, Tony Lindgren wrote: > > * Laurent Pinchart <laurent.pinch...@ideasonboard.com> [151012 14:17]: > >> Hello, > >> > >> While working on regulators,

Re: [PATCH] dmaengine: omap-dma: Add support for memcpy

2015-09-08 Thread Laurent Pinchart
49 insertions(+), 2 deletions(-) -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 02/11] iommu/omap: Remove all module references

2015-07-21 Thread Laurent Pinchart
. The comment will be removed after the OMAP3 ISP and OMAP IOMMU drivers get support for a saner IOMMU probing dependency order solution. The code seems fine to me. Reviewed-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/iommu/omap-iommu.c | 19 +-- 1 file

Re: [PATCH 07/11] iommu/omap: Remove unnecessary error traces on alloc failures

2015-07-21 Thread Laurent Pinchart
to remove the error messages is that memory allocation failures will already be reported in the kernel log by the memory management code. No big deal though, Reviewed-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/iommu/omap-iommu.c | 8 ++-- 1 file changed, 2 insertions

Re: [PATCH 01/11] Documentation: dt: Add #iommu-cells info to OMAP iommu bindings

2015-07-21 Thread Laurent Pinchart
it looks good to me. Reviewed-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- Documentation/devicetree/bindings/iommu/ti,omap-iommu.txt | 6 ++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/iommu/ti,omap-iommu.txt b/Documentation/devicetree

Re: [PATCH 04/11] iommu/omap: Protect omap-iopgtable.h against double inclusion

2015-07-21 Thread Laurent Pinchart
Hi Suman, Thank you for the patch. On Monday 20 July 2015 17:33:26 Suman Anna wrote: Protect the omap-pgtable.h header against double inclusion in source code by using the standard include guard mechanism. Signed-off-by: Suman Anna s-a...@ti.com Reviewed-by: Laurent Pinchart laurent.pinch

[PATCH 0/2] omap3isp: Remove legacy platform data support

2015-07-16 Thread Laurent Pinchart
of view it would be easier to merge the whole series through the linux-media tree. Tony, would that be fine with you ? If so could you please ack patch 1/2 ? Laurent Pinchart (2): ARM: OMAP2+: Remove legacy OMAP3 ISP instantiation v4l: omap3isp: Drop platform data support arch/arm/mach-omap2

[PATCH 1/2] ARM: OMAP2+: Remove legacy OMAP3 ISP instantiation

2015-07-16 Thread Laurent Pinchart
The OMAP3 ISP is now fully supported in DT, remove its instantiation from C code. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- arch/arm/mach-omap2/devices.c | 53 --- arch/arm/mach-omap2/devices.h | 19 2 files

[PATCH 2/2] v4l: omap3isp: Drop platform data support

2015-07-16 Thread Laurent Pinchart
Platforms using the OMAP3 ISP have all switched to DT, drop platform data support. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/platform/Kconfig | 2 +- drivers/media/platform/omap3isp/isp.c | 133 --- drivers/media

Re: [PATCH 1/2] ARM: OMAP2+: Remove legacy OMAP3 ISP instantiation

2015-07-16 Thread Laurent Pinchart
Hi Sakari, On Thursday 16 July 2015 18:45:22 Sakari Ailus wrote: Laurent Pinchart wrote: The OMAP3 ISP is now fully supported in DT, remove its instantiation from C code. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- arch/arm/mach-omap2/devices.c | 53

Re: [PATCH] drm/tilcdc: Implement dma-buf support for tilcdc

2015-06-30 Thread Laurent Pinchart
like it :-) Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/gpu/drm/tilcdc/tilcdc_drv.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c index 0f283a3..4908c1f

Re: [PATCH 0/7] OMAPDSS: use components (fix probing problems)

2015-06-16 Thread Laurent Pinchart
OMAPDSS: fix dss_init_ports error handling OMAPDSS: remove uses of __init/__exit OMAPDSS: reorder uninit calls OMAPDSS: componentize omapdss OMAPDSS: simplify submodule reg/unreg code I've quickly reviewed the whole series and it looks good to me. Acked-by: Laurent Pinchart

Re: [PATCH] [media] omap4iss: avoid broken OMAP4 dependency

2015-04-12 Thread Laurent Pinchart
, - OMAP4_CTRL_MODULE_PAD_CORE_CONTROL_CAMERA_RX); + WARN_ON(1); /* Reset used lane count */ csi2-phy-used_data_lanes = 0; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info

[PATCH] v4l: omap4iss: Replace outdated OMAP4 control pad API with syscon

2015-04-12 Thread Laurent Pinchart
. Lookup the syscon instance by compatible name for now as the OMAP4 ISS driver doesn't support DT yet. Fixes: efde234674d9 (ARM: OMAP4+: control: remove support for legacy pad read/write) Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/staging/media/omap4iss/Kconfig

Re: [PATCH] v4l: omap4iss: Replace outdated OMAP4 control pad API with syscon

2015-04-12 Thread Laurent Pinchart
Hi Sakari, Thank you for the review. On Sunday 12 April 2015 17:31:09 Sakari Ailus wrote: On Sun, Apr 12, 2015 at 03:28:13PM +0300, Laurent Pinchart wrote: diff --git a/drivers/staging/media/omap4iss/iss_csiphy.c b/drivers/staging/media/omap4iss/iss_csiphy.c index 7c3d55d..748607f 100644

Re: [PATCH 07/14] media: omap3isp: remove unused clkdev

2015-04-07 Thread Laurent Pinchart
Hello Russell, On Sunday 05 April 2015 15:20:34 Russell King - ARM Linux wrote: On Sat, Apr 04, 2015 at 12:44:35AM +0300, Laurent Pinchart wrote: Hi Russell, Thank you for the patch; On Friday 03 April 2015 18:12:58 Russell King wrote: No merged platform supplies xclks via

Re: [PATCH 07/14] media: omap3isp: remove unused clkdev

2015-04-07 Thread Laurent Pinchart
Hi Russell, On Tuesday 07 April 2015 13:45:36 Russell King - ARM Linux wrote: On Tue, Apr 07, 2015 at 12:42:52PM +0300, Laurent Pinchart wrote: On Sunday 05 April 2015 15:20:34 Russell King - ARM Linux wrote: On Sat, Apr 04, 2015 at 12:44:35AM +0300, Laurent Pinchart wrote: Hi Russell

[PATCH v1.1 07/14] media: omap3isp: remove unused clkdev

2015-04-03 Thread Laurent Pinchart
From: Russell King rmk+ker...@arm.linux.org.uk No merged platform supplies xclks via platform data. As we want to slightly change the clkdev interface, rather than fixing this unused code, remove it instead. Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk Signed-off-by: Laurent Pinchart

Re: [PATCH 07/14] media: omap3isp: remove unused clkdev

2015-04-03 Thread Laurent Pinchart
...@arm.linux.org.uk Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com with one caveat though : it conflicts with patches queued for v4.1 in the media tree. I'll post a rebased version in a reply to your e-mail. How would you like to handle the conflict ? --- drivers/media/platform

Re: [PATCH v1.1 14/15] omap3isp: Add support for the Device Tree

2015-03-23 Thread Laurent Pinchart
; + } + + isd-asd.match_type = V4L2_ASYNC_MATCH_OF; + notifier-num_subdevs++; + } + + return notifier-num_subdevs; +} -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH v1.1 13/15] v4l: of: Read lane-polarities endpoint property

2015-03-22 Thread Laurent Pinchart
unused lanes are ignored, i.e. only the polarity of the used lanes is specified. Also rework reading the data-lanes property a little. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- since v1: - Rename lane-polarity

Re: [PATCH 14/15] omap3isp: Add support for the Device Tree

2015-03-16 Thread Laurent Pinchart
) lanes = buscfg-bus.ccp2.lanecfg; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 15/15] omap3isp: Deprecate platform data support

2015-03-16 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Monday 16 March 2015 02:26:10 Sakari Ailus wrote: Print a warning when the driver is used with platform data. Existing platform data user should move to DT now. s/user/users/ Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart

Re: [PATCH 12/15] dt: bindings: Add lane-polarity property to endpoint nodes

2015-03-16 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Monday 16 March 2015 02:26:07 Sakari Ailus wrote: Add lane-polarity property to endpoint nodes. This essentially tells that the order of the differential signal wires is inverted. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent

Re: [PATCH 13/15] v4l: of: Read lane-polarity endpoint property

2015-03-16 Thread Laurent Pinchart
this be lane_polarities ? And, thinking about it, should the DT property be renamed to lane-polarities as well ? This would match data-lanes. }; /** -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 1/4] arm: dts: omap3: Extend the syscon register range

2015-03-15 Thread Laurent Pinchart
instead. The omap3isp driver did not support DT so no driver change is needed in this patch. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- arch/arm/boot/dts/omap3.dtsi |2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH 3/4] arm: dts: omap3: Add DT entries for OMAP 3

2015-03-15 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Monday 16 March 2015 02:01:19 Sakari Ailus wrote: The resources the ISP needs are slightly different on 3[45]xx and 3[67]xx. Especially the phy-type property is different. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart

Re: [PATCH 4/4] arm: dts: n950, n9: Add primary camera support

2015-03-15 Thread Laurent Pinchart
; + crc = 1; + lane-polarity = 1 1 1; + }; + }; + }; +}; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org

Re: [PATCH 2/4] dt: bindings: Add bindings for omap3isp

2015-03-15 Thread Laurent Pinchart
instead of 1 here. Apart from that, Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com + #clock-cells = 1; + ports { + #address-cells = 1; + #size-cells = 0

Re: [PATCH] media: omap3isp: hist: Move histogram DMA to DMA engine

2015-03-12 Thread Laurent Pinchart
Hi Sakari, Thank you for the review. On Friday 13 March 2015 01:56:32 Sakari Ailus wrote: On Sun, Mar 08, 2015 at 11:37:55PM +0200, Laurent Pinchart wrote: ... @@ -198,24 +177,58 @@ static void hist_dma_cb(int lch, u16 ch_status, void *data) static int hist_buf_dma(struct ispstat

[PATCH] media: omap3isp: hist: Move histogram DMA to DMA engine

2015-03-08 Thread Laurent Pinchart
Replace the custom OMAP DMA API usage by DMA engine. Feature-wise the driver has lost the ability to get notified of DMA transfers failure through the completion handler, as the DMA engine API doesn't expose that status information. Signed-off-by: Laurent Pinchart laurent.pinch

Re: [RFC 10/18] omap3isp: Move the syscon register out of the ISP register maps

2015-03-07 Thread Laurent Pinchart
); + isp-syscon_offset = isp_res_maps[m].syscon_offset; + isp-phy_type = isp_res_maps[m].phy_type; You could move those two lines after the error check to keep the check closer to the source of error. Apart from that, Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com

Re: [RFC 11/18] omap3isp: Replace many MMIO regions by two

2015-03-07 Thread Laurent Pinchart
it at two occasions, and keep the rest of the layout of the register space internal to the omap3isp driver. Signed-off-by: Sakari Ailus sakari.ai...@iki.fi Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- arch/arm/mach-omap2/devices.c | 66 +-- arch/arm

Re: [PATCH 06/21] drm/omap: check CRTC color format earlier

2015-03-04 Thread Laurent Pinchart
the more intrusive atomic update rework). I'll push the resulting branch shortly and will send the patches for review. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 06/21] drm/omap: check CRTC color format earlier

2015-03-04 Thread Laurent Pinchart
, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 01/10] media: omap3isp: remove unused clkdev

2015-03-02 Thread Laurent Pinchart
to this patch. Sakari, does it conflict with the omap3isp DT support ? If so, how would you prefer to resolve the conflict ? Russell, would it be fine to merge this through Mauro's tree ? Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/platform/omap3isp/isp.c

Re: [PATCH 01/10] media: omap3isp: remove unused clkdev

2015-03-02 Thread Laurent Pinchart
Hi Russell, On Monday 02 March 2015 23:54:35 Russell King - ARM Linux wrote: (Combining replies...) On Tue, Mar 03, 2015 at 12:53:37AM +0200, Sakari Ailus wrote: Hi Laurent and Russell, On Tue, Mar 03, 2015 at 12:33:44AM +0200, Laurent Pinchart wrote: Sakari, does it conflict

Re: [RFC PATCH 2/2] of/clk: use clkops-clocks to specify clocks handled by clock_ops domain

2014-12-12 Thread Laurent Pinchart
Hi Grygorii, I've found this mail deep inside my inbox :-) On Wednesday 30 July 2014 16:25:31 Grygorii Strashko wrote: On 07/30/2014 03:06 AM, Laurent Pinchart wrote: On Monday 28 July 2014 23:52:34 Grant Likely wrote: On Mon, Jul 28, 2014 at 11:47 AM, Grygorii Strashko wrote: On 07/28

Re: [RFC PATCH 2/2] of/clk: use clkops-clocks to specify clocks handled by clock_ops domain

2014-12-12 Thread Laurent Pinchart
Hi Kevin, On Monday 08 September 2014 13:13:25 Kevin Hilman wrote: Laurent Pinchart laurent.pinch...@ideasonboard.com writes: On Monday 28 July 2014 23:52:34 Grant Likely wrote: On Mon, Jul 28, 2014 at 11:47 AM, Grygorii Strashko wrote: On 07/28/2014 05:05 PM, Grant Likely wrote

Re: [PATCH v2 12/17] iommu/omap: Integrate omap-iommu-debug into omap-iommu

2014-10-22 Thread Laurent Pinchart
debugfs support is built alongside the OMAP IOMMU driver only when this option is enabled. Signed-off-by: Suman Anna s-a...@ti.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/iommu/Kconfig| 12 ++--- drivers/iommu/omap-iommu-debug.c | 100

Re: [PATCH 12/17] iommu/omap: Integrate omap-iommu-debug into omap-iommu

2014-10-01 Thread Laurent Pinchart
the OMAP IOMMU driver, and enabled automatically only when debugfs is enabled. That's the part I'm unsure about. We're loosing the ability to save space by not building the omap-iommu debugfs support when debugfs is enabled. For the rest of the series, Acked-by: Laurent Pinchart

Re: [PATCH 1/2] iommu/omap: Reverse dependency between omap-iommu and omap-iommu2

2014-09-20 Thread Laurent Pinchart
Hi Suman, On Tuesday 09 September 2014 17:31:44 Suman Anna wrote: On Tuesday 09 September 2014 16:33:11 Suman Anna wrote: On 09/09/2014 10:45 AM, Laurent Pinchart wrote: The OMAP IOMMU driver supports both the OMAP1 and OMAP2+ IOMMU variants by splitting the driver into a core module

[PATCH 1/2] iommu/omap: Reverse dependency between omap-iommu and omap-iommu2

2014-09-09 Thread Laurent Pinchart
. As the arch-specific operations pointer is now initialized at probe time, this change requires turning it from a global variable into a per-device variable. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/iommu/omap-iommu-debug.c | 6 ++- drivers/iommu/omap-iommu.c | 94

[PATCH 0/2] OMAP IOMMU cleanups

2014-09-09 Thread Laurent Pinchart
Hello, Those two patches clean up the OMAP IOMMU driver. Please see individual commit messages for more information. Laurent Pinchart (2): iommu/omap: Reverse dependency between omap-iommu and omap-iommu2 iommu/omap: Remove omap_iommu unused owner field drivers/iommu/omap-iommu-debug.c

[PATCH 2/2] iommu/omap: Remove omap_iommu unused owner field

2014-09-09 Thread Laurent Pinchart
The owner field is never set. Remove it. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/iommu/omap-iommu.c | 11 --- drivers/iommu/omap-iommu.h | 1 - 2 files changed, 12 deletions(-) diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c

Re: [PATCH 1/2] iommu/omap: Reverse dependency between omap-iommu and omap-iommu2

2014-09-09 Thread Laurent Pinchart
Hi Suman, On Tuesday 09 September 2014 16:33:11 Suman Anna wrote: On 09/09/2014 10:45 AM, Laurent Pinchart wrote: The OMAP IOMMU driver supports both the OMAP1 and OMAP2+ IOMMU variants by splitting the driver into a core module and a thin arch-specific operations module. (In practice

Re: [PATCH 2/2] iommu/omap: Fix iommu archdata name for DT-based devices

2014-09-05 Thread Laurent Pinchart
that rework the IOMMU core for better DT integration, have you seen them ? Can you point out the thread? Are you talking about http://marc.info/?l=linux-arm-kernelm=140968072117851w=2? Yes that's the one. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCHv2 1/2] iommu/omap: Check for valid archdata in attach_dev

2014-09-05 Thread Laurent Pinchart
that the device has valid archdata before accessing different SoC-specific fields of the archdata. This prevents a NULL pointer dereference on any misconfigured devices. Signed-off-by: Suman Anna s-a...@ti.com Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/iommu

Re: [PATCHv2 2/2] iommu/omap: Fix iommu archdata name for DT-based devices

2014-09-05 Thread Laurent Pinchart
assigned the name of the IOMMU user device, instead of the name of the IOMMU device as required by the attach logic. Fix this issue so that DT-based devices can attach successfully to an IOMMU domain. Signed-off-by: Suman Anna s-a...@ti.com Acked-by: Laurent Pinchart laurent.pinch

Re: [PATCH 1/2] iommu/omap: Check for valid archdata in attach_dev

2014-09-04 Thread Laurent Pinchart
-lock); + if (!arch_data) { + dev_err(dev, device doesn't have an associated iommu\n); + ret = -EINVAL; + goto out; + } You can move this check outside of the spinlock-protected section. With that change, Acked-by: Laurent Pinchart laurent.pinch

Re: [PATCH 2/2] iommu/omap: Fix iommu archdata name for DT-based devices

2014-09-04 Thread Laurent Pinchart
, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] video: fix composite video connector compatible string

2014-09-02 Thread Laurent Pinchart
-connector is a bit too generic name, as it doesn't even hint at video. * it's clear that this has never worked, which means no one has used those bindings, which should make it safe to change this. Signed-off-by: Tomi Valkeinen tomi.valkei...@ti.com Reported-by: Laurent Pinchart laurent.pinch

Re: [PATCHv2 27/27] OMAPDSS: connector-analog-tv: Add DT support

2014-08-26 Thread Laurent Pinchart
, + .of_match_table = tvc_of_match, }, }; -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC PATCH 2/2] of/clk: use clkops-clocks to specify clocks handled by clock_ops domain

2014-08-04 Thread Laurent Pinchart
Hi Geert, On Monday 04 August 2014 13:28:32 Geert Uytterhoeven wrote: On Wed, Jul 30, 2014 at 2:06 AM, Laurent Pinchart wrote: The third option would require storing the clocks lists in device drivers. I believe this is our best option, as a trade-off between simplicity and versatility

Re: [PATCH] ARM: dts: set 'ti,set-rate-parent' for dpll4_m5x2 clock

2014-07-30 Thread Laurent Pinchart
On Wednesday 30 July 2014 15:40:33 Tero Kristo wrote: On 07/16/2014 03:29 AM, Laurent Pinchart wrote: On Tuesday 15 July 2014 12:02:35 Stefan Herbrechtsmeier wrote: Set 'ti,set-rate-parent' property for the dpll4_m5x2_ck clock, which is used for the ISP functional clock. This fixes

Re: [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform

2014-07-29 Thread Laurent Pinchart
On Wednesday 23 July 2014 14:29:36 Kishon Vijay Abraham I wrote: On Monday 21 July 2014 08:45 PM, Felipe Balbi wrote: On Mon, Jul 21, 2014 at 05:04:57PM +0200, Laurent Pinchart wrote: Hi Felipe, What happened to these two patches ? looks like I lost them. On Monday 16 December

Re: [RFC PATCH 2/2] of/clk: use clkops-clocks to specify clocks handled by clock_ops domain

2014-07-29 Thread Laurent Pinchart
at the series before I comment. I've flagged it and will hopefully look at it tomorrow. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v2 0/3] iommu: Remove OMAP IOVMM driver

2014-07-23 Thread Laurent Pinchart
in your trees. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 0/3] iommu: Remove OMAP IOVMM driver

2014-07-22 Thread Laurent Pinchart
Hi Joerg, (Your attention is kindly requested in time for v3.17, please see below) On Monday 21 July 2014 23:19:29 Tony Lindgren wrote: * Laurent Pinchart laurent.pinch...@ideasonboard.com [140721 11:17]: On Monday 21 July 2014 02:33:36 Tony Lindgren wrote: * Laurent Pinchart laurent.pinch

Re: [PATCH v3 0/2] usb: fix controller-PHY binding for OMAP3 platform

2014-07-21 Thread Laurent Pinchart
-- 15 files changed, 61 insertions(+), 15 deletions(-) -- Regards, Laurent Pinchart signature.asc Description: This is a digitally signed message part.

Re: [PATCH v2 0/3] iommu: Remove OMAP IOVMM driver

2014-07-21 Thread Laurent Pinchart
Hi Tony and Joerg, On Monday 21 July 2014 02:33:36 Tony Lindgren wrote: * Laurent Pinchart laurent.pinch...@ideasonboard.com [140721 02:16]: Hi Suman, Joerg and Tony, On Friday 18 July 2014 11:53:56 Suman Anna wrote: On 07/18/2014 05:49 AM, Laurent Pinchart wrote: Hello

[PATCH v2 0/3] iommu: Remove OMAP IOVMM driver

2014-07-18 Thread Laurent Pinchart
- Remove omap_iommu da_start and da_end fields - Added patches 2/3 and 3/3 Laurent Pinchart (3): iommu/omap: Remove virtual memory manager ARM: omap: Don't set iommu pdata da_start and da_end fields iommu/omap: Remove platform data da_start and da_end fields arch/arm/mach-omap2/omap-iommu.c

[PATCH v2 2/3] ARM: omap: Don't set iommu pdata da_start and da_end fields

2014-07-18 Thread Laurent Pinchart
The fields are not used by the driver and will be removed from platform data. Don't set them. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- arch/arm/mach-omap2/omap-iommu.c | 2 -- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 4 arch/arm/mach-omap2

[PATCH v2 3/3] iommu/omap: Remove platform data da_start and da_end fields

2014-07-18 Thread Laurent Pinchart
The fields were used by the now gone omap-iovmm driver. They're not used anymore, remove them. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- include/linux/platform_data/iommu-omap.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/include/linux/platform_data/iommu

[PATCH v2 1/3] iommu/omap: Remove virtual memory manager

2014-07-18 Thread Laurent Pinchart
The OMAP3 ISP driver was the only user of the OMAP IOVMM API. Now that is has been ported to the DMA API, remove the unused virtual memory manager. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/iommu/Kconfig| 10 +- drivers/iommu/Makefile

Re: [PATCH] iommu/omap: Remove virtual memory manager

2014-07-18 Thread Laurent Pinchart
Hi Suman, Thank you for the review. On Thursday 17 July 2014 10:53:03 Suman Anna wrote: On 07/17/2014 06:09 AM, Laurent Pinchart wrote: The OMAP3 ISP driver was the only user of the OMAP IOVMM API. Now that is has been ported to the DMA API, remove the unused virtual memory manager

[PATCH] iommu/omap: Remove virtual memory manager

2014-07-17 Thread Laurent Pinchart
The OMAP3 ISP driver was the only user of the OMAP IOVMM API. Now that is has been ported to the DMA API, remove the unused virtual memory manager. Signed-off-by: Laurent Pinchart laurent.pinch...@ideasonboard.com --- Joerg, could you please pick this patch up for v3.17 if possible ? drivers

Re: [PATCH] media:platform: OMAP3 camera support needs VIDEOBUF2_DMA_CONTIG

2014-07-17 Thread Laurent Pinchart
/linux/drivers/media/platform/omap3isp/ispvideo.c:1381: undefined reference to `vb2_dma_contig_cleanup_ctx' make: *** [vmlinux] Error 1 Signed-off-by: Peter Meerwald pme...@pmeerw.net Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com and applied to my tree, with the select

Re: [PATCH] ARM: dts: set 'ti,set-rate-parent' for dpll4_m5x2 clock

2014-07-15 Thread Laurent Pinchart
the rate to be propagated properly to the divider node (dpll4_m5_ck). Signed-off-by: Stefan Herbrechtsmeier ste...@herbrechtsmeier.net Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com Cc: Tony Lindgren t...@atomide.com Cc: Tero Kristo t-kri...@ti.com Cc: linux-me...@vger.kernel.org Cc

Re: [PATCH] [media] staging: allow omap4iss to be modular

2014-06-13 Thread Laurent Pinchart
Hi Tony, On Thursday 12 June 2014 22:30:44 Tony Lindgren wrote: * Laurent Pinchart laurent.pinch...@ideasonboard.com [140612 08:32]: On Thursday 12 June 2014 08:15:35 Tony Lindgren wrote: * Laurent Pinchart laurent.pinch...@ideasonboard.com [140612 07:52]: On Wednesday 11 June 2014 07:47

Re: [PATCH] [media] staging: allow omap4iss to be modular

2014-06-13 Thread Laurent Pinchart
Hi Tony, On Friday 13 June 2014 00:53:25 Tony Lindgren wrote: * Laurent Pinchart laurent.pinch...@ideasonboard.com [140612 23:48]: On Thursday 12 June 2014 22:30:44 Tony Lindgren wrote: 1. They live in separate hardware modules that can be clocked separately Actually I don't think

Re: [PATCH] [media] staging: allow omap4iss to be modular

2014-06-13 Thread Laurent Pinchart
Hi Tony, On Friday 13 June 2014 04:10:12 Tony Lindgren wrote: * Laurent Pinchart laurent.pinch...@ideasonboard.com [140613 03:30]: On Friday 13 June 2014 00:53:25 Tony Lindgren wrote: * Laurent Pinchart laurent.pinch...@ideasonboard.com [140612 23:48]: On Thursday 12 June 2014 22:30:44

Re: [PATCH] [media] staging: allow omap4iss to be modular

2014-06-12 Thread Laurent Pinchart
-by: Arnd Bergmann a...@arndb.de Acked-by: Laurent Pinchart laurent.pinch...@ideasonboard.com Should I take this in my tree for v3.17 or would you like to fast-track it ? diff --git a/drivers/staging/media/omap4iss/Kconfig b/drivers/staging/media/omap4iss/Kconfig index 78b0fba..8afc6fe 100644

Re: [PATCH] [media] staging: allow omap4iss to be modular

2014-06-12 Thread Laurent Pinchart
the syscon mapping seems like the best option. I'll give it a try. -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [media] staging: allow omap4iss to be modular

2014-06-12 Thread Laurent Pinchart
Hi Arnd, On Thursday 12 June 2014 16:28:39 Arnd Bergmann wrote: On Thursday 12 June 2014 07:25:15 Greg KH wrote: On Thu, Jun 12, 2014 at 04:15:32PM +0200, Arnd Bergmann wrote: On Thursday 12 June 2014 16:12:17 Laurent Pinchart wrote: From 3a965f4fd5a6b3ef4a66aa4e7c916cfd34fd5706 Mon

Re: [PATCH] [media] staging: allow omap4iss to be modular

2014-06-12 Thread Laurent Pinchart
Hi Tony, On Thursday 12 June 2014 08:15:35 Tony Lindgren wrote: * Laurent Pinchart laurent.pinch...@ideasonboard.com [140612 07:52]: On Wednesday 11 June 2014 07:47:54 Tony Lindgren wrote: These should just use either pinctrl-single.c instead for muxing. Or if they are not mux registers

Re: video_omap4 and control module access (was ... from opensuse-arm list)

2014-06-05 Thread Laurent Pinchart
. On 06/05/2014 11:17 AM, Nishanth Menon wrote: On 06/05/2014 10:56 AM, Laurent Pinchart wrote: On Thursday 05 June 2014 08:37:27 Nishanth Menon wrote: On 06/05/2014 08:29 AM, Takashi Iwai wrote: Alexander Graf wrote: On 04.06.14 09:28, Matwey V. Kornilov wrote: On 19.05.2014 14:02

Re: [PATCHv2 resend 00/11] improve PWM lookup support without device tree

2014-05-19 Thread Laurent Pinchart
Hi Alexandre and Simon, On Tuesday 20 May 2014 07:39:13 Simon Horman wrote: [ CCed Laurent Pinchart ] The renesas and shmobile portions of this seem reasonable to me and I have checked that there do not seem to be any conflicts with changes I already have queued up for v3.16 (and v3.17

Re: [PATCH 0/2] ARM: dts: Fix OMAP3 ISP functional clock configuration

2014-05-15 Thread Laurent Pinchart
On Monday 12 May 2014 18:06:10 Tony Lindgren wrote: * Laurent Pinchart laurent.pinch...@ideasonboard.com [140512 16:17]: On Thursday 08 May 2014 13:57:15 Tomi Valkeinen wrote: On 21/04/14 13:41, Laurent Pinchart wrote: Hello, This patch set enables rate propagation from

  1   2   3   4   5   6   >