Re: [PATCH v2 0/5] mfd: twl6030-irq: rework and add twl6032 support

2013-08-20 Thread Samuel Ortiz
On Tue, Aug 20, 2013 at 08:13:54AM +0100, Graeme Gregory wrote: On 20/08/13 02:01, Samuel Ortiz wrote: Hi Grygorii, On Thu, Jul 25, 2013 at 04:15:46PM +0300, Grygorii Strashko wrote: This patch series intorduces twl6030-irq module rework to use Threaded IRQ and linear irq_domain, and adds

Re: [PATCH v2 0/5] mfd: twl6030-irq: rework and add twl6032 support

2013-08-19 Thread Samuel Ortiz
Hi Grygorii, On Thu, Jul 25, 2013 at 04:15:46PM +0300, Grygorii Strashko wrote: This patch series intorduces twl6030-irq module rework to use Threaded IRQ and linear irq_domain, and adds support for PMIC TWL6032 IRQs. After this patch series TWL6030/6032 IRQs will be supported only for DT

Re: [PATCH 4/4] regulator: Palmas: Add TPS659038 support

2013-06-27 Thread Samuel Ortiz
Hi, On Thu, Jun 20, 2013 at 04:32:15PM +0530, J Keerthy wrote: Add TPS659038 support. Signed-off-by: J Keerthy j-keer...@ti.com Acked-by: Mark Brown broo...@linaro.org --- drivers/regulator/palmas-regulator.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Applied to mfd-next,

Re: [PATCH 2/4] MFD: Palmas: Add TPS659038 PMIC support

2013-06-24 Thread Samuel Ortiz
detection, Vibrator, USB OTG are missing when compared to TWL6035. Signed-off-by: J Keerthy j-keer...@ti.com Acked-by: Samuel Ortiz sa...@linux.intel.com --- drivers/mfd/palmas.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) Applied, thanks. Cheers, Samuel. -- Intel

Re: [PATCH] MFD: Change TWL6025 references to TWL6032

2013-06-20 Thread Samuel Ortiz
Hi Oleksandr, On Wed, Jun 19, 2013 at 03:24:02PM +0300, Oleksandr Kozaruk wrote: From: Graeme Gregory g...@slimlogic.co.uk The TWL6025 was never released beyond sample form and was replaced by the PhoenixLite range of chips - TWL6032. Change the references to reference the TWL6032 class and

Re: [PATCH v3 0/4] MFD: Palmas: Add TPS659038 PMIC support on Palmas

2013-06-20 Thread Samuel Ortiz
Hi, On Wed, Jun 19, 2013 at 11:27:46AM +0530, Keerthy wrote: From: J Keerthy j-keer...@ti.com The Patch series adds TPS659038 PMIC support in the palmas MFD and Regulator drivers. The TPS659038 has almost the same registers as of the earlier supported variants of PALMAS family such as the

Re: [PATCH v3 3/4] mfd: Palmas: Add TPS659038 PMIC support

2013-06-20 Thread Samuel Ortiz
insertions(+), 0 deletions(-) This one does not apply against mfd-next as I don't have the palmas.txt. For Grant to take this one: Acked-by: Samuel Ortiz sa...@linux.intel.com If that creates conflicts (I already have a few palmas.c changes) then we'll have to find a way to fix them (Me taking

Re: [PATCH v3 2/4] MFD: Palmas: Add SMPS10_BOOST feature

2013-06-20 Thread Samuel Ortiz
Hi, On Thu, Jun 20, 2013 at 04:34:42AM +, J, KEERTHY wrote: -Original Message- From: J, KEERTHY Sent: Wednesday, June 19, 2013 11:28 AM To: linux-omap@vger.kernel.org Cc: broo...@kernel.org; J, KEERTHY; ldewan...@nvidia.com; sa...@linux.intel.com;

Re: [PATCH v3 2/4] MFD: Palmas: Add SMPS10_BOOST feature

2013-06-20 Thread Samuel Ortiz
On Thu, Jun 20, 2013 at 09:13:06AM +, J, KEERTHY wrote: Could you please pull this patch? I'm reverting this one for now as of_match_device is not define for !CONFIG_OF. So the of_match_device parts can come under #ifdef CONFIG_OF? Nevermind, you were just missing an of_device.h

Re: [PATCH] mfd: Palmas: Remove code which is not necessary for a device tree boot

2013-06-19 Thread Samuel Ortiz
Hi Lee, On Wed, Jun 19, 2013 at 09:26:33AM +0100, Lee Jones wrote: On Mon, 17 Jun 2013, J Keerthy wrote: Remove code which is not necessary for a device tree boot. So we're exclusively DT now right? Boot tested on OMAP5-UEVM board. Signed-off-by: J Keerthy j-keer...@ti.com ---

Re: [PATCH v2] mfd: Palmas: Remove code which is not necessary for a device tree boot

2013-06-17 Thread Samuel Ortiz
Hi, On Mon, Jun 17, 2013 at 05:17:58PM +0530, J Keerthy wrote: Remove code which is not necessary for a device tree boot. Boot tested on OMAP5-UEVM board. Signed-off-by: J Keerthy j-keer...@ti.com Acked-by: Laxman Dewangan ldewan...@nvidia.com Acked-by: Graeme Gregory

Re: [PATCH] mfd: twl4030: allow IRQ wake enable to succeed on subchip IRQs

2013-06-17 Thread Samuel Ortiz
Hi Kevin, On Fri, May 31, 2013 at 02:44:54PM -0700, Kevin Hilman wrote: The genirq IRQ wake method will default to failure if the irq_chip does not provide a set_wake method. However, for TWL4030 sub-chip IRQs, we want the wake enable to succeed even though we don't provide a set_wake

Re: am335x: TSC ADC reworking including DT pieces, take 5

2013-06-13 Thread Samuel Ortiz
Hi Sebastian, On Wed, Jun 12, 2013 at 06:58:01PM +0200, Sebastian Andrzej Siewior wrote: Hi Samuel, I did the cosmetic changes of the subject line and removed the changes from within the sob lines in each patch. I dropped the #define XPP STEPCONFIG_XPP thingy and patch #1 which removed

Re: am335x: TSC ADC reworking including DT pieces, take 5

2013-06-13 Thread Samuel Ortiz
Hi Sebastian, On Thu, Jun 13, 2013 at 11:25:26AM +0200, Sebastian Andrzej Siewior wrote: I fixed a couple of unused variable warnings on top of it. I saw your patch at git.k.o and I am asking you not to taking it :) I understand why now, I'll remove it. Sorry about that. Cheers, Samuel. --

Re: am335x: TSC ADC reworking including DT pieces, take 4

2013-06-12 Thread Samuel Ortiz
Hi Sebastian, On Wed, Jun 12, 2013 at 03:29:43PM +0200, Sebastian Andrzej Siewior wrote: On 06/11/2013 07:55 PM, Samuel Ortiz wrote: Hi Jonathan, Hi Samuel, Sebastian, please address the commit log and cosmetic issues I pointed out, keep the regmap code and I'll pull this patchset

Re: am335x: TSC ADC reworking including DT pieces, take 4

2013-06-12 Thread Samuel Ortiz
On Wed, Jun 12, 2013 at 04:02:00PM +0200, Sebastian Andrzej Siewior wrote: By keep the regmap code you mean I am allowed to remove the regmap usage in mfd (keep patch #1) or do you insist on adding its usage in iio and input? I insist on keeping it on the MFD driver, i.e. _not_ keeping

Re: [PATCH 04/22] input/ti_am33x_tsc: Order of TSC wires, made configurable

2013-06-11 Thread Samuel Ortiz
Hi Sebastian, On Tue, Jun 11, 2013 at 01:30:50PM +0200, Sebastian Andrzej Siewior wrote: diff --git a/include/linux/mfd/ti_am335x_tscadc.h b/include/linux/mfd/ti_am335x_tscadc.h index eeead15..2d78af8 100644 --- a/include/linux/mfd/ti_am335x_tscadc.h +++

Re: [PATCH 01/22] mfd/ti_am335x_tscadc: remove regmap

2013-06-11 Thread Samuel Ortiz
Hi Sebastian, On Tue, Jun 11, 2013 at 01:30:47PM +0200, Sebastian Andrzej Siewior wrote: The MFD part uses regmap without caching and is the only user of the regmap. The child drivers, that is input(touch) and iio(adc), use direct reg access. There is a patch which converts them to use regmap

Re: am335x: TSC ADC reworking including DT pieces, take 4

2013-06-11 Thread Samuel Ortiz
Hi Sebastian, On Tue, Jun 11, 2013 at 01:30:46PM +0200, Sebastian Andrzej Siewior wrote: I believe the whole thing should go via the MFD tree. It touches also input iio subsystem. I collected ACKs where I got some in the meantime. Please fix your commit logs, and your subject lines. It should

Re: [PATCH 10/22] mfd/ti_am335x_tscadc: Add DT support

2013-06-11 Thread Samuel Ortiz
Hi Sebastian, On Tue, Jun 11, 2013 at 01:30:56PM +0200, Sebastian Andrzej Siewior wrote: From: Patil, Rachna rac...@ti.com Make changes to add DT support in the MFD core driver. Which changes ? [ pa...@antoniou-consulting.com : use of_get_child_by_name instead of

Re: [PATCH 10/22] mfd/ti_am335x_tscadc: Add DT support

2013-06-11 Thread Samuel Ortiz
Hi Sebastian, On Tue, Jun 11, 2013 at 04:42:30PM +0200, Sebastian Andrzej Siewior wrote: In the end I would like not to post a patch with From: != me and don't make change which the original author did not do. Also dropping their authorship isn't nice. What could we agree on? You probably

Re: am335x: TSC ADC reworking including DT pieces, take 4

2013-06-11 Thread Samuel Ortiz
Hi Sebastian, On Tue, Jun 11, 2013 at 05:29:22PM +0200, Sebastian Andrzej Siewior wrote: Then, this is a pretty big patchset, with iio, input and mfd all mixed together and it is likely to create merge conflicts. They somehow depend on each other. Otherwise I would have sent three series,

Re: am335x: TSC ADC reworking including DT pieces, take 4

2013-06-11 Thread Samuel Ortiz
Hi Dmitry, On Tue, Jun 11, 2013 at 09:04:16AM -0700, Dmitry Torokhov wrote: On Tue, Jun 11, 2013 at 04:23:58PM +0200, Samuel Ortiz wrote: Hi Sebastian, On Tue, Jun 11, 2013 at 01:30:46PM +0200, Sebastian Andrzej Siewior wrote: I believe the whole thing should go via the MFD tree

Re: am335x: TSC ADC reworking including DT pieces, take 4

2013-06-11 Thread Samuel Ortiz
Hi Jonathan, On Tue, Jun 11, 2013 at 05:27:48PM +0100, Jonathan Cameron wrote: Samuel Ortiz sa...@linux.intel.com wrote: On Tue, Jun 11, 2013 at 09:04:16AM -0700, Dmitry Torokhov wrote: On Tue, Jun 11, 2013 at 04:23:58PM +0200, Samuel Ortiz wrote: Hi Sebastian, On Tue, Jun 11, 2013

Re: [PATCH 2/2] mfd: twl-core: convert to module_i2c_driver()

2013-05-16 Thread Samuel Ortiz
Hi Grygorii, On Tue, Apr 23, 2013 at 04:19:10PM +0300, Grygorii Strashko wrote: Shift TWL initialization to module/device init layer, because I2C now is not initialized on subsys init layer and shifted to module/device init layer instead. The I2C -- TWL dependency should be resolved in

Re: [RFC PATCH v2 1/4] retu-mfd: support also Tahvo

2013-04-18 Thread Samuel Ortiz
Cc: Samuel Ortiz sa...@linux.intel.com --- drivers/mfd/Kconfig |6 ++-- drivers/mfd/retu-mfd.c | 85 -- include/linux/mfd/retu.h |8 - 3 files changed, 85 insertions(+), 14 deletions(-) Simple and good enough, I applied this one

Re: [PATCH 0/6] mfd: omap-usb-host: Device tree support for 3.10

2013-04-09 Thread Samuel Ortiz
Hi Roger, On Mon, Mar 25, 2013 at 12:42:04PM +0200, Roger Quadros wrote: Hi Samuel, I've rebased this now on top of 3.9-rc4. Please pull this into your next branch when appropriate. Thanks. The following changes since commit 8bb9660418e05bb1845ac1a2428444d78e322cc7: Linux 3.9-rc4

Re: [PATCH 0/6] mfd: omap-usb-host: Device tree support for 3.10

2013-04-09 Thread Samuel Ortiz
On Tue, Apr 09, 2013 at 11:39:16AM +0300, Roger Quadros wrote: Samuel, You had the conflicts because a patch [*] was introduced and is not required since the reset logic is being removed from the driver. Anyways, I've rebased the 2 patches on top of mfd-next, so now it shouldn't matter.

Re: [RFC PATCH 1/4] retu-mfd: support also Tahvo

2013-04-08 Thread Samuel Ortiz
Cc: Samuel Ortiz sa...@linux.intel.com --- drivers/mfd/Kconfig |6 +-- drivers/mfd/retu-mfd.c | 95 +++--- include/linux/mfd/retu.h |8 +++- 3 files changed, 92 insertions(+), 17 deletions(-) Overall the patch looks good, but could you

Re: [GIT PULL] common: OMAP USB Host cleanup for 3.9

2013-02-14 Thread Samuel Ortiz
Hi Roger, On Thu, Feb 14, 2013 at 02:01:25PM +0200, Roger Quadros wrote: Hi Tony Samuel, This is the common patch for the OMAP USB Host cleanup series for 3.9. It makes changes to platform headers only. The other 2 pull requests, one for each of you will be based on this. This is based

Re: [PATCH v2 00/11] MFD: twl-core: Cleanup part 2 for 3.9

2013-02-03 Thread Samuel Ortiz
Hi Peter, On Wed, Jan 16, 2013 at 02:53:48PM +0100, Peter Ujfalusi wrote: Hello Samuel, Changes since v1: - Patch for zoom-display to avoid build issus with this set I had a patch on top of this series to move the zoom board to use bl-pwm for display backlight. Because of this I have not

Re: [PATCH v4 01/23] mfd: omap-usb-host: get rid of cpu_is_omap..() macros

2012-12-13 Thread Samuel Ortiz
. That is assuming nobody else is planning on merging this series for v3.8 presumably. This should go into 3.9, yes. Want to ack this one? Looks fine to me: Acked-by: Samuel Ortiz sa...@linux.intel.com Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com

Re: [PATCH v3 2/5] mfd: tps65217: Set PMIC to shutdown on PWR_EN toggle

2012-11-21 Thread Samuel Ortiz
Hi Anilkumar, On Tue, Nov 20, 2012 at 03:18:44PM +0530, AnilKumar Ch wrote: From: Colin Foe-Parker colin.foepar...@logicpd.com Set tps65217 PMIC status to OFF if power enable toggle is supported. By setting this bit to 1 to enter PMIC to OFF state when PWR_EN pin is pulled low. Also adds a

Re: [PATCH v4 2/4] mfd: introduce retu-mfd driver

2012-11-21 Thread Samuel Ortiz
access, IRQ handling and power off functions. Cc: Samuel Ortiz sa...@linux.intel.com Acked-by: Felipe Balbi ba...@ti.com Acked-by: Tony Lindgren t...@atomide.com Signed-off-by: Aaro Koskinen aaro.koski...@iki.fi --- drivers/mfd/Kconfig |9 ++ drivers/mfd/Makefile |1

Re: [PATCH 00/13] MFD: twl drivers: Convert to regmap IO and cleanups

2012-11-21 Thread Samuel Ortiz
Hi Peter, On Tue, Nov 13, 2012 at 09:28:41AM +0100, Peter Ujfalusi wrote: Hello, This series converts the twl-core to use regmap for IO towards the chip. With the conversion to regmap IO we no longer need to allocate bigger buffer for writes. I have appended patches to this series to

Re: [PATCH 1/1] twl4030: Fix chained irq handling on resume from suspend

2012-11-21 Thread Samuel Ortiz
Hi Kalle, On Tue, Oct 16, 2012 at 05:59:35PM +0300, Kalle Jokiniemi wrote: The irqs are enabled one-by-one in pm core resume_noirq phase. This leads to situation where the twl4030 primary interrupt handler (PIH) is enabled before the chained secondary handlers (SIH). As the PIH cannot clear

Re: [PATCH 08/16] ARM: OMAP2: Move plat/menelaus.h to linux/mfd/menelaus.h

2012-10-25 Thread Samuel Ortiz
Hi Tony, On Thu, Oct 04, 2012 at 03:04:52PM -0700, Tony Lindgren wrote: We can move menelaus.h to live with other mfd headers to get it out of plat for ARM common zImage support. Cc: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Tony Lindgren t...@atomide.com Acked-by: Samuel Ortiz sa

Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-01 Thread Samuel Ortiz
Hi Sourav, On Mon, Oct 01, 2012 at 04:31:22PM +0530, Sourav Poddar wrote: smsc ece1099 is a keyboard scan or gpio expansion device. The patch create keypad and gpio expander child for this multi function smsc driver. Tested on omap5430 evm with 3.6-rc6 custom kernel. Cc: Samuel Ortiz sa

Re: [PATCH v4 2/2] mfd: Add backlight as subdevice to the tps65217

2012-09-24 Thread Samuel Ortiz
Hi Matthias, On Mon, Sep 24, 2012 at 10:25:34PM +0200, Matthias Kaehlcke wrote: mfd: Add backlight as subdevice to the tps65217 Signed-off-by: Matthias Kaehlcke matth...@kaehlcke.net --- drivers/mfd/tps65217.c |3 +++ 1 file changed, 3 insertions(+) Applied, thanks. Cheers, Samuel.

Re: [PATCH v4 1/2] backlight: Add TPS65217 WLED driver

2012-09-24 Thread Samuel Ortiz
Hi Matthias, On Mon, Sep 24, 2012 at 10:25:28PM +0200, Matthias Kaehlcke wrote: The TPS65217 chip contains a boost converter and current sinks which can be used to drive LEDs for use as backlights. Expose this functionality via the backlight API. Tested on an AM335x based custom board with

Re: [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation

2012-09-21 Thread Samuel Ortiz
Hi Paul, On Wed, Sep 19, 2012 at 08:39:40PM +, Paul Walmsley wrote: Hi Samuel, I've queued patch 1 of this series for 3.7, which should go upstream via the OMAP - arm-soc path. Also asked Keshava to re-send patch 5 to me once patches 2-4 have been merged. It's up to you how to

Re: omap-usb-tll build broken in linux next

2012-09-21 Thread Samuel Ortiz
Hi Tony, On Thu, Sep 20, 2012 at 11:34:42AM -0700, Tony Lindgren wrote: Hi Keshava Felipe, Looks like we have something broken in linux next: make[2]: *** No rule to make target `drivers/mfd/omap-usb-tll.o', needed by `drivers/mfd/built-in.o'. Stop. This is at least with my n8x0

Re: [PATCH v2 0/3] MFD/GPIO: Add twl6040 GPO driver

2012-09-19 Thread Samuel Ortiz
Hi Peter, On Thu, Aug 16, 2012 at 03:13:12PM +0300, Peter Ujfalusi wrote: Hello, Changes since v1: - Removed the ti,use-gpo property from DT bindings - Register the GPO driver if we booted with DT blob or in legacy if the pdata for the GPO driver is present - DT binding Documentation

Re: [PATCH v2 0/3] MFD/GPIO: Add twl6040 GPO driver

2012-09-19 Thread Samuel Ortiz
Hi Peter, On Thu, Aug 16, 2012 at 03:13:12PM +0300, Peter Ujfalusi wrote: Hello, Changes since v1: - Removed the ti,use-gpo property from DT bindings - Register the GPO driver if we booted with DT blob or in legacy if the pdata for the GPO driver is present - DT binding Documentation

Re: [PATCH V4 0/5] ARM: OMAP: HOST: TLL driver implementation

2012-09-19 Thread Samuel Ortiz
Hi Keshava, On Mon, Jul 16, 2012 at 07:01:06PM +0530, Keshava Munegowda wrote: The TLL (Transceiver Less Link) is an separate IP block, independent of the host controller. Basically this TLL operates like USB PHY which allows the user to connect two USB transceiver interfaces together directly

Re: [PATCH v2] backlight: Add TPS65217 WLED driver

2012-09-19 Thread Samuel Ortiz
Hi Matthias, On Tue, Sep 18, 2012 at 10:05:07PM +0200, Matthias Kaehlcke wrote: The MFD API probably allows you to do exactly that by defining a specific cell for bl. Could you please try to use this API or otherwise justify not using it? you seem to have missed v3 of the patch which

Re: [RFC PATCH 2/5] mfd: introduce retu-mfd driver

2012-09-19 Thread Samuel Ortiz
Hi Aaro, On Wed, Aug 29, 2012 at 12:34:24AM +0300, Aaro Koskinen wrote: Retu is a multi-function device found on Nokia Internet Tablets implementing at least watchdog, RTC, headset detection and power button functionality. This patch implements a minimum functionality providing only

Re: [PATCH 2/4] mfd: introduce retu-mfd driver

2012-09-19 Thread Samuel Ortiz
Hi Aaro, On Mon, Sep 03, 2012 at 11:23:23PM +0300, Aaro Koskinen wrote: Retu is a multi-function device found on Nokia Internet Tablets implementing at least watchdog, RTC, headset detection and power button functionality. This patch implements minimum functionality providing register

Re: [PATCH v4 00/14] MFD/ASoC/Input: twl4030-audio submodule DT support

2012-09-18 Thread Samuel Ortiz
to take the whole thing, in which case you can add my: Acked-by: Samuel Ortiz sa...@linux.intel.com to the MFD patches. Please let me know how you'd like to proceed. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line

Re: [PATCH] mfd: Fix compile for twl-core.c by removing cpu_is_omap usage

2012-09-17 Thread Samuel Ortiz
...@canb.auug.org.au Cc: Paul Walmsley p...@pwsan.com Cc: Samuel Ortiz sa...@linux.intel.com Cc: Arnd Bergmann a...@arndb.de Cc: Olof Johansson o...@lixom.net Signed-off-by: Tony Lindgren t...@atomide.com --- Samuel, I'd like to queue this via arm-soc as that's where I have the breaking patch

Re: [PATCH v2] backlight: Add TPS65217 WLED driver

2012-09-16 Thread Samuel Ortiz
Hi Matthias, On Thu, Aug 09, 2012 at 10:42:31PM +0200, Matthias Kaehlcke wrote: The TPS65217 chip contains a boost converter and current sinks which can be used to drive LEDs for use as backlights. Expose this functionality via the backlight API. Tested on an AM335x based custom board with

Re: [PATCH v2] mfd/regulator: tps65217: Move regulator plat data handling to regulator

2012-08-22 Thread Samuel Ortiz
Hi AnilKumar, On Mon, Aug 13, 2012 at 08:36:05PM +0530, AnilKumar Ch wrote: Regulator platform data handling was mistakenly added to MFD driver. So we will see build errors if we compile MFD drivers without CONFIG_REGULATOR. This patch moves regulator platform data handling from TPS65217 MFD

Re: [PATCH] mfd/regulator: tps65217: Move regulator plat data handling to regulator

2012-07-27 Thread Samuel Ortiz
Hi Anilkumar, On Fri, Jul 20, 2012 at 03:00:01PM +0530, AnilKumar Ch wrote: Regulator platform data handling was mistakenly added to MFD driver. So we will see build errors if we compile MFD drivers without CONFIG_REGULATOR. This patch moves regulator platform data handling from TPS65217 MFD

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-11 Thread Samuel Ortiz
Hi Keshava, Kevin, On Fri, Jul 06, 2012 at 05:29:00PM +0530, Munegowda, Keshava wrote: Samuel I have sent that patch to disable the ehci in omap2plus_defconfig; after merging that please merge this patch too. This will fix the crashes in during boot with NFS in beagleXM I'm going

Re: [PATCH] MFD: twl-core: move device_init_wakeup to after platform_device_add.

2012-07-09 Thread Samuel Ortiz
Hi Neil, On Sat, Jul 07, 2012 at 08:51:03AM +1000, NeilBrown wrote: device_init_wakeup uses the dev_name() of the device to set the name of the wakeup_source which appears in /sys/kernel/debug/wakeup_sources. For a platform device, that name is not set until platform_device_add calls

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-05 Thread Samuel Ortiz
Hi Kevin, Keshava, On Wed, Jul 04, 2012 at 06:33:35AM -0700, Kevin Hilman wrote: Munegowda, Keshava keshava_mgo...@ti.com writes: On Tue, Jul 3, 2012 at 12:17 PM, Munegowda, Keshava keshava_mgo...@ti.com wrote: On Mon, Jul 2, 2012 at 10:24 PM, Kevin Hilman khil...@ti.com wrote: Felipe,

Re: [PATCH 07/29] mfd: omap-usb: use clk_prepare_enable and clk_disable_unprepare

2012-07-02 Thread Samuel Ortiz
Hi Rajendra, On Mon, Jul 02, 2012 at 04:46:21PM +0530, Rajendra Nayak wrote: Hi Samuel, On Monday 02 July 2012 04:48 PM, Samuel Ortiz wrote: Hi Rajendra, On Thu, Jun 14, 2012 at 06:16:56PM +0530, Rajendra Nayak wrote: As we move to Common clk framework use clk_prepare_enable() instead

Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

2012-07-02 Thread Samuel Ortiz
Hi Kevin, On Mon, Jul 02, 2012 at 10:55:39AM -0700, Kevin Hilman wrote: I'm also worried that the owners of this code are running out of time to fix these several serious regresions for v3.5. FYI, I only have one omap-usb fix queued for 3.5 in my for-linus branch, see

Re: [PATCH 07/29] mfd: omap-usb: use clk_prepare_enable and clk_disable_unprepare

2012-07-02 Thread Samuel Ortiz
Hi Rajendra, On Thu, Jun 14, 2012 at 06:16:56PM +0530, Rajendra Nayak wrote: As we move to Common clk framework use clk_prepare_enable() instead of clk_enable() and similarly clk_disable_unprepare() instead of clk_disable() Signed-off-by: Rajendra Nayak rna...@ti.com Cc: Samuel Ortiz sa

Re: [PATCH v3] ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset fix issues.

2012-07-02 Thread Samuel Ortiz
Hi Russ, On Thu, Jun 14, 2012 at 09:24:21AM -0700, Russ Dill wrote: From: Russ Dill russ.d...@gmail.com 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' (1fcb57d0) fixes an issue where the ULPI PHYs were not held in reset while initializing the EHCI controller. However, it also changes

Re: [PATCH 0/5 V2 RESEND] ARM: OMAP: TLL driver implementation for USB host driver

2012-07-02 Thread Samuel Ortiz
Hi Keshava, On Tue, Jun 26, 2012 at 04:56:02PM +0530, Keshava Munegowda wrote: The TLL configuration is removed from the UHH driver and implemented as a seperate platform driver. Now, the UHH driver configures the TLL through API's exported by the TLL platform driver. The TLL is an has

Re: [PATCHv2 1/4] MFD: palmas PMIC device support

2012-05-18 Thread Samuel Ortiz
the easiest thing is if I apply there? I'm fine with it. For the MFD parts: Acked-by: Samuel Ortiz sa...@linux.intel.com Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord

Re: [PATCH 2/2] mfd: twl: remove pdata-irq_base/_end, no more users

2012-05-11 Thread Samuel Ortiz
: Samuel Ortiz sa...@linux.intel.com Signed-off-by: Kevin Hilman khil...@ti.com Acked-by: Samuel Ortiz sa...@linux.intel.com Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message

Re: [PATCH 3/3] twl4030: enable wakeup on twl4030 IRQ.

2012-05-09 Thread Samuel Ortiz
Hi Neil, On Wed, Apr 25, 2012 at 01:05:24PM +1000, NeilBrown wrote: Most of the interrupts that come through this line should trigger wakeups: power button RTC alarm power available usb plug/unplug so mark the interrupt as a wakeup interrupt. This is particularly important for

Re: [PATCH 4/6] twl4030_charger: Allow charger to control the regulator that feeds it.

2012-05-09 Thread Samuel Ortiz
/mfd/twl-core.c |9 + drivers/power/twl4030_charger.c | 15 +++ 2 files changed, 20 insertions(+), 4 deletions(-) In case Anton has not taken that patchset yet: Acked-by: Samuel Ortiz sa...@linux.intel.com Cheers, Samuel. -- Intel Open Source Technology

Re: [PATCH] MFD: twl6040: Add regulator support for VIO, V2V1 supplies

2012-05-09 Thread Samuel Ortiz
Hi Peter, On Wed, May 02, 2012 at 04:54:42PM +0300, Peter Ujfalusi wrote: twl6040 has three power supply source: VBAT needs to be connected to VBAT, VIO, and V2V1. Add regulator support for the VIO, V2V1 supplies. Initially handle the two supply together with bulk commands. Signed-off-by:

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-05-07 Thread Samuel Ortiz
Hi Igor, On Sun, May 06, 2012 at 09:25:05AM +0300, Igor Grinberg wrote: Sorry, for being jumpy... Samuel has not answered yet (it has been more then two weeks already) Sorry about that. and I'd like this to go into 3.5. Then you may need a better changelog explaining how this fixes a

Re: [PATCH] ARM: OMAP: USB: fix warning on EHCI PHY reset path

2012-05-07 Thread Samuel Ortiz
Hi Igor, On Mon, May 07, 2012 at 02:46:35PM +0300, Igor Grinberg wrote: Hi Samuel, On 05/07/12 11:09, Samuel Ortiz wrote: Hi Igor, On Sun, May 06, 2012 at 09:25:05AM +0300, Igor Grinberg wrote: Sorry, for being jumpy... Samuel has not answered yet (it has been more then two weeks

Re: [PATCH] Fix build breakage in omap-usb-host.c

2012-05-01 Thread Samuel Ortiz
Hi Russ, On Sun, Apr 22, 2012 at 01:48:18AM -0700, Russ Dill wrote: 'ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue' removes the include for linux/gpio.h from omap-usb-host.c. This include indirectly includes plat/cpu.h which is required by omap-usb-host.c. Fix the build breakage by

Re: [PATCH] Fix build breakage in omap-usb-host.c

2012-04-30 Thread Samuel Ortiz
Hi Kevin, On Fri, Apr 27, 2012 at 01:36:28PM -0700, Kevin Hilman wrote: Samuel, Munegowda, Keshava keshava_mgo...@ti.com writes: On Sun, Apr 22, 2012 at 2:20 PM, Russ Dill russ.d...@ti.com wrote: On Sun, Apr 22, 2012 at 1:48 AM, Russ Dill russ.d...@ti.com wrote: 'ARM: OMAP3: USB: Fix

Re: [PATCH for 3.4] MFD: twl6040: Convert to i2c driver, and separate it from twl core

2012-04-16 Thread Samuel Ortiz
the kernel build (vibra, ASoC components). Signed-off-by: Peter Ujfalusi peter.ujfal...@ti.com Reviewed-by: Mark Brown broo...@opensource.wolfsonicro.com Acked-by: Tony Lindgren t...@atomide.com Acked-by: Samuel Ortiz sa...@linux.intel.com Acked-by: Dmitry Torokhov d...@mail.ru --- Hi Samuel

Re: [PATCH RESEND] ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue

2012-04-16 Thread Samuel Ortiz
Hi Keshava, On Wed, Apr 11, 2012 at 05:15:03PM +0530, Munegowda, Keshava wrote: On Tue, Mar 27, 2012 at 8:40 PM, Igor Grinberg grinb...@compulab.co.il wrote: On 03/19/12 08:42, Keshava Munegowda wrote: From: Keshava Munegowda keshava_mgo...@ti.com It is observed that the echi ports of

Re: [PATCH for 3.4] MFD: twl6040: Convert to i2c driver, and separate it from twl core

2012-04-12 Thread Samuel Ortiz
Hi Peter, On Thu, Apr 12, 2012 at 09:39:28AM +0300, Peter Ujfalusi wrote: Hi Samuel, Liam, Tony, Now rc2 is out, and the the OMAP4 audio is still broken. Can you please queue this patch for 3.4? I'm busy this week, but I'll queue this one up beginning of next week. I have several MFD fixes

Re: [PATCH RESEND] ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue

2012-03-27 Thread Samuel Ortiz
Hi Igor, On Tue, Mar 27, 2012 at 04:18:49PM +0200, Igor Grinberg wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Felipe, Samuel, On 03/20/12 17:55, Felipe Balbi wrote: On Tue, Mar 20, 2012 at 04:53:53PM +0100, Samuel Ortiz wrote: Hi Keshava, On Mon, Mar 19, 2012 at 12:12

Re: [PATCH RESEND] ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue

2012-03-20 Thread Samuel Ortiz
Hi Keshava, On Mon, Mar 19, 2012 at 12:12:47PM +0530, Keshava Munegowda wrote: From: Keshava Munegowda keshava_mgo...@ti.com It is observed that the echi ports of 3430 sdp board are not working due to the random timing of programming the associated GPIOs of the ULPI PHYs of the EHCI for

Re: [PATCH] ARM: OMAP3: USB: Fix the EHCI ULPI PHY reset issue

2012-03-16 Thread Samuel Ortiz
Hi Keshava, On Thu, Mar 08, 2012 at 08:30:21PM +0530, Munegowda, Keshava wrote: On Fri, Mar 2, 2012 at 7:36 PM, Munegowda, Keshava keshava_mgo...@ti.com wrote: On Fri, Feb 24, 2012 at 5:14 PM, Munegowda, Keshava keshava_mgo...@ti.com wrote: On Fri, Feb 24, 2012 at 3:46 PM, Felipe Balbi

Re: [PATCH 0/5] ARM: OMAP: TLL driver implementation for USB host driver

2012-03-16 Thread Samuel Ortiz
Hi Keshava, On Mon, Mar 05, 2012 at 08:13:45PM +0530, Munegowda, Keshava wrote: On Mon, Mar 5, 2012 at 8:01 PM, Keshava Munegowda keshava_mgo...@ti.com wrote: From: Keshava Munegowda keshava_mgo...@ti.com The TLL configuration is removed from the UHH driver and implemented as a

Re: Lost fixes?

2012-03-15 Thread Samuel Ortiz
On Thu, Mar 15, 2012 at 10:28:45AM +, Russell King - ARM Linux wrote: These fixes are a collection from other people which resolve various issues found with the new kautobuilder. They're now a month old, and as far as I can see, have not been merged into Linus' tree. What's the status

Re: [PATCH 0/5] MFD: Reverting twl6040 patches going for 3.4

2012-03-06 Thread Samuel Ortiz
Hi Peter, On Tue, Mar 06, 2012 at 02:35:11PM +0200, Peter Ujfalusi wrote: Hello Samuel, this series reverts the twl6040 related patches aimed for 3.4 merge window from MFD for-next branch. As we already discussed the relevant patches will be going through audio since we have some

Re: [PATCH 4/4] mmc: omap_hsmmc: Simplify init for twl6030 MMC card detect

2012-03-02 Thread Samuel Ortiz
Hi Tony, On Thu, Mar 01, 2012 at 10:55:35AM -0800, Tony Lindgren wrote: There's no need to use callbacks for this, we can do it directly between MMC driver and twl6030. Cc: Samuel Ortiz sa...@linux.intel.com Acked-by: Samuel Ortiz sa...@linux.intel.com Cheers, Samuel. -- Intel Open Source

Re: [PATCH 1/4] regulator: twl6030: add support for vdd1, vdd2 and vdd3 regulators

2012-03-02 Thread Samuel Ortiz
Cc: Samuel Ortiz sa...@linux.intel.com Acked-by: Samuel Ortiz sa...@linux.intel.com Mark, Liam, are you guys taking this one ? Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH] MFD: TWL 6030: clear IRQ status register only once

2012-02-27 Thread Samuel Ortiz
Hi Nishan, On Wed, Feb 22, 2012 at 08:03:45PM -0600, Nishanth Menon wrote: TWL6030 family of PMIC use a shadow interrupt status register while kernel processes the current interrupt event. However, any write(0 or 1) to register INT_STS_A, INT_STS_B or INT_STS_C clears all 3 interrupt status

Re: [PATCH] MFD: TWL 6030: make twl6030_irq_set_wake static

2012-02-27 Thread Samuel Ortiz
Hi Nishan, On Wed, Feb 22, 2012 at 08:03:59PM -0600, Nishanth Menon wrote: twl6030_irq_set_wake is not used anywhere else in the kernel except as irq_chip.irq_set_wake. No reason for it to be exported. Also fixes build warning: drivers/mfd/twl6030-irq.c:230:5: warning: symbol

Re: [PATCH 3/7] MFD: twl-core: regulator configuration for twl6030 V1V8, V2V1 SMPS

2012-02-23 Thread Samuel Ortiz
-by: Samuel Ortiz sa...@linux.intel.com Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 0/2] mfd: omap-usb-host: Minor omap-usb host fixes

2012-02-23 Thread Samuel Ortiz
Hi Govindraj, On Wed, Feb 15, 2012 at 03:53:32PM +0530, Govindraj.R wrote: From: Govindraj.R govindraj.r...@ti.com Minor fixes, boot tested on panda with ehci enabled. Patches based on 3.3-rc3 Govindraj.R (2): mfd: omap-usb-host: Remove magic numbers for dev dma mask mfd:

Re: [PATCH v3 0/3] MFD: twl6040: Conversion to i2c driver

2012-02-21 Thread Samuel Ortiz
sense to me, yes. Liam, if you're ok with taking it, please add my: Acked-by: Samuel Ortiz sa...@linux.intel.com to this patchset. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line unsubscribe linux-omap in the body

Re: [PATCH V4 1/2] MFD: TPS65217: Add new mfd device for TPS65217

2012-02-20 Thread Samuel Ortiz
Hi Anilkumar, On Wed, Jan 11, 2012 at 04:11:41PM +0530, AnilKumar Ch wrote: The TPS65217 chip is a power management IC for Portable Navigation Systems and Tablet Computing devices. It contains the following components: - Regulators - White LED - USB battery charger This patch adds

Re: [PATCH] mfd: twl4030: trivial code-style fixes

2012-02-20 Thread Samuel Ortiz
Hi Felipe, On Wed, Feb 01, 2012 at 03:02:48AM +0200, Felipe Contreras wrote: Signed-off-by: Felipe Contreras felipe.contre...@gmail.com Applied, thanks. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH v3 0/3] MFD: twl6040: Conversion to i2c driver

2012-02-20 Thread Samuel Ortiz
Hi Peter, On Fri, Feb 10, 2012 at 12:00:15PM +0200, Peter Ujfalusi wrote: Hello, Changes since v2: - soc/codec/Kconfig: make twl6040 depend on I2C - Regulator related patches has been removed (to be sent as separate series) I applied all 3 patches. Patch #2 did not apply cleanly, due to the

Re: [PATCH v2 7/7] MFD: TWL6040: Add regulator support for VIO, V2V1 supplies

2012-02-20 Thread Samuel Ortiz
Hi Peter, On Tue, Feb 07, 2012 at 03:01:18PM +0200, Peter Ujfalusi wrote: twl6040 has three power supply source: VBAT needs to be connected to VBAT, VIO, and V2V1. Add regulator support for the VIO, V2V1 supplies. Initially handle the two supply together with bulk commands. I applied this

Re: [PATCH v4 03/12] mfd: twl-core: Add initial DT support for twl4030/twl6030

2012-01-08 Thread Samuel Ortiz
Hi Benoit, On Tue, Jan 03, 2012 at 03:09:49PM +0100, Cousson, Benoit wrote: On 1/2/2012 10:04 AM, Grant Likely wrote: On Thu, Dec 22, 2011 at 03:56:37PM +0100, Benoit Cousson wrote: Add initial device-tree support for twl familly chips. The current version is missing the regulator entries

Re: [PATCH v4 03/12] mfd: twl-core: Add initial DT support for twl4030/twl6030

2011-12-22 Thread Samuel Ortiz
on platform_data information can be initialized properly. Add irqdomain support. Add documentation for the Texas Instruments TWL Integrated Chip. Signed-off-by: Benoit Cousson b-cous...@ti.com Cc: Balaji T K balaj...@ti.com Cc: Graeme Gregory g...@slimlogic.co.uk Cc: Samuel Ortiz sa

Re: [PATCHv8 4/5] twl4030: add support for external voltage get/set

2011-12-19 Thread Samuel Ortiz
a struct which contains function pointers for the set/get voltage operations, a data pointer for these, and the previously used features bitmask. Looks better than the previous versions. For the MFD part: Acked-by: Samuel Ortiz sa...@linux.intel.com Liam, I assume this is going through your tree

Re: [PATCH v2 03/10] mfd: twl-core: Add initial DT support for twl4030/twl6030

2011-12-19 Thread Samuel Ortiz
Hi Benoit, On Fri, Dec 09, 2011 at 03:02:34PM +0100, Benoit Cousson wrote: Add initial device-tree support for twl familly chips. The current version is missing the regulator entries due to the lack of DT regulator bindings for the moment. Only the simple sub-modules that do not depend on

Re: [PATCH 0/4] fixes for twl4030-irq in mainline

2011-12-13 Thread Samuel Ortiz
Hi Neil, On Tue, Dec 13, 2011 at 08:39:59AM +1100, NeilBrown wrote: The following 4 patches make it work for me and addresses some other less critical issues like a typo in a comment :-) Thanks, I applied all 4 of them. Thanks. I have a couple of other twl4030 patches, these ones

Re: [PATCH 0/4] fixes for twl4030-irq in mainline

2011-12-13 Thread Samuel Ortiz
Hi Felipe, On Tue, Dec 13, 2011 at 04:12:02PM +0200, Felipe Contreras wrote: Hi, On Mon, Dec 12, 2011 at 7:38 PM, Samuel Ortiz sa...@linux.intel.com wrote: On Sun, Nov 27, 2011 at 07:17:41AM +1100, NeilBrown wrote:   The recent tidying up of twl4030-irq seems to have left it broken

Re: [PATCH RESEND v2 0/2] PMIC TPS65910 fixes

2011-12-12 Thread Samuel Ortiz
Hi Mohamed, On Tue, Nov 08, 2011 at 06:53:35PM +0530, Afzal Mohammed wrote: Hi, This series applies over Kyle Manna's v3 patch series, https://lkml.org/lkml/2011/11/3/257, with changes as per comments on his/her 1/6 mfd: TPS65910: Handle non-existent devices Kyle has not updated the

Re: [PATCH 0/4] fixes for twl4030-irq in mainline

2011-12-12 Thread Samuel Ortiz
Hi Neil, On Sun, Nov 27, 2011 at 07:17:41AM +1100, NeilBrown wrote: Hi, The recent tidying up of twl4030-irq seems to have left it broken. At least it doesn't work for me on my gta04 (www.gta04.org). The first interrupt from the device freezes the whole system (by being constantly

Re: [PATCHv7 5/7] mfd: twl-core: pass driver data from pdata to add_regulator for VDD1 and VDD2

2011-12-12 Thread Samuel Ortiz
processor or default.) Signed-off-by: Tero Kristo t-kri...@ti.com Cc: Samuel Ortiz sa...@linux.intel.com --- drivers/mfd/twl-core.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c index 01ecfee..af93fce 100644

Re: [PATCH 1/2] mfd: twl6030: fix lockdep recursion warning on setting wake IRQs

2011-10-04 Thread Samuel Ortiz
Hi Todd, On Mon, Sep 26, 2011 at 04:44:23PM -0700, Todd Poynor wrote: LOCKDEP explicitly sets all irq_desc locks as a single lock-class, causing possible recursive locking detected when the TWL RTC driver calls through enable_irq_wake to twl6030_irq_set_wake, which recursively calls

  1   2   3   >