Re: [PATCH 13/15] OMAP: GPIO: cleanup _set_gpio_wakeup(), remove ifdefs

2011-05-03 Thread Kevin Hilman
Varadarajan, Charulatha ch...@ti.com writes: On Sat, Apr 23, 2011 at 04:32, Kevin Hilman khil...@ti.com wrote: Make _set_gpio_wakeup() generic by removing ifdefs.  Code for the various SoCs/bank-methods was already the same, except for the non-wakeup GPIO checking.  But that flag is set on a

Re: [PATCH 13/15] OMAP: GPIO: cleanup _set_gpio_wakeup(), remove ifdefs

2011-04-26 Thread Varadarajan, Charulatha
On Sat, Apr 23, 2011 at 04:32, Kevin Hilman khil...@ti.com wrote: Make _set_gpio_wakeup() generic by removing ifdefs.  Code for the various SoCs/bank-methods was already the same, except for the non-wakeup GPIO checking.  But that flag is set on a per-SoC basis, so can be used for all SoCs.

[PATCH 13/15] OMAP: GPIO: cleanup _set_gpio_wakeup(), remove ifdefs

2011-04-22 Thread Kevin Hilman
Make _set_gpio_wakeup() generic by removing ifdefs. Code for the various SoCs/bank-methods was already the same, except for the non-wakeup GPIO checking. But that flag is set on a per-SoC basis, so can be used for all SoCs. While here, use pr_err() and remove GPIO bank calculation assumption