Re: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-28 Thread Felipe Balbi
On Mon, Sep 27, 2010 at 04:48:04AM -0500, Sergei Shtylyov wrote: Hello. On 27-09-2010 10:07, Felipe Balbi wrote: I guess that's Felipe's call, but I don't like that option. I think it's cleaner to have the -set_clock hook be a noop on OMAP and the runtime hooks be noops on the other

Re: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-27 Thread Felipe Balbi
On Fri, Sep 24, 2010 at 09:49:34AM -0500, Sergei Shtylyov wrote: Hello. Felipe Balbi wrote: I guess that's Felipe's call, but I don't like that option. I think it's cleaner to have the -set_clock hook be a noop on OMAP and the runtime hooks be noops on the other platforms. Agreed. We

Re: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-27 Thread Sergei Shtylyov
Hello. On 27-09-2010 10:07, Felipe Balbi wrote: I guess that's Felipe's call, but I don't like that option. I think it's cleaner to have the -set_clock hook be a noop on OMAP and the runtime hooks be noops on the other platforms. Agreed. We should focus on removing -set_clock for .38

RE: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-24 Thread Kalliguddi, Hema
: Re: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb. Kalliguddi, Hema hem...@ti.com writes: -Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Thursday, September 23, 2010 9:00 PM To: Balbi, Felipe Cc: Kalliguddi, Hema; linux-omap

Re: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-24 Thread Felipe Balbi
Hi, On Fri, Sep 24, 2010 at 03:16:29AM -0500, Kalliguddi, Hema wrote: I guess that's Felipe's call, but I don't like that option. I think it's cleaner to have the -set_clock hook be a noop on OMAP and the runtime hooks be noops on the other platforms. I think the set_clock function was used

RE: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-24 Thread Kalliguddi, Hema
] usb : musb: Using runtime pm apis for musb. Hi, On Fri, Sep 24, 2010 at 03:16:29AM -0500, Kalliguddi, Hema wrote: I guess that's Felipe's call, but I don't like that option. I think it's cleaner to have the -set_clock hook be a noop on OMAP and the runtime hooks be noops on the other platforms

RE: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-24 Thread Kalliguddi, Hema
Lindgren; Cousson, Benoit; Paul Walmsley Subject: RE: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb. Felipe, -Original Message- From: Balbi, Felipe Sent: Friday, September 24, 2010 2:14 PM To: Kalliguddi, Hema Cc: Kevin Hilman; Balbi, Felipe; linux-omap@vger.kernel.org; linux

Re: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-24 Thread Felipe Balbi
Hi, On Fri, Sep 24, 2010 at 04:28:35AM -0500, Kalliguddi, Hema wrote: I just noticed one more think in the code. there are suspend/resume function pointers in platform_driver structure. Why can't we use these for platform specific operations like enable/disable clocks, context save/restore?

Re: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-24 Thread Felipe Balbi
Hi, On Fri, Sep 24, 2010 at 12:34:09AM -0500, Kalliguddi, Hema wrote: Here is the patch which is making use of already existing platform set_clock functions pointer. With this we don't need to use #ifdefs. If it looks good I will post it again along with series. those weren't even used

Re: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-24 Thread Felipe Balbi
Hi, On Thu, Sep 23, 2010 at 12:33:58PM -0500, Kevin Hilman wrote: I guess that's Felipe's call, but I don't like that option. I think it's cleaner to have the -set_clock hook be a noop on OMAP and the runtime hooks be noops on the other platforms. Agreed. We should focus on removing

RE: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-24 Thread Kalliguddi, Hema
Hi, -Original Message- From: Balbi, Felipe Sent: Friday, September 24, 2010 4:35 PM To: Kalliguddi, Hema Cc: Balbi, Felipe; Kevin Hilman; linux-omap@vger.kernel.org; linux-...@vger.kernel.org; Basak, Partha; Tony Lindgren; Cousson, Benoit; Paul Walmsley Subject: Re: [PATCH 8/9 v3] usb

Re: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-24 Thread Sergei Shtylyov
Hello. Felipe Balbi wrote: I guess that's Felipe's call, but I don't like that option. I think it's cleaner to have the -set_clock hook be a noop on OMAP and the runtime hooks be noops on the other platforms. Agreed. We should focus on removing -set_clock for .38 actually. Is DaVinci

Re: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-24 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: Hi, On Thu, Sep 23, 2010 at 12:33:58PM -0500, Kevin Hilman wrote: I guess that's Felipe's call, but I don't like that option. I think it's cleaner to have the -set_clock hook be a noop on OMAP and the runtime hooks be noops on the other platforms. Agreed.

Re: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-23 Thread Felipe Balbi
Hi, On Wed, Sep 22, 2010 at 07:30:30PM -0500, Kalliguddi, Hema wrote: Calling runtime pm APIs pm_runtime_put_sync() and pm_runtime_get_sync() for enabling/disabling the clocks,sysconfig settings. Also need to put the USB in force standby and force idle mode when usb not used and set it back to

RE: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-23 Thread Kalliguddi, Hema
-Original Message- From: Balbi, Felipe Sent: Thursday, September 23, 2010 12:06 PM To: Kalliguddi, Hema Cc: linux-omap@vger.kernel.org; linux-...@vger.kernel.org; Basak, Partha; Balbi, Felipe; Tony Lindgren; Kevin Hilman; Cousson, Benoit; Paul Walmsley Subject: Re: [PATCH 8/9 v3] usb

RE: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-23 Thread Kalliguddi, Hema
Hilman; Cousson, Benoit; Paul Walmsley Subject: RE: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb. -Original Message- From: Balbi, Felipe Sent: Thursday, September 23, 2010 12:06 PM To: Kalliguddi, Hema Cc: linux-omap@vger.kernel.org; linux-...@vger.kernel.org; Basak

Re: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-23 Thread Felipe Balbi
Hi, On Thu, Sep 23, 2010 at 02:51:12AM -0500, Kalliguddi, Hema wrote: these two should a separate series, otherwise it's difficult for different maintainers to decide what they need to pick up :-) I don't mind if you're re-sending already, please do split :-) I would rather remove these,

RE: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-23 Thread Kalliguddi, Hema
] usb : musb: Using runtime pm apis for musb. Hi, On Thu, Sep 23, 2010 at 02:51:12AM -0500, Kalliguddi, Hema wrote: these two should a separate series, otherwise it's difficult for different maintainers to decide what they need to pick up :-) I don't mind if you're re-sending already, please do

Re: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-23 Thread Felipe Balbi
Hi, On Thu, Sep 23, 2010 at 06:11:22AM -0500, Kalliguddi, Hema wrote: When there is global suspend initiated, driver's pm_ops functions Musb_suspend api is called and the clocks are disabled. Now when the system resumes after wakeup, Musb_resume_noirq is called, now need to re-enable the clocks

Re: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-23 Thread Kevin Hilman
Felipe Balbi ba...@ti.com writes: Hi, On Wed, Sep 22, 2010 at 07:30:30PM -0500, Kalliguddi, Hema wrote: Calling runtime pm APIs pm_runtime_put_sync() and pm_runtime_get_sync() for enabling/disabling the clocks,sysconfig settings. Also need to put the USB in force standby and force idle mode

RE: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-23 Thread Kalliguddi, Hema
: Re: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb. Felipe Balbi ba...@ti.com writes: Hi, On Wed, Sep 22, 2010 at 07:30:30PM -0500, Kalliguddi, Hema wrote: Calling runtime pm APIs pm_runtime_put_sync() and pm_runtime_get_sync() for enabling/disabling the clocks,sysconfig settings

Re: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-23 Thread Kevin Hilman
; Cousson, Benoit; Paul Walmsley Subject: Re: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb. Felipe Balbi ba...@ti.com writes: Hi, On Wed, Sep 22, 2010 at 07:30:30PM -0500, Kalliguddi, Hema wrote: Calling runtime pm APIs pm_runtime_put_sync() and pm_runtime_get_sync() for enabling

RE: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-23 Thread Kalliguddi, Hema
Lindgren; Cousson, Benoit; Paul Walmsley Subject: RE: [PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb. -Original Message- From: Kevin Hilman [mailto:khil...@deeprootsystems.com] Sent: Thursday, September 23, 2010 9:00 PM To: Balbi, Felipe Cc: Kalliguddi, Hema; linux-omap

[PATCH 8/9 v3] usb : musb: Using runtime pm apis for musb.

2010-09-22 Thread Hema HK
Calling runtime pm APIs pm_runtime_put_sync() and pm_runtime_get_sync() for enabling/disabling the clocks,sysconfig settings. Also need to put the USB in force standby and force idle mode when usb not used and set it back to no idle and no stndby after wakeup. For OMAP3 auto idle bit has to be