Hi Manjunath,
On Tue, Sep 21, 2010 at 03:31:18PM +0530, G, Manjunath Kondaiah wrote:
Fixes following sparse warnings for twl4030 and twl6030 irq files.
drivers/mfd/twl4030-irq.c:783:5: warning: symbol 'twl4030_init_irq' was not
declared. Should it be static?
] TWL IRQ: Fix fucntion
declaration warnings
Hi Manjunath,
On Tue, Sep 21, 2010 at 03:31:18PM +0530, G, Manjunath Kondaiah wrote:
Fixes following sparse warnings for twl4030 and twl6030 irq files.
drivers/mfd/twl4030-irq.c:783:5: warning: symbol
'twl4030_init_irq' was not declared
; Menon, Nishanth
Subject: RE: [PATCH v2 08/10] TWL IRQ: Fix fucntion
declaration warnings
Hi Samuel,
-Original Message-
From: Samuel Ortiz [mailto:sa...@linux.intel.com]
Sent: Monday, September 27, 2010 4:46 PM
To: G, Manjunath Kondaiah
Cc: linux-omap@vger.kernel.org
Hi Manjunath,
On Mon, Sep 27, 2010 at 07:19:33PM +0530, G, Manjunath Kondaiah wrote:
No, we don't want to export those. Try defining them as extern from
twl*-irq.c.
Having extern in .c file will generate checkpatch warning as:
WARNING: externs should be avoided in .c files
As an
Fixes following sparse warnings for twl4030 and twl6030 irq files.
drivers/mfd/twl4030-irq.c:783:5: warning: symbol 'twl4030_init_irq' was not
declared. Should it be static?
drivers/mfd/twl4030-irq.c:863:5: warning: symbol 'twl4030_exit_irq' was not
declared. Should it be static?
