Re: [PATCHv4 03/33] CLK: OMAP4: Add DPLL clock support

2013-08-01 Thread Rajendra Nayak
Tero, On Tuesday 23 July 2013 12:49 PM, Tero Kristo wrote: + dd-control_reg = of_iomap(node, 0); + dd-idlest_reg = of_iomap(node, 1); + dd-autoidle_reg = of_iomap(node, 2); + dd-mult_div1_reg = of_iomap(node, 3); + []... + reg = of_iomap(node, 0); Doing an of_iomap()

Re: [PATCHv4 03/33] CLK: OMAP4: Add DPLL clock support

2013-08-01 Thread Nishanth Menon
On 07/31/2013 04:46 AM, Tero Kristo wrote: On 07/30/2013 07:23 PM, Nishanth Menon wrote: This patch probably was submitted in the wrong sequence - fails build and few other issues below. Yeah, I'll double check the build sequence for these. On 07/23/2013 02:19 AM, Tero Kristo wrote: The

Re: [PATCHv4 03/33] CLK: OMAP4: Add DPLL clock support

2013-08-01 Thread Tero Kristo
On 08/01/2013 05:00 PM, Nishanth Menon wrote: On 07/31/2013 04:46 AM, Tero Kristo wrote: On 07/30/2013 07:23 PM, Nishanth Menon wrote: This patch probably was submitted in the wrong sequence - fails build and few other issues below. Yeah, I'll double check the build sequence for these. On

Re: [PATCHv4 03/33] CLK: OMAP4: Add DPLL clock support

2013-08-01 Thread Nishanth Menon
On 08/01/2013 03:29 AM, Rajendra Nayak wrote: Tero, On Tuesday 23 July 2013 12:49 PM, Tero Kristo wrote: + dd-control_reg = of_iomap(node, 0); + dd-idlest_reg = of_iomap(node, 1); + dd-autoidle_reg = of_iomap(node, 2); + dd-mult_div1_reg = of_iomap(node, 3); + []... +

Re: [PATCHv4 03/33] CLK: OMAP4: Add DPLL clock support

2013-08-01 Thread Nishanth Menon
On Thu, Aug 1, 2013 at 10:08 AM, Tero Kristo t-kri...@ti.com wrote: We should move the functions to this file instead and empty out mach-omap2 gradually, omap_dpll.h should be exported and used by mach-omap2, rather than the other way around. Yeah, the clock stuff should evolve and move

Re: [PATCHv4 03/33] CLK: OMAP4: Add DPLL clock support

2013-08-01 Thread Tero Kristo
On 08/01/2013 06:10 PM, Nishanth Menon wrote: On 08/01/2013 03:29 AM, Rajendra Nayak wrote: Tero, On Tuesday 23 July 2013 12:49 PM, Tero Kristo wrote: +dd-control_reg = of_iomap(node, 0); +dd-idlest_reg = of_iomap(node, 1); +dd-autoidle_reg = of_iomap(node, 2); +

Re: [PATCHv4 03/33] CLK: OMAP4: Add DPLL clock support

2013-07-31 Thread Tero Kristo
On 07/30/2013 07:23 PM, Nishanth Menon wrote: This patch probably was submitted in the wrong sequence - fails build and few other issues below. Yeah, I'll double check the build sequence for these. On 07/23/2013 02:19 AM, Tero Kristo wrote: The OMAP clock driver now supports DPLL clock

Re: [PATCHv4 03/33] CLK: OMAP4: Add DPLL clock support

2013-07-30 Thread Nishanth Menon
This patch probably was submitted in the wrong sequence - fails build and few other issues below. On 07/23/2013 02:19 AM, Tero Kristo wrote: The OMAP clock driver now supports DPLL clock type. This patch also adds support for DT DPLL nodes. Then why is $subject specific to OMAP4? is that

[PATCHv4 03/33] CLK: OMAP4: Add DPLL clock support

2013-07-23 Thread Tero Kristo
The OMAP clock driver now supports DPLL clock type. This patch also adds support for DT DPLL nodes. Signed-off-by: Tero Kristo t-kri...@ti.com --- drivers/clk/omap/Makefile |2 +- drivers/clk/omap/clk.c|1 + drivers/clk/omap/dpll.c | 295