Re: [PATCHv6 1/2] drivers: spi: Add qspi flash controller

2013-07-30 Thread Sourav Poddar
Hi Felipe, On Monday 29 July 2013 06:05 PM, Felipe Balbi wrote: Hi, On Mon, Jul 29, 2013 at 04:45:02PM +0530, Sourav Poddar wrote: + irq = platform_get_irq(pdev, 0); + if (irq 0) { + dev_err(pdev-dev, no irq resource?\n); + return irq; + } + +

Re: [PATCHv6 1/2] drivers: spi: Add qspi flash controller

2013-07-30 Thread Felipe Balbi
Hi, On Tue, Jul 30, 2013 at 01:04:28PM +0530, Sourav Poddar wrote: Hi Felipe, On Monday 29 July 2013 06:05 PM, Felipe Balbi wrote: Hi, On Mon, Jul 29, 2013 at 04:45:02PM +0530, Sourav Poddar wrote: + irq = platform_get_irq(pdev, 0); + if (irq 0) { +

[PATCHv6 1/2] drivers: spi: Add qspi flash controller

2013-07-29 Thread Sourav Poddar
The patch add basic support for the quad spi controller. QSPI is a kind of spi module that allows single, dual and quad read access to external spi devices. The module has a memory mapped interface which provide direct interface for accessing data form external spi devices. The patch will

Re: [PATCHv6 1/2] drivers: spi: Add qspi flash controller

2013-07-29 Thread Felipe Balbi
Hi, On Mon, Jul 29, 2013 at 12:52:29PM +0530, Sourav Poddar wrote: diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c new file mode 100644 index 000..51fe95f --- /dev/null +++ b/drivers/spi/spi-ti-qspi.c [ snip ] +struct ti_qspi { + spinlock_t lock;

Re: [PATCHv6 1/2] drivers: spi: Add qspi flash controller

2013-07-29 Thread Sourav Poddar
On Monday 29 July 2013 03:01 PM, Felipe Balbi wrote: Hi, On Mon, Jul 29, 2013 at 12:52:29PM +0530, Sourav Poddar wrote: diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c new file mode 100644 index 000..51fe95f --- /dev/null +++ b/drivers/spi/spi-ti-qspi.c [ snip ]

Re: [PATCHv6 1/2] drivers: spi: Add qspi flash controller

2013-07-29 Thread Felipe Balbi
Hi, On Mon, Jul 29, 2013 at 03:42:03PM +0530, Sourav Poddar wrote: + frame_length = (m-frame_length 3) / spi-bits_per_word; there's another way to optimize this. If you assume bits_per_word to always be power of two you can: frame_length = (m-frame_length 3)

Re: [PATCHv6 1/2] drivers: spi: Add qspi flash controller

2013-07-29 Thread Sourav Poddar
On Monday 29 July 2013 03:50 PM, Felipe Balbi wrote: Hi, On Mon, Jul 29, 2013 at 03:42:03PM +0530, Sourav Poddar wrote: + frame_length = (m-frame_length 3) / spi-bits_per_word; there's another way to optimize this. If you assume bits_per_word to always be power of two you can:

Re: [PATCHv6 1/2] drivers: spi: Add qspi flash controller

2013-07-29 Thread Felipe Balbi
Hi, On Mon, Jul 29, 2013 at 04:34:41PM +0530, Sourav Poddar wrote: + irq = platform_get_irq(pdev, 0); + if (irq 0) { + dev_err(pdev-dev, no irq resource?\n); + return irq; + } + + spin_lock_init(qspi-lock); + + qspi-base = devm_ioremap_resource(pdev-dev, r); + if

Re: [PATCHv6 1/2] drivers: spi: Add qspi flash controller

2013-07-29 Thread Sourav Poddar
On Monday 29 July 2013 04:39 PM, Felipe Balbi wrote: Hi, On Mon, Jul 29, 2013 at 04:34:41PM +0530, Sourav Poddar wrote: + irq = platform_get_irq(pdev, 0); + if (irq0) { + dev_err(pdev-dev, no irq resource?\n); + return irq; + } + +

Re: [PATCHv6 1/2] drivers: spi: Add qspi flash controller

2013-07-29 Thread Felipe Balbi
Hi, On Mon, Jul 29, 2013 at 04:45:02PM +0530, Sourav Poddar wrote: + irq = platform_get_irq(pdev, 0); + if (irq0) { + dev_err(pdev-dev, no irq resource?\n); + return irq; + } + + spin_lock_init(qspi-lock); + + qspi-base =