Re: [pm-wip/voltdm_nm][PATCH 07/10] OMAP3+: PM: VP: use uV for max and min voltage limits

2011-06-17 Thread Kevin Hilman
Menon, Nishanth n...@ti.com writes: On Thu, Jun 16, 2011 at 15:45, Kevin Hilman khil...@ti.com wrote: Nice! A reference to where these voltages values came from would be good to have in the code as well. these are just conversions of the existing values - :( I think we need a seperate

Re: [pm-wip/voltdm_nm][PATCH 07/10] OMAP3+: PM: VP: use uV for max and min voltage limits

2011-06-16 Thread Kevin Hilman
Nishanth Menon n...@ti.com writes: Every PMIC has it's own eccentricities, For example, one of the PMIC has MSB set to 1 for a specific function - voltage enable! using an hardcoded value specific for TWL when copied over to such an implementation causes the system to crash as the MSB bit

Re: [pm-wip/voltdm_nm][PATCH 07/10] OMAP3+: PM: VP: use uV for max and min voltage limits

2011-06-16 Thread Menon, Nishanth
On Thu, Jun 16, 2011 at 15:45, Kevin Hilman khil...@ti.com wrote: Nice! A reference to where these voltages values came from would be good to have in the code as well. these are just conversions of the existing values - :( I think we need a seperate patch updating from each of OMAP DMs..

[pm-wip/voltdm_nm][PATCH 07/10] OMAP3+: PM: VP: use uV for max and min voltage limits

2011-06-06 Thread Nishanth Menon
Every PMIC has it's own eccentricities, For example, one of the PMIC has MSB set to 1 for a specific function - voltage enable! using an hardcoded value specific for TWL when copied over to such an implementation causes the system to crash as the MSB bit was 0 and the voltage got disabled!.