[PATCH] pcmcia: make Open Firmware device id constant

2010-01-11 Thread Németh Márton
From: Márton Németh The match_table field of the struct of_device_id is constant in so it is worth to make the initialization data also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // @r@ disable decl_init,const_decl_init; identifie

Re: [RFC] PCMCIA patches for 2.6.34

2010-01-11 Thread Wolfram Sang
Hiya Dominik, thanks for your assistance! > Not known to me -- does it also happen with pata_pcmcia.c? Nope, it doesn't. Never noticed this driver :) > (1) diff between /proc/ioports before and after inserting the card. Extra > bonus i you can grab a /proc/ioports before the ide-cs driver is lo

Re: [PATCH V2] pcmcia/yenta: add module parameter for O2 speedups

2010-01-11 Thread Wolfram Sang
> > +static char o2_speedup[] = "default"; > > +module_param_string(o2_speedup, o2_speedup, sizeof(o2_speedup), 0444); > > +MODULE_PARM_DESC(o2_speedup, "Use prefetch/burst for O2-bridges: 'on', > > 'off' " > > + "or 'default' (uses recommended behaviour for the detected bridge)"); > > Is using

Re: [PATCH V2] pcmcia/yenta: add module parameter for O2 speedups

2010-01-11 Thread Wolfram Sang
Hi, > (1) > The default setting of O2_6933 should be "on"? It was set to "off" because of this bug-report: http://www.mail-archive.com/linux-pcmcia@lists.infradead.org/msg02048.html The patch went through this list multiple times and there were no complaints. > (2) > How about the name "enable