Re: [PATCH] pcmcia: make Open Firmware device id constant

2010-01-12 Thread Wolfram Sang
On Tue, Jan 12, 2010 at 08:56:13AM +0100, Németh Márton wrote: > From: Márton Németh > > The match_table field of the struct of_device_id is constant in > > so it is worth to make the initialization data also constant. [...] > Signed-off-by: Márton Németh > Cc: Julia Lawall > Cc: co...@diku.d

Re: [RFC] PCMCIA patches for 2.6.34

2010-01-12 Thread Dominik Brodowski
Hey, On Mon, Jan 11, 2010 at 11:01:49PM +0100, Wolfram Sang wrote: > Knowing now that this is a flaw, I digged up something, check the following > call chain in ide_detach from ide-cs.c: > > ide_release -> pcmcia_disable_device -> pcmcia_release_io > > Then(!) release_region is called twice, but

Re: [PATCH V2] pcmcia/yenta: add module parameter for O2 speedups

2010-01-12 Thread Dominik Brodowski
On Sun, Jan 10, 2010 at 09:41:24AM +0100, Wolfram Sang wrote: > O2-bridges can do read prefetch and write burst. However, for some > combinations > of older bridges and cards, this causes problems, so it is disabled for those > bridges. Now, as some users know their setup works with the speedups e

Re: [PATCH V2] pcmcia/yenta: add module parameter for O2 speedups

2010-01-12 Thread Wolfram Sang
> Last question (hopefully): is this needed for 2.6.33 or is 2.6.34 > sufficient? Uhrm, well, the bug reporter seems happy with the patch for now. The bug is also not marked as a regression. Even then, one has to change the kernel-command-line to get the old features back, so it is not really a "

[PATCH] ide/ide-cs: fix order of releasing resources

2010-01-12 Thread Wolfram Sang
ide_detach() called first ide_release() and then release_region(). This produced the following warnings: Trying to free nonexistent resource Trying to free nonexistent resource This is true, because the callchain inside i