Re: [PATCH] ide/ide-cs: fix order of releasing resources

2010-01-17 Thread David Miller
From: Wolfram Sang Date: Sat, 16 Jan 2010 19:51:24 +0100 >> > bzolnier: >> > - release resources in ide_release() to fix ordering of events >> > - remove stale FIXME note while at it >> >> Ok this does look better, Wolfram can you test this? > > Works as expected. Great, thanks for testing. _

Re: [RFC] PCMCIA locking updates for 2.6.34

2010-01-17 Thread Wolfram Sang
> > Does the new locking work for you? I'd wonder why... > > I wonder too why it worked yesterday -- I updated the patch-set completely, > it's up at the same location as yesterday > > git://git.kernel.org/pub/scm/linux/kernel/git/brodo/pcmcia-2.6.git#locking > > and survives any test case I ca

Re: [RFC] PCMCIA locking updates for 2.6.34

2010-01-17 Thread Dominik Brodowski
Hey, On Sun, Jan 17, 2010 at 03:30:08PM +0900, Komuro wrote: > Same result as Wolfram. On Sun, Jan 17, 2010 at 12:08:20PM +0100, Wolfram Sang wrote: > > If it doesn't help, could you enable lockdep, please, and check with > > I enabled locking debug and got this while inserting the card: ... > D

Re: [PATCH] sysfs: Add lockdep annotations for the sysfs active reference

2010-01-17 Thread Dominik Brodowski
Hey, On Sun, Jan 17, 2010 at 09:18:34AM -0800, Eric W. Biederman wrote: > Ming Lei writes: > > > On Sat, 02 Jan 2010 13:37:12 -0800 > > ebied...@xmission.com (Eric W. Biederman) wrote: > > > >> > >> Holding locks over device_del -> kobject_del -> sysfs_deactivate can > >> cause deadlocks if tho

Re: [PATCH] sysfs: Add lockdep annotations for the sysfs active reference

2010-01-17 Thread Eric W. Biederman
Ming Lei writes: > On Sat, 02 Jan 2010 13:37:12 -0800 > ebied...@xmission.com (Eric W. Biederman) wrote: > >> >> Holding locks over device_del -> kobject_del -> sysfs_deactivate can >> cause deadlocks if those same locks are grabbed in sysfs show or store >> methods. >> >> The I model s_active

Re: [PATCH] sysfs: Add lockdep annotations for the sysfs active reference

2010-01-17 Thread Ming Lei
On Sat, 02 Jan 2010 13:37:12 -0800 ebied...@xmission.com (Eric W. Biederman) wrote: > > Holding locks over device_del -> kobject_del -> sysfs_deactivate can > cause deadlocks if those same locks are grabbed in sysfs show or store > methods. > > The I model s_active count + completion as a sleepi

Re: [RFC] PCMCIA locking updates for 2.6.34

2010-01-17 Thread Wolfram Sang
> If it doesn't help, could you enable lockdep, please, and check with I enabled locking debug and got this while inserting the card: [ 187.347741] === [ 187.347745] [ INFO: possible circular locking dependency detected ] [ 187.347750] 2.6.33