Re: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c

2010-03-26 Thread Valdis . Kletnieks
On Wed, 24 Mar 2010 20:20:19 -0300, Marcelo Jimenez said: -     debug(skt, 2, mask: %s%s%s%s%s%sflags: %s%s%s%s%s%sVcc %d Vpp %d irq %d\n, I will redo it, no problem. But just for my information, in that particular case, is it usefull to grep using format specifiers? Until you find the

[git pull] PCMCIA bugfixes for 2.6.34-rc3

2010-03-26 Thread Dominik Brodowski
Linus, some PCMCIA bugfixes for 2.6.34-rc3 are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/brodo/pcmcia-2.6.git urgent Please pull from that location. The diffstat and list of changes follows. The PM-related change is ACKed by Rafael and needed for the

Re: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c

2010-03-26 Thread Russell King - ARM Linux
On Thu, Mar 25, 2010 at 01:19:29PM +0300, Sergei Shtylyov wrote: Hello. Russell King - ARM Linux wrote: - debug(skt, 2, mask: %s%s%s%s%s%sflags: %s%s%s%s%s%sVcc %d Vpp %d irq %d\n, - (state-csc_mask==0)?NONE :, - (state-csc_maskSS_DETECT)?DETECT :, -

[Bug 7304] no PCI irq, Cardbus support disabled

2010-03-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=7304 --- Comment #83 from Thomas Nemeth nemeth.tho...@gmail.com 2010-03-26 21:18:34 --- Created an attachment (id=25724) -- (https://bugzilla.kernel.org/attachment.cgi?id=25724) Output of cbdump on 2.6.34-rc2 with the eth card in the non-working

[Bug 7304] no PCI irq, Cardbus support disabled

2010-03-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=7304 --- Comment #84 from Thomas Nemeth nemeth.tho...@gmail.com 2010-03-26 21:20:02 --- Created an attachment (id=25725) -- (https://bugzilla.kernel.org/attachment.cgi?id=25725) Output of cbdump on 2.6.34-rc2 with the eth card in the working slot

[Bug 7304] no PCI irq, Cardbus support disabled

2010-03-26 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=7304 --- Comment #85 from Thomas Nemeth nemeth.tho...@gmail.com 2010-03-26 21:23:40 --- (In reply to comment #82) This is with both socket-cb_irq = 11; dev-irq = 11; ? Yes. tho...@cixi:exether$ grep = 11;

Re: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c

2010-03-26 Thread Marcelo Jimenez
On Fri, Mar 26, 2010 at 15:18, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Mar 25, 2010 at 01:19:29PM +0300, Sergei Shtylyov wrote:   I'd disagree in this case. Anybody will hardly grep for mask: %s%s%s%s%s%sflags: %s%s%s%s%s%s. Well, I disagree on a matter of principle

Re: [PATCH 2/2] ARM: pcmcia: fix checkpatch.pl issues in soc_common.c

2010-03-26 Thread Russell King - ARM Linux
On Fri, Mar 26, 2010 at 06:57:07PM -0300, Marcelo Jimenez wrote: On Fri, Mar 26, 2010 at 15:18, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Thu, Mar 25, 2010 at 01:19:29PM +0300, Sergei Shtylyov wrote:   I'd disagree in this case. Anybody will hardly grep for mask: